July 2002 - Wine-Devel - list.winehq.org

Re: Fixing a regression test ...

by Duane Clark

Paul Millar wrote: > ChangeLog: > Replace references to D: (which might not exist) with C: (which we > assume does) > > Index: dlls/kernel/tests/path.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel/tests/path.c,v > retrieving revision 1.6 > diff -u -r1.6 path.c > --- dlls/kernel/tests/path.c 5 Jul 2002 01:22:28 -0000 1.6 > +++ dlls/kernel/tests/path.c 12 Jul 2002 18:03:17 -0000 > @@ -673,9 +673,9 @@ > ok(lstrcmpiA(SHORTFILE,strptr)==0, > "GetLongPathNameA returned part '%s' instead of '%s'",strptr,SHORTFILE); > /* Otherwise insert the missing leading slash */ > - sprintf(tmpstr,"D:%s\\%s",SHORTDIR,SHORTFILE); > + sprintf(tmpstr,"C:%s\\%s",SHORTDIR,SHORTFILE); > ok(GetFullPathNameA(tmpstr,MAX_PATH,tmpstr1,&strptr),"GetFullPathNameA failed"); > - sprintf(tmpstr,"D:\\%s\\%s",SHORTDIR,SHORTFILE); > + sprintf(tmpstr,"C:\\%s\\%s",SHORTDIR,SHORTFILE); > ok(lstrcmpiA(tmpstr,tmpstr1)==0, > "GetLongPathNameA returned '%s' instead of '%s'",tmpstr1,tmpstr); > ok(lstrcmpiA(SHORTFILE,strptr)==0, Actually, the purpose of that particular test was to check the behavior when the supplied path is on a different drive from the current drive. The current drive is presumably C:. But the test should have tested for the existence of drive D: before using it.

July 12, 2002

Re: Crash in SHELL32_ParseNextElement

by Gregg Mattinson

No. I came across this crash a few weeks ago when testing an application. Unfortunatly, I can't even remember what caused it to crash. I just remember adding this small change and that fixed things. Gregg >From: "Jürgen Schmied" <juergenschmied(a)lycos.de> >To: Gregg Mattinson <gm138242(a)opcom-mail.canada.sun.com>, wine-devel(a)winehq.com >Date: Fri, 12 Jul 2002 18:03:17 +0200 >MIME-Version: 1.0 >Subject: Re: Crash in SHELL32_ParseNextElement >CC: wine-devel(a)winehq.com >Content-transfer-encoding: 7BIT >Content-description: Mail message body > >Im about to do a major update to the shellfolder stuff. Are you aware of any other >probkems? > >juergen > >On 12 Jul 2002 at 10:11, Gregg Mattinson wrote: > >> ChangeLog: dlls/shell32/shlfolder.c >> - Initialized the pidlOut variable in SHELL32_ParseNextElement to prevent a >> crash in some cases. >> >> Gregg Mattinson >> Co-op Developer >> Sun Microsystems of Canada >> >> > > >--- >juergen.schmied(a)debitel.net >

July 12, 2002

Re: SHLWAPI ole32 (delay-load of dlls)

by Alexandre Julliard

"Jürgen Schmied" <juergenschmied(a)lycos.de> writes: > This is not completely right. shlwapi loads ole32 per delay-load what > means nearly its linking against it. We don't have anything similar at > the moment. I don't think we should do anyting by function pointers. > Maybe we could generate stubs during the build process to implement > delay loading. It don't looks to hard to implement. It's already implemented, you just have to list them as DELAYIMPORTS instead of IMPORTS in the makefile. -- Alexandre Julliard julliard(a)winehq.com

July 12, 2002

Re: Crash in SHELL32_ParseNextElement

by Jürgen Schmied

Im about to do a major update to the shellfolder stuff. Are you aware of any other probkems? juergen On 12 Jul 2002 at 10:11, Gregg Mattinson wrote: > ChangeLog: dlls/shell32/shlfolder.c > - Initialized the pidlOut variable in SHELL32_ParseNextElement to prevent a > crash in some cases. > > Gregg Mattinson > Co-op Developer > Sun Microsystems of Canada > > --- juergen.schmied(a)debitel.net

July 12, 2002

Re: SHLWAPI ole32 (delay-load of dlls)

by Jürgen Schmied

This is not completely right. shlwapi loads ole32 per delay-load what means nearly its linking against it. We don't have anything similar at the moment. I don't think we should do anyting by function pointers. Maybe we could generate stubs during the build process to implement delay loading. It don't looks to hard to implement. juergen On 11 Jul 2002 at 21:05, Jon Griffiths wrote: > Hi, > > SHLWAPI updates continued. > > This patch removes the need for direct linking to ole32, which is > only ever late bound by the real SHLWAPI. > > For fear of patch conflicts with myself, I haven't included a patch > to Makefile.in to remove the import and the FIXME. I'll send this in > a later patch, if need be. > > > ChangeLog: > > Jon Griffiths <jon_p_griffiths(a)yahoo.com> > > +dlls/shlwapi/shlwapi_main.c dlls/shlwapi/string.c > Remove the need to directly link to ole32. > > > ===== > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > > jon_p_griffiths(a)yahoo.com > > __________________________________________________ > Do You Yahoo!? > Sign up for SBC Yahoo! Dial - First Month Free > http://sbc.yahoo.com --- juergen.schmied(a)debitel.net

July 12, 2002

RE: Any advice on how to debug this?

by Medland, Bill

> -----Original Message----- > From: Guy L. Albertelli [mailto:galberte(a)neo.lrun.com] > Sent: Thursday, July 11, 2002 5:13 PM > To: Medland, Bill; Wine devel (E-mail) > Subject: Re: Any advice on how to debug this? > > > > ----- Original Message ----- > From: "Medland, Bill" <Bill.Medland(a)accpac.com> > To: "Wine devel (E-mail)" <wine-devel(a)winehq.com> > Sent: Tuesday, July 09, 2002 5:51 PM > Subject: Any advice on how to debug this? > > > > Any suggestions would be appreciated. > > > > The application runs reasonably with builtin > comctl32/commctrl but there > are > > some alignment issues which I suspect might be corrected by > using the > native > > one. > > > Bill, > > Can you document the alignment issues for me with Bugzilla. > Screen shots are > fine. Traces with "+relay,+message,+tid,+win" are also great > for finding > these type of problems. Is the application available in a > demo version?? > > Guy > > Will comply Also I am in the process of fixing it. (Yesterday's submission was part and yesterday's question about HEADER was the other; I will continue today. Bill

July 12, 2002

Re: Items with size 0

by Dmitry Timoshkov

"Gregg Mattinson" <gm138242(a)scot.canada.sun.com> wrote: > +#ifndef __SUNPRO_C > THREADINFO ti[0]; > +#endif > } SYSTEM_PROCESS_INFORMATION; At least this one can be replaced by [1] for now, since it currently is not used in Wine and according to the Nebbett's book has very different layout. -- Dmitry.

July 12, 2002

AppDB: great news !

by Andreas Mohr

Hi all, I just wanted to let you know that the appliation database (http://appdb.codeweavers.com) just managed to reach 1000 entries !! I think that's a really great thing :-) -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

July 12, 2002

Re: Fix nasty little bug in InitializeGenericSF

by Jürgen Schmied

Sorry for this bug and the waste of time. I'm about to implement a MallocSpy in OLE32 what will catch those corruptions and leaks in general. I already found about 10 leaks in comdlg32/shell32 and ole32 with it... We should do the same in ntdll for the Heap functions I guess... juergen > > This patch fixes a little bug that caused heap corruption (ouch!) when > > running the Finale 2002 installer. > > > > Urg! I'm sorry, I just noticed that Rein fixed this on Tuesday. I just > wasted a lot of time. --- juergen.schmied(a)debitel.net

July 12, 2002

Re: RFC: Re: [ros-kernel] Shell32 and dplax

by Steven Edwards

> > I would suggest using a keyword insted of a > metabug. Perhaps ROS or > > ReactOS, It would be much cleaner. You can even > have more than one > > keyword if you think it is appropriate. ie 9xism. I am just using the keywords 9xism or unixism ATM because that is what most of the problems are. There really isnt that many problems due to wines portablity. As I have said I think psapi is the most fubar'd one we have to deal with if we want to try and share it. One of the ReactOS developers is rewriting it for ReactOS anyway and I think he will LGPL/X11 it. Once that is done if wine will implement the needed exports of ntdll then we can contribute that back. > I am not sure that we should create a ReactOS > keyword. Instead I think > we should add it to the list of OSes. We already > have Linux, FreeBSD, > Windows, Solaris... we should have ReactOs too (and > maybe push this to > the Buzilla team too ;-). I agree. All of the reports I am doing are going under Win2k or NT. I host on 2k and ReactOS is kinda expanding its goals to include some of the nicer things of 2k like acpi and wdm. > The '9xism' keyword is quite independent from that > and may be useful. > I'm not entirely sure though: we don't want to be > too fine grained > either. If we start this way we may end up with > keywords for each > general task: dllseparation, strict-compile, > window-management, etc. > That may get confusing... I'm not to worried about it ATM as there are not that many problems. If it gets to be to much I'm sure our bugzilla guys will let me know. =) Thanks Steven __________________________________________________ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com

July 12, 2002