July 2002 - Wine-Devel - list.winehq.org

Re: wine/ dlls/dsound/dsound_main.c dlls/x11drv/x1 ...

by Steven Edwards

> Log message: > No need to call GetModuleFileName16 now that > GetModuleFileNameA > handles 16-bit tasks. With this patch I can now build dsound on Mingw if I import ntdll. Are there going to be other places like this where the A/W function can be used rather then the 16? Thanks Steven __________________________________________________ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com

July 5, 2002

Re: Better fix for [bug 829] (same surface display corruption)

by Lionel Ulmer

On Fri, Jul 05, 2002 at 12:50:07PM -0700, Alexandre Julliard wrote: > Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > > > What I had in mind in my comments to your patch was something like that : > > > > if (src != iface) > > Do the standard memcpy code path > > else > > if source_Y > dest_Y > > do the ascending memmove copy > > else > > do the descending memmove copy > > Do you actually need memmove in all these cases? It seems to me that > it would only be needed if source_Y == dest_Y. Yeah, you're right. So the thing should be : if ((not on the same surface) OR (src_Y > dst_Y) OR ((src_Y == dst_Y) AND ((src_rect_Right <= dst_rect_Left) OR (dst_rect_Right <= src_rect_Left)))) ascending memcpy path else if src_Y == dst_Y memmove path else descending memcpy path And the code should even be understandable :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

July 5, 2002

Re: Better fix for [bug 829] (same surface display corruption)

by Alexandre Julliard

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > What I had in mind in my comments to your patch was something like that : > > if (src != iface) > Do the standard memcpy code path > else > if source_Y > dest_Y > do the ascending memmove copy > else > do the descending memmove copy Do you actually need memmove in all these cases? It seems to me that it would only be needed if source_Y == dest_Y. -- Alexandre Julliard julliard(a)winehq.com

July 5, 2002

Re: ShellExecute placeholder patch

by Eric Pouech

Duane Clark a écrit : > > As the comment to ShellExecute states, there can be placeholders in > commandlines retrieved from the registry. For example, MS Installer has > this string: [snip] Hi Duane, It would be better IMO to merge actually ShellExecute and ShellExecuteEx Most of what you need is already in ShellExecute but not in ShellExecuteEx (of course, ShellExecute should call ShellExecuteEx, but this isn't done yet) A+

July 5, 2002

RE: warcraft 3

by Vincent Béron

Le ven 05/07/2002 à 05:16, Hans Leidekker a écrit : > > > After buying Warcraft 3, and reading on the mailing list that the beta had > > worked under wine, I decided to try the final version under wine. It installed > > fine, but won't run. Or rather, when I try to run it, it prints this out, and > > just sits there: > > > > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported > > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported > > fixme:midi:OSS_MidiInit Synthesizer support MIDI in. Not supported yet (please report) > > Let me guess: you have SCSI cdrom drive. I stumbled on this one as well > some time ago. I learned that 11 is the SCSI major. It looks strange to > me that the function CDROM_GetIdeInterface gets called while we have > a SCSI cdrom drive? Or (like me) SCSI emulation over IDE. I use that to get easy access to my burner, and it's enabled for all CD-ROM drives in my system. Bug #693 is the starting place (not much yet). [snip] Vincent

July 5, 2002

GRand Prix Legends network code

by Christoph Frick

Hi! I did some debugging, to find out why the game Grand Prix Legends did not work as network client/server. The problem: Its only possible to connect to servers/let clients connect from the local network. Solution: The game set (WS_)SO_DONTROUTE on the socket - and of course this works perfect under unix - but i never had problems while i played this game under windows so this is either not set, when the game runs under windows - or it has no effect within windows. Also the game like to bind the socket for the client connection a second time, when the first connection failed or was canceled. This does not work (addr. in use) - so a (WS_)SO_REUSEADDR would have been needed. Could please someone with a deeper insight in the world of windows direct me to some docu/specs or what ever to get informations about the winsock stuff? The link in the header of the dlls/winsock/socket.c is not valid. I even dont know what winsock version is the current one (1.1,2.0,???). Help is appreciated! Thanx alot! CU!

July 5, 2002

Re: warcraft 3

by Bobby Bingham

On Fri, Jul 05, 2002 at 10:10:46AM +0200, Rizsanyi Zsolt wrote: > On Friday 05 July 2002 01:53, Bobby Bingham wrote: > > After buying Warcraft 3, and reading on the mailing list that the beta had > > worked under wine, I decided to try the final version under wine. It > > installed fine, but won't run. Or rather, when I try to run it, it prints > > this out, and just sits there: > > > > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not > > supported > > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 > > not supported > > You have an scsi cdrom drive. My code works just with the ide cdrom drives. it's actually an ide cdrom, using the ide-scsi emulation for cdrecord and cdrdao. if i turn off the scsi emulation, these messages go away, but it still doesn't work. > But this should not be a too big problem, unless the game uses SafeDisc copy > protection. And even then it may be not so important. > You can check if the cd is safedisk protected by looking for files: > secdrv.sys > drvmgt.dll > clcd16.dll > clcd32.dll > clokspl.exe > they are not present ... <snip> > > > now, how would one go about debugging this. It doesn't seem as convenient > > as just crashing in one specific function and bringing up the debugger ... > > You did not write which version of wine you are using. That could be quite > important... > i was using CVS as of about a week ago, but it's the same with this morning's CVS. > Regards > Zsolt Rizsanyi >

July 5, 2002

Re: dlls/advapi32/registry.c patch for RegEnumValuesA

by Tony Lambregts

Massimo wrote: >Resubmitting as for Tony Lambregts request :) > >Well, finally found and corrected a bug that made AutoCAD R14 hang... >I guess some other apps could have the same problem solved, but >had no time to test more :) > >In RegEnumValueA, when the size for requested data buffer is too small, >function should return an error (as it does), but also return correct >buffer size (as it doesn't). >Found in AutoCAD; it asked for a reistry key value, got error, and then >looped forever trying to get val with wrong buffer size. > >I guess, but had no time yet to check, that this problem could happen >somwhere else in Registry.c, I'll check it out next days. > >With this patch, finally AutoCAD R14 is perfectly usable in wine, even without >a native windows installed ! > >Change log: Change In RegEnumValueA, when the size for requested data >buffer is too small, function should return an error (as it did), and >also return correct buffer size (now it does). > > >Max max(a)com.veneto [reversed :) ] >----- > > > > > >------------------------------------------------------------------------ > >--- dlls/advapi32/registry.c Sat Jul 6 01:29:08 2002 >+++ /home/massimo/wine-patches/registry.c Sat Jul 6 01:35:32 2002 >@@ -1157,6 +1157,9 @@ > RtlUnicodeToMultiByteSize( &len, info->Name, info->NameLength ); > if (len >= *val_count) > { >+ /* MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ >+ *val_count = len + 1 ; > status = STATUS_BUFFER_OVERFLOW; > goto done; > } >@@ -1174,6 +1177,9 @@ > { > if (len > *count) > { >+ /* MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ >+ *count = len+1 ; > status = STATUS_BUFFER_OVERFLOW; > goto done; > } > > It looks great to me. Please submit it to wine patches. Tony Lambregts

July 5, 2002

RE: warcraft 3

by Hans Leidekker

> After buying Warcraft 3, and reading on the mailing list that the beta had > worked under wine, I decided to try the final version under wine. It installed > fine, but won't run. Or rather, when I try to run it, it prints this out, and > just sits there: > > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported > fixme:cdrom:CDROM_GetIdeInterface CD-ROM device with major ID 11 not supported > fixme:midi:OSS_MidiInit Synthesizer support MIDI in. Not supported yet (please report) Let me guess: you have SCSI cdrom drive. I stumbled on this one as well some time ago. I learned that 11 is the SCSI major. It looks strange to me that the function CDROM_GetIdeInterface gets called while we have a SCSI cdrom drive? Anyways, as a workaround -- I don't think this is the right solution -- I added the following line to the switch statement in cdrom:CDROM_GetIdeInterface: case SCSI_CDROM_MAJOR: *iface = 0; break; This allowed my application to proceed (don't remember which application that was though). Regards, -Hans Leidekker

July 5, 2002

Re: dlls/advapi32/registry.c patch for RegEnumValuesA

by Massimo

Resubmitting as for Tony Lambregts request :) Well, finally found and corrected a bug that made AutoCAD R14 hang... I guess some other apps could have the same problem solved, but had no time to test more :) In RegEnumValueA, when the size for requested data buffer is too small, function should return an error (as it does), but also return correct buffer size (as it doesn't). Found in AutoCAD; it asked for a reistry key value, got error, and then looped forever trying to get val with wrong buffer size. I guess, but had no time yet to check, that this problem could happen somwhere else in Registry.c, I'll check it out next days. With this patch, finally AutoCAD R14 is perfectly usable in wine, even without a native windows installed ! Change log: Change In RegEnumValueA, when the size for requested data buffer is too small, function should return an error (as it did), and also return correct buffer size (now it does). Max max(a)com.veneto [reversed :) ] ----- --- dlls/advapi32/registry.c Sat Jul 6 01:29:08 2002 +++ /home/massimo/wine-patches/registry.c Sat Jul 6 01:35:32 2002 @@ -1157,6 +1157,9 @@ RtlUnicodeToMultiByteSize( &len, info->Name, info->NameLength ); if (len >= *val_count) { + /* MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ + *val_count = len + 1 ; status = STATUS_BUFFER_OVERFLOW; goto done; } @@ -1174,6 +1177,9 @@ { if (len > *count) { + /* MUST RETURN REQUESTED CORRECT BUFFER SIZE, NOT ONLY TELL IT'S WRONG */ + *count = len+1 ; status = STATUS_BUFFER_OVERFLOW; goto done; }

July 5, 2002