July 2002 - Wine-Devel - list.winehq.org

Re: Removed extra , from enum declarations

by Andreas Mohr

On Tue, Jul 02, 2002 at 03:39:04PM -0400, Gregg Mattinson wrote: > Resubmitting because I forgot to attach the file. Sorry. I'm also sorry about > the large number of posts today. You feel sorry about WHAT !? Heck, I guess you might have a minimalistic reason to feel sorry once you manage to crash the mailing list server due to sending way too many patches, but until that happens... ;-) Have a nice day ! -- "My attitude is, everybody should try competing with Microsoft once in their life. Once." - Marc Andreessen, former Netscape lead employee, in a "browser wars" interview

July 2, 2002

Re: Added support for APPMODE=<type>[:<mainFunc>]

by Joerg Mayer

On Tue, Jul 02, 2002 at 04:06:56PM -0400, Gregg Mattinson wrote: > - .spec files can't be compiled with -g when using Forte C. This causes static > variables to have a "random" prefix attached to their name, and prevents the > assembly code from linking to them correctly. > - Forte C has linker issues, so cui executables with main() conflicted with > main() in $WINELOADER. Renaming main() to main2() solved the issue, so I added > support to winebuild to allow the main function name to be optionally specified > in the makefile. > - Forte C does not support .previous It was replaced with a .section statement > for the appropriate section > - '.section .text' is incorrect. It should be '.section ".text"' You omitted: - Replace constants by numeric values (aka magic numbers). > - fprintf( outfile, " rec.code = 0x%08x;\n", EXCEPTION_WINE_STUB ); > + fprintf( outfile, " rec.code = 0x%08x;\n", 0x80000100 ); - Inserted compiler specific compilation (as opposed to feature specific compilation) > +#ifndef __SUNPRO_C > fprintf( outfile, "\n#include \"pshpack1.h\"\n" ); > +#endif - Removed some unneeded includes. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

July 2, 2002

Re: Void functions can't return a value

by Joerg Mayer

On Tue, Jul 02, 2002 at 03:34:44PM -0400, Gregg Mattinson wrote: > - void functions can't return a value, even if it is the return value from > another void function. Just looking at the patch a bit. This looks wrong to me. If you want to make the changes, you should convert return xxx() into { xxx(); return } > void WINAPI PathStripPathAW(LPVOID lpszPath) > { > if (SHELL_OsIsUnicode()) > - return PathStripPathW(lpszPath); > - return PathStripPathA(lpszPath); > + PathStripPathW(lpszPath); > + PathStripPathA(lpszPath); <----- should not be executed if condition is met > } This pattern is repeated several times. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

July 2, 2002

Arts, DSound, and Media Player

by Jeremy Shaw

Hello, I am trying to get media player to work with the winearts audio driver. I compiled the latest source from CVS, added Drivers="winearts.drv" to the config file, and installed media player. When I try to play a file (like an mp3), I do not get any audio. If I watch the elapse time, it will increment normally for a few seconds and then start playing super fast. Also when it starts playing super-fast I get the following error a bunch of times: fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=17640 < primary_done=49392) At this point in time I know very little about what is wrong. Do you guys (we are all guys ???) think it is a problem with the wine source, my build of KDE, or just some messed up config files. Or perhaps I just installed too many native DLLs trying to make media player work? I will keep hacking away, but any guidance will be highly valued. I have not gotten ever gotten sound using the winearts driver, but so far I have only tried media player. Thanks in advance, Jeremy Shaw.

July 2, 2002

Re: Bug in RegEnumValueA ?

by Shachar Shemesh

Massimo wrote: >Looking more with some debug print statements, it appears that Autocad allocates 4 >bytes of buffer for the value, but RegEnumValueA needs much more, 94 in this case, >giving an Out-Of-Buffer error back. >It seems to me that the 94 bytes are for the name of the key, not for the value.... > >Regards > >Max > > > Is it me, or did you just say that placing a five characters value in the registry will cause Autocad to hang indefenitely on Windows? Sloppy programming if I ever saw one. Not that this is, in any way, an excuse, mind you. Shachar

July 2, 2002

Bug in RegEnumValueA ?

by Massimo

Again investigating AutoCAD r14 app under wine, I found a bug that make app hang when some registry values are present. At first I've made a script that cleans up registry before launching AutoCAD,but this was only a way-around to the problem. Looking at relay output, I found a loop in calling RegEnumValueA : // @@@@ START OF LOOP BLOCK HERE......... :Call advapi32.dll.RegEnumValueA (000000cc,00000001,40486844,404868ec,00000000,404868f4,41e62020, 404868fc) ret=008a3850 :Call ntdll.dll.NtEnumerateValueKey (000000cc,00000001,00000001,40486544,00000100,40486540) ret=406afb24 :Ret ntdll.dll.NtEnumerateValueKey() retval=00000000 ret=406afb24 :Call ntdll.dll.RtlUnicodeToMultiByteSize(4048653c,40486558 L"REGPATH\\\\HKEY_LOCAL_MACHINE\\Software\\Autodesk\\AutoCAD\\R1 4.0\\ACAD-2452448:80143967\\AutodeskApps\\LsObj",0000000e) ret=406afc03 :Ret ntdll.dll.RtlUnicodeToMultiByteSize() retval=00000000 ret=406afc03 :Call ntdll.dll.RtlUnicodeToMultiByteN (40486844,00000007,00000000,40486558,0000000e) ret=406afc24 :Ret ntdll.dll.RtlUnicodeToMultiByteN() retval=00000000 ret=406afc24 :Call ntdll.dll.RtlUnicodeToMultiByteSize(40486538,40486566 L"\\\\HKEY_LOCAL_MACHINE\\Software\\Autodesk\\AutoCAD\\R14.0\\AC AD-2452448:80143967\\AutodeskApps\\LsObj",000000bc) ret=406afc77 :Ret ntdll.dll.RtlUnicodeToMultiByteSize() retval=00000000 ret=406afc77 :Call ntdll.dll.RtlNtStatusToDosError(80000005) <--ERROR HERE ! ret=406afd5d :Ret ntdll.dll.RtlNtStatusToDosError() retval=000000ea ret=406afd5d :Ret advapi32.dll.RegEnumValueA() retval=000000ea ret=008a3850 <-- MORE DATA AVAILABLE RETURN (AUTOCAD KEEPS TRYING TO GET DATA) // @@@@ END OF LOOP BLOCK HERE Here RegEnumValueA returns an error of invalid buffer; Looking into code it seems to me that the NtEnumerateValueKey() used to find the largest name and value sizes of keys to be enumerated returns a wrong size; next use for reading the key gives an arror of buffer overflow, being it allocated with wrong (too small) size. AutoCAD keeps trying to get the keys/values, in and endless loop. Looking more with some debug print statements, it appears that Autocad allocates 4 bytes of buffer for the value, but RegEnumValueA needs much more, 94 in this case, giving an Out-Of-Buffer error back. It seems to me that the 94 bytes are for the name of the key, not for the value.... Regards Max

July 2, 2002

Re: Running half-life turns X display into garbage

by Serge Ryabchun

On Tue, 2 Jul 2002, Joshua Thielen wrote: > When I run half-life, the X display gets totally > corrupted and the only way to restore is to restart > the X server. I'm using an NVidia G-force 3 video card > running at 1024x768 with 16-bit color. Try "UseDGA"="no" in config or run HL without root rights. -- Serge Ryabchun sr(a)energy.uch.net

July 2, 2002

Re: Running half-life turns X display into garbage

by Ian D. Stewart

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tuesday 02 July 2002 10:56, Joshua Thielen wrote: > Hello, > > When I run half-life, the X display gets totally > corrupted and the only way to restore is to restart > the X server. I'm using an NVidia G-force 3 video card > running at 1024x768 with 16-bit color. I have already > run a few traces, but since I have no idea at what > point the display gets corrupted, it's kind of hard to > debug. Has anyone encountered this problem yet? Are > there any specific functions or channels I should be > looking at in the trace? Take a look at Bugs 829 and 841 at http://bugs.winehq.com. May be related. Ian -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9IcbvAjpHQQmBAUMRAn5eAJ46GRPxlzz8F0Jyvb//DmWfSuyPcgCggKiC M35JaK8ZL/F468wlXi+3pQA= =I3eR -----END PGP SIGNATURE-----

July 2, 2002

Running half-life turns X display into garbage

by Joshua Thielen

Hello, When I run half-life, the X display gets totally corrupted and the only way to restore is to restart the X server. I'm using an NVidia G-force 3 video card running at 1024x768 with 16-bit color. I have already run a few traces, but since I have no idea at what point the display gets corrupted, it's kind of hard to debug. Has anyone encountered this problem yet? Are there any specific functions or channels I should be looking at in the trace? Thanks, Josh Thielen __________________________________________________ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com

July 2, 2002

Re: Private Profile Regression Test

by Joshua Thielen

Dmitry, thank you for your comments! > IMO it's not very good idea to make some tests > succeed under Wine, which > clearly crashes under win2k. That would play some > bad role in the case > of the back porting Wine code to Windows, since some > code, internal > to Wine, could rely on that forbidden API behaviour. Ok. I thought that these test cases might be a problem and I wasn't sure what to do with them. I had originally commented these tests out, and then I decided to put them back in. What do you think about cases 10 and 11 in WritePrivateProfileSection where the section name is [Strange 2]? If this section name is added twice, windows does not replace the section as is expected but instead adds a duplicate [Strange 2] section. I thought this case was interesting, but I wasn't sure if it should be tested in wine. > I also have the following failures under win2k: > > Number of bytes read do not match > FAIL: c:\result.ini does not match compare1.ini > Number of bytes read do not match > FAIL: c:\result.ini does not match compare2.ini I originally wrote the test in windows, but I'm afraid something might have changed when I ported it from windows to wine test code. How do you compile and run the tests under windows? If you like, you can comment out the lines with DeleteFileA("c:\\result.ini") and then comment out either test_WritePrivateProfileString or test_WritePrivateProfileSection from the START_TEST function to see the result.ini that is supposed to match compare1.ini or compare2.ini, respectively. After looking at the code again (with rested eyes), I think that I might be missing some tests that I intended to put in and I definitely have a few typos. If you see anything else that needs to be added or changed, please let me know. Thanks again, Josh __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

July 2, 2002