July 2002 - Wine-Devel - list.winehq.org

Re: PATCH: temp fixes, again

by Alexandre Julliard

Marcus Meissner <meissner(a)suse.de> writes: > This has been some time ago, and those old libc versions should not be used > anymore for security reasons. Well the man page says "Don't use this function", and if it's broken in old glibc it can be broken on other systems too. I think it's safer to do the open ourselves, especially since this is pretty trivial to do. > If you have a description on what was broken I can whip up a configure > check though. The bug is that the temp file is created with mode 0666. But you can't do a configure check for a run-time feature/bug anyway. -- Alexandre Julliard julliard(a)winehq.com

July 27, 2002

Re: shlwapi cleanup

by Alexandre Julliard

"Jürgen Schmied" <juergenschmied(a)lycos.de> writes: > Are there any ideas if the build process could be fixed? I had a brief > look at it and I'm there... It would require that importing dlls doesn't use the .dll.so file, but some kind of import library generated separately. It's feasible, but not completely trivial. -- Alexandre Julliard julliard(a)winehq.com

July 27, 2002

Re: PATCH: temp fixes, again

by Marcus Meissner

On Fri, Jul 26, 2002 at 01:21:05PM -0700, WINE wrote: > Marcus Meissner <meissner(a)suse.de> writes: > > > Check for mkstemp, added a port implementation if it is > > not present. Use mkstemp() in various places needing tmp files. > > I'm not sure this is a good idea, mkstemp() is apparently buggy in old > libc versions. tmpnam() is actually pretty reasonable assuming it is > used correctly, which of course is not the case everywhere but that > could be fixed. This has been some time ago, and those old libc versions should not be used anymore for security reasons. If you have a description on what was broken I can whip up a configure check though. Ciao, Marcus

July 27, 2002

Re: PATCH: temp fixes, again

by Joerg Mayer

On Fri, Jul 26, 2002 at 01:21:05PM -0700, Alexandre Julliard wrote: > I'm not sure this is a good idea, mkstemp() is apparently buggy in old > libc versions. What do you mean by buggy? Is the result wrong or are the security features not working correctly? What are "old" libc versions? > tmpnam() is actually pretty reasonable assuming it is > used correctly, which of course is not the case everywhere but that > could be fixed. Depending on your answer to the questions above, I think the approach Marcus took was the right one. If need be, there could always be a configure check for the buggy implementation. ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

July 27, 2002

Re: shlwapi cleanup

by Jürgen Schmied

Are there any ideas if the build process could be fixed? I had a brief look at it and I'm there... juergen On 25 Jul 2002 at 16:34, Alexandre Julliard wrote: > "Jürgen Schmied" <juergenschmied(a)lycos.de> writes: > > > --- wine/dlls/shlwapi/Makefile.in 22 Jul 2002 20:32:53 -0000 1.21 > > +++ wine/dlls/shlwapi/Makefile.in 24 Jul 2002 19:21:55 -0000 > > @@ -4,8 +4,8 @@ > > SRCDIR = @srcdir@ > > VPATH = @srcdir@ > > MODULE = shlwapi.dll > > -# fixme: avoid ole32.dll import > > -IMPORTS = ole32 user32 gdi32 advapi32 kernel32 > > +IMPORTS = advapi32 gdi32 kernel32 user32 > > +DELAYIMPORTS = comctl32 comdlg32 mpr ole32 shell32 version winmm > > Some of these (like shell32) will create circular dependencies. This > must be avoided, our build process doesn't handle that. > > -- > Alexandre Julliard > julliard(a)winehq.com > > > --- juergen.schmied(a)debitel.net

July 27, 2002

Re: How to mantain complete CVS repository

by Max

Thanx, Dimitrie, t works good and it's really fast! Regards Max

July 27, 2002

Re: Compiling dll's

by Peter Hunnisett

On Fri, 26 Jul 2002 14:00:01 -0600, steve_lustbader(a)hsgmed.com said: > I'm trying to build a dll using WineLib. The source compiles fine under windows. When I try to compile it with winelib, I get this error: > > c++ -shared -Wl,-rpath,/usr/local/lib -Wl,-Bsymbolic -o liberrh_auto.dll.so errh.o errhReg.o liberrh_auto.dll.spec.o -lwine -lwine_unicode -lwine_uuid -lm > liberrh_auto.dll.spec.o: In function `LoadStringW': > liberrh_auto.dll.spec.o(.data+0x188): undefined reference to `DllMain' > > My spec file only contains this line: init DllMain > > And DllMain is defined in errh.cpp as (it's not prototyped in errh.h): > BOOL APIENTRY DllMain( HINSTANCE h,DWORD d, LPVOID l) extern "C" is most likely required as you've got a c++ file.... > > Any help? > > ****************************** > Steve Lustbader > > > Ciao, Peter >

July 26, 2002

Re: PATCH: temp fixes, again

by Alexandre Julliard

Marcus Meissner <meissner(a)suse.de> writes: > Check for mkstemp, added a port implementation if it is > not present. Use mkstemp() in various places needing tmp files. I'm not sure this is a good idea, mkstemp() is apparently buggy in old libc versions. tmpnam() is actually pretty reasonable assuming it is used correctly, which of course is not the case everywhere but that could be fixed. -- Alexandre Julliard julliard(a)winehq.com

July 26, 2002

Compiling dll's

by steve_lustbader＠hsgmed.com

I'm trying to build a dll using WineLib. The source compiles fine under windows. When I try to compile it with winelib, I get this error: c++ -shared -Wl,-rpath,/usr/local/lib -Wl,-Bsymbolic -o liberrh_auto.dll.so errh.o errhReg.o liberrh_auto.dll.spec.o -lwine -lwine_unicode -lwine_uuid -lm liberrh_auto.dll.spec.o: In function `LoadStringW': liberrh_auto.dll.spec.o(.data+0x188): undefined reference to `DllMain' My spec file only contains this line: init DllMain And DllMain is defined in errh.cpp as (it's not prototyped in errh.h): BOOL APIENTRY DllMain( HINSTANCE h,DWORD d, LPVOID l) Any help? ****************************** Steve Lustbader

July 26, 2002

Re: How to mantain complete CVS repository

by Tony Lambregts

LUSTBADER,STEVE (Non-A-hsgAndover,ex1) wrote: >So there's no reason to use tools/wineinstall if you're just updating the source? > > > Yes, wineinstall sets up your ~/.wine/config file and the default registries in addition to compiling wine so most of the time if you already have these set up then it is not nessesary to use wineinstall. However the structure of both the .wine/config and registries and thier contents has changed over time and as new features are added to wine. For example over time more functionality has been added to the various dlls and in the default config file various dlls now default to builtin rather than native. So running wineinstall once a month and letting it overwrite your old config is not a really bad idea. Your old config is called config.sav and you can run "diff -u config.sav config>config.dif" to see what it has changed . Tony Lambregts

July 26, 2002