August 2002 - Wine-Devel - list.winehq.org

ReactOS PSAPI released as LGPL

by Steven Edwards

Hi all. To help share code with WINE I have asked some of the ReactOS developers to license thier work as LGPL where possible. ReactOS is distributed under the GPL with certain sources being LGPL or X11/BSD. In case anyone wants to work on PSAPI in wine feel free to leech whatever. I will keep wine-devel up to date if anything else is relicensed. CVSROOT: /CVS/ReactOS Module name: reactos Repository: reactos/lib/psapi/misc/ Changes by: hyperion(a)mok.lvcm.com 02/08/31 08:36:56 Modified files: reactos/lib/psapi/misc/: dllmain.c malloc.c win32.c reactos/lib/psapi/: psapi.def psapi.edf reactos/lib/psapi/enum/: module.c process.c reactos/lib/psapi/include/internal/: psapi.h reactos/lib/psapi/: makefile psapi.def psapi.edf reactos/lib/psapi/misc/: stubs.c win32.c Log message: PSAPI: all the annoying stuff (enumeration and search, basically) has been taken care of. Only profiling remains to be implemented. PSAPI (re)licensed under LGPL to be shared with WinE, as per Steven's request. Interfaces (headers and import library definitions) and trivial sources put in the public domain Check out the subsystem-independent routines in enum/ (FWIW: the whole DLL only imports two calls from kernel32.dll, SetLastError and AreFileApisANSI): they've been tested, and they could make for a great static library, to implement task manager, tlist, ToolHelp API, etc. Maybe a future addition to mingwnt? __________________________________________________ Do You Yahoo!? Yahoo! Finance - Get real-time stock quotes http://finance.yahoo.com

Aug. 31, 2002

Re: removing mp3 code

by Igor Izyumin

On Saturday 31 August 2002 02:02 pm, Shachar Shemesh wrote: > Eric Pouech wrote: > >my point is: > >- a company X has an audio player for Win32 > >- company X ports its app to Wine using the wine source, and it's mp3 > >player and makes a closed package of it > >- it'll have to pay for the license > >so I think this has to be documented somehow > > > >A+ > > Isn't it always the case with Open Source software that, when you want > to repackage a piece of code, patent licensing requirements are yours to > figure out and comply? Why is this case any different than the Unisys > LZW patent, when free (bear) implementations were free of charge? Well, yes, but it should probably be disclosed somewhere in the readme and/or the license file. You don't want people to encounter this after they've ported and released stuff, right? Wine is not legally OBLIGATED to find patent dependencies, but I think that developers should make an effort to document known/possible patent issues. It's not that hard, just put a notice in the documentation somewhere. Note: I am not a lawyer, so this is just my opinion and not legal advice. -- -- Igor

Aug. 31, 2002

Re: removing mp3 code

by Shachar Shemesh

Eric Pouech wrote: >my point is: >- a company X has an audio player for Win32 >- company X ports its app to Wine using the wine source, and it's mp3 >player and makes a closed package of it >- it'll have to pay for the license >so I think this has to be documented somehow > >A+ > > > Isn't it always the case with Open Source software that, when you want to repackage a piece of code, patent licensing requirements are yours to figure out and comply? Why is this case any different than the Unisys LZW patent, when free (bear) implementations were free of charge? Shachar

Aug. 31, 2002

Re: quartz.dll

by Gavriel State

Hidenori, I have sent you a private reply to the above address. Since it has the appearance of a temporary address that you might not check, I am replying here as well to let you know. If there is a better address for me to reach you at, please feel free to send it to me. The quick summary: I have an idea that may be able to provide you with protection against the liability that you believe exists. Thanks, -Gav Hidenori Takeshima wrote: > I'm original developer of quartz. > I don't want my quartz code to be restored. > > There seems to be many patented algorythms. > Many codecs like MPEG-1/2/4 are patented. > The ffmpeg library seems to use > many patented codes. > And the legal state of quartz interfaces is > unclear for me. > I can't accept any liability. > > Please add all codes in CVS explicitly: > The code has been removed since the > original author requests 'please > remove my quartz codes' explicitly. > The original author don't accept any liability. > > > __________________________________________________ > Do You Yahoo!? > Yahoo! Finance - Get real-time stock quotes > http://finance.yahoo.com > -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com/ gav(a)transgaming.com

Aug. 31, 2002

Re: quartz.dll

by Gavriel State

Hidenori, I have sent you a private reply to the above address. Since it has the appearance of a temporary address that you might not check, I am replying here as well to let you know. If there is a better address for me to reach you at, please feel free to sent it to me. The quick summary: I have an idea that may be able to provide you with protection against the liability that you believe exists. Thanks, -Gav Hidenori Takeshima wrote: > I'm original developer of quartz. > I don't want my quartz code to be restored. > > There seems to be many patented algorythms. > Many codecs like MPEG-1/2/4 are patented. > The ffmpeg library seems to use > many patented codes. > And the legal state of quartz interfaces is > unclear for me. > I can't accept any liability. > > Please add all codes in CVS explicitly: > The code has been removed since the > original author requests 'please > remove my quartz codes' explicitly. > The original author don't accept any liability. > > > __________________________________________________ > Do You Yahoo!? > Yahoo! Finance - Get real-time stock quotes > http://finance.yahoo.com > -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com/ gav(a)transgaming.com

Aug. 31, 2002

Re: PATCH: rename WIN_Handle{16,32} to HWND_{16,32}

by Alexandre Julliard

Michael Stefaniuc <mstefani(a)redhat.de> writes: > - rename WIN_Handle{16,32} to HWND_{16,32} to make it consistent > with the other handle <--> handle16 macros I think you should keep WIN_Handle32 as it is, to make it clear that it does more that simply cast the handle to the right type. Especially since we will need an HWND_32 macro in other dlls that does what its name suggests. Otherwise it's going to be very confusing to have HWND_32 be sometimes a simple macro and sometimes a complex function. -- Alexandre Julliard julliard(a)winehq.com

Aug. 31, 2002

Re: Quartz DLL

by Alexandre Julliard

Lionel Ulmer <lionel.ulmer(a)free.fr> writes: > So, well, even if it's not in ReWind I do not see what (except for respect > for Hidenori's wishes) would prevent us to merge it in WineHQ. But of course if we didn't want to respect Hidenori's wishes then we wouldn't have the problem at all because the code would still be there. The fact is that Hidenori doesn't want his code distributed, and that's why I have removed it; so I'm not going to add it again just because it went through WineX first. We can certainly include the LGPL parts that have been written by Transgaming (if any, I haven't checked what they did), but not the ones written by Hidenori. -- Alexandre Julliard julliard(a)winehq.com

Aug. 31, 2002

MYOB 3.5.2 autorun

by Anand Kumria

I just tried out MYOB (a popular financial program used widely in Australia). The autorun program on the CD attempts to start programs using WinExec as WinExec("whatnews\\whatnews.exe") Unfortunately the FILE_contains_pathW function belueves that is a full path which causes (in files/directory.c): if (FILE_contains_pathW(name)) { ret = DOSFS_GetFullName( name, TRUE, full_name ); goto done; } to fail and return an error to WinExec and subsequently not do anything. The below patch fixes this problem (for me) and lets me install a number of ancillory programs. Unfortunately MYOB install uses InstallShield6 as its installer, so I've had no success with the actual program. Is there a better way to do this patch? Thanks, Anand -- `` We are shaped by our thoughts, we become what we think. When the mind is pure, joy follows like a shadow that never leaves. '' -- Buddha, The Dhammapada --- files/directory.c Sun Sep 1 01:27:00 2002 +++ files/directory.c Sun Sep 1 01:26:02 2002 @@ -821,12 +821,11 @@ } /* If the name contains an explicit path, everything's easy */ + /* But only jump if we successfully found it */ - if (FILE_contains_pathW(name)) - { - ret = DOSFS_GetFullName( name, TRUE, full_name ); + if ( FILE_contains_pathW(name) && + DOSFS_GetFullName(name, TRUE, full_name) ) goto done; - } /* Search in the specified path */

Aug. 31, 2002

Re: Quartz DLL

by Gavriel State

Lionel Ulmer wrote: > On Fri, Aug 30, 2002 at 05:37:08PM -0500, Igor Izyumin wrote: > >>Is it in rewind (the LGPL tree?) The link goes to the AFPL tree. Is this >>code also in ReWind? > > Well, I looked at one of the file in the WineX tree pointed by the link and > the license for this particular file is LGPL. And once a file is LGPLed, it > cannot be moved back to APFL (AFAIK). > > So, well, even if it's not in ReWind I do not see what (except for respect > for Hidenori's wishes) would prevent us to merge it in WineHQ. Of course, to > do that, one would have to ask WineX people what files are under which > license (ie is the file license header 'correct' for the whole file to be > sure they did not mix APFL and LGPL code in one file). The WineX head branch hasn't quite had all the license and quartz updating as yet, but you can find the detailed list in the WineX LICENSE file for the winex-2-0-branch CVS branch: http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/winex/wine/LICENS… I tried contacting Hidenori for several weeks before we included the quartz code in WineX 2.1, but without success. His email address no longer seems valid, and mail to the postmaster at his domain has gone unanswered. Google searches also turn up very little. -Gav -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com/ gav(a)transgaming.com

Aug. 31, 2002

Re: seg fault compiling wine

by Sebastian 'yath' Schmidt

On Tue, May 07, 2002 at 08:40:20PM -0500, Mason Kidd wrote: > Hi everyone, Hi, > I'm getting a segmentation fault compiling wine. This is the error > message: > [...] I got the same error. > wine-20020411 release of wine and got the same error. I am assuming > that > there is something wrong with my setup, because I compiled the CVS > source about 2 weeks ago without problems, which was after the > wine-20020411 release. Any ideas? It seems the configure-script is broken; it detects mmap64(), but there isn't mmap64(). So size_t gets 32 bits and off_t 64 bits. fstat() returns a structure with a member of type off_t, which is handed over to mmap(), which wants a size_t. mmap() gets 0 as size, returns a NULL-pointer, and in check_header(), where get_dword() the program receives a segmentation fault. Fix: change the "#define _FILE_OFFSET_BITS 64" in config.h to "#undef _FILE_OFFSET_BITS" and recompile. Sebastian -- pub 1024D/5A13B048 2001-08-28 Sebastian Schmidt (yath) <yathen(a)web.de> Key fingerprint = 8D25 C96B 3DE0 C7D0 AE01 6824 BC15 6273 5A13 B048 VI VI VI The editor of the beast.

Aug. 31, 2002