August 2002 - Wine-Devel - list.winehq.org

Bug #931

by Dusan Vujosevic

I seems that the problem I noted in bug #931 goes away when "PerfectGraphics" is set to false (????). I tracked the problem down to implementation of PATINVERT in BITBLT_InternalStretchBlt() (in graphics/x11drv/bitblt.c). It check whether 'perfect_graphics' is on and if it is it actually doesn't do the drawing: case PATINVERT: /* 0x5a */ if (perfect_graphics()) break; Maybe I'm missing soemthing here but I think that test should be: case PATINVERT: /* 0x5a */ if (!perfect_graphics()) break; That would give a more logical behaviour where there would not be any drawing errors when "PerfectGraphics" is set to True. (There are other spots where this is used in similar fashion) Another question is why have the "PerfectGraphics" option at all when it produces drawing artifacts? D.

Aug. 8, 2002

Re: Wine release 20020804

by Rein Klazes

On 04 Aug 2002 12:46:48 -0700, you wrote: > If you submitted a patch, please check to make sure it has been > included in the new release. Looking at the problems of the submittor of bug #952, I noticed that this patch wasn't applied: http://www.integrita.com/cgi-local/lwgate.pl/WINE-PATCHES/archives/2002-07/… Are there any objections? I think it is only reproducing Microsofts winsock behaviour more faithfully. Rein. -- Rein Klazes rklazes(a)xs4all.nl

Aug. 8, 2002

Incomplete support in Win32

by Shachar Shemesh

Hi all, As you may know (I make a lot more noise than actual work), I am trying to implement BiDi support for WINE. The most promising place to start seemed to be GetCharacterPlacement, that does everything even remotely BiDi related. The most immediate thing to do was to call GetCharacterPlacement from ExtTextOut in order to do the BiDi rearrenging. In typical MS fashion, however, it seems that this will not work. Despite the fact that you are supposed to be able to call GetCharacterPlacement once, and then call ExtTextOut with the result as many times as necessary (speeding up the process, and suggesting that GetCharacterPlacement can do anything ExtTextOut can do), it seems there is one thing that ExtTextOut is expected to know how to do, and GetCharacterPlacement does not know. For those who are really interested, this is specfying the base directionality of the paragraph. I am pretty sure the way Windows implements this is by having a common parent function used for reordering by both ExtTextOut and GetCharacterPlacement. I think such an arrangment is awfully crude. I was considering an alternative solution, and would like your opinion. What I thought of doing was adding a bit to the flags GetCharacterPlacement gets, which says "right to left paragraph, if you'll be so kind". My question is - how acceptable is such a behaviour. Is that a huge no-no, or is that a harmless little tweak? It goes without saying that I will document the fact that this is a WINE only flag, and that there are unused bits in the GetCharacterPlacement current flags set. Another alternative I was considering was to add a directional push at the start of the string in order to achieve this without changing the algorithm. The problem is that I am not sure what affect this will have on the reordering, not to mention the fact that I will then need to copy and widen the string inside ExtTextOut, which is an inconvinence to say the least. Your opinios, please. Shachar

Aug. 7, 2002

Re: regarding bug 756

by Dimitrie O. Paun

> From: Daniel Gudbjartsson <dfg(a)decode.is> > static int char2digit(char c, int base) { > - if ((c>='0') && (c<='9') && (c<='0'+base-1)) return (c-'0'); > + if ((c>='0') && (c<='9') && (c<='0')+base-1) return (c-'0'); First off, I can't parse the above. It's A && B && C + base -1. What is that?!? If you intend to clean it up, make it more readable: + if (('0' <= c) && (c <= min('0'+base-1, '9')) return c-')'; 'cause that's what you want to say: if c is a valid digit (but no more then '9') in the given base, right? -- Dimi.

Aug. 7, 2002

Re: AutoCAD2000 again and CreateFiber

by Malte Cornils

On Friday, 2. August 2002 08:29, you wrote: > >Any idea ? Is there some plan to implement xxxxxFiber functions, or >it's > > too difficult ? I'd like to know who's working on it too, since the Fiber API is required for Adobe InDesign 1.5 too and because if nobody will do it, I'll have a look at it sometimes this year; no promises though. -Malte #8-)

Aug. 7, 2002

Re: PATCH: Convert HDRVR to a void*

by Alexandre Julliard

Michael Stefaniuc <mstefani(a)redhat.de> writes: > 1.) just include dlls/winmm/winemm.h > 2.) put the $HANDLE_{16,32} macros into include/wownt32.h surrounded by > #ifdef __WINE__ and include wownt32.h > 3.) put the $HANDLE_{16,32} macros into one of the include/wine/*.h > header files (in which?) > 4.) create include/wine/handleconv.h and put all handle conversions into > it > > I would prefer 4 and 3 but I don't mind to do it in any way. 5) duplicate the HDRVR_16 macro into msvideo. This should be a rare problem since in general 16-bit functions are not exported across dlls, so duplicating the macro shouldn't really be a problem. And we can always change it later if it turns out that we have a lot of duplicated stuff. -- Alexandre Julliard julliard(a)winehq.com

Aug. 7, 2002

Re: Bugzilla rights

by Alexandre Julliard

Tony Lambregts <tony_lambregts(a)telusplanet.net> writes: > I also notice that some people who have gotten patches into wine are > not in the authors list (myself for one --<snifle>). I do not know > what that means other than that it is not up to date. Could someone > tell me what up with that. Because it has to be done manually, I only update the AUTHORS file occasionally (usually when someone complains <g>). I'll update it. -- Alexandre Julliard julliard(a)winehq.com

Aug. 7, 2002

Re: 20020804 - Sparc / Solaris fixes

by Shachar Shemesh

Hi Gregg, I couldn't get WINE to compile on sparc at all. Is there anything I am missing regarding causing it to compile winelib only? Special command lines for configure? I just used the vanilla "./configure && make depend && make". Shachar Gregg Mattinson wrote: >Here's the patches required to get 20020804 compiled on Sparc / Solaris with cc. > >License: X11 / LGPL, as usual. > >comments.diff: > - Remove C++ style comments > >ddraw.diff: > - Remove non-static structure initializers > - Fix initialization order of full_rect structure. > >msvcrt.diff: > - Fix the IX86_ONLY macro. This has been bugging me for a while. > >shlwapi_tests.diff: > - Fix the SHQueryValueEx test so nUsedBuffer is currect. > >strings.diff: > - Removed multi-line string constant from classes.c > >utils.diff: > - cc doesn't support __attribute__(...). > >widl.diff: > - cc doesn't support typeof() in macros, and since the LINK_LAST macro was >always used with a attr_t type, I replaced it. > >Gregg Mattinson >Co-op Developer >Sun Microsystems of Canada > > >------------------------------------------------------------------------ > >Index: dlls/ole32/compobj.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/ole32/compobj.c,v >retrieving revision 1.3 >diff -u -r1.3 compobj.c >--- /tmp/T03RaGiL Tue Aug 6 13:11:13 2002 >+++ compobj.c Tue Aug 6 13:09:03 2002 >@@ -73,7 +73,7 @@ > */ > > typedef struct { >- unsigned char threadingModell; // we use the COINIT flags >+ unsigned char threadingModell; /* we use the COINIT flags */ > unsigned long threadID; > long AppartmentLockCount; > } OleAppartmentData; >Index: dlls/shell32/shlfolder.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/shell32/shlfolder.c,v >retrieving revision 1.3 >diff -u -r1.3 shlfolder.c >--- /tmp/T0vHaqLL Tue Aug 6 13:25:08 2002 >+++ shlfolder.c Tue Aug 6 13:22:54 2002 >@@ -381,7 +381,7 @@ > nextpidl2; > IShellFolder *psf; > >- // test for empty pidls >+ /* test for empty pidls */ > BOOL isEmpty1 = _ILIsDesktop (pidl1); > BOOL isEmpty2 = _ILIsDesktop (pidl2); > >@@ -392,26 +392,26 @@ > if (isEmpty2) > return 1; > >- // test for different types. Sort order is the PT_* constant */ >+ /* test for different types. Sort order is the PT_* constant */ > type1 = _ILGetDataPointer (pidl1)->type; > type2 = _ILGetDataPointer (pidl2)->type; > if (type1 != type2) > return (type1 - type2); > >- // test for name of pidl >+ /* test for name of pidl */ > _ILSimpleGetText (pidl1, szTemp1, MAX_PATH); > _ILSimpleGetText (pidl2, szTemp2, MAX_PATH); > nReturn = strcasecmp (szTemp1, szTemp2); > if (nReturn != 0) > return nReturn; > >- // test of complex pidls >+ /* test of complex pidls */ > firstpidl = ILCloneFirst (pidl1); > nextpidl1 = ILGetNext (pidl1); > nextpidl2 = ILGetNext (pidl2); > >- // optimizing: test special cases and bind not deeper >- // the deeper shellfolder would do the same >+ /* optimizing: test special cases and bind not deeper */ >+ /* the deeper shellfolder would do the same */ > isEmpty1 = _ILIsDesktop (nextpidl1); > isEmpty2 = _ILIsDesktop (nextpidl2); > >@@ -421,7 +421,7 @@ > nReturn = -1; > } else if (isEmpty2) { > nReturn = 1; >- // optimizing end >+ /* optimizing end */ > } else if (SUCCEEDED (IShellFolder_BindToObject (iface, firstpidl, NULL, &IID_IShellFolder, (LPVOID *) & psf))) { > nReturn = IShellFolder_CompareIDs (psf, lParam, nextpidl1, nextpidl2); > IShellFolder_Release (psf); > > >------------------------------------------------------------------------ > >Index: dlls/ddraw/dsurface/dib.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/ddraw/dsurface/dib.c,v >retrieving revision 1.3 >diff -u -r1.3 dib.c >--- /tmp/T0u_aqgL Tue Aug 6 13:08:39 2002 >+++ dib.c Tue Aug 6 13:02:52 2002 >@@ -413,8 +413,13 @@ > > /* The easy case : the source-less blits.... */ > if (src == NULL) { >- RECT full_rect = { 0, 0, ddesc.dwHeight, ddesc.dwWidth }; >+ RECT full_rect; > RECT temp_rect; /* No idea if intersect rect can be the same as one of the source rect */ >+ >+ full_rect.left = 0; >+ full_rect.top = 0; >+ full_rect.right = ddesc.dwWidth; >+ full_rect.bottom = ddesc.dwHeight; > IntersectRect(&temp_rect, &full_rect, &xdst); > xdst = temp_rect; > } else { > > >------------------------------------------------------------------------ > >Index: dlls/msvcrt/math.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/msvcrt/math.c,v >retrieving revision 1.2 >diff -u -r1.2 math.c >--- /tmp/T0wHaaWK Tue Aug 6 11:17:53 2002 >+++ math.c Tue Aug 6 10:33:59 2002 >@@ -292,7 +292,7 @@ > > /* The above cannot be called on non x86 platforms, stub them for linking */ > >-#define IX86_ONLY(func) double MSVCRT_##func(void) { return 0.0; } >+#define IX86_ONLY(func) double func(void) { return 0.0; } > > IX86_ONLY(_CIacos) > IX86_ONLY(_CIasin) > > >------------------------------------------------------------------------ > >Index: dlls/shlwapi/tests/shreg.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/shlwapi/tests/shreg.c,v >retrieving revision 1.2 >diff -u -r1.2 shreg.c >--- /tmp/T023aGXK Tue Aug 6 11:18:28 2002 >+++ shreg.c Tue Aug 6 10:30:58 2002 >@@ -108,8 +108,8 @@ > /****** SHQueryValueExA ******/ > > sTestedFunction = "SHQueryValueExA"; >- nUsedBuffer1 = max(strlen(sExpTestpath1)+1, strlen(sTestpath1)); >- nUsedBuffer2 = max(strlen(sExpTestpath2)+1, strlen(sTestpath2)); >+ nUsedBuffer1 = max(strlen(sExpTestpath1)+1, strlen(sTestpath1)+1); >+ nUsedBuffer2 = max(strlen(sExpTestpath2)+1, strlen(sTestpath2)+1); > /* > * Case 1.1 All arguments are NULL > */ > > >------------------------------------------------------------------------ > >Index: dlls/shell32/classes.c >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/dlls/shell32/classes.c,v >retrieving revision 1.2 >diff -u -r1.2 classes.c >--- /tmp/T0tfaiIL Tue Aug 6 13:18:33 2002 >+++ classes.c Tue Aug 6 13:16:03 2002 >@@ -65,8 +65,8 @@ > > RegCloseKey(hkey); > >- TRACE("--UE; >-} %s\n", szFileType ); >+ TRACE("--UE;\n" >+"} %s\n", szFileType ); > > return TRUE; > } > > >------------------------------------------------------------------------ > >Index: tools/widl/utils.h >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/tools/widl/utils.h,v >retrieving revision 1.1 >diff -u -r1.1 utils.h >--- /tmp/T0D2a4JL Tue Aug 6 13:22:30 2002 >+++ utils.h Tue Aug 6 11:35:29 2002 >@@ -29,6 +29,10 @@ > void *xrealloc(void *, size_t); > char *xstrdup(const char *str); > >+#ifndef __GNUC__ >+#define __attribute__(X) >+#endif >+ > int yyerror(const char *s, ...) __attribute__((format (printf, 1, 2))); > int yywarning(const char *s, ...) __attribute__((format (printf, 1, 2))); > void internal_error(const char *file, int line, const char *s, ...) __attribute__((format (printf, 3, 4))); >Index: tools/wmc/utils.h >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/tools/wmc/utils.h,v >retrieving revision 1.1 >diff -u -r1.1 utils.h >--- /tmp/T0i7aqKL Tue Aug 6 13:22:30 2002 >+++ utils.h Tue Aug 6 13:20:06 2002 >@@ -31,6 +31,10 @@ > void *xrealloc(void *, size_t); > char *xstrdup(const char *str); > >+#ifndef __GNUC__ >+#define __attribute__(X) >+#endif >+ > int yyerror(const char *s, ...) __attribute__((format (printf, 1, 2))); > int xyyerror(const char *s, ...) __attribute__((format (printf, 1, 2))); > int yywarning(const char *s, ...) __attribute__((format (printf, 1, 2))); >Index: tools/wrc/utils.h >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/tools/wrc/utils.h,v >retrieving revision 1.2 >diff -u -r1.2 utils.h >--- /tmp/T0s_aOKL Tue Aug 6 13:22:31 2002 >+++ utils.h Tue Aug 6 11:35:20 2002 >@@ -31,6 +31,10 @@ > void *xrealloc(void *, size_t); > char *xstrdup(const char *str); > >+#ifndef __GNUC__ >+#define __attribute__(X) >+#endif >+ > int yyerror(const char *s, ...) __attribute__((format (printf, 1, 2))); > int yywarning(const char *s, ...) __attribute__((format (printf, 1, 2))); > void internal_error(const char *file, int line, const char *s, ...) __attribute__((format (printf, 3, 4))); > > >------------------------------------------------------------------------ > >Index: tools/widl/widltypes.h >=================================================================== >RCS file: /opcom/comp/ws/wine/CVSROOT/wine/tools/widl/widltypes.h,v >retrieving revision 1.1 >diff -u -r1.1 widltypes.h >--- /tmp/T0fwaaiL Tue Aug 6 13:10:19 2002 >+++ widltypes.h Tue Aug 6 11:40:33 2002 >@@ -36,7 +36,7 @@ > type *l_prev; > > #define LINK(x,y) do { x->l_next = y; if (y) y->l_prev = x; } while (0) >-#define LINK_LAST(x,y) do { if (y) { typeof(x) _c = x; while (_c->l_next) _c = _c->l_next; LINK(_c, y); } } while (0) >+#define LINK_LAST(x,y) do { if (y) { attr_t *_c = x; while (_c->l_next) _c = _c->l_next; LINK(_c, y); } } while (0) > #define LINK_SAFE(x,y) do { if (x) LINK_LAST(x,y); else { x = y; } } while (0) > > #define INIT_LINK(x) do { x->l_next = NULL; x->l_prev = NULL; } while (0) > >

Aug. 6, 2002

Re: Bugzilla rights

by Shachar Shemesh

Tony Lambregts wrote: > I also notice that some people who have gotten patches into wine are > not in the authors list (myself for one --<snifle>). I do not know > what that means other than that it is not up to date. Could someone > tell me what up with that. > > > Tony Lambregts > Speaking for myself, it didn't feel right to submit a patch that added me to the author's list, so I didn't. Someone actually suggested writing a perl script that will go over the changelog and generate the file, sorted by number of lines contributed ;-). A probably better solution would have been to use "cvs annotate" to count number of lines. This would also remove people from the file if their lines were no longer used. That won't work, of course, as all commits are marked as coming from either ridgway or juliard. Shachar

Aug. 6, 2002

Bugzilla rights

by Tony Lambregts

Jeremy Newman wrote: >Well... since you said please. ;-) > >On Mon, 2002-08-05 at 13:23, Tony Lambregts wrote: > > >>Well if Jeremy Newman will give me the access I need to set this up, I >>would be glad to "fix up" each developer that has an account in >>Bugzilla. (Pretty Please). >> >> > > > I went through the AUTHORS list and gave everyone that had a bugzilla account (that I could find) the abillity to confirm and change bugs. If I missed anyone I please tell me and I will fix you up. I also notice that some people who have gotten patches into wine are not in the authors list (myself for one --<snifle>). I do not know what that means other than that it is not up to date. Could someone tell me what up with that. Tony Lambregts

Aug. 6, 2002