September 2002 - Wine-Devel

Re: [PATCH] winemaker fixes

by Martin Wilck

Francois, you seem to be working on winemaker again. I wonder if you still recall the patch I sent on May 22. I am a bit irritated that none of the fixes I sent with that patch have so far gone into CVS. If I recall right, only one of the changes I made was controversial (whether the wrapper app should call FreeLibrary() or not). In particular, - winemaker still doesn't get --nomfc right - winemaker completely messes up wrapped "cuiexe" applications. (I am not sure for guiexe, but I guess that has been tested more thoroughly). I will prepare a series of patches that are essentially equivalent with my old stuff. The FreeLibrary() issue seems to have been fixed otherwise (no core dumps anymore), so I am leaving that out. _Please_ have a look at my stuff this time!! The patches will apply over the patch you submitted to wine-patches yesterday. If they conflict with any patches you haven't submitted yet, please tell me so that we can resolve the conflicts. Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

Sept. 6, 2002

Winelib apps containing upper case letters don't run

by Martin Wilck

The patch below fixes a problem introduced August 14 (process.c 1.196): Names of "builtin" apps (into which category fall also Winelib apps) aren't found if they aren't lowercase-only. Explanation: Create a directory "Test" and there a file foo.cpp like this: #include <iostream.h> int main (void) { cout << "Hello world!" <<endl; return 0; } In the "Test" directory, run $ winemaker --cuiexe .; ./configure; make; ./Test => error. This fails because the "Test" shell script (aka "wineloader") calls "wine Test.exe", and this ends up searching "test.exe.so" in the DLL path. My patch below fixes that, but I'm not sure if it is the right thing to do. Perhaps wineloader should simply look for "Test.exe.so" rather than for "Test.exe". This is only one of several problems I have with the current winelib/winemaker. Martin Patch: process.diff Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com> scheduler: process.c open_builtin_exe_file(): Allow running Winelib apps whose names contain upper case letters. Index: scheduler/process.c =================================================================== RCS file: /home/wine/wine/scheduler/process.c,v retrieving revision 1.198 diff -u -r1.198 process.c --- scheduler/process.c 27 Aug 2002 01:13:59 -0000 1.198 +++ scheduler/process.c 6 Sep 2002 12:05:17 -0000 @@ -265,11 +265,15 @@ { char exename[MAX_PATH], *p; const char *basename = get_basename(name); + void *dll = NULL; if (strlen(basename) >= sizeof(exename)) return NULL; strcpy( exename, basename ); for (p = exename; *p; p++) *p = FILE_tolower(*p); - return wine_dll_load_main_exe( exename, error, error_size, test_only ); + dll = wine_dll_load_main_exe( exename, error, error_size, test_only ); + if (!dll) + dll = wine_dll_load_main_exe( basename, error, error_size, test_only ); + return dll; } -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

Sept. 6, 2002

Re: Comctrl generic notification support

by Dimitrie O. Paun

On September 5, 2002 07:21 pm, Alexandre Julliard wrote: > Can't say that I care much either. Personally I wouldn't use > underscores here, but if you like it that way it's fine. But of course > it will get you in trouble with the cosmetics police (hi Andreas ;-) Fine, fine ... resent without the underscores. -- Dimi.

Sept. 6, 2002

Re: Comctrl generic notification support

by Alexandre Julliard

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > I don't really care... I also don't think it's a problem, but if you feel strong about it, > I'll rename it. Alexandre? Can't say that I care much either. Personally I wouldn't use underscores here, but if you like it that way it's fine. But of course it will get you in trouble with the cosmetics police (hi Andreas ;-) -- Alexandre Julliard julliard(a)winehq.com

Sept. 5, 2002

Re: Atom test fix

by Dmitry Timoshkov

"Francois Gouget" <fgouget(a)free.fr> wrote: > Conformance tests must not use Wine-specific headers (like > wine/unicode.h) otherwise they will not compile on Windows. > > wine/test.h is the only exception. > > Changelog: > > * dlls/kernel/tests/atom.c > > Do not include wine/unicode.h > Duplicate strlenW I would suggest to simply replace it by lstrlenW, instead of duplicating code. -- Dmitry.

Sept. 5, 2002

Re: Comctrl generic notification support

by Dimitrie O. Paun

On September 5, 2002 02:42 pm, Andreas Mohr wrote: > > +inline static LRESULT __send_notify(HWND hwnd, UINT code, NMHDR *hdr) > > Isn't using double underscore for such non-system functions rather pretty weird ? I don't really care... I also don't think it's a problem, but if you feel strong about it, I'll rename it. Alexandre? -- Dimi.

Sept. 5, 2002

Re: Comctrl generic notification support

by Andreas Mohr

Hi, On Thu, Sep 05, 2002 at 01:54:50PM -0400, Dimitrie O. Paun wrote: > ChangeLog > Add generic notification support to comctl32 > > Index: dlls/comctl32/comctl32.h > =================================================================== > RCS file: /var/cvs/wine/dlls/comctl32/comctl32.h,v > retrieving revision 1.16 > diff -u -r1.16 comctl32.h > --- dlls/comctl32/comctl32.h 31 May 2002 23:25:43 -0000 1.16 > +++ dlls/comctl32/comctl32.h 5 Sep 2002 17:33:49 -0000 > @@ -4,6 +4,7 @@ > * > * Copyright 1999 Thuy Nguyen > * Copyright 1999 Eric Kohl > + * Copyright 2002 Dimitrie O. Paun > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -23,6 +24,8 @@ > #ifndef __WINE_COMCTL32_H > #define __WINE_COMCTL32_H > > +#include "commctrl.h" > + > extern HMODULE COMCTL32_hModule; > extern HBRUSH COMCTL32_hPattern55AABrush; > > @@ -125,4 +128,132 @@ > #define WINE_FILEVERSION 5, COMCTL32_VERSION_MINOR, 0, 0 > #define WINE_FILEVERSIONSTR "5.00" > > +/* Notification support */ > + > +inline static LRESULT __send_notify(HWND hwnd, UINT code, NMHDR *hdr) Isn't using double underscore for such non-system functions rather pretty weird ? (or IOW: even strongly discouraged ?) -- Microsoft Licensing 6.0: "Pay us now in advance, so that we can own you later."

Sept. 5, 2002

Re: VersionNumber reg. key

by Andreas Mohr

On Thu, Sep 05, 2002 at 09:40:30AM -0700, Bill Medland wrote: > Question; is the "current version" a property of the client or the server; I > guess its the client. It's a property of the client. However, the registry data is a property of the server. This is a conflict, of course. In this case I'm afraid we'll have to register the version value the first wine instance has. This method will break if you decide to run programs with *differing* Windows version requirements within the same wineserver session, of course. :-\ (as the first program's setting/requirement will be used for all wine sessions) -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://mohr.de.tt

Sept. 5, 2002

Re: VersionNumber reg. key

by Bill Medland

Question; is the "current version" a property of the client or the server; I guess its the client. I would suggest that when the registry is loaded the value is modified in line with the current version. Then we only need to check as we load the registry; we don't need to keep watching for the question (especially because it can be asked in so many different ways). Bill ----- Original Message ----- From: "Jeff Smith" <whydoubt(a)hotmail.com> To: <wine-devel(a)winehq.com> Sent: Thursday, September 05, 2002 7:19 AM Subject: Re: VersionNumber reg. key > My $0.02: > I say don't create, and dynamically 'lie' about it's value. > I'm sure it's easier said than done, but that's my thoughts, anyway. > > -- Jeff S > > > >From: Ender <winedev(a)admdev.com> > >To: wine-devel(a)winehq.com > >Subject: VersionNumber reg. key > >Date: Wed, 4 Sep 2002 21:28:32 -0500 (CDT) > > >read the HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\VersionNumber > >key. And of course, as this is a 'required' key in Windows, there was no > >code to cope with failure :) > > >whether or not Wine should dynamically 'lie' about this registry key, > >depending what winver the current thread is running in. > > > - Ender > > > > > _________________________________________________________________ > Chat with friends online, try MSN Messenger: http://messenger.msn.com > > >

Sept. 5, 2002

Re: VersionNumber reg. key

by Jeff Smith

My $0.02: I say don't create, and dynamically 'lie' about it's value. I'm sure it's easier said than done, but that's my thoughts, anyway. -- Jeff S >From: Ender <winedev(a)admdev.com> >To: wine-devel(a)winehq.com >Subject: VersionNumber reg. key >Date: Wed, 4 Sep 2002 21:28:32 -0500 (CDT) >read the HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\VersionNumber >key. And of course, as this is a 'required' key in Windows, there was no >code to cope with failure :) >whether or not Wine should dynamically 'lie' about this registry key, >depending what winver the current thread is running in. > - Ender _________________________________________________________________ Chat with friends online, try MSN Messenger: http://messenger.msn.com

Sept. 5, 2002