January 2003 - Wine-Devel - list.winehq.org

Re: RFH: ICON statement

by Dimitrie O. Paun

On January 2, 2003 12:37 pm, Mehmet YASAR wrote: > I just tested icon ressource beginning with weird characters like > "!icon" or "-icon" and that works (tested under VC++/sp5). Cool, thanks. I've sent a patch in to support them. BTW, are these chars also accepted in filenames? -- Dimi.

Jan. 3, 2003

wine.m4 install bug

by Enrico Horn

Hi, When installing the wine.m4 macro file you cant just use the <prefix>/share/aclocal dir of wine as destination. You need to use the <prefix>/share/aclocal dir of automake as this is the only path where the m4 files will be found. Ciao Enrico farmboy1(a)subdimension.com

Jan. 2, 2003

regression with CFLAGS=-g

by Shachar Shemesh

Hi, There is a regression when compiling wine with CFLAGS=-g. The latest CVS throws an unhandled exception when exiting notepad. When notepad is compiled with CFLAGS=-g -O2 (the defaults), there is no crash even if the rest of the libraries are compiled with -g. This also happens on Wine 20021216. Any idea? Shachar

Jan. 2, 2003

Fixing SUBLANG_NEUTRAL (was: Re: Fixing include quotes (was: Re: conformance test for ShellExecute))

by Shachar Shemesh

While we are on the subject of api_check and such, how about changing SUBLANG_NEUTRAL in all non-neutral languages to SUBLANG_DEFAULT, as it should be? Sh. Dimitrie O. Paun wrote: >On January 2, 2003 02:07 pm, Dan Kegel wrote: > > >>There is one downside: it may make old patches harder to >>apply, and it may make it harder to sync with other >>trees (e.g. rewind). >> >> > >In general yes, but I don't think it's a big problem in this >particular case where _only_ #include statements are touched. >These are seldomly changed anyway. As for other trees, all of >Patrik work is BSD AFAIK, so everybody can run the script on >their trees as well. > > >

Jan. 2, 2003

Re: Fixing SUBLANG_NEUTRAL (was: Re: Fixing include quotes (was: Re: conformance test for ShellExecute))

by Dimitrie O. Paun

On January 2, 2003 04:05 pm, Shachar Shemesh wrote: > While we are on the subject of api_check and such, how about changing > SUBLANG_NEUTRAL in all non-neutral languages to SUBLANG_DEFAULT, as it > should be? Are you volunteering? :) If it's supposed to be this way, a patch would be most appreciated, me thinks <g> -- Dimi.

Jan. 2, 2003

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

by Dan Kegel

Dimitrie O. Paun wrote: > Bottom line, since the change is free (the work is done by a script), > and there is little chance of conflicts with other patches (it touches > only the include statements), I think it's worth doing now. There is one downside: it may make old patches harder to apply, and it may make it harder to sync with other trees (e.g. rewind). On the other hand, encouraging people to use the tool to tidy up any files they're working on makes patches harder to read, as it mixes formatting changes with real changes. Six of one, half dozen of another... - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

Jan. 2, 2003

Re: Make RECT === RECTL, fix compile warnings, use uniform format

by Alexandre Julliard

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > As for the new debug* functions, most nontrivial ones are not that > small. Do you want them defined as static inline in wine/debug.h, > or exported from ntdll as the other ones? In fact, why not create > a helper DLL (winedebug) that holds all of this, and that can be > used on Windows as well, when we port most of our stuff over? IMO this would be a mechanism to use only for trivial functions that can be put inline; more complex ones should be implemented in their respective dlls. We definitely don't want a big centralized module that dumps all known structures. -- Alexandre Julliard julliard(a)winehq.com

Jan. 2, 2003

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

by Alexandre Julliard

"Patrik Stridvall" <ps(a)leissner.se> writes: > I think it is better than Alexandre runs > winapi_cleanup --include-quotes > himself if he thinks it does the correct things. > If not please inform me what the problem is. > > In my tree, the patch is over 800k. I'm not sure there's much point in fixing all the C files. It works fine the way it is now, the only thing that we need the change is the exported headers. -- Alexandre Julliard julliard(a)winehq.com

Jan. 2, 2003

Re: argv[0] needs to be an absolute path

by Dan Kegel

"sometimes" == "if the program was invoked with a relative path" BTW the one-line patch I submitted seems to just preserve the D: in the example I gave. This is good enough to make my test case work, but won't fix all uses, I think. - Dan Sylvain Petreolle wrote: > What do you mean by "sometimes" ? > > >>outputs an absolute path on Windows, but sometimes >>outputs a relative path on Wine. This causes the >>commandline >> $ wine d:setup >>to fail to find its files properly if it uses the >>basename of argv[0]. One example of this is msvc4.0 >>(although it only tries this if an earlier method fails, >>so there's another bug lurking). >> >>I am about to submit a one-line patch to fix this to >>wine-patches. (If I weren't a wimp, I'd figure out >>a way to submit a regression test, too, although >>it'd be a strange one; most of our tests don't need >>to invoke Wine itself from the Unix commandline!) >> >>The same problem exists for programs launched from other >>wine programs, e.g. from inside wcmd. >>That's another code path, and I couldn't find a >>one-line fix for that one. >>- Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

Jan. 2, 2003

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

by Dimitrie O. Paun

On January 2, 2003 02:07 pm, Dan Kegel wrote: > There is one downside: it may make old patches harder to > apply, and it may make it harder to sync with other > trees (e.g. rewind). In general yes, but I don't think it's a big problem in this particular case where _only_ #include statements are touched. These are seldomly changed anyway. As for other trees, all of Patrik work is BSD AFAIK, so everybody can run the script on their trees as well. -- Dimi.

Jan. 2, 2003