January 2003 - Wine-Devel - list.winehq.org

Re: Patch for crash caused by XIM and make XIM functions properly

by Dmitry Timoshkov

"liu spider" <liuspider(a)yahoo.com> wrote: > @@ -1000,8 +1100,11 @@ > > wine_tsx11_lock(); > if (xic) > - ascii_chars = XmbLookupString(xic, event, Str, sizeof(Str), &keysym, NULL); > - else > + { > + if(XIM_KeyEvent(GetFocus(), xic, event)) > + return; > + } > + > ascii_chars = XLookupString(event, Str, sizeof(Str), &keysym, NULL); > wine_tsx11_unlock(); I can't comment on other parts, but in the above chunk the return after a successful XIM_KeyEvent() leaves X11 lock held. -- Dmitry.

Jan. 24, 2003

Re: Packagers Guide Update #5

by Tom Wickline

Andreas Mohr wrote: > On Thu, Jan 23, 2003 at 11:42:31PM -0500, Tom Wickline wrote: > >>Changelog >> >>Update the Sample config > > IMHO this doesn't even have *any* business in the Packaging Guide. > The guide should simply contain a pointer to the REAL sample config file, > otherwise this exactly leads to the permanent updating mess which you > just demonstrated ;-) > I am aware of this... There was a Sample win.ini at the end of this list and I moved it here. Now it is the Sample config file.... And put a Sample RH .spec in its place. I looked at the config sample and it gets updated about once a month on average but im trying to fill holes. = http://www.winehq.com/Docs/wine-pkg/pkg-wineconf.shtml I'm not saying this is the best approach but at least it is upto date! And when _you_ or anyone else has time we can tweak it ;-) Flames, Comments, and most of all Volinteers and Patches are Welcome. Tom

Jan. 24, 2003

Re: Packagers Guide Update #5

by Andreas Mohr

On Thu, Jan 23, 2003 at 11:42:31PM -0500, Tom Wickline wrote: > Changelog > > Update the Sample config IMHO this doesn't even have *any* business in the Packaging Guide. The guide should simply contain a pointer to the REAL sample config file, otherwise this exactly leads to the permanent updating mess which you just demonstrated ;-) -- The Declaration of Software Freedom: http://freedevelopers.net/freedomdec/index.php

Jan. 24, 2003

Packaging Guide Update #6

by Tom Wickline

Francois pointed out that I should fix <wineconf> as sgml will pick it up as a tag. Also replaced the <para> tag with <programlisting> to prevent the text from bunching together. Changelog Fix <wineconf> tag replace <para> tag with <programlisting> Tom Index: documentation/packaging.sgml =================================================================== RCS file: /opt/cvs-commit/wine/documentation/packaging.sgml,v retrieving revision 1.12 diff -u -r1.12 packaging.sgml --- documentation/packaging.sgml 24 Jan 2003 00:49:05 -0000 1.12 +++ documentation/packaging.sgml 24 Jan 2003 08:47:40 -0000 @@ -1442,7 +1442,9 @@ This is the sample config file provided with wine 20030115. You can edit this file to best suit the needs of your intended user. </para> - <para> + + <programlisting> + WINE REGISTRY Version 2 ;; All keys relative to \\Machine\\Software\\Wine\\Wine\\Config @@ -1512,6 +1514,8 @@ ;"ShowDotFiles" = "1" "ShellLinker" = "wineshelllink" +# <wineconf> + [Version] ; Windows version to imitate (win95,win98,winme,nt351,nt40,win2k,winxp,win20,win30,win31) ;"Windows" = "win98" @@ -1720,6 +1724,20 @@ ;"UseDnsComputerName" = "N" ;; sample AppDefaults entries + +; 3 InstallShield versions who like to put their full screen window in front, +; without any chance to switch to another X11 application. +; So just catch them in a desktop window. + +[AppDefaults\\_INS5576._MP\\x11drv] +"Desktop" = "640x480" + +[AppDefaults\\_INS5176._MP\\x11drv] +"Desktop" = "640x480" + +[AppDefaults\\_INS0466._MP\\x11drv] +"Desktop" = "640x480" + ;[AppDefaults\\iexplore.exe\\DllOverrides] ;"shlwapi" = "native" ;"rpcrt4" = "native" @@ -1742,7 +1760,9 @@ ;[AppDefaults\\pickygame.exe\\dsound] ;"EmulDriver" = "N" - </para> +# <wineconf> + + </programlisting> </sect1> </chapter>

Jan. 24, 2003

Re: Packagers Guide Update #5

by Tom Wickline

Francois Gouget wrote: > Hmmm, anything of the form <xxx> is a tag sgml so the above > will not work very well. You should use: > > # <wineconf> Yea I see where it could cause problems now .. > > > I noticed another problem. This section is in a simple <para> tag. > That means that linefeeds are not significant and everything can be > bunched together. I think what's needed is to replace the <para> tags > with <screen> tags. What about <programlisting> ? I'm still learning sgml. Im doing all this by hand in a simple text editor :) > > With these two changes it should work great. Thanks for the help! Tom > -- One People, One Reich, One Leader - Adolph Hitler, Nazi Germany One World, One Web, One Program - William Gates III, Microsoft Corp.

Jan. 24, 2003

dlls/d3d8/device.c: statement with no effect

by Gerald Pfeifer

In dlls/d3d8/device.c I am getting the following warning (on FreeBSD): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -g -O2 -Wall -Wpointer-arith -mpreferred-stack-boundary=2 -gstabs+ -fPIC -D__WINESRC__ -D_REENTRANT -o device.o device.c device.c: In function `DrawPrimitiveI': device.c:475: warning: statement with no effect Could someone please have a look? (If fixed about half a dozen portability problems last week, but this one I'm having a hard time with.) Gerald -- Gerald "Jerry" pfeifer(a)dbai.tuwien.ac.at http://www.pfeifer.com/gerald/

Jan. 24, 2003

Re: Whither fnt2bdf?

by Fabian Cenedese

>>>I guess we could have a font control panel at some point, but there >>>isn't that much to manage anyway. As long as the font files are >>>somewhere on the font path everything should just work. >> >>Right. We'll need to add support for using libfontconfig soon - >>that'll mean we don't have to set up a font path manually. > >Yes! libfontconfig support in Wine will be wonderful, >it'll mean that any fonts the user adds in the "control panel" >in Linux will automatically be available in Wine, >and possibly vice-versa (!). This tool could also be used to just see the installed fonts and check if they work. Maybe like that the error messages of not finding fonts go down as you can check first if the font is really there and working or not. bye Fabi

Jan. 24, 2003

Re: Doccumetation issue: "The Service Thread" Does it exist?

by Ove Kaaven

On Thu, 23 Jan 2003, Robert North wrote: > This concerns the documentation on thw www.winehq.com website, if it's > out of date, then this post may be irrelevant. > > In the "Wine Developer's Guide" > In Section 8.1.4, "The Service thread" > > Says there exists a service thread, that is implemented in: > scheduler/services.c. > It also says this thread is used to support the X11 driver's event loop. > > Firstly, I cannot find the "scheduler/services.c" file. Yeah, the service thread is no more. Everything it did is now done more or less synchronously, in the thread that needs the functionality, instead of having another thread do it (or sometimes by shifting more functionality into the wineserver). > Secondly from my reading of the x11drv code, the X11 event loop is > serviced for every call of to X11DRV_MsgWaitForMultipleObjectsEx, > which is inturn called by MsgWaitForMultipleObjectsEx, and GetMessage. > Therefore, whichever thread is active will service the X11 event queue. Almost; each thread has its own display and X11 event queue now, where the messages that this thread is interested in gets posted. That way there's no need for a process-wide queue or an independent service thread to process it, instead the thread can check its own thread-specific queue whenever it's appropriate for it to do so. > It also appears, because each thread has it's own XDisplay object that > messages created by a X11 window will only be picked up in the thread > that created the window. That's right. It even fits the Win32 model better, as there, messages to a window are always sent to the thread that created the window.

Jan. 24, 2003

Re: Packagers Guide Update #5

by Francois Gouget

Hi Tom, On Thu, 23 Jan 2003, Tom Wickline wrote: [...] > Index: documentation/packaging.sgml > =================================================================== > RCS file: /opt/cvs-commit/wine/documentation/packaging.sgml,v > retrieving revision 1.12 > diff -u -r1.12 packaging.sgml > --- documentation/packaging.sgml 24 Jan 2003 00:49:05 -0000 1.12 > +++ documentation/packaging.sgml 24 Jan 2003 04:24:53 -0000 > @@ -1512,6 +1512,8 @@ > ;"ShowDotFiles" = "1" > "ShellLinker" = "wineshelllink" > > +# <wineconf> Hmmm, anything of the form <xxx> is a tag sgml so the above will not work very well. You should use: # <wineconf> I noticed another problem. This section is in a simple <para> tag. That means that linefeeds are not significant and everything can be bunched together. I think what's needed is to replace the <para> tags with <screen> tags. With these two changes it should work great. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Dieu dit: "M-x Lumière". Et la lumière fut.

Jan. 24, 2003

Re: RtlpWaitForCriticalSection?

by Dan Kegel

Alexandre Julliard wrote: > Christian Costa <titan.costa(a)wanadoo.fr> writes: > > >>In this case, CRITICAL_SECTION_INIT should be update, at least to have >>the line number. :-) >> >>So, if everyone agree. That 's fine for me. :-) >>Would you submit a patch that handle that ? > > > As discussed recently, CRITICAL_SECTION_INIT should be removed since > it's not in the standard headers. So you probably don't want to start > changing it now... OK, maybe I'll make this patch remove CRITICAL_SECTION_INIT, too. Thanks! - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 23, 2003