January 2003 - Wine-Devel - list.winehq.org

Re: Reseting X resolution

by Marcus Meissner

On Sat, Jan 18, 2003 at 01:15:35AM +0000, Luis Marques wrote: > Hello all, > > I like to test some DirectX applications from time to time. Problem is that > they succed long enough to set the resolution but after that fail. I can > Ctrl-C the application and resume working but it's not very practial to work > on a 320x200 desktop... > > How can I restore the resolution? Is there any standard way? Should I just > write a few lines of SDL code to set the resolution? Ctrl-Alt-Numpad+ or Ctrl-Alt-Numpad- Ciao, Marcus

Jan. 18, 2003

Re: Patch for Wine-20030115 GetFreeSpace on Solaris 8 x86

by Marcus Meissner

On Fri, Jan 17, 2003 at 06:03:35PM -0500, John Wehle wrote: > wine ie5setup reports it can't determine the free disk space. > truss shows statfs failed with EOVERFLOW and sys/statfs.h > says: > > * Structure returned by statfs(2) and fstatfs(2). > * This structure and associated system calls have been replaced > * by statvfs(2) and fstatvfs(2) and will be removed from the system > * in a near-future release. > > This patch allows wine ie5setup to at least startup. A cleaner > patch would probably use an explict autoconf check for statvfs > in addition to checking for sys/vfs.h. > > ChangeLog: > > Fri Jan 17 18:02:37 EST 2003 John Wehle (john(a)feith.com) > > * files/drive.c (DRIVE_GetFreeSpace): Use statvfs > on systems which have sys/vfs.h. This will break on Linux, it has have sys/vfs.h but no statvfs. Better use an autoconf check for the 'statvfs' function and use the result. > + #ifdef HAVE_SYS_VFS_H Use #ifdef HAVE_STATVFS > + struct statvfs info; > + #else > struct statfs info; > + #endif > *** 1297,1305 **** > return 0; > } > > ! /* FIXME: add autoconf check for this */ > ! #if defined(__svr4__) || defined(_SCO_DS) || defined(__sun) > ! if (statfs( DOSDrives[drive].root, &info, 0, 0) < 0) > #else > if (statfs( DOSDrives[drive].root, &info) < 0) > #endif > --- 1301,1308 ---- > return 0; > } > > ! #ifdef HAVE_SYS_VFS_H Dito. > ! if (statvfs( DOSDrives[drive].root, &info) < 0) > #else Ciao, Marcus

Jan. 18, 2003

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86

by Dan Kegel

John Wehle wrote: >>Don't you think that it would have been time to ask Alexandre >>what the hell he's been thinking about constantly rejecting it ? ;-) > > > Didn't know it had been rejected. > > I'm really not up on how wine development is done. In general I'm suppose > to email julliard(a)winehq.com if I don't receive an ACK / NACK regarding a > patch? I think it's more like: If you get any feedback about a proposed patch on the mailing list, you need to deal with the feedback one way or another before the patch will be applied. That allows Alexandre to just snoop the mailing list to get a feel for what patches pass muster. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 18, 2003

Implementation of 'start', take 2

by Dan Kegel

I had a look at cygstart, but it doesn't even try to be commandline-compatible with Microsoft's start.exe. Oh, well. I've verified that this implementation of start can do both start notepad and start foo.txt and that it obeys all the options obeyed by WindowsMe's start.exe. It also implements the /L option to print out the LGPL. (Do we have a convention for what this option, required by the LGPL, should be?) I'd rather compile it as a .exe rather than a winelib app - is there a way to do that in the Wine tree? Also, what do I have to do to cause the resulting .exe to end up as %windir%/command/start.exe, so it's in the same place as it is in real Microsoft Windows? BTW, to make 'start foo.txt' work, you need the registry entries [HKEY_CLASSES_ROOT\.txt] @="txtfile" "Content Type"="text/plain" [HKEY_CLASSES_ROOT\txtfile\shell\open\command] @="C:\\WINDOWS\\NOTEPAD.EXE %1" I verified that removing either of these on WinMe caused 'start foo.txt' to fail. I did not verify that, when you use the /w flag, the exit status of the subprocess is returned in the same way as it's done in Windows. Thanks, Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.116 diff -u -r1.116 configure.ac --- configure.ac 4 Jan 2003 02:52:05 -0000 1.116 +++ configure.ac 18 Jan 2003 02:41:32 -0000 @@ -1497,6 +1497,7 @@ programs/regtest/Makefile programs/rpcss/Makefile programs/rundll32/Makefile +programs/start/Makefile programs/uninstaller/Makefile programs/view/Makefile programs/wcmd/Makefile Index: programs/Makefile.in =================================================================== RCS file: /home/wine/wine/programs/Makefile.in,v retrieving revision 1.33 diff -u -r1.33 Makefile.in --- programs/Makefile.in 4 Jan 2003 02:52:05 -0000 1.33 +++ programs/Makefile.in 18 Jan 2003 02:41:32 -0000 @@ -19,6 +19,7 @@ regtest \ rpcss \ rundll32 \ + start \ uninstaller \ view \ wcmd \ @@ -43,6 +44,7 @@ regsvr32 \ rpcss \ rundll32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -73,6 +75,7 @@ # Symlinks to apps that we want to run from inside the source tree SYMLINKS = \ + start.exe \ rpcss.exe \ wcmd.exe \ wineconsole.exe \ @@ -136,6 +139,9 @@ winhelp.exe$(DLLEXT): winhelp/winhelp.exe$(DLLEXT) $(RM) $@ && $(LN_S) winhelp/winhelp.exe$(DLLEXT) $@ + +start.exe$(DLLEXT): start/start.exe$(DLLEXT) + $(RM) $@ && $(LN_S) start/start.exe$(DLLEXT) $@ wcmd/wcmd.exe$(DLLEXT): wcmd wineconsole/wineconsole.exe$(DLLEXT): wineconsole --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/Makefile.in 2003-01-16 08:20:35.000000000 -0800 @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = start.exe +APPMODE = cui +IMPORTS = shell32 + +C_SRCS = start.c + +(a)MAKE_PROG_RULES@ + +### Dependencies: --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/start.c 2003-01-17 17:34:36.000000000 -0800 @@ -0,0 +1,199 @@ +/* + * Start a program using ShellExecuteEx, optionally wait for it to finish + * Compatible with Microsoft's "c:\windows\command\start.exe" + * + * Copyright 2003 Dan Kegel + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" +#include "wine/debug.h" + +#include <windows.h> +#include <stdio.h> +#include <stdlib.h> +#include <shlobj.h> + +#define VERSIONMSG "start.exe version 0.1 Copyright (C) 2003, Dan Kegel" + +/** + Output given message to stdout without formatting. +*/ +static void output(const char *message) +{ + DWORD count; + WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); +} + +/** + Output given message, + followed by ": ", + followed by description of given GetLastError() value to stdout, + followed by a trailing newline, + then terminate. +*/ +static void fatal_error(const char *msg, DWORD error_code) +{ + LPVOID lpMsgBuf; + int status; + + output(msg); + output(": "); + status = FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error_code, 0, (LPTSTR) & lpMsgBuf, 0, NULL); + if (!status) { + output("FormatMessage failed\n"); + } else { + output(lpMsgBuf); + LocalFree((HLOCAL) lpMsgBuf); + output("\n"); + } + ExitProcess(1); +} + +static void usage() +{ + output("\ +Start a program, or open a document in the program normally used for files with that suffix.\n\ +Usage:\n\ +start [options] program_filename [...]\n\ +start [options] document_filename\n\ +\n\ +Options:\n\ +/M[inimized] Start the program minimized.\n\ +/MAX[imized] Start the program maximized.\n\ +/R[estored] Start the program normally (neither minimized nor maximized).\n\ +/W[ait] Wait for started program to finish, then exit with its exit code.\n\ +/L Show end-user license.\n\ +\n\ +" VERSIONMSG "\n\ +Start comes with ABSOLUTELY NO WARRANTY; for details run with /L option.\n\ +This is free software, and you are welcome to redistribute it\n\ +under certain conditions; run 'start /L' for details.\n\ +"); + ExitProcess(1); +} + +static void license() +{ + output("\ +" VERSIONMSG "\n\n\ +This program is free software; you can redistribute it and/or\n\ +modify it under the terms of the GNU Lesser Public License\n\ +as published by the Free Software Foundation; either version 2.1\n\ +of the License, or (at your option) any later version.\n\ +\n\ +This program is distributed in the hope that it will be useful,\n\ +but WITHOUT ANY WARRANTY; without even the implied warranty of\n\ +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n\ +GNU Lesser Public License for more details.\n\ +\n\ +You should have received a copy of the GNU Lesser Public License\n\ +along with this program; if not, write to the Free Software\n\ +Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.\n\ +\n\ +See the COPYING.LIB file for license information.\n\ +"); + ExitProcess(1); +} + +int main(int argc, char *argv[]) +{ + char arguments[MAX_PATH]; + char *p; + SHELLEXECUTEINFO sei; + int argi; + + memset(&sei, 0, sizeof(sei)); + sei.cbSize = sizeof(sei); + sei.lpVerb = "open"; + sei.nShow = SW_SHOWNORMAL; + /* Dunno what these mean, but it looks like winMe's start uses them */ + sei.fMask = SEE_MASK_FLAG_DDEWAIT|SEE_MASK_FLAG_NO_UI; + + /* Canonical Microsoft commandline flag processing: + * flags start with /, are case insensitive, + * and may be run together in same word. + */ + for (argi=1; argi<argc; argi++) { + int ci; + + if (argv[argi][0] != '/') + break; + + /* Handle all options in this word */ + for (ci=0; argv[argi][ci]; ) { + /* Skip slash */ + ci++; + switch(argv[argi][ci]) { + case 'l': + case 'L': + license(); + break; /* notreached */ + case 'm': + case 'M': + if (argv[argi][ci+1] == 'a' || argv[argi][ci+1] == 'A') + sei.nShow = SW_SHOWMAXIMIZED; + else + sei.nShow = SW_SHOWMINIMIZED; + break; + case 'r': + case 'R': + /* sei.nShow = SW_SHOWNORMAL; */ + break; + case 'w': + case 'W': + sei.fMask |= SEE_MASK_NOCLOSEPROCESS; + break; + default: + printf("Option '%s' not recognized\n", argv[argi]+ci-1); + usage(); + } + /* Skip to next slash */ + while (argv[argi][ci] && (argv[argi][ci] != '/')) + ci++; + } + } + + if (argi == argc) + usage(); + + sei.lpFile = argv[argi++]; + + /* FIXME - prone to overflow */ + arguments[0] = 0; + for (p = arguments; argi < argc; argi++) + p += sprintf(p, " %s", argv[argi]); + + sei.lpParameters = arguments; + + if (!ShellExecuteEx(&sei)) { + fatal_error("Application could not be started, or no application associated with the specified file. ShellExecuteEx failed", GetLastError()); + } + + if (sei.fMask & SEE_MASK_NOCLOSEPROCESS) { + DWORD exitcode; + DWORD waitcode; + waitcode = WaitForSingleObject(sei.hProcess, INFINITE); + if (waitcode) + fatal_error("WaitForSingleObject", GetLastError()); + if (!GetExitCodeProcess(sei.hProcess, &exitcode)) + fatal_error("GetExitCodeProcess", GetLastError()); + /* fixme: haven't tested whether exit code works properly */ + ExitProcess(exitcode); + } + + ExitProcess(0); +}

Jan. 18, 2003

Check for block device in DRIVE_ReadSuperblock

by Michal Janusz Miroslaw

I thought, that this may be useful to somebody ... If this patch were here before it would save me a few hours searching why every program hanged on commdlg open/save file dialogs ... I'm sending it here because I'm not sure whether I should be more/less paranoid and stat() the file before open() or not, or even if this check really should go into this function. Decide. ;) Changelog: [MQ] Add check for block device in DRIVE_ReadSuperblock Index: files/drive.c =================================================================== RCS file: /home/wine/wine/files/drive.c,v retrieving revision 1.83 diff -u -r1.83 drive.c --- files/drive.c 13 Jan 2003 20:44:13 -0000 1.83 +++ files/drive.c 18 Jan 2003 02:05:38 -0000 @@ -623,20 +623,36 @@ int fd; off_t offs; int ret = 0; + struct stat stat_buf; if (memset(buff,0,DRIVE_SUPER)!=buff) return -1; if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) { - struct stat st; if (!DOSDrives[drive].device) ERR("No device configured for drive %c: !\n", 'A'+drive); else ERR("Couldn't open device '%s' for drive %c: ! (%s)\n", DOSDrives[drive].device, 'A'+drive, - (stat(DOSDrives[drive].device, &st)) ? + (stat(DOSDrives[drive].device, &stat_buf)) ? "not available or symlink not valid ?" : "no permission"); ERR("Can't read drive volume info ! Either pre-set it or make sure the device to read it from is accessible !\n"); PROFILE_UsageWineIni(); return -1; + } + + /* MQ: I guess, we don't have to merge this call with the one above - some weird user + may try to swap the file before stat() and open() while we're not watching ;) + OTOH if we open FIFO we're stuck anyway, so FIXME */ + if (fstat(fd, &stat_buf) < 0) { /* shouldn't happen since we just opened that file */ + ERR("fstat() failed for opened device '%s' (drive %c:) ! IT SHOULDN'T HAPPEN !!!\n", + DOSDrives[drive].device, 'A'+drive); + ret = -1; + goto the_end; + } + if (!S_ISBLK(stat_buf.st_mode)) { + ERR("Device '%s' (drive %c:) is not a block device - check your config\n", + DOSDrives[drive].device, 'A'+drive); + ret = -1; + goto the_end; } switch(DOSDrives[drive].type)

Jan. 18, 2003

Heap* in memory/heap.c

by Michal Janusz Miroslaw

While checking why my new shiny man pages for HeapAlloc and friends didn't get generated, I found something weird. The functions HeapAlloc, HeapFree, (...) are redirected to ntdll equivalents RtlAllocateHeap, RtlFreeHeap, (...). There are more functions that are of return RtlXXX(args); type but are not forwarded in kernel32.spec. My questions: * Should the forwardings be added for the rest of functions ? * What about documenting them (and changing c2man.pl to support it) ? -- Michal Miroslaw

Jan. 18, 2003

Re: Patch for Wine-20030115 heap allocation on Solaris 8 x86

by John Wehle

>On Fri, Jan 17, 2003 at 01:52:08PM -0500, John Wehle wrote: >> Currently wine exits after complaining about an invalid heap during >> startup on Solaris 8 x86. What happens is mmap is returning an address >> above 0xc0000000 which HEAP_InitSubHeap passes to NtAllocateVirtualMemory >> who rejects it. Perhaps someone familiar with the code can suggest >> a better solution or explain why the ADDRESS_SPACE_LIMIT check is there. > Correct me if I'm wrong, but AFAICS this is even the third time that you > submit this. Yep. > Don't you think that it would have been time to ask Alexandre > what the hell he's been thinking about constantly rejecting it ? ;-) Didn't know it had been rejected. I'm really not up on how wine development is done. In general I'm suppose to email julliard(a)winehq.com if I don't receive an ACK / NACK regarding a patch? -- John ------------------------------------------------------------------------- | Feith Systems | Voice: 1-215-646-8000 | Email: john(a)feith.com | | John Wehle | Fax: 1-215-540-5495 | | -------------------------------------------------------------------------

Jan. 18, 2003

Reseting X resolution

by Luis Marques

Hello all, I like to test some DirectX applications from time to time. Problem is that they succed long enough to set the resolution but after that fail. I can Ctrl-C the application and resume working but it's not very practial to work on a 320x200 desktop... How can I restore the resolution? Is there any standard way? Should I just write a few lines of SDL code to set the resolution? Thanks, Luís Marques

Jan. 18, 2003

Re: Getting a program to crash

by Sylvain Petreolle

Have this issue with Power Archiver 6.0 (don't want it to crash :)) When started, it opens a box : Illegal read at adress 0x00000000, I click OK and it continues to work. --- Duane Clark <dclark(a)akamail.com> a écrit : > Howdy, > > I am trying to make a program crash ;) Instead, the program > apparently > captures exceptions, pops up a dialog, and continues on. I am hoping > for > a way to prevent that from happening, and instead falling into the > debugger. > > It does call EXC_RtlRaiseException when the exception occurs, but it > is > not clear to me how that function works. Hopefully I can comment out > something there to get it to crash properly? > > > ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

Jan. 17, 2003

Re: wine-releases has gone?

by Jeremy Newman

I took a look into this and found the problem. We use hypermail for our archives, there wasn't a config file for that list. I created one just now. So hopefully, the next post to that list will get the archives going. I don't know if that will bring back the old posts to the list though. I'll dig through the hypermail docs some more to see if there is anything else I need to do. On Fri, 2003-01-17 at 14:46, Alexandre Julliard wrote: > Mike Hearn <m.hearn(a)signal.qinetiq.com> writes: > > > On the Wine release notice it talks about a mailing list for large diffs > > between the releases, which would be useful for me (no cvs access at the > > moment at work), but the list appears to be dead, with no archives > > available. Is it still in use? > > It's in use, I'm not sure why the archives are empty. But note that > the diffs I send there are the same than what you can get on sunsite, > so archives wouldn't be all that useful anyway. -- _ _ WebGeek/SysAdmin CodeWeavers -= http://www.codeweavers.com | \| |_____ __ ___ __ __ _ _ _ -= http://www.dracowulf.com | .` / -_) | | / ' \/ _` | ' \ -= mailto:jnewman(a)codeweavers.com |_|\_\___|\_/\_/|_|_|_\__,_|_||_| -= ICQ: 1711553 Yahoo: laxdragon

Jan. 17, 2003