January 2003 - Wine-Devel - list.winehq.org

Re: Add check to SetMenuItemInfo

by Mike Hearn

Unfortunately it seems I was wrong about it stopping the QuickTime menu corruption... it merely reduces it and changes where it appears. The changes you gave below don't seem to change that, as far as I can see, so somehow we're missing a check that Windows does somewhere. In particular the rather confusing nature of the calls Quicktime makes doesn't help: SetMenuItemInfoA( 0x0006025F 0 TRUE [0x0013FD04] -> 44 , MIIM_CHECKMARKS | MIIM_BITMAP | MIIM_FTYPE , MFT_BITMAP | MFT_MENUBARBREAK | MFT_OWNERDRAW | MFT_SEPARATOR , 0x00000020 , 1310100 , 0x3C0052C4 , 0x00000311 , 0x00000202 , 0x00000000 , "xH" , 4 , 0x0013FD94 ) -> FALSE fMask -> MIIM_CHECKMARKS | MIIM_BITMAP | MIIM_FTYPE fType -> MFT_BITMAP | MFT_MENUBARBREAK | MFT_OWNERDRAW | MFT_SEPARATOR Which other than being API violations don't make sense anyway, why would any menu in quicktime need to have a vertical break? I think you're right in that a full test case is needed, but I can't do that (at least, not in C, if Object Pascal is acceptable I might be able to do so). On Thu, 2003-01-16 at 01:30, Dmitry Timoshkov wrote: > "Alistair Leslie" <aleslie(a)neumaflo.com.au> wrote: > > > Reading about the MENUITEMINFO structure. > > Take from MSDN > > The MFT_BITMAP, MFT_SEPARATOR, and MFT_STRING values cannot be combined with > > one another. > > In that case the code which verifies MENUITEMINFO fields could be generalized. > All existing checks in SetMenuItemInfoA should be removed and something like > this should be added to SetMenuItemInfo_common: > > if (lpmii->fMask & MIIM_TYPE ) > { > if (lpmii->fType & MFT_BITMAP) > { > if (lpmii->fType & (MFT_SEPARATOR | MFT_STRING)) > return FALSE; > } > else if (lpmii->fType & MFT_SEPARATOR) > { > if (lpmii->fType & (MFT_BITMAP | MFT_STRING)) > return FALSE; > } > else if (lpmii->fType & MFT_STRING) > { > if (lpmii->fType & (MFT_BITMAP | MFT_SEPARATOR)) > return FALSE; > } > } > > Mike, could you please try this approach and report whether it helps? -- Mike Hearn <m.hearn(a)signal.qinetiq.com> QinetiQ - Malvern Technology Center

Jan. 16, 2003

RunOnceEx - is it necessary?

by Shachar Shemesh

RunOnceEx is a key that is not available "by default" in Windows 95 and in Windows NT. Its processing is installed as part of the "IE integration" (shell integration?). When installing IE 5.5 on systype "nt40", these entries are processed by a rundll entry that was added to "runonce", even with wineboot as it is today. The question that needs to be answered is how important it is to add explicit support for it in wineboot? Shachar

Jan. 16, 2003

Re: Implementation of "start" command

by Dan Kegel

Dimitrie O. Paun wrote: > On Thu, 16 Jan 2003, Dan Kegel wrote: > > >>Well, of course Wine should be able to do that, I realized >>when I woke up this morning, and I vowed to make it happen >>before I went to work today. So here's a quickie implementation >>of the start command. Seems to work... comments welcome. > > > Shouldn't this be an internal wcmd command instead? You might think so, but on WindowsMe at least, it's a separate executable, C:\windows\command\start.exe -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 16, 2003

Re: Implementation of "start" command

by Dan Kegel

Dan Kegel wrote: > I saw somebody at work type the following commandline in Windows: > start notepad blah.c > He said "It's the easiest way to bring up a random file in Notepad." > > Well, of course Wine should be able to do that, I realized > when I woke up this morning, and I vowed to make it happen > before I went to work today. So here's a quickie implementation > of the start command. Seems to work... comments welcome. BTW, with this implementation, start notepad works, and start wordpad will probably work if you have the right registry entry (attached), but start foo.txt probably won't... I'll try it out, and maybe improve ShellExecute if needed. Also, start takes a number of switches; I'll try to implement them soon. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 REGEDIT4 [HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\WORDPAD.EXE] @="C:\\Progra~1\\Access~1\\WORDPAD2.EXE"

Jan. 16, 2003

Implementation of "start" command

by Dan Kegel

I saw somebody at work type the following commandline in Windows: start notepad blah.c He said "It's the easiest way to bring up a random file in Notepad." Well, of course Wine should be able to do that, I realized when I woke up this morning, and I vowed to make it happen before I went to work today. So here's a quickie implementation of the start command. Seems to work... comments welcome. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045 Index: configure.ac =================================================================== RCS file: /home/wine/wine/configure.ac,v retrieving revision 1.116 diff -d -u -r1.116 configure.ac --- configure.ac 4 Jan 2003 02:52:05 -0000 1.116 +++ configure.ac 16 Jan 2003 16:28:55 -0000 @@ -1497,6 +1497,7 @@ programs/regtest/Makefile programs/rpcss/Makefile programs/rundll32/Makefile +programs/start/Makefile programs/uninstaller/Makefile programs/view/Makefile programs/wcmd/Makefile Index: programs/Makefile.in =================================================================== RCS file: /home/wine/wine/programs/Makefile.in,v retrieving revision 1.33 diff -d -u -r1.33 Makefile.in --- programs/Makefile.in 4 Jan 2003 02:52:05 -0000 1.33 +++ programs/Makefile.in 16 Jan 2003 16:28:55 -0000 @@ -19,6 +19,7 @@ regtest \ rpcss \ rundll32 \ + start \ uninstaller \ view \ wcmd \ @@ -43,6 +44,7 @@ regsvr32 \ rpcss \ rundll32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -61,6 +63,7 @@ progman \ regedit \ regsvr32 \ + start \ uninstaller \ wcmd \ wineboot \ @@ -73,6 +76,7 @@ # Symlinks to apps that we want to run from inside the source tree SYMLINKS = \ + start.exe \ rpcss.exe \ wcmd.exe \ wineconsole.exe \ --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/Makefile.in 2003-01-16 08:20:35.000000000 -0800 @@ -0,0 +1,13 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = start.exe +APPMODE = cui +IMPORTS = shell32 + +C_SRCS = start.c + +(a)MAKE_PROG_RULES@ + +### Dependencies: --- /dev/null 2002-08-30 16:31:37.000000000 -0700 +++ programs/start/start.c 2003-01-16 08:23:33.000000000 -0800 @@ -0,0 +1,59 @@ +/* + * Start a program using ShellExecute + * + * Copyright 2003 Dan Kegel + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" +#include "wine/debug.h" + +#include <windows.h> +#include <stdio.h> +#include <stdlib.h> + +WINE_DEFAULT_DEBUG_CHANNEL(start); + +/* Placeholder implementation for now. */ + +int main(int argc, char *argv[]) +{ + char *program; + char *arguments; + HINSTANCE hres; + + if (argc == 1) { + printf("Usage: start file-or-program ...\n"); + exit(0); + } + if (argc > 3) { + WINE_FIXME("More than one argument not implemented"); + exit(1); + } + + program = argv[1]; + arguments = NULL; + if (argc == 3) + arguments = argv[2]; + + hres = ShellExecute(NULL, "open", program, arguments, NULL, SW_SHOWNORMAL); + if (((int)hres) <= 32) { + printf("Cannot execute %s %s, error %d\n", program, arguments?arguments:"", (int)hres); + exit(1); + } + + exit(0); +}

Jan. 16, 2003

Re: Implementation of "start" command

by Dimitrie O. Paun

On Thu, 16 Jan 2003, Dan Kegel wrote: > You might think so, but on WindowsMe at least, it's a > separate executable, C:\windows\command\start.exe Indeed, but I'm a bit worried of poluting the Unix command line namespace with such a Windows specific feature... With your command, what's the difference between start prog and prog & ? If I'm using bash, I expect Unix-like behaviour. I only expect Windows behaviour if I use wcmd. So maybe we can keep it as a separate program, but install it in a different path that's searched by default only in wcmd? Say $prefix/wine/bin? Or $prefix/bin/wine? What does FHS say, if anything? -- Dimi.

Jan. 16, 2003

Re: WINE in CD-ROM

by Dan Kegel

Dan Kegel wrote: > Uwe Bonnes wrote: > >>>>>>> "Jelcyn" == Jelcyn <jelcyn(a)send.pl> writes: >> >> >> Jelcyn> Hi, I write a book about editing binary files (Hex Workshop, >> Jelcyn> Resource Hacker etc.) to polish Helion publishing >> Jelcyn> (www.helion.pl) Can I add in CD-ROM in my book wine ?? >> >> You can redistribute winehq Wine accxording to the GNU License. > > > Here's the text of the license in Polish, in case that helps: > http://gnu.org.pl/text/licencja-gnu.html D'oh! Wrong license! And unfortunately, there's no translation of the LGPL into Polish. http://opensource.org/docs/osd-polish.php has a short description of some properties common to both licenses, but it's not really much help. Sorry! - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 16, 2003

Re: FHS vs LSB

by Dan Kegel

Vincent Béron wrote: > Le mer 15/01/2003 à 22:20, Tom Wickline a écrit : > >>In updating the Packagers Guide I plan to replace FHS with LSB >>any objections ? >> >>FHS = http://www.pathname.com/fhs/ >> >>LSB = http://www.linuxbase.org/ > > Linux is not the only system on which Wine can be built (FreeBSD and > Solaris/SunOS comes to mind). The FHS covers various Unices, the LSB > covers only Linux. I agree the FHS is the right standard to reference. However, the LSB does not cover only Linux. It's quite likely Solaris could conform to the LSB. The LSB authors are eager to avoid actually requiring a Linux kernel. > And if Wine is distributed as a Windows application sometime in the > future... :) Heh. Well, it'll be a cold day in Hell before Windows conforms to the FHS :-) - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 16, 2003

Re: WINE in CD-ROM

by Dan Kegel

Uwe Bonnes wrote: >>>>>>"Jelcyn" == Jelcyn <jelcyn(a)send.pl> writes: > > Jelcyn> Hi, I write a book about editing binary files (Hex Workshop, > Jelcyn> Resource Hacker etc.) to polish Helion publishing > Jelcyn> (www.helion.pl) Can I add in CD-ROM in my book wine ?? > > You can redistribute winehq Wine accxording to the GNU License. Here's the text of the license in Polish, in case that helps: http://gnu.org.pl/text/licencja-gnu.html - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

Jan. 16, 2003

Re: Implementation of "start" command

by Dimitrie O. Paun

On Thu, 16 Jan 2003, Dan Kegel wrote: > Well, of course Wine should be able to do that, I realized > when I woke up this morning, and I vowed to make it happen > before I went to work today. So here's a quickie implementation > of the start command. Seems to work... comments welcome. Shouldn't this be an internal wcmd command instead? -- Dimi.

Jan. 16, 2003