January 2003 - Wine-Devel - list.winehq.org

patch for "GetFileTitleW: illegal call to GetFileTitleA" 2ed

by liu spider

Thanks to Dmitry Timoshkov. This patch is the second edition, adopted his suggestions. ChangeLog: -dlls/commdlg/filetitle.c implemented GetFileTitleW make GetFileTitleA a wrapper of GetFileTitleW liuspider __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

Jan. 12, 2003

Re: tests for GetPrinterDriverDirectoryA

by Francois Gouget

On Tue, 7 Jan 2003, Stefan Leichter wrote: > Hello, > > here are some tests for GetPrinterDriverDirectoryA. They should pass on NT4 > and hopefully win95 too. Thanks to Francois Gouget for testing. I see this test has not been committed yet... I tested it and it works on Win95, Win98, NT4 and XP. It's a much better score than some other tests... However it fails on Wine: info.c:25: Test failed: pcbNeeded set to 18 instead of 19 info.c:30: Test failed: pcbNeeded set to 18 instead of 19 info.c:34: Test failed: expected result == 0, got 18 info.c:35: Test failed: pcbNeeded set to 18 instead of 19 info.c:48: Test failed: expected result != 0, got 0 info.c:71: Test failed: expected result != 0, got 0 The easy solution is to just wrap the relevant tests in a 'todo_wine'. The better one is to fix Wine... Or if the fix is too long to do, wrap with todo_wine now so the test can be committed now, and then fix Wine and remove the relevant todo_wine statements after each fix. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

Jan. 12, 2003

Re: wine/programs/wineboot wineboot.c Makefile.in

by Shachar Shemesh

Alexandre Julliard wrote: >Shachar Shemesh <wine-devel(a)sun.consumer.org.il> writes: > > > >>Two points about the differences between the version I submitted and >>the version that made it in. >> >> 1. If you are going to reject the printing of "Windows is finishing >> to install your programs..." closing message, at least also remove >> the starting message (lines 105 and 106 of version 1.3 of the >> file). >> >> > >I'm not opposed to having a message, but "continuing to boot wine" is >very misleading to indicate the end of the app. > > I only put these messages in because smilar messages appear on the original wininit.exe. Any of removing the messages altogether, moving the second message to the very end of wineboot (as opposed to the end of the wininit part, which is just a tiny part), or changing the wording is ok by me. Shachar

Jan. 11, 2003

Re: wine/programs/wineboot wineboot.c Makefile.in

by Shachar Shemesh

Dimitrie O. Paun wrote: >On January 11, 2003 05:26 pm, Shachar Shemesh wrote: > > >>The problem is that buffer is defined as a >>"const WCHAR *", while free expects "void *". >> >> > >Change the var to WCHAR *, why would you free a const string >without a warning? > > > My mistake after all. I wasn't thinking straight (does slight fever count as an excuse?). The var should be WCHAR *. I see it now - since the buffer was written to using RegQueryValueEx, and therefore required a cast to LPBYTE, I didn't catch this error. That is part of the reason Strastroup says casts are evil.... Do you want an official patch, or will you just remove the "const"? Shachar

Jan. 11, 2003

Re: wine/programs/wineboot wineboot.c Makefile.in

by Alexandre Julliard

Shachar Shemesh <wine-devel(a)sun.consumer.org.il> writes: > Two points about the differences between the version I submitted and > the version that made it in. > > 1. If you are going to reject the printing of "Windows is finishing > to install your programs..." closing message, at least also remove > the starting message (lines 105 and 106 of version 1.3 of the > file). I'm not opposed to having a message, but "continuing to boot wine" is very misleading to indicate the end of the app. > 2. The reason I added the cast on the free line was to remove a > compilation warning. If you made sure the warning doesn't happen > by changing somewhere else in the code, that's, of course, fine. > Otherwise there is a warning when compiling (I am currently doing > a clean compile to make sure whether that happens on my system). If there's a warning it's because you are doing something wrong, you shouldn't need to cast pointers passed to free(). Actually I see it now, the buffer is const which doesn't make sense since we are writing to it. I'll fix it. -- Alexandre Julliard julliard(a)winehq.com

Jan. 11, 2003

Re: wine/programs/wineboot wineboot.c Makefile.in

by Shachar Shemesh

Shachar Shemesh wrote: > 2. The reason I added the cast on the free line was to remove a > compilation warning. If you made sure the warning doesn't happen > by changing somewhere else in the code, that's, of course, fine. > Otherwise there is a warning when compiling (I am currently doing > a clean compile to make sure whether that happens on my system). I hate replying to my own emails, but I realized that it was not clear where this warning came from. The problem is that buffer is defined as a "const WCHAR *", while free expects "void *". When trying to simply do "free(buffer)", the compiler complains about the removal of the "const" modifier from the call. Either change free to expect "const void *", or leave the cast as I placed it. Shachar

Jan. 11, 2003

Re: wine/programs/wineboot wineboot.c Makefile.in

by Shachar Shemesh

Alexandre Julliard wrote: >ChangeSet ID: 6997 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2003/01/11 15:02:50 > >Modified files: > programs/wineboot: wineboot.c Makefile.in > >Log message: > Shachar Shemesh <wine-patches(a)sun.consumer.org.il> > Implemented the "pending rename" registry processing. > >Patch: http://cvs.winehq.com/patch.py?id=6997 > >Old revision New revision Changes Path > 1.2 1.3 +158 -3 wine/programs/wineboot/wineboot.c > 1.1 1.2 +1 -1 wine/programs/wineboot/Makefile.in > > > > Hi Alexander, Two points about the differences between the version I submitted and the version that made it in. 1. If you are going to reject the printing of "Windows is finishing to install your programs..." closing message, at least also remove the starting message (lines 105 and 106 of version 1.3 of the file). 2. The reason I added the cast on the free line was to remove a compilation warning. If you made sure the warning doesn't happen by changing somewhere else in the code, that's, of course, fine. Otherwise there is a warning when compiling (I am currently doing a clean compile to make sure whether that happens on my system). Shachar

Jan. 11, 2003

Re: Wine, Mozilla & IE ?

by Shachar Shemesh

Dan Kegel wrote: > Actually, the Linux kernel uses this technique, and it doesn't > always lead to longer code than, say, nested if's. It can > actually be quite clean, and given that the use of 'goto' > is restricted to a very narrow idiom, it's not all that hard to read. I use that for kernel programming too, sometimes. >> Exceptions, on the other hand, give a clean solution to the entire >> problem. ... > > > Or at least seems to. It's *very* difficult to write C++ code that > is threadsafe and exception safe at the same time. I'll have to think about that one. >> If the discussion goes forward, I can give an example of rewriting my >> latest patch to wineboot (currently using approach 1) with the other >> four approaches (2, 3, 4 and exceptions). > > > I've enjoyed the bit of Wine work I've done, but I'm not sure > I'd continue enjoying it if C++ began to be used inside the > core of Wine. C++ is for applications, not operating systems. I don't think that inside the core is a good idea either (except in places where the "core" is a huge application, such as may happen if we integrate a web browser in). I was thinking about the peripherial apps, though. > > - Dan > Shachar

Jan. 11, 2003

Re: MciWave: some small cleanups

by Eric Pouech

> Actually the changelog is a bit short... I know... Alexandre already complained... some code cleanups better error handling removed unneeded internal variables A+ -- Eric Pouech

Jan. 11, 2003

Re: MciWave: some small cleanups

by Francois Gouget

On Sat, 11 Jan 2003, Eric Pouech wrote: > see changelog for the details [...] > Name: mciwave > ChangeLog: > License: X11 Actually the changelog is a bit short... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

Jan. 11, 2003