January 2003 - Wine-Devel - list.winehq.org

Re: Wine, Mozilla & IE ?

by Roderick Colenbrander

Why do I allways forget attachments or urls? :( Here it is: http://developer.apple.com/darwin/projects/webcore/ (Not sure if it is still relevant for the rest of the thread.) On Friday 10 January 2003 21:58, Dimitrie O. Paun wrote: > On January 10, 2003 05:15 pm, Roderick Colenbrander wrote: > > Forgot to include an url to the safari developer page containing the > > usefull source code. > > Funny thing is, you forgot the second time as well... :)

Jan. 11, 2003

Re: Wine, Mozilla & IE ?

by Shachar Shemesh

Alexandre Julliard wrote: >None of these are showstoppers, but it needs a *really* good reason to >overcome all of them. So far I haven't heard anything convincing >enough. > > > THE thing that makes me miss C++ the most is exception handling. C offers you, basically, three options: 1. Having to perform an "if" every other line and perform a *shudder* goto in case of error. 2. Have nested "if"s seven levels deep. 3. return from the middle of the function. 4. Worst yet, write insecure code. 1. produces the longest code. It is also the ugliest one, structured programming wise. 2. has solved the ugliness, at the expense of code readability. For performance reasons you have to place the branch most likely to happen as the "then" part of the if, leaving the error handling to the "else" part. This means that you have an operation, long long list of what to do in case it succeeds (this list includes nested "if"s, mind you), and then an "else" and a sigle line of error handling. These last lines are all bunched together for each nesting level, and by the time you read them you no longer have the opening condition on screen. 3. This one produces a very neat solution, except that it requires performing the shutdown procedure over and over again. With multiple resources allocated, the shutdown also gets progressively longer. 4. This is the simplest one, and very easy to understand. It is also very common. In a nutshell - this means that you don't check the results of the operations you perform, and therefor you don't clutter your code with error handling. I think I don't have to elaborate why this is bad. Exceptions, on the other hand, give a clean solution to the entire problem. The source code looks almost like option 4 - on error checks are performed. The resulting machine language, however, looks almost like 1 - all resource cleanups in one place, and you jump there if necessary. If the discussion goes forward, I can give an example of rewriting my latest patch to wineboot (currently using approach 1) with the other four approaches (2, 3, 4 and exceptions). Shachar

Jan. 11, 2003

Re: Help with /?? stuff

by Shachar Shemesh

John K. Hohm wrote: >>>Alberto Massari wrote: >>>I guess Wine is converting the NULL into \?? to be able to store it as >>>a string. >>> >>> > >Shachar Shemesh wrote: > > >>You guessed wrong. The leading \?? is there under both Wine and Windows >>2000, and in both cases there is ALSO a NULL. As neither Wine nor >>Windows 2000 then accepts that as a valid path, I'll just remove it. I >>was just wondering whether anyone knows why Windows 2000 puts that extra >>stuff in (it's obvious why wine does that - to be compatible). >> >> > >I'm not sure about \??, but see this excerpt from MSDN Re CreateFile: > >lpFileName [in] >Pointer to a null-terminated string that specifies the name of the object >to create or open. > >In the ANSI version of this function, the name is limited to MAX_PATH >characters. To extend this limit to 32,767 wide characters, call the >Unicode version of the function and prepend "\\?\" to the path. For more >information, see Naming a File. > >Windows 95/98/Me: This string must not exceed MAX_PATH characters. > > That's true, except: 1. Wine does not support this convention. 2. I have not managed to get Windows to really support it either. 3. Changing the first '?' to a '\' is more difficult, as you need to perform elaborate tests to make sure that you are not accessing data outside of the buffer. I was seriously considering doing it in C++ (which SHOULD be ok, as this is not a DLL, right?). That would have allowed much more felxibility. Oh well, maybe next time. Shachar > >

Jan. 11, 2003

Re: PATCH - Check/Define for vsnprintf/_vsnprintf

by Steven Edwards

> It's astatic library which ships with Visual C++. You can find it > in VC98\Lib > > The issue wrt. open and other variable argument functions may be our cue > that we should really have our own oldnames.a library... Sounds good and if it will save me from having to write more boring configure checks then I am all for it. =) Once again I think its one of those things that sounds god but I dont know how much I can help on it other then testing. Thanks Steven __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

Jan. 11, 2003

shlwapi.dll from Wine regression tests on Windows 2000 SP3

by Steven Edwards

I did a compare of windows shlwapi with WINEs shlwapi. With Windows 2000 SP3 shlwapi.dll we get - C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe clist clist: 236 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe generated generated: 25 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe path path.c:92: Test failed: Expected ?query=x&return=y, but got query=x&return=y path: 33 tests executed, 0 marked as todo, 1 failure. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe shreg shreg.c:171: Test failed: (44,43) shreg.c:183: Test failed: (2) shreg.c:195: Test failed: (14,43) shreg.c:196: Test failed: (2) shreg.c:204: Test failed: Expected ERROR_MORE_DATA shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (1,43) shreg.c:218: Test failed: (44,43) shreg.c:262: Test failed: didn't open copy shreg: 40 tests executed, 0 marked as todo, 10 failures. C:\Documents and Settings\Administrator\Desktop\test> With the current WINE shlwapi on Windows 2000 we get C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe clist clist: 236 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe generated generated: 25 tests executed, 0 marked as todo, 0 failures. C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe path fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected localhost, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected 21, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected foo, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected bar, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected http, but got x☺� fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:81: Test failed: UrlGetPartA didn't return S_OK fixme:shell:URL_ParseUrl failed to parse L"http://foo:bar(a)localhost:21/internal. php?query=x&return=y" path.c:83: Test failed: UrlGetPartW didn't return S_OK path.c:87: Test failed: Strings didn't match between ascii and unicode UrlGetPar t! path.c:92: Test failed: Expected ?query=x&return=y, but got x☺� path: 33 tests executed, 0 marked as todo, 24 failures. C:\Documents and Settings\Administrator\Desktop\test> C:\Documents and Settings\Administrator\Desktop\test>shlwapi_test.exe shreg shreg.c:171: Test failed: (44,43) shreg.c:195: Test failed: (44,43) shreg.c:205: Test failed: () shreg.c:206: Test failed: () shreg.c:207: Test failed: (44,43) shreg.c:218: Test failed: (44,43) shreg.c:262: Test failed: didn't open copy shreg: 37 tests executed, 0 marked as todo, 7 failures. C:\Documents and Settings\Administrator\Desktop\test> __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

Jan. 11, 2003

Re: PATCH - Check/Define for vsnprintf/_vsnprintf

by Francois Gouget

On Fri, 10 Jan 2003, Steven Edwards wrote: > --- Alexandre Julliard <julliard(a)winehq.com> wrote: > > "Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > > > > > Alexandre, why don't we link with oldnames.lib in Windows, and > > > get rid of all these tests? > > > > Unfortunately there's no vsnprintf in oldnames.lib... > > I think I missed something somewhere. Where is oldnames.lib? It's astatic library which ships with Visual C++. You can find it in VC98\Lib The issue wrt. open and other variable argument functions may be our cue that we should really have our own oldnames.a library... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

Jan. 11, 2003

Re: Wine, Mozilla & IE ?

by Ender

> Ender, you may be right that we might have to integrate something into > the tree. Nonetheless, it scares me shitless! What happens 3 mo, 1 year > down the road? KHTML is very much a work in progress, who's gonna track > it? We don't have any richedit control, heck even our bog standard edit > box is not finished! And for how many years now?!? I brought up this very same argument when I first took on the task of porting it over.. however I as basically outvoted with doing the implementation as more of a wrapper than a true port :P > off of, and we have to avoid touching their sources. To this end, I think > we are much better off by implementing a QT subset: As it seem there is some effort going on to create a native Win32 KHTML port using Apple's WebCore wrapper system I think I will take a break on my current code and play with that a little. Personally I didn't want to have to take on the chore myself, but this whole Safari thing IS creating more intrest in non-X11/QT platforms... it definatly changes the playing field, and with the large speed and compatability merges from Safari lately my current tree is hopelessly out of date anyway :) So I think I will play with that and work on the DLL layout and COM interfaces until something eventuates... I've decided it's worth waiting to see what direction KHTML takes (portability wise) now that it is being use in a 'real' non-KDE application. There's no point rushing into a WINE-specific implementation if something more closely tied to the upstream code is released meer weeks later. Of course there still a small problem of having to seperate the code into MS compatible COM objects and DLLs... I will have to benchmark the speed impact of stubbing the MS dll's into khtml.dll/kjs.dll ecetra, instead of replicating the exports more natively. Cheers, Ender

Jan. 11, 2003

Re: PATCH - Check/Define for vsnprintf/_vsnprintf

by Steven Edwards

--- Alexandre Julliard <julliard(a)winehq.com> wrote: > "Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > > > Alexandre, why don't we link with oldnames.lib in Windows, and > > get rid of all these tests? > > Unfortunately there's no vsnprintf in oldnames.lib... I think I missed something somewhere. Where is oldnames.lib? Thanks Steven __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com

Jan. 11, 2003

Re: PATCH - Check/Define for vsnprintf/_vsnprintf

by Alexandre Julliard

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > Alexandre, why don't we link with oldnames.lib in Windows, and > get rid of all these tests? Unfortunately there's no vsnprintf in oldnames.lib... -- Alexandre Julliard julliard(a)winehq.com

Jan. 11, 2003

Re: dx8 Patches - Question

by Alexandre Julliard

Raphaël Junqueira <fenix(a)club-internet.fr> writes: > Ok, how do you prefer: > a huge d3d8 patch (very easy for me) > many many little patches (hmmmm) Many small patches please <g> > but we have a new external need: the new x11drv/GLX stuff (know as "[WINE-D3D] glx init and D3D stuff") > who is the begin for GL abstraction. I don't like this one; the X11 escape interface is a hack that should be used as little as possible, and export only what's absolutely necessary. We shouldn't export large structures like that one. -- Alexandre Julliard julliard(a)winehq.com

Jan. 11, 2003