January 2003 - Wine-Devel - list.winehq.org

Re: problem building tests with msvc6

by Dan Kegel

Paul Millar wrote: > I'm in the process of extending WRT [1] to include running the conformance > tests on as many Windows platforms as I can get my hands on (which, in > theory should be more-or-less all of them). > > I didn't want to say anything until I knew it was feasible, but I've got > most of it figured out ... it just needs setting up (oh and the > conformance tests to cross-compile with mingw ;^) > > [1] - http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php Wow. Does it really make sense to test against windows 2.0 or 3.0 anymore? I recall Windows itself was pretty much a joke and terribly unstable until windows 3.1... Are the WRT sources in CVS? - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

Jan. 10, 2003

Re: problem building tests with msvc6

by Paul Millar

On Thu, 9 Jan 2003, LarstiQ wrote: > On Sun, Jan 05, 2003 at 07:18:05PM -0800, Dan Kegel wrote: > > grab the source for the tests from CVS and build them themselves > > under Windows. > > Furthermore, I'm hoping to write scripts to continuously update > > from cvs and run the regression tests, all on windows. > > (It'll be interesting making that work noninteractively.) > > How about something inspired by tinderbox? It continuously > checks out from CVS, builds, and mails the results, all of that > noninteractively. I'm in the process of extending WRT [1] to include running the conformance tests on as many Windows platforms as I can get my hands on (which, in theory should be more-or-less all of them). I didn't want to say anything until I knew it was feasible, but I've got most of it figured out ... it just needs setting up (oh and the conformance tests to cross-compile with mingw ;^) [1] - http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php ---- Paul Millar

Jan. 10, 2003

[RFC] msvcrt: defines break C++ code

by Dimitrie O. Paun

Folks, We have a lot of code in msvcrt headers like so: #define umask _umask #define unlink _unlink #define write _write This breaks C++ that define a write method in a header, and then implement it like so: #include <io.h> void MyClass::write(...) { write(...); } I suggest we turn those defines into inlines, like this: inline int write(int fd, const void* ptr, unsigned int size) { return _write(fd, ptr, size); } Any other solutions? -- Dimi.

Jan. 9, 2003

Re: Registering DLL's

by Alexandre Julliard

"John K. Hohm" <jhohm(a)acm.org> writes: > Are you suggesting that the static data defining which classes and > interfaces to register be located in the same file as the implementation of > the (un)registration functions? That would make copying the implementation > around even more work, since I couldn't just copy regsvr.[hc] and keep the > differing data in the respective dll-specific sources. Not really, you shouldn't be copying it around all the time anyway. Once the functions are working properly they shouldn't need to change. The idea is that you put everything into regsvr.c, both the common functions and the dll-specific stuff; then when you want to do a new dll you copy a regsvr.c and modify the dll-specific parts. This also allows simplifying the code for dlls that don't need the complete support. -- Alexandre Julliard julliard(a)winehq.com

Jan. 9, 2003

Re: prevent dereferencing null

by Dimitrie O. Paun

On January 9, 2003 07:08 pm, Bill Medland wrote: > + if (!tpinfo->chanbuf) { > + ERR("tpinfo has no Rpc Channel Buffer\n"); > + return 0; > + } Is this expected behaviour? If so, there's no need for the ERR msg. If not, there's no need for the test, we need to fix the root cause... -- Dimi.

Jan. 9, 2003

Re: Can't find MFC afx.h

by Hans Christian Studt

Francois Gouget wrote: > Hi John, > > John Westerman wrote: > >> Hi Everybody, >> >> I'm currently trying to compile the basic Win32 "Hello world" project >> that VC6 generates for you using Wine. >> >> My problem is that when I run ./configure -with-wine=/usr/local/wine >> >> It fails with the Message "checking for afx.h .... Could not find the >> MFC includes" > > Is this application really an MFC application? Winemaker will assume > that an application is an MFC application if it sees that it uses the > 'StdAfx.h' header. However by default Visual C++ also uses this header > for its (evil) precompiled header tricks. > So you may want to re-run winemaker with the --nomfc option. Great - I also ran into that problem. As part of the winelib applications challange http://www.dssd.ca/wine/Winelib-Apps-0.2.html I have downloaded some *random* applications form sourceforge and have no idea if they use MFC Is there a way to find out more precise if an application really uses MFC ??? -- Hans Christian Studt : http://hc.studt.dk mailto:hc(a)studt.dk .dk og W3C standarder : http://w3c.studt.dk

Jan. 9, 2003

Re: fix shgetfileinfoW

by Andreas Mohr

On Wed, Jan 08, 2003 at 09:34:50PM +0100, Jürgen Schmied wrote: Content-Description: Mail message body > - fixed crash in winamp reported by andreas mohr Yay !!! That fixed it indeed ! (in other words: I just didn't trust you, so I had to try myself ;-) Andreas Mohr

Jan. 9, 2003

Re: Registering DLL's

by John K. Hohm

Quoting Alexandre Julliard <julliard(a)winehq.com>: > Please do it in one dll only for now and submit that; once it's tested > and integrated we can start copying it around. Also I'd suggest Okay. Should I perhaps start with something better-used than comcat (perhaps ole32) so that testing will be likely to fail quickly if it's broken? > putting the Dll(Un)RegisterServer functions in the same .c file so > that you don't need a .h at all, this way there will be less > duplication. Are you suggesting that the static data defining which classes and interfaces to register be located in the same file as the implementation of the (un)registration functions? That would make copying the implementation around even more work, since I couldn't just copy regsvr.[hc] and keep the differing data in the respective dll-specific sources. I suppose you could also mean that *only* the static data be stored in a dll- specific file, with predefined variable names to be found by the regsvr.c, but that still requires a regsvr.h to get the struct definitions.

Jan. 9, 2003

Re: problem building tests with msvc6

by Dan Kegel

LarstiQ wrote: > On Sun, Jan 05, 2003 at 07:18:05PM -0800, Dan Kegel wrote: > > <snip> > >>I guess I'm aiming at making it easier for Windows folks to >>grab the source for the tests from CVS and build them themselves >>under Windows. >>Furthermore, I'm hoping to write scripts to continuously update >>from cvs and run the regression tests, all on windows. >>(It'll be interesting making that work noninteractively.) > > > How about something inspired by tinderbox? It continuously > checks out from CVS, builds, and mails the results, all of that > noninteractively. > > See tinderbox.mozilla.org, tinderbox.blender.org and > http://lxr.mozilla.org/mozilla/source/webtools/. Yes, exactly. I didn't say "tinderbox" because I wasn't sure how much of that I could reuse. - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

Jan. 9, 2003

Re: html browser for wine (khtml)

by Marcus Meissner

On Thu, Jan 09, 2003 at 12:28:38PM -0500, Dimitrie O. Paun wrote: > On January 9, 2003 01:46 pm, Marcus Meissner wrote: > > Actually there already was a Konqueror / WINE integration already, called > > reaktivate. It replaced urlmon and provided a IWebBrowser interface. > > Sweet! This is exactly what I was hoping for. > [...searching for it...] > Here's the original announcement: > > http://dot.kde.org/994747675/ > > But this seems to be going what cxplugin does. We need the complement > of that, don't we? Not sure, it might just work both ways. Will have to go back and check. Ciao, Marcus

Jan. 9, 2003