October 2003 - Wine-Devel - list.winehq.org

Re: PATCH: tools/winegcc/utils.c -- casts

by Ferenc Wagner

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Add proper casts to avoid signed vs. unsigned mismatches in strmake(). > - if (n > -1 && n < size) return p; > - size = min( size*2, n+1 ); > + if (n > -1 && (size_t)n < size) return p; > + size = min( size*2, (size_t)n+1 ); Once at it, could you please explain to me what the hell is going on here (min)? I came across this function recently, and do not agree with its logic. I would write it like char *strmake(const char *fmt, ...) { int n; size_t size = 100; char *p = xmalloc (size+1); va_list ap; va_start (ap, fmt); n = vsnprintf (p, size, fmt, ap); while (n < 0) { size *= 2; p = xrealloc (p, size+1); n = vsnprintf (p, size, fmt, ap); } if ((size_t)n == size) p[size]=0; va_end (ap); return p; } By the way, either Wine's snprintf implementation is wrong or I do not know how to use it correctly. I am submitting a conformance test... -- Feri.

Oct. 31, 2003

Re: Add some exports to NtDll and AdvApi32

by Alexandre Julliard

Robert Shearman <R.J.Shearman(a)warwick.ac.uk> writes: > Changelog: > - Add some stub exports to spec files for NtDll and AdvApi As a rule, for functions that only exist in later Windows versions, it's better to add them commented out, so that apps don't try to call the stubs. We should only add a real stub if an app links against it directly. -- Alexandre Julliard julliard(a)winehq.com

Oct. 30, 2003

Re: Simple patch q

by Mike Hearn

On Thu, 30 Oct 2003 22:52:50 +0000, Sir Jason Edmeades scribed thus: > Thanks - Thats what I was after - I knew it should be simple, but I > 'expected' a flag on diff! > Jason Well you can just ignore them you know - patch ignores garbage it doesn't understand. Alternatively do what I do for winecfg and use the --exclude option with an exclusions file. thanks -mike

Oct. 30, 2003

Useful article on x86 disassembly skills

by Mike Hearn

After finding that COM article, I decided to dig my way through the backissues of MSJ to see what other gems I could uncover. Here's one useful one: http://www.microsoft.com/msj/0298/hood0298.aspx It is a basic introduction to x86 assembly from a reverse engineers point of view. Most of it is basic stuff you probably know already, however there are some useful bits there - for instance, it took me some time before I figured out that "xor eax, eax" was being used to clear the register because it led to smaller code size whereas this article tells you about that and similar tricks so it's easier to read optimized code. It also gives you some useful constructs that access the TEB, for instance now I know that these fs:[00000000] things are setting up new SEH frames. A worthwhile read for times when disas is the only way forward.... thanks -mike

Oct. 30, 2003

Re: Simple patch q

by Jason Edmeades

Johan Dahlin wrote: >>I always get lots of "Only in dlls/d3d8: basetexture.o, Only in >>dlls/d3d8: cubetexture.o etc" type lines - How can I get rid of these >> >You can always filter them out with help of grep: > >diff ... | egrep -v "^Only in" > > > Thanks - Thats what I was after - I knew it should be simple, but I 'expected' a flag on diff! Jason

Oct. 30, 2003

Re: Simple patch q

by Johan Dahlin

> I always get lots of "Only in dlls/d3d8: basetexture.o, Only in > dlls/d3d8: cubetexture.o etc" type lines - How can I get rid of these (I > normally edit them out by hand but I forgot this time) - I looked in the > man pages and nothing stood out. You can always filter them out with help of grep: diff ... | egrep -v "^Only in" -- |#| Johan Dahlin < johan (at) gnome (dot) org> | Nordenskioldsg. 19 |#| |#| Web: http://www.async.com.br/~jdahlin/ | 413 09 Gothenburg |#| |#| Phone: +46 (0)735-570778 | Sweden |#|

Oct. 30, 2003

Re: Simple patch q

by Vincent Béron

Le jeu 30/10/2003 à 16:54, Jason Edmeades a écrit : > Hi, When I can I use cvs diff, but once I get a few patches out I end up > diffing to the previous patch using diff -u3 backup_of_last_patch > dlls/d3d8. > > I always get lots of "Only in dlls/d3d8: basetexture.o, Only in > dlls/d3d8: cubetexture.o etc" type lines - How can I get rid of these (I > normally edit them out by hand but I forgot this time) - I looked in the > man pages and nothing stood out. diff -x '*.o'? Vincent

Oct. 30, 2003

Re: Misc wine debugging questions

by Mike Hearn

On Thu, 30 Oct 2003 15:28:49 -0600, Sir Gregory M. Turner scribed thus: > Unfortunately, there isn't a ton of documentation -- or, more accurately, the > documentation that you may find is scattered throughout MSDN and the > internet, instead of being in an "obvious" place. The MSDN documentation for > NdrClientCall2, for example, is almost worthless from the wine implementer's > perspective, just stating something like "This is the entry-point for > stubless proxies." From the perspective of most users, stubless proxies are > a behind-the-scenes implementation detail that isn't worth learning too much > about. > > The end-programmer's perspective is as follows: pass /Oicf to MIDL, and MIDL > will magically generate stubless proxies. I forget if /Oic is considered > "stubless" as well, I think it may be. The resulting client proxy code > generated by MIDL will contain "NdrClientCall2" or "NdrClientCall" instead of > the usual multi-step proxy code (there is no in-proxy marshalling, > exception-handling, etc -- just the single call). > > In wine, NdrClientCall2 (the more common entry-point) is totally unimplemented > -- it simply emits a FIXME and returns indicating success. > > The server side is analogous. You will see some code by Ove floating around > to generate the manager entry-point thunks in asm, but I don't think they are > used yet (?). > > Unfortunately, stubless proxies have been the recommended (by Microsoft) mode > of generating code from MIDL for many years. Increasingly, I see calls to > NdrClientCall2. The only solution (aside from coding wine) is to use native > rpcrt4/ole32 -- but this, in turn, means you must use Windows 98 dll's or > else you will bump up against the missing "Ports" API if ncalrpc is used (it > usually is -- this is why I keep musing that I want to take a crack at > implementing this). ncalrpc? > I think, the way to code those is to use the structures provided by MIDL (and > eventually widl) to determine the necessary steps. In particular, I think > this is where the format strings come in handy -- presumably, NdrClientCall2 > should parse the format strings and determine what to marshall/unmarshall > using those. My theory is that the steps taken in NdrClientCall2 would look > very much like those MIDL would spit out in /Oi mode. Your theory is correct. Somehow I stumbled upon this article: http://www.microsoft.com/msj/0199/com/com0199.aspx which explains the whole thing. It also talks about how the MS typelib marshaller is implemeneted - basically it generates format strings from the typelib data then feeds that to the Ndr format string interpreters. > Stated succinctly, stubless proxies are the RPC/DCOM holy grail for wine. Indeed. That seems to be the way it goes.... thanks -mike

Oct. 30, 2003

Simple patch q

by Jason Edmeades

Hi, When I can I use cvs diff, but once I get a few patches out I end up diffing to the previous patch using diff -u3 backup_of_last_patch dlls/d3d8. I always get lots of "Only in dlls/d3d8: basetexture.o, Only in dlls/d3d8: cubetexture.o etc" type lines - How can I get rid of these (I normally edit them out by hand but I forgot this time) - I looked in the man pages and nothing stood out. Jason

Oct. 30, 2003

VARIANT_ValidateType ?

by Marcus Meissner

Hi Jon, Can you please explain why VARIANT_ValidateType rejects for instance VT_SAFEARRAY variants (and more) with DISP_E_BADVARTYPE? Why does it handle the whole range VT_HRESULT - VT_CF as invalid (except VT_RECORD) ? We got one InstallShield regression from this patch (where it wants to clear a VT_SAFEARRAY I think). Ciao, Marcus

Oct. 30, 2003