November 2003 - Wine-Devel - list.winehq.org

Re: Splitting out shared Win16/Win32 code

by Eric Pouech

Casper Hornstrup wrote: > Dlls/winmm/lolvldrv.c has a function (MMDRV_Message) shared by the > Win16 and the Win32 implementation of mmsystem. Since it is shared > by both mmsystem.dll and winmm.dll, all Win16 APIs used in the shared > functions will be imported by the Win32 implementation (winmm.dll) > also. On ReactOS no such APIs exist so the library will not load. I don't see any 16 bit (exported from mmsystem.dll) function called from this MMDRV_Message function. Could you elaborate a bit more ? winmm should be able to be compiled without the mmsystem support (the contrary is not correct, but you don't need it in ROS AFAICT). A+ -- Eric Pouech

Nov. 30, 2003

Re: [Curses] Choose curses so library at startup (4/5)

by Eric Pouech

> I would agree with you allmost any time. But (of cause there is a but) we > are only using functions that was standard pre waaay old and I did > actually spend some time looking for functions/types etc. and nothing has > changed. As we are not touching internal stuff, allocating structs or > termcap/terminfo etc. I am convinced that they are binary compatible (and > I ran wine with some of the oldes curses lib I could find). the point is not only at function prototype level, lost of curses functions are defined as macros, and this can change from implementation to implementation. Hence the .so / header peering and the rest... A+ -- Eric Pouech

Nov. 30, 2003

Re: FontDlg sample text

by Rein Klazes

On Sun, 30 Nov 2003 21:48:47 +0800, you wrote: > > table, and you get "ain't worth the hassle". > > I hope you will reconsider. This discussion did not answer the question that I was thinking of at your first remark: do these strings depend on the local language? It would be inclined to think the would depend only on the character encoding of the font and need no translation (what is the translation of AaBb?) Rein. -- Rein Klazes rklazes(a)xs4all.nl

Nov. 30, 2003

Mmsystem API timeGetTime

by Casper Hornstrup

How can this API be implemented so it does not have to use ReleaseThunkLock and RestoreThunkLock (at least the Win32 version)? DWORD WINAPI timeGetTime(void) { /* FIXME: releasing the win16 lock here is a temporary hack (I hope) * that lets mciavi.drv run correctly */ DWORD count; ReleaseThunkLock(&count); RestoreThunkLock(count); TIME_MMTimeStart(); return WINMM_IData->mmSysTimeMS; }

Nov. 30, 2003

Crypt32 - CryptProtectData

by Thomas Brix Larsen

Hi list, I've been trying to get the application "Skype" (http://skype.org) working in wine. But it complains about that it can't locate the function CryptProtectData, which MSDN says belongs to crypt32.dll. I've been trying to implement this function as a stub. By adding this to crypt32/main.c: BOOL WINAPI CryptProtectData(DATA_BLOB* pDataIn, LPCWSTR szDataDescr, DATA_BLOB* pOptionalEntropy, PVOID pvReserved, void* pPromptStruct, DWORD dwFlags, DATA_BLOB* pDataOut) { FIXME("stub!\n"); return FALSE; } I know the args aren't correct but I had a problem with CRYPTPROTECT_PROMPTSTRUCT*, which isn't implented, so I just replaced with void*. I added: @ stdcall CryptProtectData(ptr wstr ptr ptr ptr long ptr) to crypt32.spec But, the app still says it can't locate CryptProtectData, so what needs to be done? Greetings, --Thomas _________________ My worst enemy gave me a copy of Windows...

Nov. 30, 2003

Re: Direct Sound problem

by Andreas Mohr

Hi, On Sun, Nov 30, 2003 at 12:13:27AM +0100, Kris 'Spike' J wrote: > Hello there, > I get an error when starting a voice communication tool that uses dsound: > err:win32:PE_fixup_imports No implementation for DSOUND.dll.12 imported from > C:\Programme\Ventrilo\Ventrilo.exe, setting to 0xdeadbeef > a guy called TD from #winehq @ irc.freenode.net told me to mail this to the > list. > Done. Spike :> Well, it's simply NOT a Wine problem ;-) For some strange reason you're using a native dsound.dll (one which doesn't implement DirectSoundCaptureCreate8 even!). Use builtin dsound.dll and 12 stdcall DirectSoundCaptureCreate8(ptr ptr ptr) should hopefully work fine then... (but maybe it's not fully implemented in Wine, I haven't verified that) Andreas Mohr P.S.: Your reply address is broken.

Nov. 30, 2003

Re: FontDlg sample text

by Dmitry Timoshkov

"Shachar Shemesh" <wine-devel(a)shemesh.biz> wrote: > The main reason is that they are loaded based on encoding, rather than > language. This has several implications that caused me not to go that route: > 1. The mapping between encoding and charcter encoding is not a > straightforward one. The reverse mapping is even less so. Well, GetTextCharset() does exactly what you want. > 2. The mapping is based on the selected locale, and does not care about > the current language. The mapping should be based on the font charset, and actually has nothing to do with current language or locale. > These two mean that placing the sample text in a resource will only > server to confuse the issue. The first point is even harder - what if > you want different sample text for Chinese BIG-5 and the other Chinese > encoding? Which language should I try to load for centeral Europe? > French? German? I can only load one. Exactly. GetTextCharset() is your friend here. Just have different strings for different charsets in the resources and load them at appropriate time. > In short, doing that through resources seems like an unnecessary > complication to me. Add to that the fact that you still need the mapping > table, and you get "ain't worth the hassle". I hope you will reconsider. -- Dmitry.

Nov. 30, 2003

Re: FontDlg sample text

by Shachar Shemesh

Rein Klazes wrote: >On Sun, 30 Nov 2003 03:43:04 +0200, you wrote: > > > >>+ {'C','c','D','d',0}, /* Symbol */ >> >> > >With native win98, ME and win2k the example string for symbol I get is >spelled 'S','y','m','b','o','l' > >BTW, I have a patch for this and other fontdlg enhancements as well. Do >you plan to submit any more patches soon? > >Rein. > > Well aware of that. However, doing that would require me to introduce a significant change into the code, and I don't see the reward. It's not as if you can read the resulting string anyways. Likewise, the Japanese sample text only has Aa (and not AaBb) of Romanji (latin characters). For similar reasons, I left AaBb in place (why remove it?). Shachar -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/ The opinions expressed in this mail are my own, and do not necessarily represent the opinions of my employer. Wait! I am self employed! Hmm...

Nov. 30, 2003

Re: FontDlg sample text

by Shachar Shemesh

Dmitry Timoshkov wrote: >"Shachar Shemesh" <wine-patches(a)shemesh.biz> wrote: > > > >> * Add sample text characters for Symbol, Japanese, Greek, Turkish, >> Arabic, Baltic, Vietnamese, Russian, East European and Thai codepages. >> >> > >Why to not add them into resources? That would simplify locale >handling a lot, and make our translators actually notice that >strings as well. > > > The main reason is that they are loaded based on encoding, rather than language. This has several implications that caused me not to go that route: 1. The mapping between encoding and charcter encoding is not a straightforward one. The reverse mapping is even less so. 2. The mapping is based on the selected locale, and does not care about the current language. These two mean that placing the sample text in a resource will only server to confuse the issue. The first point is even harder - what if you want different sample text for Chinese BIG-5 and the other Chinese encoding? Which language should I try to load for centeral Europe? French? German? I can only load one. In short, doing that through resources seems like an unnecessary complication to me. Add to that the fact that you still need the mapping table, and you get "ain't worth the hassle". Shachar -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/ The opinions expressed in this mail are my own, and do not necessarily represent the opinions of my employer. Wait! I am self employed! Hmm...

Nov. 30, 2003

Re: FontDlg sample text

by Rein Klazes

On Sun, 30 Nov 2003 03:43:04 +0200, you wrote: > + {'C','c','D','d',0}, /* Symbol */ With native win98, ME and win2k the example string for symbol I get is spelled 'S','y','m','b','o','l' BTW, I have a patch for this and other fontdlg enhancements as well. Do you plan to submit any more patches soon? Rein. -- Rein Klazes rklazes(a)xs4all.nl

Nov. 30, 2003