February 2003 - Wine-Devel - list.winehq.org

Re: Report after porting a windows app to WINE

by Mike Engelhardt

Alexandre, > > I've noticed a few things about WINE that might help you > > improve it. WINE can confuse SendMessage() with PostMessage(). > > LTspice uses SendMessage to handshake between threads > > sometimes. Wine usually obeys the difference, but treated > > some SendMessage calls like a PostMessage. My workaround > > was to poll volatile global variables. > > I'd be interested to hear more details; SendMessage is > definitely supposed to behave properly. Here's the situation: The app has two threads. One is the whole MDI/user interface/CAD and text editor. The worker thread does a simulation of the circuit you draw in the CAD editor. The messages are all registered messages for a historical reason in a footnote(1). The first message back from the worker thread says it's got some partial data to plot and sends a message to the view window that launched the thread. The view knows the name of the file containing the data and launches a doc/view to read it. That doc/view throws up a dialog asking which data to plot. The schematic doc/view and plotting doc/view handshake here by calling each other's functions and setting each other's data members. After the data is read, the original view to get the message from the working thread returns the number of data points that were found in the file. All this time the worker thread, having done a SendMessage() and not a PostMessage(), is frozen waiting for the return value of the number of points so it can decide where to try again or continue. The scheme that I'm using has been extensively debugged and used under 95,98,Me,NT,2K, and XP. But under wine, the worker thread doesn't freeze when it calls SendMessage() but keeps executing. It's imperative that it does because on subsequent calls from the worker to the UI thread, it sends little compressed packets of data. The UI must process these before the worker thread continues. //Here's the code that worked under Windows: int nPnts = SendMessage(TheChartWindow, WM_MARCH_INIT, 0, 0); if(nPnts != run->pointCount) // try again if it failed SendMessage(TheChartWindow, WM_MARCH_INIT, 0, 0); // And here's the code hacked to work under Wine: volatile BOOL LinuxProcessed = FALSE; volatile int NumberPoints = 0; unsigned MarchInit() { NumberPoints = 0; LinuxProcessed = FALSE; SendMessage(TheChartWindow, WM_MARCH_INIT, 0, 0); // the function that receives this will // assign the return value to NumberPoints // and assign a value to LinuxProcessed while(!LinuxProcessed) // Will Wine every simply ever lose the message? Do I need to time-out? Sleep(100); return(NumberPoints); } int nPnts = MarchInit(); if(nPnts != run->pointCount) MarchInit(); I did find one other problem in Wine that may or may not be related to messaging, that being with the FindReplace common dialog. When you press "Find Next" which is IDOK, under Wine nothings happened in my app. My app uses one FindReplace dialog for all document types and relates the command to the active document. The workaround was to add an OnOK() handler: // Wine is a global BOOL the TRUE if running under Wine void CFindDlg::OnOK() // for WINE { // for WINE if(Wine) // for WINE { // for WINE WineFindReplaceHack = TRUE; // for WINE LPARAM lParam = (unsigned ) this + offsetof(CFindReplaceDialog, m_fr); // for WINE ::SendMessage(theApp.m_pMainWnd->m_hWnd, WM_FINDREPLACE, 0, lParam); // for WINE WineFindReplaceHack = FALSE; // for WINE } // for WINE else // for WINE Default(); // for WINE } // for WINE LRESULT CMainFrame::OnFindString(WPARAM wParam, LPARAM lParam) { CFindDlg *dlg = (CFindDlg *) CFindReplaceDialog::GetNotifier(lParam); . . . if(WineFindReplaceHack || dlg->FindNext()) { // search active document for dlg->m_findWindowText and highlight. } . . . return(0); } Let me know if you have any other questions. I'd like to be as helpful as I can in this and immensely appreciate the help that, e.g., Uwe has been. I officially feel guilty that I'm not subscribed to the e-mail list, but I get too many e-mails and phone calls as it is. --Mike (1) Normally the graphical schematic drives the worker thread. but a text netlist can also be used. I used to use a CEditView for this netlist and under Win95, the original message scheme didn't work until I used registered messages. I no longer use a CEditView but an more general purpose syntax colonizing editor with unlimited undo/redo, so i don't know if the messages still have to be registered.

Feb. 28, 2003

Re: Report after porting a windows app to WINE

by Mike Hearn

> 3. Function key F6 is not trapped. Can you explain this one a bit further? You mean Wine doesn't forward it to the app? > 4. The cursor colors are off. For example, the voltage probe > cursor should have a red body. In WINE it's black. The sleeve > of the pointing hand is blue, in WINE it's black. Ah, I think that's not a bug in wine per se, as up until yesterday no stable release of X could actually do coloured cursors. The XCursor extension that comes in with XFree 4.3 adds support for colour, animated, alpha blended cursors, as opposed to the old system that was 1 bit only. The solution here is to add support for XCursor uploads to Wine. File a bug against it I guess, write it yourself, or hire a Wine developer to do it for you. > I would like to know if there is a way to determine if my app is > running > under WINE under runtime. That way I can work around more of these > problems without imparing its performance under MS Windows. If you > know > the answer, please e-mail me directly. As has already been pointed out, it'd be much better for you to actually fix bugs in Wine rather than work around them in your own app when possible - that way, everybody wins :) In particular, if in the future the bug is fixed, your workarounds will either break or become redundant. thanks -mike

Feb. 28, 2003

Re: Report after porting a windows app to WINE

by Eric Pouech

Paul McNett wrote: > On Thursday 27 February 2003 04:29 pm, Mike Engelhardt wrote: > > >>I would like to know if there is a way to determine if my app is running >>under WINE under runtime. That way I can work around more of these >>problems without imparing its performance under MS Windows. If you know >>the answer, please e-mail me directly. the real best way is to fix the behavior in Wine, not try to get around it. so, any good bugreport is also more than welcomed in order to have it fixed A+ -- Eric Pouech

Feb. 28, 2003

Re: Report after porting a windows app to WINE

by Mike Engelhardt

Thank you very much. Uwe suggested a method along these lines: HMODULE hModule = GetModuleHandle("kernel32"); BOOL Wine = hModule && GetProcAddress(hModule, "wine_get_unix_file_name"); It'd be a good thing to put in a FAQ. I couldn't find it anyway. --Mike ----- Original Message ----- From: "Paul McNett" <p(a)ulmcnett.com> To: "Mike Engelhardt" <pmte(a)concentric.net>; <wine-devel(a)winehq.com> Sent: Friday, February 28, 2003 10:38 AM Subject: Re: Report after porting a windows app to WINE On Thursday 27 February 2003 04:29 pm, Mike Engelhardt wrote: > I would like to know if there is a way to determine if my app is running > under WINE under runtime. That way I can work around more of these > problems without imparing its performance under MS Windows. If you know > the answer, please e-mail me directly. In my app startup, I look for the environmental variable "_". Under Windows, it will likely not even exist. Under Wine, it will tell you something like "/usr/local/bin/wine". I save this to a global variable called _WINE. That way, no matter where I am in my app I can check the value of _WINE to decide which branch to execute. I haven't had to use this yet, and hope not to, but built it in already just in case. HTH -- Paul McNett - p(a)ulmcnett.com Hollister, California, USA

Feb. 28, 2003

Re: Report after porting a windows app to WINE

by Paul McNett

On Thursday 27 February 2003 04:29 pm, Mike Engelhardt wrote: > I would like to know if there is a way to determine if my app is running > under WINE under runtime. That way I can work around more of these > problems without imparing its performance under MS Windows. If you know > the answer, please e-mail me directly. In my app startup, I look for the environmental variable "_". Under Windows, it will likely not even exist. Under Wine, it will tell you something like "/usr/local/bin/wine". I save this to a global variable called _WINE. That way, no matter where I am in my app I can check the value of _WINE to decide which branch to execute. I haven't had to use this yet, and hope not to, but built it in already just in case. HTH -- Paul McNett - p(a)ulmcnett.com Hollister, California, USA

Feb. 28, 2003

Re: Report after porting a windows app to WINE

by Alexandre Julliard

"Mike Engelhardt" <pmte(a)concentric.net> writes: > I've noticed a few things about WINE that might help you > improve it. WINE can confuse SendMessage() with PostMessage(). > LTspice uses SendMessage to handshake between threads > sometimes. Wine usually obeys the difference, but treated > some SendMessage calls like a PostMessage. My workaround > was to poll volatile global variables. I'd be interested to hear more details; SendMessage is definitely supposed to behave properly. -- Alexandre Julliard julliard(a)winehq.com

Feb. 28, 2003

Re: Clean-up of scroll.c (1/4)

by Alexandre Julliard

"Andrew M. Johnston" <johnstonam(a)logica.com> writes: > Note the code as in this area CVS seems to have a bug. In the case of a zero > infoPtr it zeros the return pointers not the return value as I am sure is > intended. A patch like the one below shown the likely intended code. Yes that's definitely what was intended. Though note that even with that fix the implementation is still not right, most of the GetScroll* functions should be sending messages to the window for the SB_CTL case instead of accessing the data structure directly. -- Alexandre Julliard julliard(a)winehq.com

Feb. 28, 2003

Re: Consoles (1/3)

by Eric Pouech

> If you're saying running nested wcmd isn't working, > then yeah, that needs fixing. this comes from wcmd using FindExecutable/SHGetFileInfo, and those API don't handle properly builtin executables A+ -- Eric Pouech

Feb. 28, 2003

Re: Consoles (1/3)

by Eric Pouech

Sylvain Petreolle wrote: > how to continue to have a separate window with this patch applied ? you can't with current CVS (as I wrote in a previous mail, I'll submit something RSN) > this break some functions in wcmd. you should run wineconsole wcmd not wcmd if you want console support A+ -- Eric Pouech

Feb. 28, 2003

Re: Wine 0.9 config applets?

by Steven Edwards

I have a old 6 gig from a compaq 1200 laptop I will part with for $40 US as the wife just dropped that laptop and killed the LCD. It was such a nice system to demo WINE and ReactOS with....oh well may she rest in pieces. If you need the parts let me know. Thanks Steven --- Dan Kegel <dank(a)kegel.com> wrote: > Jaco Greeff wrote: > > ... I Need to > > scramble now to get some money together to either rescue the laptop (which is > > quite old anyway) > > http://www.driveguys.com have hard drives for old systems at > good prices. I got a drive for my 1997 laptop recently > for $30. > - Dan __________________________________________________ Do you Yahoo!? Yahoo! Tax Center - forms, calculators, tips, more http://taxes.yahoo.com/

Feb. 28, 2003