May 2003 - Wine-Devel - list.winehq.org

Re: New metabugs

by Shachar Shemesh

Francois Gouget wrote: > * I am not convinced we should have a 'bidi' keyword. A component may >be more approriate. Would the 'wine-gdi' component be suitable or is it >too crowded? Or maybe an 'internationalization' keyword (or 'i18n', >it's much shorter). > Some BiDi bugs are in GDI, some in UI, some in common controls. I don't think specifying BiDi as a component is the right thing to do. It has no specific location in the sources, for one thing. Right now BiDi bugs are blocking meta-bug 609 (opened by you, Francois :-). This actually makes sense, as the meta-bug has an owner (me), who is notified by email when something changes there (such as - the addition of bug 1425, which has now totally changed its name). As such, I'm not sure how important it is to have a keyword as well (though it will probably make it easier for people who are not familiar with meta-bug 609 to navigate the system). -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

May 5, 2003

Re: rpc exception

by Ove Kaaven

tor, 01.05.2003 kl. 19.25 skrev Alexandre Julliard: > "Gregory M. Turner" <gmturner007(a)ameritech.net> writes: > > > Say, Alexandre, would it be a possibility to just bake some magic into wpp for > > this? > > I don't see any reasonable way of doing that, you really need some > compiler support. Note that even with gcc nested functions it won't be > 100% correct, for instance a return inside a try block will corrupt > the handler list; Hmm. That could be solved by making the try block a nested function too, but I suppose that would bring some overhead...

May 5, 2003

Re: Problem in ole32.CoCreateInstance ?

by Ove Kaaven

man, 05.05.2003 kl. 01.22 skrev Sylvain Petreolle: > Trying to run dxdiag for testing DirectPlay , get a read at 0x0 in > CoCreateInstance > at line 1355 (dlls/ole32/compobj.c): > > 1355 hres = IClassFactory_CreateInstance(lpclf, pUnkOuter, > iid, ppv); > > This cant work since lpcf is always 0 and this function is defined as a > macro in include/unknwn.h : Why not check why it's "always 0" for you, instead of complaining that it is? If the CoGetClassObject call can't obtain the class factory, it's usually because the registry entries are missing, incorrect, or the referenced dll can't be loaded, but then it should have returned a failure, and CoCreateInstance should then bail out before getting to this point. You could also find out why it didn't, then?

May 5, 2003

Re: New metabugs

by Francois Gouget

I continued looking at the component list and especially the component definition page: http://bugs.winehq.com/describecomponents.cgi?product=Wine Some interesting things I noticed: * wine-patches 'Report consisting solely of a patch' I think this should be a keyword, 'patch', rather than a component. * wine-help 'Basic support or configuration request' I think such requests belong to wine-users rather than Bugzilla. The reason is that I see Bugzilla as a way for developpers to track bugs in the code and reports such as 'Application foo does not work' are quite useless to developpers. They start to become more useful when you get to the level of a crash with a relay log, a stack trace, a meaningful FIXME, etc. That being said, I'm not sure it would be 'right' to close such bugs. But I think our policy should be to at least direct the reporter to wine-users and assign the bug to the 'wine-help' component. * wine-ole 'OLE, Active X' We should change the description as follows: 'OLE, Active X, Com, DCOM' * wine-directx 'DirectDraw, DirectSound, Direct3D, DirectPlay' I noticed some DirectSound bugs were assigned to 'wine-multimedia' and it's true that there can be some confusion. The above settles it. * wine-gdi 'Drawing, graphics, fonts, drivers' That appears to include BiDi. But I still think an internationalization keyword that would cover BiDi, XIM, dead-keys, and localization of resources would be a good thing. * wine-gui 'Controls, dialogs, shell' I was wondering where 'shell' bugs should go. 'wine-gui' it is apparently. * Nothing says where registry issues should go. 'wine-kernel'? Same question for opengl issues. For msvcrt/crtdll issues (but I already proposed to add wine-crt). We really need it too, I have seen at least a dozen msvcrt bugs assigned to various components, the most common one being 'wine-misc'! * I still think it would be nice to be able to attach a bug to a specific dll. I don't know if that means we should add a bunch of components or a bunch of keywords or find yet another mechanism. Similarly having keywords/components corresponding to the debug channels would be nice. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

May 5, 2003

Re: New metabugs

by Francois Gouget

On Sun, 4 May 2003, hatky wrote: > Well I haven't seen any real answers about this, > Can anybody here add keywords to bugzilla? > Are you aggreing with the ones that are requested > here? That's the thing with keywords an components, not everyone can create them (which is a good thing). I'm not sure who has the right permissions to create them (I don't). * We *need* a way to find all 'open' bugs - concerning a given component - with a given keyword This doesn't work right now and it has to be fixed, even if it means making special search form that only allows this kind of query because the other types of queries take too much CPU. * I propose adding the following components: wine-direct3d wine-directsound wine-directdraw wine-crt * I'm ok with the 'game' and 'installer' keywords (singular, both). Though I am not 100% sure they are needed. (is it hard to remove a keyword?) * I am not convinced we should have a 'bidi' keyword. A component may be more approriate. Would the 'wine-gdi' component be suitable or is it too crowded? Or maybe an 'internationalization' keyword (or 'i18n', it's much shorter). Another interesting thing is the 'Named Queries'. If you go to 'Find a bug', you have the option to save the query and it will then appear in your sidebar in the 'Named Queries' section. So if you're a DirectX developper you could have a 'DirectX bugs' query that returns all the open bugs for the 'wine-directx' component. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

May 5, 2003

Problem in ole32.CoCreateInstance ?

by Sylvain Petreolle

Trying to run dxdiag for testing DirectPlay , get a read at 0x0 in CoCreateInstance at line 1355 (dlls/ole32/compobj.c): 1355 hres = IClassFactory_CreateInstance(lpclf, pUnkOuter, iid, ppv); This cant work since lpcf is always 0 and this function is defined as a macro in include/unknwn.h : ./include/unknwn.h:160:#define IClassFactory_CreateInstance(p,a,b,c) (p)->lpVtbl->CreateInstance(p,a,b,c) Should we rewrite this as a function or is lpclf assumed to be non NULL ? ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

May 4, 2003

Re: WinZip registry patch

by Sylvain Petreolle

Im not against this patch, but this is hiding a problem and not resolving it. We should make sure a bug is open about this or add comments into richedit/winedefault.reg. --- "Dimitrie O. Paun" <dpaun(a)rogers.com> a écrit : > On May 4, 2003 08:39 am, Nick Brereton wrote: > > Should I post this anywhere else? eg the wine-patch list? Any > comments > > would be appreciated. > > This is a great idea! It removes the main problem with WinZip, > hopefully > this makes WinZip work flawlessly under Wine. Now, you should submit > this as a patch against winedefault.reg to wine-patches(a)winehq.org. ===== Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259 No more War ! "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". For the Law of Oil and Fire, Im an European that lives in France. For all my Brothers and friends, Im a human living on Earth. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

May 4, 2003

Re: How to add a new DLL?

by Gerhard W. Gruber

On Sun, 4 May 2003 00:43:13 +0200, Joerg Mayer <jmayer(a)loplof.de> wrote: >So what you have to to is add the new Makefile to configure.ac - search for >AC_CONFIG_FILES([ >Then you need to run autoconf (no arguments required but we require a version >>=2.53). After that you need to rerun ./configure <options> (or >./config-status --recheck && ./config.status). Ok. So I did add it to configure.ac and ran autoconf. I could see that it was added to configure and it also created the makefile. But when I run the makefile I always get this error: make: *** No rule to make target `../../configure', needed by `Makefile'. Stop. The Makefile.in looks like this: TOPSRCDIR = @top_srcdir@ TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = w95inf32.dll IMPORTS = ALTNAMES = EXTRALIBS = $(LIBUNICODE) LDDLLFLAGS = @LDDLLFLAGS@ SYMBOLFILE = $(MODULE).tmp.o C_SRCS = w95inf32_main.c @MAKE_DLL_RULES@ ### Dependencies: ------------------------------------ I took it from lzexpand and only removed the imports and altnames. Also the C_SRCS16 because I don't have 16bit files. Or are they always needed also when it is just a 32 bit DLL? Another questions is how I can create the sources from the spec file? -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

May 4, 2003

Re: Window opnes on other desktop

by hatky

I really think it is not by wine since I have Mandrake 9.1 running kde and when I open the mandrake control pannel then the pakage manager (whese take some time to load) they open up on my active window just as you described with the newsgroups program. I do not know if there is a diffrence between type of programs or windows opening but I reall think it is at kde's control. Hatky. --- "Gerhard W. Gruber" <sparhawk(a)gmx.at> wrote: > I just noticed this by accident. I closed Agent and > it showed the dialog that > it purges newsgroups. While it were at it I switched > to another desktop and > did some work and suddenly the Agent dialog popped > up telling me that it now > will purge the trash folder (which it does after it > cleared the newsgroups). > Shouldn't the wine app stay on the same desktop > where I started it? I'm not > sure if this is a bug or a feature, because when I > start other apps in one > desktop and switch to another before they open any > window (i.e. Netscape takes > some time) then the window will also be opened on > the active desktop instead > from where I launched it. > > -- > Gerhard Gruber > > F?r jedes menschliche Problem gibt es immer eine > einfache L�sung: > Klar, einleuchtend und falsch. (Henry Louis Mencken) > > __________________________________ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com

May 4, 2003

Re: New metabugs

by hatky

Well I haven't seen any real answers about this, Can anybody here add keywords to bugzilla? Are you aggreing with the ones that are requested here? Anybody? Hatky. --- Shachar Shemesh <wine-devel(a)shemesh.biz> wrote: > Francois Gouget wrote: > > >On Fri, 2 May 2003, hatky wrote: > >[...] > > > > > >>>Anyway, don't let me slow you down. Just > remember that > >>>bug tracking is a social issue, and you have to > pay attention > >>>to how the other developers feel about it. > >>> > >>> > >>I am not sure what they realy think yes I only got > 3 > >>responces 2 of witch where positive :)... > >>I guess I will have to wait for the next week to > start > >>when codewaver will return to flame me (or not) :) > >> > >> > > > >This is Wine's bugzilla so you don't need to worry > about CodeWeavers > >flaming you (or about the CodeWeavers' needs). > However, as Dan said, > >beware of the Wine developpers ;-). > > > >I know I used meta-bugs in the past and we used > them too in our internal > >CodeWeavers bugzilla database. But meta-bugs are > not very practical in > >the long term and it is worth considering > alternatives. In particular: > > > > * Component field > > Some developpers are specialized in a certain > aspect of Wine. Havnig > >specialists is good, it's certainly more efficient > than having to learn > >from scratch each time. So we need to provide a way > for specialists to > >find bugs in their area of expertise. > > The 'Component' field is one way to do so. Let's > say you're a > >Direct3D specialist, you can find bugs in that area > by querying Bugzilla > >for all bugs tagged with 'Component=wine-directx'. > > > > * keywords > > Keywords are another way to tag and query bugs. > It's pretty flexible > >and even lets you put multiple keywords on a bug. > For instance you can > >find all the bugs related to conformance testing by > querying Bugzilla > >for bugs that have the 'conformance' keyword. > Similarly you can look for > >all bugs related to programs for which the source > is available by > >searching for bugs with the 'source' keyword. > > See http://bugs.winehq.com/describekeywords.cgi > > > > > > > >That being said, > > > > * Bugzilla queries don't appear to work. Newman do > you know what's up? > >Is it a database performance issue? Bugzilla bug? > > > > * Direct3D and DirectSound are pertty different > areas. Maybe we should > >split the wine-directx component into direct3d, > directdraw, directsound > >and the generic directx. > > > > * Maybe we need a 'wine-msvcrt' component. I know > there are people > >interested in msvcrt but looking at the component > list I don't know > >where such bugs would go. Or maybe we should be a > bit more general and > >have a 'wine-libc' so that it includes crtdll and > potential future C++ > >libraries, etc. > > > > * Maybe we should add more keywords. I'm not > saying we should do it, > >but adding 'game' keyword would provide the same > functionality as the > >current game meta-bug. If we go this way, I could > see another useful > >keyword: 'installer' to identify all bugs related > to application > >installers. But we have to be careful not to add > frivolous keywords. > > > > * One useful things that can be done now is to > inspect all new bugs to > >make sure that: > > - the component field is set correctly > > - the download URL to the binary or source is > provided if applicable > > (in case of doubt ask the reporter) > > - all applicable keywords are set > > That said, things seem to be already pretty much > in order (more so > >for the component field than for keywords). > > > > > While wer'e at it, can we add a "BiDi" keyword, or > at least a > "complex-lang" keyword? > > Shachar > > -- > Shachar Shemesh > Open Source integration consultant > Home page & resume - http://www.shemesh.biz/ > > > __________________________________ Do you Yahoo!? The New Yahoo! Search - Faster. Easier. Bingo. http://search.yahoo.com

May 4, 2003