June 2003 - Wine-Devel - list.winehq.org

Re: still many warnings from Mesa

by Lionel Ulmer

> Could someone please have a look at addressing these? Well, I think the only way to safely remove these are by using --disable-opengl. Ie I will detect that one has 'ABI-compliant' GL headers (ie that it defines the glXGetProcAddressARB / multi-texture prototypes) and disable OpenGL build if not. I know it's a Linux only ABI but well, people on other platforms can fix the issue if they need it to be fixed :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

June 30, 2003

Package setups

by Mike Hearn

hi, I'm just looking at the HOWTO and want to clarify that all the Wine RPMs/packages attempt to set up a fake windows drive and configuration for the user. I'm under the impression that binary packages should work out of the box, so the user has no need to create their own config or fake windows drive. Is this right? If so, I'll amend the HOWTO to suit.

June 30, 2003

Re: Copy & Paste doesn't work again

by Ulrich Czekalla

Sure, I'll take a look. I need to look at this anyway to solve problems with klipper interactions. I probably won't get around to this for a couple of days since I'm really busy with other bugs but it is high on my priority list. If you could send me a trace log of Agent with +relay,+clipboard that would really help me out. Thanks, /Ulrich On Mon, 2003-06-30 at 10:39, Rein Klazes wrote: > On Sun, 29 Jun 2003 20:30:08 +0200, you wrote: > > > On Sun, 29 Jun 2003 19:59:40 +0200, you wrote: > > > > > On Sun, 29 Jun 2003 18:26:07 +0200, Rein Klazes <rklazes(a)xs4all.nl> wrote: > > > > > > >Occasionally it seems to work again. Just restart Agent and then you > > > >find that it is not. > > > > > > I know that it worked. I used it quite frequently. I only update yesterday, > > > but I din't do it regulrarly teh last weeks. Before that it worked fine. > > > > I did notice here that copying from X to Agent (the other direction) has > > stopped working completely recently. I will try to find the commit that > > did this. > > This is the commit: > > | Log message: > | Ulrich Czekalla <uczekalla(a)codeweavers.com> > | - use global atoms for the format ids > | - add timeout when calling XCheckTypedWindowEvent > | - fix broken IsClipboardFormatAvailable; it tried to do a trick with > | EnumClipboardFormats by making incorrect assumptions > | - in X11DRV_IsClipboardFormatAvailable do a quick exit if no one owns > | the selection > | - add 1 second *minimum* time lapse between XSelectionOwner calls > | - sync clipboard ownership between different wine processes > | - prevents apps from getting into wierd state where they thought they > | didn't own the selection but they did and as a result queried > | themselves for available selection data > | > | Patch: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8573 > > Causing in Agent several problems: > > - copy&paste from Agent to 'X' doesn't work, occasionally I see some > rubbish characters; > - copy&paste from 'X' to Agent doesn't work at all; > - copy&paste within Agent does not always work. For instance I cannot > copy Ulrich's email address from the text editor to the To:list at all. > Copying within the editor or from the cc:list to the To:list is no > problem. > > Ulrich,I have never had much luck fixing things related to the > clipboard. Do you have a suggestion how to find out what the problem is? > > Rein.

June 30, 2003

Re: Copy & Paste doesn't work again

by Rein Klazes

On Sun, 29 Jun 2003 20:30:08 +0200, you wrote: > On Sun, 29 Jun 2003 19:59:40 +0200, you wrote: > > > On Sun, 29 Jun 2003 18:26:07 +0200, Rein Klazes <rklazes(a)xs4all.nl> wrote: > > > > >Occasionally it seems to work again. Just restart Agent and then you > > >find that it is not. > > > > I know that it worked. I used it quite frequently. I only update yesterday, > > but I din't do it regulrarly teh last weeks. Before that it worked fine. > > I did notice here that copying from X to Agent (the other direction) has > stopped working completely recently. I will try to find the commit that > did this. This is the commit: | Log message: | Ulrich Czekalla <uczekalla(a)codeweavers.com> | - use global atoms for the format ids | - add timeout when calling XCheckTypedWindowEvent | - fix broken IsClipboardFormatAvailable; it tried to do a trick with | EnumClipboardFormats by making incorrect assumptions | - in X11DRV_IsClipboardFormatAvailable do a quick exit if no one owns | the selection | - add 1 second *minimum* time lapse between XSelectionOwner calls | - sync clipboard ownership between different wine processes | - prevents apps from getting into wierd state where they thought they | didn't own the selection but they did and as a result queried | themselves for available selection data | | Patch: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8573 Causing in Agent several problems: - copy&paste from Agent to 'X' doesn't work, occasionally I see some rubbish characters; - copy&paste from 'X' to Agent doesn't work at all; - copy&paste within Agent does not always work. For instance I cannot copy Ulrich's email address from the text editor to the To:list at all. Copying within the editor or from the cc:list to the To:list is no problem. Ulrich,I have never had much luck fixing things related to the clipboard. Do you have a suggestion how to find out what the problem is? Rein. -- Rein Klazes rklazes(a)xs4all.nl

June 30, 2003

difference between delivery delays introduced by list-server and web-archive

by Saulius Krasuckas

hello, newbie is testing delays. thank you for not paying your attention. good luck

June 30, 2003

still many warnings from Mesa

by Gerald Pfeifer

As far as I can see, patches from Raphaël resolved many related warnings I used to see (Thanks!), but using XFree86 4.3 and Mesa 3.4.2 I still get the following. Could someone please have a look at addressing these? directx.c:779: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: implicit declaration of function `glXGetProcAddressARB' wgl.c:325: warning: comparison between pointer and integer wgl.c:334: warning: assignment makes pointer from integer without a cast opengl_norm.c:26: warning: implicit declaration of function `glActiveTextureARB' opengl_norm.c:208: warning: implicit declaration of function `glClientActiveTextureARB' opengl_norm.c:2150: warning: implicit declaration of function `glMultiTexCoord1dARB' opengl_norm.c:2160: warning: implicit declaration of function `glMultiTexCoord1dvARB' opengl_norm.c:2170: warning: implicit declaration of function `glMultiTexCoord1fARB' opengl_norm.c:2180: warning: implicit declaration of function `glMultiTexCoord1fvARB' opengl_norm.c:2190: warning: implicit declaration of function `glMultiTexCoord1iARB' opengl_norm.c:2200: warning: implicit declaration of function `glMultiTexCoord1ivARB' opengl_norm.c:2210: warning: implicit declaration of function `glMultiTexCoord1sARB' opengl_norm.c:2220: warning: implicit declaration of function `glMultiTexCoord1svARB' opengl_norm.c:2230: warning: implicit declaration of function `glMultiTexCoord2dARB' opengl_norm.c:2240: warning: implicit declaration of function `glMultiTexCoord2dvARB' opengl_norm.c:2250: warning: implicit declaration of function `glMultiTexCoord2fARB' opengl_norm.c:2260: warning: implicit declaration of function `glMultiTexCoord2fvARB' opengl_norm.c:2270: warning: implicit declaration of function `glMultiTexCoord2iARB' opengl_norm.c:2280: warning: implicit declaration of function `glMultiTexCoord2ivARB' opengl_norm.c:2290: warning: implicit declaration of function `glMultiTexCoord2sARB' opengl_norm.c:2300: warning: implicit declaration of function `glMultiTexCoord2svARB' opengl_norm.c:2310: warning: implicit declaration of function `glMultiTexCoord3dARB' opengl_norm.c:2320: warning: implicit declaration of function `glMultiTexCoord3dvARB' opengl_norm.c:2330: warning: implicit declaration of function `glMultiTexCoord3fARB' opengl_norm.c:2340: warning: implicit declaration of function `glMultiTexCoord3fvARB' opengl_norm.c:2350: warning: implicit declaration of function `glMultiTexCoord3iARB' opengl_norm.c:2360: warning: implicit declaration of function `glMultiTexCoord3ivARB' opengl_norm.c:2370: warning: implicit declaration of function `glMultiTexCoord3sARB' opengl_norm.c:2380: warning: implicit declaration of function `glMultiTexCoord3svARB' opengl_norm.c:2390: warning: implicit declaration of function `glMultiTexCoord4dARB' opengl_norm.c:2400: warning: implicit declaration of function `glMultiTexCoord4dvARB' opengl_norm.c:2410: warning: implicit declaration of function `glMultiTexCoord4fARB' opengl_norm.c:2420: warning: implicit declaration of function `glMultiTexCoord4fvARB' opengl_norm.c:2430: warning: implicit declaration of function `glMultiTexCoord4iARB' opengl_norm.c:2440: warning: implicit declaration of function `glMultiTexCoord4ivARB' opengl_norm.c:2450: warning: implicit declaration of function `glMultiTexCoord4sARB' opengl_norm.c:2460: warning: implicit declaration of function `glMultiTexCoord4svARB' Thanks, Gerald

June 30, 2003

regression of patch 8366

by Oleg Prokhorov

Hello , This patch http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8366 Caused regression with chess.net application. (http://www.chess.net/cnfw/download/cnfw254.exe) If you click on a help button it will drop a messagebox which tells that 'No browser found', it is normal. The anomality is that it is not possible to close messagebox by clicking "ok" button with a mouse. But both pressing "enter" and clicking close window icon work. The line which produce the problem is (dlls/ole2/compobj.c) apt->win = CreateWindowA(aptWinClass, NULL, 0, 0, 0, 0, 0, 0, 0, OLE32_hInstance, NULL); -- Best regards, Oleg mailto:xolegpro(a)rbcmail.ru

June 30, 2003

Re: Known Wine ToDo's

by Shachar Shemesh

Tom wrote: > Hello Shachar, > > I am going to update the ToDo page : > http://www.winehq.com/?page=status_todo > > And im wondering if you can send me a list of ToDo's that your > aware of ? > > Thanks > > Tom > The tasks I'm talking about here are long term. Not all of them have been discussed on wine-devel yet. I'm CCing wine-devel in case anyone wants to object. National Language Support - Remove "Hebrew and Arabic" - it's just part of BiDi if technology is what wer'e talking about. If interface localization is what wer'e talking about, then just add "add localization to more languages". As a subitem of keyboard support, add "allow using a keyboard with keys outside the current locale codepage". Tools - Add "perform Windows' reboot operations automatically when required". Under "Low priority" add "Windows ACL support". -- Shachar Shemesh Open Source integration consultant Home page & resume - http://www.shemesh.biz/

June 30, 2003

Re: [MSRLE32] Some bugs and improvements.

by Tom

Michael Günnewig wrote: >Changelog: > - Fixed interframe compression - now works for RLE4 and RLE8. > - Fixed alignment of RLE4 in absolute mode. > - Improved compression (smaller output). > > Michael Günnewig > > > >------------------------------------------------------------------------ > >Index: dlls/msvideo/msrle32/msrle32.c >=================================================================== >RCS file: /home/wine/wine/dlls/msvideo/msrle32/msrle32.c,v >retrieving revision 1.4 >diff -d -u -r1.4 msrle32.c >--- dlls/msvideo/msrle32/msrle32.c 13 Jun 2003 23:17:01 -0000 1.4 >+++ dlls/msvideo/msrle32/msrle32.c 29 Jun 2003 17:32:06 -0000 >@@ -1,5 +1,5 @@ > /* >- * Copyright 2002 Michael Günnewig >+ * Copyright 2002-2003 Michael Günnewig > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public >@@ -17,8 +17,7 @@ > */ > > /* TODO: >- * - compression of RLE4 is buggy -- see FIXME's >- * - many improvements possible >+ * - some improvements possible > * - implement DecompressSetPalette? -- does we need it for anything? > */ > >@@ -297,10 +296,13 @@ > if (ColorCmp(clr1, clr3) <= lDist && > ColorCmp(clr2, clr4) <= lDist) { > /* diff at end? -- look-ahead for atleast ?? more encodable pixel */ >- >- /* FIXME */ >- >- return count; >+ if (pos + 2 < width && ColorCmp(clr1,lpB[pos+1]) <= lDist && >+ ColorCmp(clr2,lpB[pos+2]) <= lDist) { >+ if (pos + 4 < width && ColorCmp(lpB[pos+1],lpB[pos+3]) <= lDist && >+ ColorCmp(lpB[pos+2],lpB[pos+4]) <= lDist) >+ return count - 3; /* followed by atleast 4 encodable pixels */ >+ return count - 2; >+ } > } else if (lpP != NULL && ColorCmp(lpP[pos], lpB[pos]) <= lDist) { > /* 'compare' with previous frame for end of diff */ > INT count2 = 0; >@@ -331,9 +333,11 @@ > > for (count = 0; pos < width; pos++, count++) { > if (ColorCmp(lpA[pos], lpB[pos]) <= lDist) { >- /* diff at end? -- look-ahead for atleast one more encodable pixel */ >- if (pos + 1 < width && ColorCmp(lpA[pos], lpB[pos+1]) <= lDist) >- return count; >+ /* diff at end? -- look-ahead for some more encodable pixel */ >+ if (pos + 1 < width && ColorCmp(lpB[pos], lpB[pos+1]) <= lDist) >+ return count - 1; >+ if (pos + 2 < width && ColorCmp(lpB[pos+1], lpB[pos+2]) <= lDist) >+ return count - 1; > } else if (lpP != NULL && ColorCmp(lpP[pos], lpB[pos]) <= lDist) { > /* 'compare' with previous frame for end of diff */ > INT count2 = 0; >@@ -382,6 +386,8 @@ > /* add some pixel for absoluting if possible */ > count += countDiffRLE4(lpP, lpC - 1, lpC, pos-1, lDist, lpbi->biWidth); > >+ assert(count > 0); >+ > /* check for near end of line */ > if (x + count > lpbi->biWidth) > count = lpbi->biWidth - x; >@@ -390,9 +396,11 @@ > while (count > 2) { > INT i; > INT size = min(count, 254); >- BOOL extra_byte = (size / 2) % 2 || (size % 2); >+ int bytes = ((size + 1) & (~1)) / 2; >+ BOOL extra_byte = bytes & 0x01; > >- *lpSizeImage += 2 + size/2 + (size % 2) + extra_byte; >+ *lpSizeImage += 2 + bytes + extra_byte; >+ assert(((*lpSizeImage) % 2) == 0); > count -= size; > *lpOut++ = 0; > *lpOut++ = size; >@@ -468,6 +476,8 @@ > /* add some more pixels for absoluting if possible */ > count += countDiffRLE8(lpP, lpC - 1, lpC, pos-1, lDist, lpbi->biWidth); > >+ assert(count > 0); >+ > /* check for over end of line */ > if (x + count > lpbi->biWidth) > count = lpbi->biWidth - x; >@@ -663,6 +673,10 @@ > assert(lpOut == lpOutStart + lpbiOut->biSizeImage); > } > } >+ >+ /* add EOL -- will be changed to EOI */ >+ lpbiOut->biSizeImage += 2; >+ *((LPWORD)lpOut)++ = 0; > } > > /* change EOL to EOI -- end of image */ >@@ -789,11 +803,14 @@ > if (jumpy == 0) { > /* add EOL -- end of line */ > lpbiOut->biSizeImage += 2; >- *lpOut++ = 0; >- *lpOut++ = 0; >+ *((LPDWORD)lpOut)++ = 0; > assert(lpOut == (lpOutStart + lpbiOut->biSizeImage)); > } > } >+ >+ /* add EOL -- will be changed to EOI */ >+ lpbiOut->biSizeImage += 2; >+ *((LPDWORD)lpOut)++ = 0; > } > > /* change EOL to EOI -- end of image */ >@@ -847,7 +864,7 @@ > } > break; > default: /* absolute mode */ >- extra_byte = (code1 / 2) & 0x01 || (code1 % 2); >+ extra_byte = (((code1 + 1) & (~1)) / 2) & 0x01; > > if (pixel_ptr/bytes_per_pixel + code1 > lpbi->biWidth) > return ICERR_ERROR; >@@ -1468,9 +1485,7 @@ > > if (lpic->lpbiOutput->biBitCount == 4) > MSRLE32_CompressRLE4(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, >- lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, TRUE); >- /*MSRLE32_CompressRLE4(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, >- lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0);*/ >+ lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0); > else > MSRLE32_CompressRLE8(pi, lpic->lpbiInput, (LPBYTE)lpic->lpInput, > lpic->lpbiOutput, (LPBYTE)lpic->lpOutput, (lpic->dwFlags & ICCOMPRESS_KEYFRAME) != 0); > >

June 29, 2003

Re: Uninitialised variable in TASK_Create

by Saulius Krasuckas

> Hi, > > There is an unintialised string (the name variable) in TASK_Create in > task.c (visible if you run almost any program with --debugmsg +task). > I would try and fix the problem but I have no idea what the correct > fix is. Is this just a case of adding *name = 0? > > Rob hello, (heh, i've lost the race.. :P) cents: i have found patch, which made my valgrind to scream bout the same issue: http://cvs.winehq.com/patch.py?root=/home/winehq/opt/cvs-commit&id=8245 Index: wine/loader/task.c diff -u wine/loader/task.c:1.132 wine/loader/task.c:1.133 --- wine/loader/task.c:1.132 Sun Jun 29 20:22:43 2003 +++ wine/loader/task.c Sun Jun 29 20:22:43 2003 <skipped> @@ -299,13 +300,16 @@ /* Copy the module name */ - GetModuleName16( pModule->self, name, sizeof(name) ); - strncpy( pTask->module_name, name, sizeof(pTask->module_name) ); + if (hModule) + { + GetModuleName16( hModule, name, sizeof(name) ); + strncpy( pTask->module_name, name, sizeof(pTask->module_name) ); + } in addition to null-initializing the "name", i'd add this at several page-downs: - pTask->compat_flags = GetProfileIntA( "Compatibility", name, 0 ); + if(name) + { + pTask->compat_flags = GetProfileIntA( "Compatibility", name, 0 ); + } IMHO we'd "save" two api-calls (GetProfileIntA() ant GetPrivateProfileIntA()) using such check.

June 29, 2003