July 2003 - Wine-Devel - list.winehq.org

Re: first go at some notepad changes

by Jonathan Wilson

> Do not send bogus WM_SIZE messages, use SetWindowPos instead. Remove > iStatusBarHeight from globals and use IsWindowVisible and GetWindowRect > when you need to take into account status bar size. From looking at microsoft examples, said examples send WM_SIZE to the status bar and let it reposition itself. And also, said examples store the status bar height for later use (presumably because calling IsWindowVisible and GetWindowRect multiple times is slower than saving it and reusing it later) I dont know if there is one example that does both things but I do know that both things are done by microsoft example code.

July 28, 2003

Re: cab_F_00: codename: "whee"

by Gregory M. Turner

On Sunday 27 July 2003 09:35 pm, Dimitrie O. Paun wrote: > On July 27, 2003 04:46 pm, Gregory M. Turner wrote: > > - WARN("FDIIsCabinet failed.\n"); > > + ERR("FDIIsCabinet failed.\n"); > > Why these changes, they don't seem to make sense. > The function handles the problem just fine, no need > to spam the user with such messages, we already have > too many IMO. There is a "legitimate" way for this to occur, which makes it arguably excessive, but my reasoning was that 99% of the time this would instead be the result of some prior error which had occurred silently... Since there was no memory leak FIXME in fdi.c we get a failure in msiexec or whatever and it gives some message like "File not found" but debugmsg +file reveals nothing because no file operation occurs... I dunno I guess I thought maybe cabinet.dll would just be silent in this case and too easy to miss as a culprit... maybe it's stupid. -- gmt #define SHOCK_TRACE(...) \ do {\ WINE_TRACE("\n\nXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "X#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#X\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "X#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#X\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n\n"); \ WINE_TRACE(__VA_ARGS__); \ WINE_TRACE("\n\nXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "X#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#X\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n" \ "X#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#*#X\n" \ "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\n\n"); \ } while (0)

July 28, 2003

Re: first go at some notepad changes

by Dmitry Timoshkov

"Jonathan Wilson" <jonwil(a)tpgi.com.au> wrote: > +VOID DIALOG_ShowStatusBar(VOID) > +{ > + RECT rcs; > + RECT rc; > + GetClientRect(Globals.hMainWnd, &rc); > + Globals.bStatusBarEnabled = !Globals.bStatusBarEnabled; > + if (Globals.bStatusBarEnabled == TRUE) > + { > + ShowWindow(Globals.hStatusBar,SW_SHOW); > + GetClientRect(Globals.hStatusBar,&rcs); > + Globals.iStatusBarHeight = rcs.bottom - rcs.top; > + SendMessage(Globals.hStatusBar, WM_SIZE, 0, 0); > case WM_SIZE: > - SetWindowPos(Globals.hEdit, NULL, 0, 0, LOWORD(lParam), HIWORD(lParam), > + SetWindowPos(Globals.hEdit, NULL, 0, 0, LOWORD(lParam), (HIWORD(lParam)-Globals.iStatusBarHeight), > SWP_NOOWNERZORDER | SWP_NOZORDER); > + if (Globals.bStatusBarEnabled == TRUE) > + { > + SendMessage(Globals.hStatusBar, WM_SIZE, 0, 0); > + } Do not send bogus WM_SIZE messages, use SetWindowPos instead. Remove iStatusBarHeight from globals and use IsWindowVisible and GetWindowRect when you need to take into account status bar size. -- Dmitry

July 28, 2003

Re: first go at some notepad changes

by Dimitrie O. Paun

On July 27, 2003 08:16 am, Jonathan Wilson wrote: > 25.modify WM_SIZE to correctly size the edit controll if the status bar > is visble and to tell the status bar to resize itself if needed Shouldn't the status bar do this automatically when CCS_BOTTOM is specified? If our status bar needs some work to have this style properly implemented, we better fix it there. -- Dimi.

July 28, 2003

Re: Work for hire^H^H^H^Hgrade

by Dimitrie O. Paun

On July 27, 2003 11:42 am, Mark Westcott wrote: > It's also increadibly boring, which probably explains why at least 3 people > have started work on it and then stopped :). Patch comming Where, where? :))) -- Dimi.

July 28, 2003

Re: cab_F_00: codename: "whee"

by Dimitrie O. Paun

On July 27, 2003 04:46 pm, Gregory M. Turner wrote: > - WARN("FDIIsCabinet failed.\n"); > + ERR("FDIIsCabinet failed.\n"); Why these changes, they don't seem to make sense. The function handles the problem just fine, no need to spam the user with such messages, we already have too many IMO. -- Dimi.

July 28, 2003

MACRO and other problems on porting to w32api headers

by Steven Edwards

Hello, I am trying to get some of the WINE dlls to build with the w32api package and am running in to problems with typedefs. When I try to build some of the dlls lets take mapi32 as a example I am getting a parse error because of this: typedef unsigned long FAR *LPLHANDLE, FAR *LPULONG; Also some of the functions and structures are declaired as STDCALL in MS_VC and w32api but in wine it is listed as CALLBACK and this causes problems. Is there any documentation anywhere on how I should deal with the macro FAR and CALLBACK type in the headers? Thanks Steven

July 28, 2003

Re: API tracking and documentation

by Francois Gouget

On Sat, 12 Jul 2003, Steven Edwards wrote: [...] > The ReactOS project is interested in making a change to WINE the > function commented that would make API tracking a little nicer. We > have implemented a web page like the mono project has that shows the > implemented and unimplemented functions in the API. Will the WINE > project accept patches to the comments to support this type of > tracking system? It would be nice because you guys could implement the > same thing on your website. If the answer is no it is REALLY going to > be a PITA for us to diff our sources to yours for every function. > > Please take a momenet to look at the site and how it works. > http://reactos.wox.org/index.php?page=apistatus Patrik Stridvall wrote some code in winapicheck that makes it quite simple to do something relatively similar to the above. What's best, no new information is needed in the Wine sources. Check the following page for more details: http://fgouget.free.fr/wine/winapi_stats-en.shtml -- Francois Gouget fgouget(a)codeweavers.com

July 27, 2003

Re: dmusic loader question

by Dustin Navea

--- Rok Mandeljc <rok.mandeljc(a)gimb.org> wrote: > BTW, is it illegal to use MSDN examples to implement stuff in wine > (EULA...)? Fortunately, AFAIK, it is not illegal. It is only illegal to reverse engineer a compiled file, or to use copyrighted source obtained through other methods without the author's consent.. I know of several developers that take advantage of the articles in the MSDN, so that is where I am bassing my knowledge, although anyone else here can feel free to correct me if I am wrong.. ===== -- Dustin Navea Minor Contributor, winehq.com Buzilla Janitor, bugs.winehq.com Network Admin, irc.blynk.net (down) __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

July 27, 2003

Re: Work for hire^H^H^H^Hgrade

by Philipp Wollermann

Hi, I don't think it's boring, I like coding tools like this. :-) If there is a base to work on (and I finally get a new monitor, my current one is so unsharp / old, I can't read these antialiased fonts anymore ;-)) I think I could do some work on it.. Philipp ----- Original Message ----- From: "Mark Westcott" <mark(a)houseoffish.org> To: <wine-devel(a)winehq.com> Sent: Sunday, July 27, 2003 5:42 PM Subject: Re: Work for hire^H^H^H^Hgrade > On Sunday 27 July 2003 14:26, Dimitrie O. Paun wrote: > > On July 27, 2003 01:38 am, Shachar Shemesh wrote: > > > Currently at hand are adding encoding selection to the font dlg (and > > > making it ANSI call Unicode in the process), and adding BiDi to the edit > > > control. If you feel you have something else that may be of interest to > > > him, feel free to try and grab him away :-) > > > > Also, a nice project would be winecfg. It's not too difficult, it's > > self contained, it's important to Wine. > > It's also increadibly boring, which probably explains why at least 3 people > have started work on it and then stopped :). Patch comming > > Mark >

July 27, 2003