August 2003 - Wine-Devel - list.winehq.org

Re: New EXE

by Dimitrie O. Paun

On August 30, 2003 01:40 pm, Jakob Eriksson wrote: > http://vmlinux.org/jakov/Wine/regrtest.exe Very nice! I already submitted some results :) Some comments: -- I have Win2k here, and the comctl32 test bombed because it could not find DPA_Create (why?!?) -- We should look for and report the exact version number of the OS. Now that we have a C program, it should not be difficult. -- I haven't checked, I hope it also cleans up after itself :) This is shaping up nicely. What we still need to do: -- enlist someone for building this binary on every release, and upload it to WineHQ. -- process these results automatically. Feri is on that one -- create a new page on WineHQ dedicated to testing. We should move the testing bits from the janitorial pages there, plus instructions, links to the binary, the results, etc. -- Dimi.

Aug. 30, 2003

Re: LoadModule16 regression?

by Alexandre Julliard

Jukka Heinonen <jhei(a)iki.fi> writes: > MSDN documentation on Win32 version of LoadModule states > that path should not be stripped but I'm not sure how Win16 > version is supposed to work. It probably uses different > search order if path is not present, anyway. Yes, Win16 is somewhat different, the module path is stripped and only the base name is used when looking for an existing module. But of course we should only strip the full path after the file has been opened... this should fix it: Index: dlls/kernel/ne_module.c =================================================================== RCS file: /home/winehq/opt/cvs-commit/wine/dlls/kernel/ne_module.c,v retrieving revision 1.5 diff -u -p -r1.5 ne_module.c --- dlls/kernel/ne_module.c 27 Aug 2003 03:16:56 -0000 1.5 +++ dlls/kernel/ne_module.c 30 Aug 2003 18:37:13 -0000 @@ -1162,22 +1162,23 @@ static HINSTANCE16 MODULE_LoadModule16( enum loadorder_type loadorder[LOADORDER_NTYPES]; int i; const char *filetype = ""; - const char *ptr; + const char *ptr, *basename; /* strip path information */ - if (libname[0] && libname[1] == ':') libname += 2; /* strip drive specification */ - if ((ptr = strrchr( libname, '\\' ))) libname = ptr + 1; - if ((ptr = strrchr( libname, '/' ))) libname = ptr + 1; + basename = libname; + if (basename[0] && basename[1] == ':') basename += 2; /* strip drive specification */ + if ((ptr = strrchr( basename, '\\' ))) basename = ptr + 1; + if ((ptr = strrchr( basename, '/' ))) basename = ptr + 1; - if (is_builtin_present(libname)) + if (is_builtin_present(basename)) { - TRACE( "forcing loadorder to builtin for %s\n", debugstr_a(libname) ); + TRACE( "forcing loadorder to builtin for %s\n", debugstr_a(basename) ); /* force builtin loadorder since the dll is already in memory */ loadorder[0] = LOADORDER_BI; loadorder[1] = LOADORDER_INVALID; } - else MODULE_GetLoadOrder(loadorder, libname, FALSE); + else MODULE_GetLoadOrder(loadorder, basename, FALSE); for(i = 0; i < LOADORDER_NTYPES; i++) { -- Alexandre Julliard julliard(a)winehq.com

Aug. 30, 2003

New EXE

by Jakob Eriksson

http://vmlinux.org/jakov/Wine/regrtest.exe Should now work on Win9x too. Works on ME at least.

Aug. 30, 2003

Re: winedos / Fix DOS exit paths

by Dimitrie O. Paun

On August 30, 2003 12:52 pm, Jukka Heinonen wrote: > The reason why I'm posting lots of small patches is that I'm currently > working on a big RMCB fix which seems to still have some minor problems What is this RMCB? Google wasn't all that helpful... -- Dimi.

Aug. 30, 2003

Bug in regrtest

by Jakob Eriksson

The tester runs on Win9X, but there is a bug that prevents it from running tests properly. I am working on it. Tested working on Windows NT so far. I will keep you posted. regards, Jakob

Aug. 30, 2003

LoadModule16 regression?

by Jukka Heinonen

After LoadModule16 was moved to dlls/kernel, it started to strip path from module name. This makes it impossible to execute DOS applications (and probably Win16 applications, too) unless you are in the same directory as the application. MSDN documentation on Win32 version of LoadModule states that path should not be stripped but I'm not sure how Win16 version is supposed to work. It probably uses different search order if path is not present, anyway. -- Jukka Heinonen <http://www.iki.fi/jhei/>

Aug. 30, 2003

shlobj.h [resend]

by Martin Fuchs

> Your patch is unfortunately wrapped. shlguid.h suffers from the same > problem. OK, now as attachement. Changelog: * define interface IDragSourceHelper * define interface IDropTargetHelper I will post the 'const' correction for LPCITEMIDLIST as a separate change, because there has to be adjusted more in dlls/shell32. -- Martin Fuchs martin-fuchs(a)gmx.net

Aug. 30, 2003

Re: shlobj.o

by Vincent Béron

Le sam 30/08/2003 à 08:29, Martin Fuchs a écrit : > + STDMETHOD_(ULONG, AddRef) (THIS) PURE; > + STDMETHOD_(ULONG, Release) (THIS) PURE; > + STDMETHOD (DragEnter)(THIS_ HWND hwndTarget, IDataObject* pDataObject, > POINT* ppt, DWORD dwEffect) PURE; > + STDMETHOD (DragLeave)(THIS) PURE; > + STDMETHOD (DragOver)(THIS_ POINT* ppt, DWORD dwEffect) PURE; > + STDMETHOD (Drop)(THIS_ IDataObject* pDataObject, POINT* ppt, DWORD > dwEffect) PURE; Your patch is unfortunately wrapped. shlguid.h suffers from the same problem. Vincent

Aug. 30, 2003

Re: Wine 0.9 progress

by Dimitrie O. Paun

On August 30, 2003 05:59 am, Jakob Eriksson wrote: > I change my mind. I want a new mailing list! :-) > What is the name of it? Cool :-) It's wine-tests-results(a)winehq.org Jer, can you set it up please when you get a chance? -- Dimi.

Aug. 30, 2003

Re: [winecfg 1.1] Implement saveConfigValue(), style changes, code cleanup, UI alignment

by Francois Gouget

On Fri, 29 Aug 2003, Dustin Navea wrote: [...] > Not sure how possible this is or if it has already been thought of just let > me know, but what about loading the config into memory and having wine make > it look like the registry while loaded (ie for windows regedit). I believe Wine already does somethin like this, but maybe not. [...] > wine can do > the processing of both the registry and the config, and then when it is time > to save the changes done in regedit, wine sorts it out between what needs to > be written to the actual registry and what needs to be written to the config > file. But in any case, this is where you hit problems. When loading the registry or the configuration, Wine simply ignores the comments. And when saving the changes Wine rewrites the registry file from scratch. If we do the same for the configuration file it means we loose all the comments, making it pointless to put them in in the first place... Of course we could have a special case for the configuration file so that we keep the comments in memory, maybe also keep the file layout and then merge the changes when we save. But that means using a different codebase for the settings and for the registry which I believe is the opposite of what we want to do by moving the settings to the registry. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

Aug. 30, 2003