August 2003 - Wine-Devel - list.winehq.org

Re: Trackbar select range tweaks

by Dustin Navea

--- Duane Clark <dclark(a)akamail.com> wrote: > Dustin Navea wrote: > > ok thx, running on win2k sp2, the attached executable showed > > > > GetSystemMetrics(SM_CYCAPTION) = 19 > > > > Hmm, that's interesting. I'm running Win2K "Professional" SP3. Anyway, I > played around a bit and found out that if I login as administrator, then > GetSystemMetrics(SM_CYCAPTION) = 19, but if I login as dclark then > GetSystemMetrics(SM_CYCAPTION) = 20. Very strange ;) There is no visible > difference between the two accounts that I can see. In both cases, the > thumb is 21. > > I can get a different metric if I set Windows to use large fonts, and > that does increase the size of the trackbar thumb. That is odd.. Because when I ran that, I was running it on a user account on a computer that I did not have administrative access to.. here is the output on my home comp (w2k sp3) from my user acct: GetSystemMetrics(SM_CYCAPTION) = 19 admin acct in a min.. ===== -- Dustin Navea Minor Contributor, http://www.winehq.com Bugzilla Janitor, http://bugs.winehq.com Network Admin, irc://irc.blynk.net (down) __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

Aug. 4, 2003

RE: [dx73b] Try3: Performance of texture states

by Ann and Jason Edmeades

>> (Try#3 - Also fixes Operation Flashpoint problem which was introduced >> AND includes the patch... oops!) >My goodness... Flashpoint works? How long has that been? Good $*^!$#^@ work!! I should define 'work' - The graphics appear ok now, but I always run with sound disabled (I have enough problems without adding to them) so I have no idea if sound works. However, this is the game I mention has a weird mouse cursor which does silly things like jumping and not liking diagonals! Therefore it is viewable (I started the tutorial and it all seems to display fine), but I wouldnt call it playable... Get on with the OLE/DCOM stuff instead :-) Jason

Aug. 4, 2003

Re: Windows API db / find APIs missing for a given app

by Vincent Béron

Le lun 04/08/2003 à 10:39, Dimitrie O. Paun a écrit : > On August 3, 2003 03:38 am, David Miller wrote: > > Recently I spent some time on this again and would like anyone interested > > in the database to take a look and email me comments. > > When comparing 'exports' for example, I get this kind of output: > ... > IID_IAVIStream is exported by win98-4.10.1998 and wine > IID_IGetFrame is exported by win98-4.10.1998 and wine > BitReverseBuf is exported by win98-4.10.1998 only > FaxCodecChange is exported by win98-4.10.1998 only > ... > > which is fine, but I will drop the similarities: > > IID_IAVIStream is exported by win98-4.10.1998 and wine > IID_IGetFrame is exported by win98-4.10.1998 and wine > > just output the differences, there are too many anyway. > Or have a checkbox to ask the user if they want to see > only the differences. I checked the unimplemented APIs for vcdeasy, and there are two things: - Cygwin's dlls (cygz, cygjpeg6b, cygxml2-2, cygwin1) are listed, when they're not part of a Windows installation. You should try to separate what's part of Windows (any version), and what can be found elsewhere (from an application, a toolkit, etc.). - Also, in gdi32, BitBlt and StretchBlt are marked as stubs. I have a hard time believing that. What's your method to identify stubs? Vincent

Aug. 4, 2003

Re: Windows API db / find APIs missing for a given app

by Dimitrie O. Paun

On August 3, 2003 03:38 am, David Miller wrote: > Recently I spent some time on this again and would like anyone interested > in the database to take a look and email me comments. When comparing 'exports' for example, I get this kind of output: ... IID_IAVIStream is exported by win98-4.10.1998 and wine IID_IGetFrame is exported by win98-4.10.1998 and wine BitReverseBuf is exported by win98-4.10.1998 only FaxCodecChange is exported by win98-4.10.1998 only ... which is fine, but I will drop the similarities: IID_IAVIStream is exported by win98-4.10.1998 and wine IID_IGetFrame is exported by win98-4.10.1998 and wine just output the differences, there are too many anyway. Or have a checkbox to ask the user if they want to see only the differences. -- Dimi.

Aug. 4, 2003

Re: Profiling wine

by Mike McCormack

Hi Mike, When compiling the profiled build, the configure script defines the Makefile variable PROFILE_CFLAGS to contain: -DWINE_NO_PROFILE="__attribute__((no_instrument_function))" When we're not using the profiler, WINE_NO_PROFILE is defined to nothing, and thus has no effect. Mike Mike Hearn wrote: > Yup, found it, but looking through the code it seems Mikes initial > evaluation (i missed bits and it doesn't work) is accurate. Is Charles > around? If so it'd be good to get this patch into WineHQ, more and more > bugs these days seem to be along the lines of "wine is too slow". I also > have some questions, like what exactly WINE_NO_PROFILE does (it's > defined to nothing....) > > thanks -mike >

Aug. 4, 2003

RE: Linking to _wtol function

by thomas.mertes＠gmx.at

"Robert Shearman" <R.J.Shearman_at_warwick.ac.uk> wrote: > I'd like to get people's opinions on how I should link to the _wtol function > from a Wine DLL. Should I: > > a) Link to NTDLL and use the function there > b) Link to MSVCRT and use the function there > c) Create a new function in unicode.h > d) Copy the function into my DLL a) and b) are equivalent. In dlls/msvcrt/msvcrt.spec _wtol is just a link to ntdll._wtol. I suggest you use a) since NTDLL is always present (in NT systems). If your program/dll should also run in DOS based systems you should use b). Btw. The wine implementation of the _wtol function is okay, so c) is not necessary. And code duplication d) is also not a good idea. > In that case should I reimplement _wtol in NTDLL function using strtolW? The > rest of the functions in wcstring.c call their libunicode versions, but this > one doesn't. This is wrong the only function in wcstring.c calling strtolW is _wcstol. As you can see in the changelog several months ago I implemented the functions _ultoa, _ltoa, _itoa, _ui64toa, _i64toa, _atoi64, _ultow, _ltow, _itow, _ui64tow, _i64tow, _wtol, _wtoi, _wtoi64. There are also test functions for this functions in the dlls/ntdll/tests directory. All this functions work correct and are documented. There is no reason to rewrite them for fun unless you find a bug. If you want to write little library functions, It is not necessary to rewrite something already working. Search for library functions in msvcrt. There are tons of unimplemented functions. Greetings Thomas Mertes -- COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test -------------------------------------------------- 1. GMX TopMail - Platz 1 und Testsieger! 2. GMX ProMail - Platz 2 und Preis-Qualitätssieger! 3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post

Aug. 4, 2003

Re: Strange code in misc/registry.c

by Lionel Ulmer

> > > new_key_name = malloc(strlen(key_name)+dkh->keynamelen+1); > > > strcpy(new_key_name, key_name); > > > > Well, these two lines are EXACTLY what the strndup code does :-) > > I don't think so. memcpy != strcpy. I meant to add 'with my fix attached to my first mail'. But well, will let the masters fix it (I am currently happpy with the fix I have in my tree). Lionel -- Lionel Ulmer - http://www.bbrox.org/

Aug. 4, 2003

Re: [dx73b] Try3: Performance of texture states

by Gregory M. Turner

On Sunday 03 August 2003 05:02 am, Ann and Jason Edmeades wrote: > (Try#3 - Also fixes Operation Flashpoint problem which was introduced > AND includes the patch... oops!) My goodness... Flashpoint works? How long has that been? Good $*^!$#^@ work!! But: you should /not/ have told me this as I will be much less productive now. -- gmt "Microsoft is committed to making cabinet files an open technology" http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dncabsdk/h…

Aug. 4, 2003

Re: Linking to _wtol function

by Dmitry Timoshkov

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> wrote: > > e) use strtolW provided by libwine_unicode and declared in unicode.h > > > > In that case should I reimplement _wtol in NTDLL function using strtolW? The > rest of the functions in wcstring.c call their libunicode versions, but this > one doesn't. No. Current _wtol implementation is fine. -- Dmitry.

Aug. 4, 2003

Re: Strange code in misc/registry.c

by Dmitry Timoshkov

"Lionel Ulmer" <lionel.ulmer(a)free.fr> wrote: > > It's clearly a bug, since the code asks for trouble by requesting to > > read more data than it actually should. In that case the code has to do: > > > > new_key_name = malloc(strlen(key_name)+dkh->keynamelen+1); > > strcpy(new_key_name, key_name); > > Well, these two lines are EXACTLY what the strndup code does :-) I don't think so. memcpy != strcpy. -- Dmitry.

Aug. 4, 2003