August 2003 - Wine-Devel - list.winehq.org

RE: Linking to _wtol function

by Robert Shearman

> > I'd like to get people's opinions on how I should link to the > > _wtol function > > e) use strtolW provided by libwine_unicode and declared in unicode.h > In that case should I reimplement _wtol in NTDLL function using strtolW? The rest of the functions in wcstring.c call their libunicode versions, but this one doesn't. Rob

Aug. 3, 2003

Re: Windows API db / find APIs missing for a given app

by BiGgUn

>3. Find unimplemented APIs for a given program. I typed some apps name (mirc, dreamweaver...) but i just got 'The following applications were found:'. Did i miss something ? >The forms are currently at http://24.229.94.2 Unfortunately I can't keep this as a permanent location. The PC is just too slow >and the scripts really hog CPU. They do lots of SQL queries. :) SQL queries are already optimized ? Do you use a CGI or PHP script tp make your queries ? Stephan

Aug. 3, 2003

Windows API db / find APIs missing for a given app

by David Miller

Recently I spent some time on this again and would like anyone interested in the database to take a look and email me comments. (What's good, how it can be better, and what features could be there, but aren't) Currently the web interface consists of a few forms which do the following: 1. Compare imports or exports between two windows versions. This will output all APIs imported or exported by a dll you specify along with which version exports that API. Example: you specify wine and windows95 as windows versions. Each API will say it is exported by wine only, win95 only, or both. It is color coded in the hope of making it slightly more readable. 2. Perform general queries. This just does SQL queries based on the criteria you specify. You can query by any or all fields. 3. Find unimplemented APIs for a given program. This locates all APIs imported by a specified application and outputs the ones which are unimplemented or stubs in wine. This is broken down by dll which the app tries to import from. Red APIs are not in wine spec files while blue APIs are listed as stubs in the spec files. There are only a couple of apps listed right now. Leave the application field empty for a complete list. I intend to make the output hyperlinks which will query for all apps importing that specific API. Maybe that will help find test cases when tracking down a bug. The forms are currently at http://24.229.94.2 Unfortunately I can't keep this as a permanent location. The PC is just too slow and the scripts really hog CPU. They do lots of SQL queries. :)

Aug. 3, 2003

Re: Strange code in misc/registry.c

by Dmitry Timoshkov

"Lionel Ulmer" <lionel.ulmer(a)free.fr> wrote: > Not really as the code does this : > > /* create new subkey name */ > new_key_name = _strdupnA(key_name,strlen(key_name)+dkh->keynamelen+1); > if (strcmp(new_key_name,"") != 0) strcat(new_key_name,"\\"); > strncat(new_key_name,dkh->name,dkh->keynamelen); > > So basically it does 'duplicate my string but add XXX bytes to it as I want > to strcat to it a new string of len XXX'. It's clearly a bug, since the code asks for trouble by requesting to read more data than it actually should. In that case the code has to do: new_key_name = malloc(strlen(key_name)+dkh->keynamelen+1); strcpy(new_key_name, key_name); if (strcmp(new_key_name,"") != 0) strcat(new_key_name,"\\"); strncat(new_key_name,dkh->name,dkh->keynamelen); -- Dmitry.

Aug. 3, 2003

Re: Strange code in misc/registry.c

by Lionel Ulmer

> I'm not a Registry guru by all means :-), but IMO the real bugs are at lines > 701: > new_key_name = _strdupnA(key_name,strlen(key_name)+dkh->keynamelen+1); > and 1011: > new_key_name = _strdupnA(key_name,strlen(key_name)+nk->name_len+1); Not really as the code does this : /* create new subkey name */ new_key_name = _strdupnA(key_name,strlen(key_name)+dkh->keynamelen+1); if (strcmp(new_key_name,"") != 0) strcat(new_key_name,"\\"); strncat(new_key_name,dkh->name,dkh->keynamelen); So basically it does 'duplicate my string but add XXX bytes to it as I want to strcat to it a new string of len XXX'. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Aug. 3, 2003

Re: Strange code in misc/registry.c

by Dmitry Timoshkov

"Lionel Ulmer" <lionel.ulmer(a)free.fr> wrote: > The attached patch fixes all crashes on my box, but well, as I am not very > familiar with this code, sent it to wine-devel and not wine-patches for > review by Registry gurus :-) I'm not a Registry guru by all means :-), but IMO the real bugs are at lines 701: new_key_name = _strdupnA(key_name,strlen(key_name)+dkh->keynamelen+1); and 1011: new_key_name = _strdupnA(key_name,strlen(key_name)+nk->name_len+1); which incorrectly do request to copy too much bytes. -- Dmitry.

Aug. 3, 2003

Re: Linking to _wtol function

by Dmitry Timoshkov

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> wrote: > I'd like to get people's opinions on how I should link to the _wtol function > from a Wine DLL. Should I: > > a) Link to NTDLL and use the function there > b) Link to MSVCRT and use the function there > c) Create a new function in unicode.h > d) Copy the function into my DLL e) use strtolW provided by libwine_unicode and declared in unicode.h -- Dmitry.

Aug. 3, 2003

Re: [dx73b] Try2: Performance of texture states

by Marcelo Duarte

You forget the patch ;) ----- Original Message ----- From: "Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> To: "wine patches" <wine-patches(a)winehq.com>; "Raphael Junqueira" <fenix(a)club-internet.fr> Sent: Saturday, August 02, 2003 8:19 PM Subject: [dx73b] Try2: Performance of texture states > (Try#2 - Also fixes Operation Flashpoint problem which was introduced) > > This is the first patch which looks at the performance of changing the > textures on a texture unit. As was pointed out to me by Lucho, certain > information is per texture unit and hence not affected when a different > texture object is bound. This patch on my machine changes the displayed > fps by the Billboard sample from 30.6 to about 42.6. [Actually it was > 43.0 > with patch b, but I dont see why!] > > There is still more optimization which can be done here, but this is a > start. > > Let me know if anyone notices any regressions with this one. > > Changelog > Only reapply the texture states necessary when a different texture gets > bound to the same texture unit. > Jason >

Aug. 3, 2003

(no subject)

by puoti＠inwind.it

I've decided I'll include the wine faq and wine user guide into my next wine rpm, but I've noticed that the docs need some updates. For a start, they need a version for rpm packages, it seems a bit crazy to install a binary rpm of wine, open the user manual, and find a guide on where you can download wine and howto compile the source, one would usually expect something like 'thank you for installing wine, we hope you enjoy out product'. Also, as the wine packaging guide says that rpms should get the user up and running in minutes, using a script or something like winesetuptk, so I don't think that a guide for end users that what to install office/there new windows 3D game/whatever should have a long description of the wine config file (I don't remember seeing documentation about the windows registry anyware after installing windows 98). The current manual presumes that one doesn't have wine installed, so all the where to get/how to install part should go, at least from the version we want i packages after 1.0, and something like 'you can download the most recent version of wine from <link to the wine sourceforge download page>' should go in it's place. Once wine reaches 0.9, I would be happy to help updating the docs, so we have something very user friendly before 1.0, and I could also translate the docs to italian.

Aug. 3, 2003

Re:how to use wine on linux??

by puoti＠inwind.it

This site may help you http://digilander.libero.it/winehqitalia

Aug. 3, 2003