January 2004 - Wine-Devel - list.winehq.org

Re: Re: cvs documentation not in sync with website?

by chmorgan＠charter.net

Well documentation/documentation.sgml 1.12->1.13 was when the change was made in cvs, and that looks like it was 3+ months ago. Chris > > From: Jeremy Newman <jnewman(a)codeweavers.com> > Date: 2004/01/19 Mon AM 10:52:47 EST > To: Chris Morgan <cmorgan(a)alum.WPI.EDU> > CC: wine-devel(a)winehq.com > Subject: Re: cvs documentation not in sync with website? > > The docs build when Alexandre runs the wine_release script in the tools > cvs. http://cvs.winehq.org/cvsweb/tools/wine_release > > wine_release calls make_winehq also found in the tools cvs. If the docs > are out of date, it would be an error found in one of these two scripts. > > > On Sun, 2004-01-18 at 21:54, Chris Morgan wrote: > > I noticed this snippet from the online docs in the documentation section: > > http://winehq.com/site/docs/wine-devel/wine-docbook > > > > Run ./configure (or make distclean && ./configure) > > Switch to the documentation/ directory > > run ./make_winehq <----------- This line has changed > > View wine-doc/index.html in your favorite browser > > > > make_winehq has apparently been obsoleted, replaced by 'make html'. I was > > wondering why the web documentation wasn't in sync with the html docs. > > Shouldn't we be pulling the web documentation pages directly from the cvs > > pages at some scheduled interval? > > > > Thanks, > > Chris > -- > Jeremy Newman <jnewman(a)codeweavers.com> > CodeWeavers, Inc. > > >

Jan. 19, 2004

Re: DPA_Create/Search may be missing

by Hans Leidekker

On Sunday 18 January 2004 18:02, Francois Gouget wrote: > What about MinGW? It sounds like this test does not compile there > either... Well, it compiles and links, but doesn't link at run-time because MinGW's import lib exports these symbols by name, not ordinal-only. I submitted a patch to correct this to MinGW but they wouldn't accept it because of some documented-by-Microsoft-only policy. -Hans

Jan. 19, 2004

Re: cvs broken?

by Tom

Jeremy Newman wrote: > I assume you are talking about CVSweb (aka http://cvs.winehq.org/) If > you want to download a file, use the command line cvs client. I am not > comfortable giving apache or the cvsweb.cgi write privileges to the CVS > tree. Well it use to let you view a file... Now all I get is error's go to say : http://cvs.winehq.org/cvsweb/wine/dlls/dplayx/dplaysp.h select (download) = error select for diff works e.g. http://cvs.winehq.org/cvsweb/wine/dlls/dplayx/dplaysp.h.diff?r1=1.12&r2=1.13 So its broke :-) Can you fix it ? Tom

Jan. 19, 2004

Re: cvs documentation not in sync with website?

by Jeremy Newman

The docs build when Alexandre runs the wine_release script in the tools cvs. http://cvs.winehq.org/cvsweb/tools/wine_release wine_release calls make_winehq also found in the tools cvs. If the docs are out of date, it would be an error found in one of these two scripts. On Sun, 2004-01-18 at 21:54, Chris Morgan wrote: > I noticed this snippet from the online docs in the documentation section: > http://winehq.com/site/docs/wine-devel/wine-docbook > > Run ./configure (or make distclean && ./configure) > Switch to the documentation/ directory > run ./make_winehq <----------- This line has changed > View wine-doc/index.html in your favorite browser > > make_winehq has apparently been obsoleted, replaced by 'make html'. I was > wondering why the web documentation wasn't in sync with the html docs. > Shouldn't we be pulling the web documentation pages directly from the cvs > pages at some scheduled interval? > > Thanks, > Chris -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

Jan. 19, 2004

Re: cvs broken?

by Jeremy Newman

I assume you are talking about CVSweb (aka http://cvs.winehq.org/) If you want to download a file, use the command line cvs client. I am not comfortable giving apache or the cvsweb.cgi write privileges to the CVS tree. On Sun, 2004-01-18 at 21:55, Tom wrote: > If I try to download a file from cvs > I get this error. > > Error > Error: Unexpected output from cvs co: cvs [checkout aborted]: Absolute > module reference invalid: `/wine/dlls/msdmo/msdmo_main.c' > > Check, whether there exists a directory /home/wine/CVSROOT and the > script has write-Access to the CVSROOT/history if it exists. > It needs to place lock-files in the directory the file is in as well. > > Jer ? > > Tom -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

Jan. 19, 2004

Re: Hi

by Jeremy Newman

Hmmm, you shouldn't be subscribed to the list anymore. Consider yourself unsubscribed. I'll find this and remove it from the archive as well... On Sun, 2004-01-18 at 22:58, jsheets(a)codeweavers.com wrote: > Test =) > jxbvitmuqfjiwe > -- > Test, yep. -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

Jan. 19, 2004

Re: Re: [winecfg] - audio tab w/autodetection, misc

by chmorgan＠charter.net

If other people think it makes sense then yes, I think we should probably move the autodetection code to run at wine startup. The code thus far is very much non-portable so while it should work under linux I'm not sure about other os's. I've considered also trying to dynamically load the sound libraries and use their library calls to detect the sound libraries. Any improvments or suggestions are more than welcome. The autodetection works well for me though so I'd imagine it would work for most linux end-users. Chris > > From: Mike Hearn <mike(a)theoretic.com> > Date: 2004/01/19 Mon AM 09:00:48 EST > To: wine-devel(a)winehq.com > Subject: Re: [winecfg] - audio tab w/autodetection, misc > > On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > > Winmm to winejack.drv, res=1021 > > > > Is this expected as changing this option would require the registry functions > > to modify the config file, something they can't do? > > Yes, that's normal. The config file is loaded as a read-only branch. To > fully test patches change the constant in the winecfg.h file so it points > to a new branch (ie a writable one). > > > Chris Morgan <cmorgan(a)alum.wpi.edu> > > Add audio tab with first pass at autodetection of audio driver. Double > > clicking a drive entry brings up drive edit window. > > One thing I'd ask is should the autodetection code be in Wine itself, > rather than the config utility? > > The patch looks good! :) > > thanks -mike > > > >

Jan. 19, 2004

Re: [winecfg] - audio tab w/autodetection, misc

by Mike Hearn

On Sun, 18 Jan 2004 18:08:30 -0500, Chris Morgan wrote: > err:winecfg:setConfigValue Unable to set configuration key Drivers in section > Winmm to winejack.drv, res=1021 > > Is this expected as changing this option would require the registry functions > to modify the config file, something they can't do? Yes, that's normal. The config file is loaded as a read-only branch. To fully test patches change the constant in the winecfg.h file so it points to a new branch (ie a writable one). > Chris Morgan <cmorgan(a)alum.wpi.edu> > Add audio tab with first pass at autodetection of audio driver. Double > clicking a drive entry brings up drive edit window. One thing I'd ask is should the autodetection code be in Wine itself, rather than the config utility? The patch looks good! :) thanks -mike

Jan. 19, 2004

Re: Hi (virus alert)

by Mike Hearn

On Mon, 19 Jan 2004 03:03:31 -0800, Joshua Walker wrote: > 3) If Microsoft just removed the ability to run > executables from Outlook, and made it so the user > would have to "activate" it via a executable > permission (Chmod 755 wsmktvxhew.exe) 99% of these > things won't even propgate. I don't really believe that, to be honest. People choose to run these things, if they have to go through some meaningless mechanical ritual in order to run it they will anyway. I mean, it's not like their finger slips and they say "oops looks like I clicked the virus, ah well".

Jan. 19, 2004

Re: Hi (virus alert)

by Jeremy White

Hi Joshua, Joshua Walker wrote: > "W32.Beagle.A(a)mm" was found as an attachment. > > A few things amuse me about this... > > 1) Coadweaves makes a great product, I just hope that > this wan't sent from a Linux box running crossover. No; John Sheets hasn't worked with us for a few years, his email has clearly been harvested from someone elses address book (one that had both he and wine-devel in it :-( ). Of course, doesn't mean that person wasn't bitten by Wine... > > 2) I think we all run linux here. We can pretty much > say that this particular distrobution spoke is pretty > much dead... > > 3) If Microsoft just removed the ability to run > executables from Outlook, and made it so the user > would have to "activate" it via a executable > permission (Chmod 755 wsmktvxhew.exe) 99% of these > things won't even propgate. CrossOver Office has a hack^H^H^H^Hproprietary technology that prevents CreateProcess from opening .exe, .bat, and a few others if the calling process is 'outlook.exe'. *This* is why Wine is so cool - because we can choose to do the things that Microsoft is resistant too. Cheers, Jeremy

Jan. 19, 2004

shell32: Implement PathGetShortPathA/W

by Rolf Kalbermatter

Changelog - include/shlobj.h Add declaration for PathGetShortPath - dlls/shell32/undocshell.h Change prototype of PathGetShortPathAW to match MSDN - dlls/shell32/shellpath.c Implement PathGetShortPathA/W and change it's prototype to match the documentation on MSDN. Tests show that at least under W2K SP4 the return value actually seems to be the buffer pointer on success or NULL otherwise, but that might be rather a side effect of the function than intended behaviour. One thing I'm not entirely sure is how to declare the prototype in shlobj.h correctly. This is one of those functions shell32 exports as Unicode/ANSI depending on the Windows version, without the normal A and W exports as well. So shlobj.h needs to declare a function name without the A or W ending. The normal WINELIB_AW macros won't work here as the decision about A/W is not made on compile time of the application but instead on compile time of the library. What I don't like about this approach is the fact that there are basically two declarations for the same exported function in two different places GetShortPathAW in dlls/shell32/undocshell.h and GetShortPath in include/shlobj.h. License: X11/LGPL Rolf Kalbermatter Index: include/shlobj.h =================================================================== RCS file: /home/wine/wine/include/shlobj.h,v retrieving revision 1.80 diff -u -r1.80 shlobj.h --- include/shlobj.h 8 Jan 2004 00:39:21 -0000 1.80 +++ include/shlobj.h 19 Jan 2004 11:21:45 -0000 @@ -841,6 +841,11 @@ DECL_WINELIB_TYPE_AW(FILEGROUPDESCRIPTOR) DECL_WINELIB_TYPE_AW(LPFILEGROUPDESCRIPTOR) +/**************************************************************************** + * Path Manipulation Routines + */ +VOID WINAPI PathGetShortPath(LPVOID pszPath); + #include <poppack.h> /***************************************************************************** Index: dlls/shell32/undocshell.h =================================================================== RCS file: /home/wine/wine/dlls/shell32/undocshell.h,v retrieving revision 1.19 diff -u -r1.19 undocshell.h --- dlls/shell32/undocshell.h 16 Jan 2004 23:04:41 -0000 1.19 +++ dlls/shell32/undocshell.h 19 Jan 2004 11:51:43 -0000 @@ -544,7 +544,7 @@ BOOL WINAPI PathRemoveFileSpecAW(LPVOID lpszPath); -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath); +VOID WINAPI PathGetShortPathAW(LPVOID lpszPath); void WINAPI PathRemoveBlanksAW(LPVOID lpszPath); Index: dlls/shell32/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shellpath.c,v retrieving revision 1.77 diff -u -r1.77 shellpath.c --- dlls/shell32/shellpath.c 16 Jan 2004 23:04:41 -0000 1.77 +++ dlls/shell32/shellpath.c 19 Jan 2004 11:25:29 -0000 @@ -22,7 +22,6 @@ * Many of these functions are in SHLWAPI.DLL also * */ - #include "config.h" #include "wine/port.h" @@ -236,29 +235,41 @@ /************************************************************************* * PathGetShortPathA [internal] */ -LPSTR WINAPI PathGetShortPathA(LPSTR lpszPath) +VOID WINAPI PathGetShortPathA(LPSTR pszPath) { - FIXME("%s stub\n", lpszPath); - return NULL; + CHAR path[MAX_PATH]; + + TRACE("%s\n", pszPath); + + if (GetShortPathNameA(pszPath, path, MAX_PATH)) + { + lstrcpyA(pszPath, path); + } } /************************************************************************* * PathGetShortPathW [internal] */ -LPWSTR WINAPI PathGetShortPathW(LPWSTR lpszPath) +VOID WINAPI PathGetShortPathW(LPWSTR pszPath) { - FIXME("%s stub\n", debugstr_w(lpszPath)); - return NULL; + WCHAR path[MAX_PATH]; + + TRACE("%s\n", debugstr_w(pszPath)); + + if (GetShortPathNameW(pszPath, path, MAX_PATH)) + { + lstrcpyW(pszPath, path); + } } /************************************************************************* * PathGetShortPath [SHELL32.92] */ -LPVOID WINAPI PathGetShortPathAW(LPVOID lpszPath) +VOID WINAPI PathGetShortPathAW(LPVOID pszPath) { if(SHELL_OsIsUnicode()) - return PathGetShortPathW(lpszPath); - return PathGetShortPathA(lpszPath); + PathGetShortPathW(pszPath); + PathGetShortPathA(pszPath); } /*************************************************************************

Jan. 19, 2004

Re: Hi (virus alert)

by Robert van Herk

Joshua Walker wrote: >"W32.Beagle.A(a)mm" was found as an attachment. > >A few things amuse me about this... > >1) Coadweaves makes a great product, I just hope that >this wan't sent from a Linux box running crossover. > > Well, wouldn't that be an ultimate compatibility test :-). Just test whether all the virusses like wine/crossover as much as a nomal app will mean that even the security holes were implemented correctly :D.

Jan. 19, 2004

Re: Hi (virus alert)

by Joshua Walker

"W32.Beagle.A(a)mm" was found as an attachment. A few things amuse me about this... 1) Coadweaves makes a great product, I just hope that this wan't sent from a Linux box running crossover. 2) I think we all run linux here. We can pretty much say that this particular distrobution spoke is pretty much dead... 3) If Microsoft just removed the ability to run executables from Outlook, and made it so the user would have to "activate" it via a executable permission (Chmod 755 wsmktvxhew.exe) 99% of these things won't even propgate. --- jsheets(a)codeweavers.com wrote: > Test =) > jxbvitmuqfjiwe > -- > Test, yep. > > ATTACHMENT part 2 application/x-msdownload name=wsmktvxhew.exe

Jan. 19, 2004

/dlls/gdi/freetype.c breakage

by Gerald Pfeifer

The following patch to dlls/gdi/freetype.c revision 1.52 date: 2004/01/18 23:35:13; author: julliard; state: Exp; lines: +3 -4 Use the exported FONTENUMPROCW as parameter in the EnumDeviceFonts driver function instead of defining a private function type. breaks compilation freetype.c:2521: error: syntax error before "DEVICEFONTENUMPROC" freetype.c: In function `WineEngEnumFonts': freetype.c:2522: error: number of arguments doesn't match prototype gdi_private.h:220: error: prototype declaration on a system with FreeType 2.1.4 and XFree86 4.3.0. The problem seems that DEVICEFONTENUMPROC is not defined, though on some of my other test boxes with slightly different versions of FreeType, I did not see this problem. http://www.rtp.freebsd.org/~gerald/config.h contains the config.h file from autoconf. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

Jan. 19, 2004

Re: shlwapi: Implement PathFileExistsAndAttributesA/W

by Dmitry Timoshkov

"Rolf Kalbermatter" <rolf.kalbermatter(a)citeng.com> wrote: > + iPrevErrMode = SetErrorMode(1); Please use a symbolic name (SEM_FAILCRITICALERRORS in this case), not just an arbitrary constant. Same for both A and W APIs. -- Dmitry.

Jan. 19, 2004

Re: DPA_Create/Search may be missing

by Rolf Kalbermatter

Francois Gouget <fgouget(a)free.fr> wrote: > >On Sun, 18 Jan 2004, Alexandre Julliard wrote: > > Francois Gouget <fgouget(a)free.fr> writes: > > > Or is there a way to keep the static ordinal import and still have > > something that compiles with MSVC? > > Yes, you just need an MSVC version that has a correct import lib (or > copy the import lib from somewhere). >The link fails with both the Visual C++ 6 import library, and the one >from the very latest Microsoft SDK (downloaded this week). So I'm not >sure such a 'correct' import lib exists. > >But I must be missing something: if the function is exported by ordinal >only, how is the linker supposed to know that 328 is DPA_Create? The import lib does export fully named symbols for ordinal DLL exports with the exception of those few functions which according to my under- standing are not there or just a crazy thought: maybe there is a COMCTL_328 function in there?? Nope it doesn't seem to! I can however see a _DPA_Search symbol in the import lib from Platform SDK Feb 2003. No _DPA_Create and _DPA_GetPtr though. Wine does the same for the import libs created from the spec files, or doesn't it? Rolf Kalbermatter

Jan. 19, 2004

Re: DPA_Create/Search may be missing

by Rolf Kalbermatter

Alexandre Julliard <julliard(a)winehq.org> wrote: >Francois Gouget <fgouget(a)free.fr> writes: > >> Or is there a way to keep the static ordinal import and still have >> something that compiles with MSVC? > >Yes, you just need an MSVC version that has a correct import lib (or >copy the import lib from somewhere). Does that exist???? Of course one could create one (no, not the entire comctl32.lib but just an extension import lib) but how to distribute it in a way that anyone trying to compile the test suite with MSVC has it? Rolf Kalbermatter

Jan. 19, 2004

Re: DPA_Create/Search may be missing

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > I checked in more details and with the import library that comes from > the latest Microsoft SDK, it's only DPA_Create which is missing. > DPA_Search is there and links fine. Yes, it seems DPA_Create has been removed; it's there in the import lib of MSVC 5 but not in the latest one. This looks like an MS bug since it's declared in the header file. > So we could compromise: use GetProcAddress() on DPA_Create and link > normally to DPA_Search. This way the test compiles with MSVC and we > still get to test the ordinal imports. Yes that's a good solution. -- Alexandre Julliard julliard(a)winehq.com

Jan. 19, 2004

Hi

by jsheets＠codeweavers.com

Test =) jxbvitmuqfjiwe -- Test, yep.

Jan. 19, 2004

cvs broken?

by Tom

If I try to download a file from cvs I get this error. Error Error: Unexpected output from cvs co: cvs [checkout aborted]: Absolute module reference invalid: `/wine/dlls/msdmo/msdmo_main.c' Check, whether there exists a directory /home/wine/CVSROOT and the script has write-Access to the CVSROOT/history if it exists. It needs to place lock-files in the directory the file is in as well. Jer ? Tom

Jan. 19, 2004

cvs documentation not in sync with website?

by Chris Morgan

I noticed this snippet from the online docs in the documentation section: http://winehq.com/site/docs/wine-devel/wine-docbook Run ./configure (or make distclean && ./configure) Switch to the documentation/ directory run ./make_winehq <----------- This line has changed View wine-doc/index.html in your favorite browser make_winehq has apparently been obsoleted, replaced by 'make html'. I was wondering why the web documentation wasn't in sync with the html docs. Shouldn't we be pulling the web documentation pages directly from the cvs pages at some scheduled interval? Thanks, Chris

Jan. 19, 2004

Re: Fixed some problems found while compiling and linking Wine under Cygwin

by Dmitry Timoshkov

"BiGgUn" <fbiggun(a)hotmail.com> wrote: > Did you succeed in running Wine under Cygwin ? Cygwin misses a lot of required functionality to run Wine: passing file descriptors via sendmsg(), thread context management to mention some of them. -- Dmitry.

Jan. 19, 2004

Re: INSENG, IActiveSetup and ICifFile interfaces ...

by Mike McCormack

Well, I don't think we need to implement it, unless we find some other program that uses it but doesn't install IE first. I started writing this because IE didn't seem to install INSENG.DLL when using Version=win2k, but later found that it was a wierd dll override problem. Rather than just throw away the work from that misadventure, I decided to post it here incase somebody did need it or was curious :) Mike Mike Hearn wrote: > If IE ships it, and uses it internally, why do we need to reimplement it? > > thanks -mike >

Jan. 19, 2004

Re: Translation assessment tool (part 1)

by Vincent Béron

Le dim 18/01/2004 à 18:30, Alexandre Julliard a écrit : > Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > > > Here we go again after a couple of months... > > > > Changelog: > > Adds a new dump flag to wrc, to be used to assess translations > > advancement. > > OK, I put that one in with a few changes, but it would be really nice > if it could be print something understandable, instead of just random > characters that require an external parser to interpret. It wouldn't > be much harder for the parser to check for specific strings instead of > '+' or '-', and it would make that mode useful by itself, for instance > to check translations of a single file. Ok, I'll make it emit something more meaningful by itself. Just give me a couple of days. Probably something along the lines of only outputting the meaningful data, and not the rest. > Also, this thing should be > driven by make instead of having a shell script parse the makefiles by > hand. Right. I just wanted to have a working something before mixing it with make. Still unsure how to get a single file for all dlls at the end (as was asked by a couple people back in October) with a recursive make run. Maybe with two commands, one to start it (will cleanup any leftovers from a previous run) and another one for the recursive part... Or if it's possible to know how deep the makefile is located (during recursivity), do something special when coming back to level==1... (Just thinking out loud) Vincent

Jan. 19, 2004

Re: DPA_Create/Search may be missing

by Francois Gouget

On Mon, 19 Jan 2004, Francois Gouget wrote: [...] > The link fails with both the Visual C++ 6 import library, and the one > from the very latest Microsoft SDK (downloaded this week). So I'm not > sure such a 'correct' import lib exists. I checked in more details and with the import library that comes from the latest Microsoft SDK, it's only DPA_Create which is missing. DPA_Search is there and links fine. So we could compromise: use GetProcAddress() on DPA_Create and link normally to DPA_Search. This way the test compiles with MSVC and we still get to test the ordinal imports. I'll submit a patch (tomorrow morning). -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

Jan. 19, 2004