January 2004 - Wine-Devel - list.winehq.org

Re: DPA_Create/Search may be missing

by Francois Gouget

On Sun, 18 Jan 2004, Alexandre Julliard wrote: > Francois Gouget <fgouget(a)free.fr> writes: > > > Or is there a way to keep the static ordinal import and still have > > something that compiles with MSVC? > > Yes, you just need an MSVC version that has a correct import lib (or > copy the import lib from somewhere). The link fails with both the Visual C++ 6 import library, and the one from the very latest Microsoft SDK (downloaded this week). So I'm not sure such a 'correct' import lib exists. But I must be missing something: if the function is exported by ordinal only, how is the linker supposed to know that 328 is DPA_Create? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

Jan. 19, 2004

ntdll

by MediaHost (TM)

Hi, Just a small question: The error: err:ntdll:RtlpWaitForCriticalSection section 0x40dd36a0 "x11drv_main.c: X11DRV_CritSection" wait timed out in thread 0032, blocked by 0039, retrying (60 sec) seams to happen often....Is there anything I can do about it? Also: fixme:system:SystemParametersInfoA Unknown action: 8198 Is disturbing many Micro$oft Apps. Again, what to do? Implement? Regards Signer: Eddy Nigg Company: StartCom Group at http://www.startcom.org MediaHostT at http://www.mediahost.org

Jan. 19, 2004

Re: Translation assessment tool (part 1)

by Alexandre Julliard

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Here we go again after a couple of months... > > Changelog: > Adds a new dump flag to wrc, to be used to assess translations > advancement. OK, I put that one in with a few changes, but it would be really nice if it could be print something understandable, instead of just random characters that require an external parser to interpret. It wouldn't be much harder for the parser to check for specific strings instead of '+' or '-', and it would make that mode useful by itself, for instance to check translations of a single file. Also, this thing should be driven by make instead of having a shell script parse the makefiles by hand. -- Alexandre Julliard julliard(a)winehq.com

Jan. 18, 2004

Re: DPA_Create/Search may be missing

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > Or is there a way to keep the static ordinal import and still have > something that compiles with MSVC? Yes, you just need an MSVC version that has a correct import lib (or copy the import lib from somewhere). > What about MinGW? It sounds like this test does not compile there > either... That's a MinGW bug, you can work around it by using the Wine-generated import libs. -- Alexandre Julliard julliard(a)winehq.com

Jan. 18, 2004

Re: DPA_Create/Search may be missing

by Francois Gouget

On Sun, 18 Jan 2004, Alexandre Julliard wrote: [...] > I think we should leave it as it is. These are about the only > functions exported by ordinal that are available in basically all > Windows versions, and that are even documented on MSDN, so this is > a very good opportunity to test ordinal imports. Can't we find another way to test ordinal imports in Winelib? Because without this patch the comtcl32 tests don't compile with the Windows SDK. As far as I am concerned that means there is no way to generate a Windows executable for the comctl32 tests and thus it is impossible to make sure they are correct. Not just the dpa tests but also the tab tests and certainly more in the future. Or is there a way to keep the static ordinal import and still have something that compiles with MSVC? What about MinGW? It sounds like this test does not compile there either... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Any sufficiently advanced Operating System is indistinguishable from Linux

Jan. 18, 2004

Re: INSENG, IActiveSetup and ICifFile interfaces ...

by Mike Hearn

On Sun, 18 Jan 2004 17:50:24 +0900, Mike McCormack wrote: > This is a stub implemenation of the undocumented IActiveSetup from > Internet Explorer's INSENG.DLL. I'm not sure that any other software > except for Internet Explorer uses INSENG, however incase anybody is ever > interested in it, I'm posting it here. If IE ships it, and uses it internally, why do we need to reimplement it? thanks -mike

Jan. 18, 2004

Re: readme update

by Marcelo Duarte

Ivan, Dimi had much work in officializing the domain winehq.org and you modified text placing .com again. ----- Original Message ----- From: "Ivan Leo Murray-Smith" <puoti(a)inwind.it> To: "wine-patches" <wine-patches(a)winehq.com> Sent: Sunday, January 18, 2004 5:44 PM Subject: readme update This patch improves the italian version fo the README file, and uniforms it layout to the one of the English README. It also updates the links to the faq, the forums and the cvs to the urls currently used at winehq in all versions of README. Alexandre, I think it would be a good idea to move these files to the root source directory, so that non-English speakers can spot them immediately. It may also be a good idea to rename them something more obvious, for example from README.it to LEGGIMI.italiano (README.italian), shall I send in a patch that does this? License: LGPL Ivan.

Jan. 18, 2004

Re: DPA_Create/Search may be missing

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > But Hans Leidekker and Rolf Kalbermatter were right: the functions are > there, it's only that they are exported by ordinal only and/or are > missing from the MSVC import libraries. In any case, modifying the test > to load them by ordinal using GetProcAddress makes the test work on NT4 > and even on Windows 95 (with comctl32 version 4.00.950). > > So I'm sending an updated patch. I think we should leave it as it is. These are about the only functions exported by ordinal that are available in basically all Windows versions, and that are even documented on MSDN, so this is a very good opportunity to test ordinal imports. -- Alexandre Julliard julliard(a)winehq.com

Jan. 18, 2004

Re: readme update

by Andreas Mohr

Hi, On Sun, Jan 18, 2004 at 08:44:19PM +0100, Ivan Leo Murray-Smith wrote: > This patch improves the italian version fo the README file, and uniforms it > layout to the one of the English README. It also updates the links to the faq, > the forums and the cvs to the urls currently used at winehq in all versions of > README. Alexandre, I think it would be a good idea to move these files to the root > source directory, so that non-English speakers can spot them immediately. It may > also be a good idea to rename them something more obvious, for example from > README.it to LEGGIMI.italiano (README.italian), shall I send in a patch that > does this? And then we do the same for French, Russian, German, Spanish, Chinese, Polish, Bavarian ;-), Portuguese, Norvegian, Danish, Raeto Romanian, Kiswahili? Don't think so ;-) I'd say as the very first part in the README file, we write something like *********************************************************** Foreign languages (language, langue, Sprache, lingua, ...): ---> open documentation/README.<country_domain> *********************************************************** Sounds better than polluting the Wine root directory with many different localized versions. (also, if people still haven't learned to look at a file called "README" first, then they're not supposed to use Wine anyway) I still think that someone should put a system in place to make sure that all localized content gets kept current properly. (otherwise we might just end up deleting more modern versions of installation-und-konfiguration.german again and again...) That file once was a beautiful piece of documentation... and then it died... horribly even. ;-) Anyway, thanks for your docu maintenance! Andreas Mohr

Jan. 18, 2004

Re: I'm off to Cuba!

by Shachar Shemesh

Brian Vincent wrote: >>I hope it's going to be sweet, but I'll be off the web >>until next Sunday. Until then, hasta la vista amigos! :) >> >> > >Excelente! > >Just in time to bring us souvenirs at Wineconf. > >-brian > > > I think you are forgetting we are getting quite a few people travelling from abroad anyways. I can bring a couple of Israeli wine bottles - I think we cannot have a wine conference without wine. If Francois is coming, bring something too. Shachar -- Shachar Shemesh Lingnu Open Systems Consulting http://www.lingnu.com/

Jan. 18, 2004

Re: DPA_Create/Search may be missing

by Francois Gouget

On Fri, 16 Jan 2004, Alexandre Julliard wrote: > Francois Gouget <fgouget(a)free.fr> writes: > > > On NT4 (or is that on Internet Explorer <=5?), comctl32 is missing entry > > points for DPA_Create and DPA_Search. So we need to link them > > dynamically if we want the rest of the tests to run. > > What version of comctl32 is that? That was version 5.00.2919.6304. But Hans Leidekker and Rolf Kalbermatter were right: the functions are there, it's only that they are exported by ordinal only and/or are missing from the MSVC import libraries. In any case, modifying the test to load them by ordinal using GetProcAddress makes the test work on NT4 and even on Windows 95 (with comctl32 version 4.00.950). So I'm sending an updated patch. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

Jan. 18, 2004

Re: Regression tests and Paul Millars WRT

by Paul Millar

On Sat, 17 Jan 2004, Mike Hearn wrote: > On Sat, 17 Jan 2004 18:40:01 +0000, Paul Millar wrote: > >> 3) Is the source to WRT available anywhere? [...] > > http://www.astro.gla.ac.uk/users/paulm/Code/wrt-0.1.tar.gz > Cool, thanks! :) No problem. Of course, any feedback/bug-fixes would be appreciated :) BTW, I should have pointed out that wrt-0.1 isn't what the live version is using. I'm still testing v0.1 before switching over. > Good to know you're tracking these things anyway, though I don't recall > seeing you forward a build failure in a year of me hacking on Wine so I > guess failed tests don't get through these days.... >From April through to October last year it wasn't working: http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php?start=400 Some server juggling broke the (even more hacky) way the old code worked. At the same time, things at work got a bit hairy, taking up nearly all my time. Eventually got it up again... ---- Paul Millar

Jan. 18, 2004

Re: Fixed some problems found while compiling and linking Wine under Cygwin

by BiGgUn

Hi Did you succeed in running Wine under Cygwin ? Stéphan

Jan. 18, 2004

Re: wine cvs notes and proposed keyboard detection fix.

by Dmitry Timoshkov

"Sylvain Petreolle" <spetreolle(a)yahoo.fr> wrote: > Forwarded fom wine-users. > The keyboard detection when starting wine does not detect my turkish keyboard > and choses a scandinavion keyboard instead. I had a look at the keyboard.c > and there is a turkish keyboard defined. I found in the > X11DRV_KEYBOARD_DetectLayout function that the keysym detection loop exited > at the first wrong match which resulted in an incorrect match for the > keyboard. Attached is a patch that appears (for me) to solve this problem. > This problem has been evident since before cvs 2003-12-13. Wine still states > that it is unable to find the correct keyboard but it at least loads and uses > the correct definition although some keys don't work correctly. The patch is wrong, since it cures just a symptom not the problem itself. There are two problems with current x11drv keyboard code: 1. Very likely that Turkish keyboard layout there is incorrect. 2. As stated before the keyboard code should be fixed to take into account the real keyboard layout while building the keyc2vkey map, not the hardcoded one. Regarging Office 97 and Quicken problems: it's better to start with simple +relay trace and search for MessageBox and the first occurence of the wrongly formatted date respectively. Or just find a patch which caused a regression for Office97. -- Dmitry.

Jan. 18, 2004

Re: bin2res - Make adding resources work on Windows.

by Dmitry Timoshkov

"Martin Fuchs" <martin-fuchs(a)gmx.net> wrote: > The error does not occure when build with cygwin. > It's displayed only when build with MinGW: > > Processing failed: File exists Thanks. Now I see the cause of that: 'rename' will fail if the target already exists. -- Dmitry.

Jan. 18, 2004

Re: Need help debugging ... Ddraw issue

by Jason Edmeades

Andreas Rosenberg: >If somebody could provide me the problematic exe of DK and the address >where the crash occurs I will put it through IDA pro. This might help lifting the >mystery. If IDA pro detects which compiler suite has been used to link the EXE, >it should be "easy" to detect where the string came from http://ftp.sunet.se/pub/pc/games/pcgameworld/demos/dkdemo.zip Unzip it, run KDDATA -d, and keeper95 is the executable From my notes (I dont have Linux to hand just now): Trap occurs ar 0x43d4e2 At this point in time the path/exe is in 0x552150 On windows: This was copied from 0x12fe20 (Was already filled in at a breakpoint at 0x43d4ba) which in turn came from 0x141ee0 when the pgm is very first loaded (windbg or msdev prior to executing any code). Jason

Jan. 18, 2004

Re: bin2res - Make adding resources work on Windows.

by Martin Fuchs

On 18.01.2004 11:52:06 Dmitry Timoshkov wrote: > "Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > > > I dont know if anyone else has tried this but when I try to add > > resources to a *.rc I get a error. This patch fixes it. > > What kind of error do you get? I just tried to change an .rc > and to rebuild resources of commdlg under cygwin and I don't > see any problem with it. The error does not occure when build with cygwin. It's displayed only when build with MinGW: Processing failed: File exists Regards, Martin

Jan. 18, 2004

Re: bin2res - Make adding resources work on Windows.

by Dmitry Timoshkov

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > I dont know if anyone else has tried this but when I try to add > resources to a *.rc I get a error. This patch fixes it. What kind of error do you get? I just tried to change an .rc and to rebuild resources of commdlg under cygwin and I don't see any problem with it. -- Dmitry.

Jan. 18, 2004

Re: ntdll / kernel32 #39-2

by Eric Pouech

Dmitry Timoshkov a e'crit : > "Eric Pouech" <pouech-eric(a)wanadoo.fr> wrote: > > >>+DWORD WINAPI GetFullPathNameW( LPCWSTR name, DWORD len, LPWSTR buffer, >>+ LPWSTR *lastpart ) >>+{ >>+ LPWSTR dst = HeapAlloc(GetProcessHeap(), 0, len * sizeof(buffer)); >>+ DWORD ret; >>+ >>+ if (!dst) return 0; >>+ ret = RtlGetFullPathName_U(name, len * sizeof(WCHAR), dst, lastpart) / sizeof(WCHAR); > > > I don't quite understand the above bit of code: > > 1. HeapAlloc(GetProcessHeap(), 0, len * sizeof(buffer)) when buffer is > a pointer good catch > 2. Why you don't pass buffer directly to RtlGetFullPathName_U without > allocating an intermediate storage. because RtlGetFullPathName_U is buggy when name = buffer (it would be better anyway to fix RtlGetFullPathName_U to support that case). A+

Jan. 18, 2004

Re: ntdll / kernel32 #39-2

by Dmitry Timoshkov

"Eric Pouech" <pouech-eric(a)wanadoo.fr> wrote: > +DWORD WINAPI GetFullPathNameW( LPCWSTR name, DWORD len, LPWSTR buffer, > + LPWSTR *lastpart ) > +{ > + LPWSTR dst = HeapAlloc(GetProcessHeap(), 0, len * sizeof(buffer)); > + DWORD ret; > + > + if (!dst) return 0; > + ret = RtlGetFullPathName_U(name, len * sizeof(WCHAR), dst, lastpart) / sizeof(WCHAR); I don't quite understand the above bit of code: 1. HeapAlloc(GetProcessHeap(), 0, len * sizeof(buffer)) when buffer is a pointer 2. Why you don't pass buffer directly to RtlGetFullPathName_U without allocating an intermediate storage. -- Dmitry.

Jan. 18, 2004

INSENG, IActiveSetup and ICifFile interfaces ...

by Mike McCormack

Hi All, This is a stub implemenation of the undocumented IActiveSetup from Internet Explorer's INSENG.DLL. I'm not sure that any other software except for Internet Explorer uses INSENG, however incase anybody is ever interested in it, I'm posting it here. To build this dll in wine place the following 3 files in dlls/inseng, remove the #MKDLL_SKIP line from Makefile.in, add dlls/inseng/Makefile to configure.ac and run make_dlls. Hopefully this will be of use to somebody someday... Mike #MKDLL_SKIP TOPSRCDIR = @top_srcdir@ TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = inseng.dll IMPORTS = user32 advapi32 kernel32 ntdll EXTRALIBS = $(LIBUNICODE) $(LIBUUID) EXTRADEFS = -DCOM_NO_WINDOWS_H C_SRCS = \ inseng.c @MAKE_DLL_RULES@ ### Dependencies: /* * INSENG Implementation * * Copyright 2002 Lionel Ulmer * Copyright 2003 Mike McCormack * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "config.h" #include <stdarg.h> #include "windef.h" #include "winbase.h" #include "winuser.h" #include "ole2.h" #include "uuids.h" #include "wine/debug.h" #include "initguid.h" DEFINE_GUID(CLSID_DLManager, 0xBFC880F1,0x7484,0x11D0,0x83,0x09,0x00,0xAA,0x00,0xB6,0x01,0x5C); DEFINE_GUID(CLSID_ActiveSetupEng, 0x6e449686,0xc509,0x11cf,0xaa,0xfa,0x00,0xaa,0x00,0xb6,0x01,0x5c ); DEFINE_GUID(IID_IActiveSetupUnknown, 0x6e449689,0xc509,0x11cf,0xaa,0xfa,0x00,0xaa,0x00,0xb6,0x01,0x5c ); WINE_DEFAULT_DEBUG_CHANNEL(inseng); static HRESULT create_activesetup(IUnknown *pUnkOuter, LPVOID *ppObj); /* For the moment, do nothing here. */ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { switch(fdwReason) { case DLL_PROCESS_ATTACH: DisableThreadLibraryCalls(hInstDLL); break; case DLL_PROCESS_DETACH: break; } return TRUE; } /****************************************************************************** * INSENG ClassFactory */ typedef struct { IClassFactory ITF_IClassFactory; DWORD ref; HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); } IClassFactoryImpl; struct object_creation_info { const CLSID *clsid; LPCSTR szClassName; HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); }; static const struct object_creation_info object_creation[] = { { &CLSID_DLManager, "Active Download Manager", NULL }, { &CLSID_ActiveSetupEng, "Active Setup Engine", create_activesetup }, }; static HRESULT WINAPI INSENGCF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) { ICOM_THIS(IClassFactoryImpl,iface); if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IClassFactory)) { IClassFactory_AddRef(iface); *ppobj = This; return S_OK; } WARN("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppobj); return E_NOINTERFACE; } static ULONG WINAPI INSENGCF_AddRef(LPCLASSFACTORY iface) { ICOM_THIS(IClassFactoryImpl,iface); return ++(This->ref); } static ULONG WINAPI INSENGCF_Release(LPCLASSFACTORY iface) { ICOM_THIS(IClassFactoryImpl,iface); ULONG ref = --This->ref; TRACE("%p\n",This); if (ref == 0) HeapFree(GetProcessHeap(), 0, This); return ref; } static HRESULT WINAPI INSENGCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, REFIID riid, LPVOID *ppobj) { ICOM_THIS(IClassFactoryImpl,iface); HRESULT hres; LPUNKNOWN punk; TRACE("(%p)->(%p,%s,%p)\n",This,pOuter,debugstr_guid(riid),ppobj); hres = This->pfnCreateInstance(pOuter, (LPVOID *) &punk); if (FAILED(hres)) { *ppobj = NULL; return hres; } hres = IUnknown_QueryInterface(punk, riid, ppobj); if (FAILED(hres)) { *ppobj = NULL; return hres; } IUnknown_Release(punk); return hres; } static HRESULT WINAPI INSENGCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { ICOM_THIS(IClassFactoryImpl,iface); FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } static ICOM_VTABLE(IClassFactory) INSENGCF_Vtbl = { ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE INSENGCF_QueryInterface, INSENGCF_AddRef, INSENGCF_Release, INSENGCF_CreateInstance, INSENGCF_LockServer }; HRESULT WINAPI INSENG_DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv) { int i; IClassFactoryImpl *factory; TRACE("%s %s %p\n",debugstr_guid(rclsid), debugstr_guid(iid), ppv); if ( !IsEqualGUID( &IID_IClassFactory, iid ) && ! IsEqualGUID( &IID_IUnknown, iid) ) return E_NOINTERFACE; for (i=0; i < sizeof(object_creation)/sizeof(object_creation[0]); i++) { if (IsEqualGUID(object_creation[i].clsid, rclsid)) break; } if (i == sizeof(object_creation)/sizeof(object_creation[0])) { FIXME("%s: no class found.\n", debugstr_guid(rclsid)); return CLASS_E_CLASSNOTAVAILABLE; } TRACE("Creating a class factory for %s\n",object_creation[i].szClassName); if( !object_creation[i].pfnCreateInstance) return CLASS_E_CLASSNOTAVAILABLE; factory = HeapAlloc(GetProcessHeap(), 0, sizeof(*factory)); if (factory == NULL) return E_OUTOFMEMORY; factory->ITF_IClassFactory.lpVtbl = &INSENGCF_Vtbl; factory->ref = 1; factory->pfnCreateInstance = object_creation[i].pfnCreateInstance; *ppv = &(factory->ITF_IClassFactory); TRACE("(%p) <- %p\n", ppv, &(factory->ITF_IClassFactory) ); return S_OK; } HRESULT WINAPI INSENG_DllCanUnloadNow(void) { FIXME("\n"); return S_FALSE; } STDAPI DllRegisterServer(void) { FIXME("\n"); return S_OK; } BOOL WINAPI CheckTrustEx( LPVOID a, LPVOID b, LPVOID c, LPVOID d, LPVOID e ) { FIXME("%p %p %p %p %p\n", a, b, c, d, e ); return TRUE; } /*************************************************************************/ typedef struct IENUMSetupModes IENUMSetupModes; typedef struct IENUMSetupModes_Vtbl IENUMSetupModes_Vtbl; struct IENUMSetupModes { const IENUMSetupModes_Vtbl* lpVtbl; }; struct IENUMSetupModes_Vtbl { ICOM_MSVTABLE_COMPAT_FIELDS /*** IUnknown methods ***/ HRESULT (STDMETHODCALLTYPE *QueryInterface)( IENUMSetupModes* This, REFIID riid, void** ppvObject); ULONG (STDMETHODCALLTYPE *AddRef)( IENUMSetupModes* This); ULONG (STDMETHODCALLTYPE *Release)( IENUMSetupModes* This); ULONG (STDMETHODCALLTYPE *Method1)( IENUMSetupModes* This, LPVOID *ptr); }; static HRESULT WINAPI IENUMSetupModes_QueryInterface(IENUMSetupModes * iface,REFIID riid,LPVOID *ppobj); static ULONG WINAPI IENUMSetupModes_AddRef(IENUMSetupModes * iface); static ULONG WINAPI IENUMSetupModes_Release(IENUMSetupModes * iface); static ULONG WINAPI IENUMSetupModes_Method1(IENUMSetupModes * iface, LPVOID *ptr); const struct IENUMSetupModes_Vtbl enummodes_vtbl = { ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE IENUMSetupModes_QueryInterface, IENUMSetupModes_AddRef, IENUMSetupModes_Release, IENUMSetupModes_Method1 }; typedef struct { IENUMSetupModes ITF_IENUMSetupModes; DWORD ref; } enummodes_impl; static HRESULT WINAPI IENUMSetupModes_QueryInterface(IENUMSetupModes * iface,REFIID riid,LPVOID *ppobj) { ICOM_THIS(enummodes_impl,iface); FIXME("%p %s %p\n", This, debugstr_guid(riid), ppobj); return E_NOINTERFACE; } static ULONG WINAPI IENUMSetupModes_AddRef(IENUMSetupModes * iface) { ICOM_THIS(enummodes_impl,iface); TRACE("%p\n",This); return ++(This->ref); } static ULONG WINAPI IENUMSetupModes_Release(IENUMSetupModes * iface) { ICOM_THIS(enummodes_impl,iface); ULONG ref = --This->ref; TRACE("%p\n",This); if (ref == 0) HeapFree(GetProcessHeap(), 0, This); return ref; } static ULONG WINAPI IENUMSetupModes_Method1(IENUMSetupModes * iface, LPVOID *ptr) { ICOM_THIS(enummodes_impl,iface); FIXME("%p %p\n",This, ptr); return E_NOTIMPL; } static HRESULT create_enummodes( LPVOID *ppObj ) { enummodes_impl *em; em = HeapAlloc( GetProcessHeap(), 0, sizeof (enummodes_impl) ); if (em == NULL) return E_OUTOFMEMORY; em->ITF_IENUMSetupModes.lpVtbl = &enummodes_vtbl; em->ref = 1; *ppObj = em; TRACE("%p\n",em); return S_OK; } /*************************************************************************/ typedef struct ICifFile ICifFile; typedef struct ICifFile_Vtbl ICifFile_Vtbl; struct ICifFile { const ICifFile_Vtbl* lpVtbl; }; struct ICifFile_Vtbl { ICOM_MSVTABLE_COMPAT_FIELDS /*** IUnknown methods ***/ HRESULT (STDMETHODCALLTYPE *QueryInterface)( ICifFile* This, REFIID riid, void** ppvObject); ULONG (STDMETHODCALLTYPE *AddRef)( ICifFile* This); ULONG (STDMETHODCALLTYPE *Release)( ICifFile* This); ULONG (STDMETHODCALLTYPE *EnumComponents)( ICifFile* This, LPVOID *ppObj, LPVOID b, LPVOID c); ULONG (STDMETHODCALLTYPE *Method2)( ICifFile* This); ULONG (STDMETHODCALLTYPE *EnumGroups)( ICifFile* This, LPVOID *ppObj, LPVOID b, LPVOID c); ULONG (STDMETHODCALLTYPE *Method4)( ICifFile* This); ULONG (STDMETHODCALLTYPE *EnumModes)( ICifFile* This, LPVOID *ppObj, LPVOID b, LPVOID c); ULONG (STDMETHODCALLTYPE *Method6)( ICifFile* This); ULONG (STDMETHODCALLTYPE *Method7)( ICifFile* This); }; static HRESULT WINAPI ICifFile_QueryInterface(ICifFile * iface,REFIID riid,LPVOID *ppobj); static ULONG WINAPI ICifFile_AddRef(ICifFile * iface); static ULONG WINAPI ICifFile_Release(ICifFile * iface); static ULONG WINAPI ICifFile_EnumComponents(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c); static ULONG WINAPI ICifFile_Method2(ICifFile * iface); static ULONG WINAPI ICifFile_EnumGroups(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c); static ULONG WINAPI ICifFile_Method4(ICifFile * iface); static ULONG WINAPI ICifFile_EnumModes(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c); static ULONG WINAPI ICifFile_Method6(ICifFile * iface); static ULONG WINAPI ICifFile_Method7(ICifFile * iface); const struct ICifFile_Vtbl ciffile_vtbl = { ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE ICifFile_QueryInterface, ICifFile_AddRef, ICifFile_Release, ICifFile_EnumComponents, ICifFile_Method2, ICifFile_EnumGroups, ICifFile_Method4, ICifFile_EnumModes, ICifFile_Method6, ICifFile_Method7 }; typedef struct { ICifFile ITF_ICifFile; DWORD ref; } ciffile_impl; static HRESULT WINAPI ICifFile_QueryInterface(ICifFile * iface,REFIID riid,LPVOID *ppobj) { /* ICOM_THIS(ciffile_impl,iface); */ FIXME("%p %s %p\n", iface, debugstr_guid(riid), ppobj); /*jif( IsEqualGUID(riid, &IID_IActiveSetupUnknown) ) { activesetupimpl_AddRef(iface); *ppobj = This; ERR("OK\n"); return S_OK; }*/ return E_NOINTERFACE; } static ULONG WINAPI ICifFile_AddRef(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); TRACE("%p\n",This); return ++(This->ref); } static ULONG WINAPI ICifFile_Release(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); ULONG ref = --This->ref; TRACE("%p\n",This); if (ref == 0) HeapFree(GetProcessHeap(), 0, This); return ref; } static ULONG WINAPI ICifFile_EnumComponents(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c) { ICOM_THIS(ciffile_impl,iface); FIXME("%p %p %p %p\n", This, ppObj, b, c); return create_enummodes( ppObj ); } static ULONG WINAPI ICifFile_Method2(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); FIXME("%p\n", This); return E_FAIL; } static ULONG WINAPI ICifFile_EnumGroups(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c) { ICOM_THIS(ciffile_impl,iface); FIXME("%p %p %p %p\n", This, ppObj, b, c); return create_enummodes( ppObj ); //return E_FAIL; } static ULONG WINAPI ICifFile_Method4(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); FIXME("%p\n", This); return E_FAIL; } static ULONG WINAPI ICifFile_EnumModes(ICifFile * iface, LPVOID *ppObj, LPVOID b, LPVOID c) { ICOM_THIS(ciffile_impl,iface); FIXME("%p %p %p %p\n", This, ppObj, b, c); return create_enummodes( ppObj ); //return E_NOTIMPL; } static ULONG WINAPI ICifFile_Method6(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); FIXME("%p\n", This); return E_FAIL; } static ULONG WINAPI ICifFile_Method7(ICifFile * iface) { ICOM_THIS(ciffile_impl,iface); FIXME("%p\n", This); return E_FAIL; } static HRESULT create_ciffile( LPVOID *ppObj ) { ciffile_impl *cf; cf = HeapAlloc( GetProcessHeap(), 0, sizeof (ciffile_impl) ); if (cf == NULL) return E_OUTOFMEMORY; cf->ITF_ICifFile.lpVtbl = &ciffile_vtbl; cf->ref = 1; *ppObj = cf; TRACE("%p\n",cf); return S_OK; } /*************************************************************************/ typedef struct IActiveSetupUnknown IActiveSetupUnknown; typedef struct IActiveSetupUnknown_Vtbl IActiveSetupUnknown_Vtbl; struct IActiveSetupUnknown { const IActiveSetupUnknown_Vtbl* lpVtbl; }; struct IActiveSetupUnknown_Vtbl { ICOM_MSVTABLE_COMPAT_FIELDS /*** IUnknown methods ***/ HRESULT (STDMETHODCALLTYPE *QueryInterface)( IActiveSetupUnknown* This, REFIID riid, void** ppvObject); ULONG (STDMETHODCALLTYPE *AddRef)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Release)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method1)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *EnumModes)( IActiveSetupUnknown* This, LPVOID *ptr, DWORD b, DWORD c); ULONG (STDMETHODCALLTYPE *Method3)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method4)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method5)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method6)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method7)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method8)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method9)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method10)( IActiveSetupUnknown* This, DWORD a, DWORD b, DWORD c); ULONG (STDMETHODCALLTYPE *Method11)( IActiveSetupUnknown* This, DWORD a, LPVOID b); ULONG (STDMETHODCALLTYPE *Method12)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method13)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method14)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method15)( IActiveSetupUnknown* This, LPVOID a); ULONG (STDMETHODCALLTYPE *SetInstallDrive)( IActiveSetupUnknown* This, CHAR drive); ULONG (STDMETHODCALLTYPE *SetInstallOption)( IActiveSetupUnknown* This, DWORD a); ULONG (STDMETHODCALLTYPE *Method18)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method19)( IActiveSetupUnknown* This, IStream * stm); ULONG (STDMETHODCALLTYPE *Method20)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method21)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method22)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *SetLocalCif)( IActiveSetupUnknown* This, LPCSTR name ); ULONG (STDMETHODCALLTYPE *GetICifFile)( IActiveSetupUnknown* This, LPVOID *ptr ); ULONG (STDMETHODCALLTYPE *Method25)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method26)( IActiveSetupUnknown* This); ULONG (STDMETHODCALLTYPE *Method27)( IActiveSetupUnknown* This); }; static HRESULT WINAPI activesetupimpl_QueryInterface(IActiveSetupUnknown * iface,REFIID riid,LPVOID *ppobj); static ULONG WINAPI activesetupimpl_AddRef(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Release(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method1(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_EnumModes(IActiveSetupUnknown * iface, LPVOID *ptr, DWORD b, DWORD c); static ULONG WINAPI activesetupimpl_Method3(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method4(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method5(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method6(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method7(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method8(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method9(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method10(IActiveSetupUnknown * iface, DWORD a, DWORD b, DWORD c); static ULONG WINAPI activesetupimpl_Method11(IActiveSetupUnknown * iface, DWORD a, LPVOID b ); static ULONG WINAPI activesetupimpl_Method12(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method13(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method14(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method15(IActiveSetupUnknown * iface, LPVOID a); static ULONG WINAPI activesetupimpl_SetInstallDrive(IActiveSetupUnknown * iface, CHAR drive); static ULONG WINAPI activesetupimpl_SetInstallOption(IActiveSetupUnknown * iface, DWORD a); static ULONG WINAPI activesetupimpl_Method18(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method19(IActiveSetupUnknown * iface, IStream * stm ); static ULONG WINAPI activesetupimpl_Method20(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method21(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method22(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_SetLocalCif(IActiveSetupUnknown * iface, LPCSTR name ); static ULONG WINAPI activesetupimpl_GetICifFile(IActiveSetupUnknown * iface, LPVOID *ptr ); static ULONG WINAPI activesetupimpl_Method25(IActiveSetupUnknown * iface); static ULONG WINAPI activesetupimpl_Method26(IActiveSetupUnknown * iface); const struct IActiveSetupUnknown_Vtbl activesetupimpl_vtbl = { ICOM_MSVTABLE_COMPAT_DummyRTTIVALUE activesetupimpl_QueryInterface, activesetupimpl_AddRef, activesetupimpl_Release, activesetupimpl_Method1, activesetupimpl_EnumModes, activesetupimpl_Method3, activesetupimpl_Method4, activesetupimpl_Method5, activesetupimpl_Method6, activesetupimpl_Method7, activesetupimpl_Method8, activesetupimpl_Method9, activesetupimpl_Method10, activesetupimpl_Method11, activesetupimpl_Method12, activesetupimpl_Method13, activesetupimpl_Method14, activesetupimpl_Method15, activesetupimpl_SetInstallDrive, activesetupimpl_SetInstallOption, activesetupimpl_Method18, activesetupimpl_Method19, activesetupimpl_Method20, activesetupimpl_Method21, activesetupimpl_Method22, activesetupimpl_SetLocalCif, activesetupimpl_GetICifFile, activesetupimpl_Method25, activesetupimpl_Method26 }; typedef struct { IActiveSetupUnknown ITF_IActiveSetupUnknown; DWORD ref; } activesetup_impl; static HRESULT WINAPI activesetupimpl_QueryInterface(IActiveSetupUnknown *iface,REFIID riid,LPVOID *ppobj) { ICOM_THIS(activesetup_impl,iface); TRACE("%p %s %p\n", iface, debugstr_guid(riid), ppobj); if( IsEqualGUID(riid, &IID_IActiveSetupUnknown) ) { activesetupimpl_AddRef(iface); *ppobj = This; ERR("OK\n"); return S_OK; } return E_NOINTERFACE; } static ULONG WINAPI activesetupimpl_AddRef(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); TRACE("%p\n",This); return ++(This->ref); } static ULONG WINAPI activesetupimpl_Release(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); ULONG ref = --This->ref; TRACE("%p\n",This); if (ref == 0) HeapFree(GetProcessHeap(), 0, This); return ref; } static ULONG WINAPI activesetupimpl_Method1(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_EnumModes(IActiveSetupUnknown * iface, LPVOID *ppObj, DWORD dwPlatform, DWORD c) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %p %08lx %ld\n", This, ppObj, dwPlatform, c ); return E_FAIL; //return create_enummodes( ppObj ); } static ULONG WINAPI activesetupimpl_Method3(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method4(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method5(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method6(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method7(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method8(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method9(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method10(IActiveSetupUnknown * iface, DWORD a, DWORD b, DWORD c) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %ld %ld %ld\n", This, a, b, c ); return S_OK; } /* * the third parameter looks like a pointer to a structure * * struct { * DWORD dwSize; // size of this structure * DWORD a1; * DWORD a2; * DWORD a3; * DWORD x1; * DWORD b1; * DWORD b2; * DWORD b3; * DWORD b4; * DWORD x2; * } */ static ULONG WINAPI activesetupimpl_Method11(IActiveSetupUnknown * iface, DWORD a, LPVOID b ) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %lx %p\n", This, a, b ); return S_OK; } static ULONG WINAPI activesetupimpl_Method12(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method13(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method14(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method15(IActiveSetupUnknown * iface, LPVOID a) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %p\n", This, a ); return S_OK; //return E_FAIL; } static ULONG WINAPI activesetupimpl_SetInstallDrive(IActiveSetupUnknown * iface, CHAR drive) { ICOM_THIS(activesetup_impl,iface); FIXME("%p drive = %c\n", This, drive ); return E_FAIL; } static ULONG WINAPI activesetupimpl_SetInstallOption(IActiveSetupUnknown * iface, DWORD a) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %08lx\n", This, a ); return E_NOTIMPL; } static ULONG WINAPI activesetupimpl_Method18(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } /* set the stream to log errors to */ static ULONG WINAPI activesetupimpl_Method19(IActiveSetupUnknown * iface, IStream *stm) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %p\n", This, stm ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method20(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method21(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method22(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_SetLocalCif(IActiveSetupUnknown * iface, LPCSTR name) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %s\n", This, debugstr_a( name ) ); return S_OK; } static ULONG WINAPI activesetupimpl_GetICifFile(IActiveSetupUnknown * iface, LPVOID *ppObj ) { ICOM_THIS(activesetup_impl,iface); FIXME("%p %p\n", This, ppObj ); return create_ciffile( ppObj ); } static ULONG WINAPI activesetupimpl_Method25(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static ULONG WINAPI activesetupimpl_Method26(IActiveSetupUnknown * iface) { ICOM_THIS(activesetup_impl,iface); FIXME("%p\n", This ); return E_FAIL; } static HRESULT create_activesetup(IUnknown *pUnkOuter, LPVOID *ppObj) { activesetup_impl *as; as = HeapAlloc( GetProcessHeap(), 0, sizeof (activesetup_impl) ); if (as == NULL) return E_OUTOFMEMORY; as->ITF_IActiveSetupUnknown.lpVtbl = &activesetupimpl_vtbl; as->ref = 1; *ppObj = as; TRACE("%p\n",as); return S_OK; } @ stub DownloadFile @ stub PurgeDownloadDirectory @ stub CheckForVersionConflict @ stub CheckTrust @ stdcall CheckTrustEx(ptr ptr ptr ptr ptr) @ stub DllCanUnloadNow @ stdcall DllGetClassObject(ptr ptr ptr) INSENG_DllGetClassObject @ stub DllInstall @ stdcall DllRegisterServer() @ stub DllUnregisterServer @ stub GetICifFileFromFile @ stub GetICifRWFileFromFile

Jan. 18, 2004

Re: Alsa 1.0 patch for audio.c

by Sylvain Petreolle

--- "Brett I. Holcomb" <brettholcomb(a)charter.net> a écrit : > In November Sylvain Petreolle posted a patch to audio.c to make it work > with the new Alsa 1.0 version. What is the license on that patch? I > ask because I'd like to pass it on to the winex-devel list so they can > include it. Is it possible to send it on? If not that's fine - I want > to check first. > > Thanks. Its licensed as LGPL, but it hasnt been included in Wine for now. ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

Jan. 18, 2004

Re: Debugger doc pages

by Sylvain Petreolle

Looks ok here on my WinXP in both Mozilla 1.5/IE. --- Jason Edmeades <us(a)the-edmeades.demon.co.uk> a écrit : > Is it something about my machine but when I go to the online debugger > > docs, eg: http://www.winehq.com/site/docs/wine-devel/wine-debugger I can > see absolutely nothing in the text boxes. I can highlight the text and > it appears to be in a minute font, and cut+paste into an editor shows me > the text is there, its just too small to be visible. > > I tried with mozilla and IE (both from a Windows machine). > > Jason ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

Jan. 18, 2004

Re: Need help debugging ... Ddraw issue

by Sylvain Petreolle

Could you see if it runs ok when launched with winecfg ? --- Mike Hearn <mike(a)theoretic.com> a écrit : > Awwww crud. > > I wonder if when a program is invoked directly from the wine loader > app we > should pretend it's been run from Explorer and pass it the full path. > Alexandre, would that be an acceptable solution (subject to more > thorough > testing of course). > > thanks -mike ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

Jan. 18, 2004

DIB_DirectDrawSurface_BltFast signed/unsigned comparision bug

by Piotr Pawlow

Hello, I spotted this bug while trying to fix mouse pointer trails problem in Warlords Battlecry. All widths, heights and left/top coordinates are of DWORD type, so substracting them from each other always give positive numbers. Thus h and w are always >= 0, so DDERR_INVALIDRECT is returned only in a couple of boundary cases. I just added explicit casting to int where needed. It didn't fix the mouse trails, but previously missing mouseover effect on icons at the main screen appeared, so I guess it is a change in the right direction :) Patch attached.

Jan. 18, 2004