January 2004 - Wine-Devel - list.winehq.org

Re: x11drv

by Alex Pasadyn

Dimitrie O. Paun wrote: > On January 30, 2004 09:00 am, RemiAssailly(a)aol.com wrote: > >>I don't understand you ! >>Without that it does not work. >>With that, it works and graphic working is faster. > > > Maybe so, but it looks obviously incorrect. Not everything > that seems to fix problems is a real fix. You maybe hiding > a bigger issue. The fix as you sent it can't be right, but > you maybe on to something. Someone knowledgable in the area > should express a more informed opinion. > Here's the deal. ChangeDisplaySettings used to always return success, even though it actually did nothing. When I added support for resolution changing using XRandR, one of the changes was to actually fail if the requested mode did not exist. If XRandR or XVidMode is used, the requested mode must really exist, or you will get an error. In desktop mode, there is a hardcoded list of allowable modes that covers all the commonly used ones. The original post about this issue included an error message that included the string (NoRes) in it, which meant that XRandR, XVidMode, and desktop mode were all disabled. While I think the correct fix is for the user to enable desktop mode or real resolution changing, there is a different hack that can be used without causing crashes. Simply go into X11DRV_ChangeDisplaySettingsExW and replace both instances of DISP_CHANGE_BADMODE with DISP_CHANGE_SUCCESSFUL. Alex

Jan. 30, 2004

Re: Add a test case and a fix for the window styles state at the window creation time

by Bill Medland

On January 30, 2004 08:08 am, Dmitry Timoshkov wrote: > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Add a test case and a fix for the window styles state > at the window creation time. > SNIP > + cs->style |= WS_CAPTION; > + wndPtr->flags |= WIN_NEED_SIZE; > + } > + } > + > /* Fill the window structure */ > > wndPtr->tid = GetCurrentThreadId(); SNIP The problem with comments is that they don't get maintained. I suggest that this is one of those "x=x+1; /* increment x */" type comments and the comment should go too. (If it is not clear to anyone, the comment suggests that below the comment is where the structure gets filled in and the casual observer won't notice that one element was actually done before the comment). Bill -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

Jan. 30, 2004

RE: desktop mode again

by Robert Shearman

Alex Pasadyn wrote: > > Robert Shearman wrote: > > > I suggest you put the system metrics stuff in a separate patch. > It is a lot more tested and more likely to get in than the other > code, which is quite a big change. > > I can do that, if it would get applied. :) I sent an earlier version > of the sysmetrics patch by itself a long time ago, and it was not > applied because it could give incorrect results in desktop mode. This > version is cleaner that that one, and I think that by itself it would at > least give correct results for an application running in the one desktop > that changed its size. So, Alexandre? Is that worth sending? How about a quick hack doing the same as we do now if the user wants desktop mode, but use the new code otherwise? Then if a version of this patch gets applied you can remove that hack. > X doesn't allow inter-process operations right? > > Actually, I think X doesn't care. It has no problem with me having one > process create the desktop window and another process creating a > "normal" window inside it. Or did you mean something else? > > This is bad. There shouldn't be a direct server call in a > > normal wine program. We should try and find the right Windows API > > to do this, or create our own export from user32. Only user32, > > gdi32, ntdll and x11drv should need to use server calls (and > > kernel32 out of convenience). It has just occurred to me that CreateDesktop and SwitchDesktop are the functions to use, but that means writing a lot of extra code. > > Why do you need two windows procedures? If you're sure you do > need both of them, a comment in the code explaining why would be > good. It's not at all obvious to the casual observer (i.e. me) otherwise. > > That I can add. The basic thing is that the "main" window created by > winedesktop is just a normal ordinary window, and it can be minimized, > etc. The child window came in because an app should be able to ask for > the size of the desktop window and always get the right answer. I > thought it was better to create a child window than to have to put code > in the server to intercept calls to get the size of the desktop and > fudge the results if it was minimized. Ok, that sounds sensible. > > It appears you don't launch winedesktop anywhere and you don't > > remove any options from the config file. It will be a bit > > confusing for people who do use the wine desktop when it doesn't > > do anything after applying your patch (until they launch > > winedesktop). Do you plan to launch winedesktop at startup > > (possibly just after wineserver is launched) if the desktop > > setting is enabled? > This was described when I originally posted a version of this a long > time ago. The general idea is that if no other Wine apps are running, > you can start winedesktop. I still think it would be a good idea to launch it for them automatically. > While it's running, all Wine apps that get > started get trapped inside the desktop. I would like to find a way to > have multiple desktops or desktop coexisting with non-desktop, but that > would be a ton of additional bookkeeping in the server. We can adapt the multi-monitor APIs to do this. However, Windows doesn't support multiple independent desktops, but there are probably was around this. Rob

Jan. 30, 2004

Re: Wine totally broken on Fedora Core because of security patch in kernel

by Abdul-Haseeb Ahmad

Ivan Leo Murray-Smith wrote: > FC has some security patch in the kernel, so wine fails with this error: > > err:virtual:map_image Standard load address for a Win32 program (0x00400000) > not available - security-patched kernel ? > wine: could not load L"C:\\Program Files\\Common > Files\\InstallShield\\Engine\\6\\Intel 32\\IKernel.exe" as Win32 binary > > as reported by Marek Lipovcan and some users on the newsgroup, I don't have fc > myself, but I guess something should be done about this. > > Ivan. > > > > i made myself a script that runs LD_ASSUME_KERNEL=2.2.5 setarch i386 wine $* it should work if you run wine in a similar format to this in bash

Jan. 30, 2004

Re: [oleaut32] implement VarMod() + tests, fix bug in VarNot()

by Chris Morgan

On Friday 30 January 2004 04:50 am, Hans Leidekker wrote: > On Friday 30 January 2004 04:30, Chris Morgan wrote: > > Still have a couple of issues with this change. I'm not sure why the > > (BSTR) tests fail under wine and not windows, I've wrappered them with > > todo_wine{} but they still get listed as failures. > > Run it like so: > > WINETEST_PLATFORM="wine" wine oleaut32_crosstest.exe vartest > > and you won't get the failures. > > -Hans Ahh ok ;-) Chris

Jan. 30, 2004

Re: ListView painting (was Re: Mouse up vs Mouse click)

by Fabian Cenedese

>On January 30, 2004 07:55 am, Fabian Cenedese wrote: >> I think I already found the (apparent) difference in the events, the >> (not) hanging in the OnLButtonDown. I need to find out why it doesn't >> stay in there and if it's in listview, message, events... > >The mouse tracking in listview happens in the LISTVIEW_TrackMouse() >function, which seems correct. It is getting called from only one >place (in LISTVIEW_LButtonDown()) so a few print statements there >would be nice to see that (1) it is being called, and (2) that it >doesn't exit prematurely. I made a test and added a printf message in the loop of TrackMouse. When I hold the mouse button in the first column I see hundreds of these message pass by. But when I press on another column I don't even see it enter the whole function TrackMouse, not to mention the message from the loop. In LISTVIEW_LButtonDown the nItem is -1, so it thinks that no item is selected and skips most of the code. I'm still looking at logs. But I also thought that LISTVIEW_HitTest gave wrong results for other columns (LVHT_NOWHERE) but I still need to look further. But that might go along with the listview thinking that no item is selected. Thanks for your hints, give me new ideas. bye Fabi

Jan. 30, 2004

Re: x11drv

by Dimitrie O. Paun

On January 30, 2004 09:00 am, RemiAssailly(a)aol.com wrote: > I don't understand you ! > Without that it does not work. > With that, it works and graphic working is faster. Maybe so, but it looks obviously incorrect. Not everything that seems to fix problems is a real fix. You maybe hiding a bigger issue. The fix as you sent it can't be right, but you maybe on to something. Someone knowledgable in the area should express a more informed opinion. -- Dimi.

Jan. 30, 2004

Re: ListView painting (was Re: Mouse up vs Mouse click)

by Dimitrie O. Paun

On January 30, 2004 07:55 am, Fabian Cenedese wrote: > I think I already found the (apparent) difference in the events, the > (not) hanging in the OnLButtonDown. I need to find out why it doesn't > stay in there and if it's in listview, message, events... The mouse tracking in listview happens in the LISTVIEW_TrackMouse() function, which seems correct. It is getting called from only one place (in LISTVIEW_LButtonDown()) so a few print statements there would be nice to see that (1) it is being called, and (2) that it doesn't exit prematurely. In this case a PE build of the comctl32 would be priceless: you could just replace the native comctl32 DLL on a real Windows installation with our own implementation, and see if the problem persists. Is so, the error is in our comctl32 DLL. If not, it is in the lower layers (message, events, etc.). In fact, a PE build of the comctl32 would be so useful that I'm a bit surprised nobody attempted it thus far... We should offer a full PE build on SourceForge, together with the other downloads. Any takers? -- Dimi.

Jan. 30, 2004

Re: x11drv

by Dimitrie O. Paun

On January 30, 2004 08:47 am, RemiAssailly(a)aol.com wrote: Please, no HTML mail if possible. > - if (devmode) > + if (devmode==NULL) > { > TRACE("DM_fields=%s\n",_DM_fields(devmode->dmFields)); This can't possibly be right. In effect you're disabling that if completely (unless devmode is NULL, in which case you'll get a segfault on the next line). -- Dimi.

Jan. 30, 2004

alsa and audioio testing needed for dsound patch

by Robert Reif

This patch insures that the hardware primary buffer is deleted and recreated properly when changing the primary format. It also makes sure the proper frequency adjust is calculated for the actual format used rather than the requested one. This should only affect oss, alsa, and audioio and I have tested oss already. Please test it with the dsound tests in the interactive mode so sounds are actually played. Make sure "HardwareAcceleration" in the config file is not set to 'Emulation" so the dsound HAL driver is used. Thanks, Bob.

Jan. 30, 2004