October 2004 - Wine-Devel - list.winehq.org

Re: GetTimeZoneInformation return value fix

by Alexandre Julliard

Rein Klazes <rklazes(a)xs4all.nl> writes: > - reordered some code from the existing helper _GetTimeZoneBias > to make it more general useful (and changed the helper names to > TIME_xyz). > - Make GetTimeZoneInformation return the correct zone id > constants. > - changed some "const LPX_Y_Z" declarations to "const X_Y_Z *" This breaks the msvcrt tests: ../../../tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so time.c && touch time.ok time.c:101: Test failed: Wrong date:Year 70 mon 0 yday 1 mday 2 wday 5 hour 0 min 0 sec 0 dst -1 time.c:112: Test failed: Wrong date:Year 70 mon 0 yday 1 mday 2 wday 5 hour 0 min 0 sec 0 dst -1 -- Alexandre Julliard julliard(a)winehq.org

Oct. 26, 2004

RE: [dx9-12] Major change to design

by Ann and Jason Edmeades

>Looks much better yes, thanks. Thanks! >There's still something strange here: >> + /* Not recording... */ >> + if (oldSrc != NULL) { >> + IWineD3DVertexBuffer_Release(oldSrc); >> + IUnknown_Release((IUnknown *)((IWineD3DVertexBufferImpl *)oldSrc)->resource.parent); /* Released an internal reference to a VB */ >> + } >> + if (pStreamData != NULL) { >> + IWineD3DVertexBuffer_AddRef(pStreamData); >> + IUnknown_AddRef((IUnknown *)((IWineD3DVertexBufferImpl *)pStreamData)->resource.parent); /* Gained an internal reference to a VB */ >> + } >You shouldn't need to AddRef the parent, that's up to the object that >holds the pointer (also you should do the AddRef before the Release in >case old and new are the same object). Well, that's where I come unstuck :-) The problem is that in the caller, I could do the addref, but I cant do the release because the caller doesn't know nor have access to (nor should know / have access to!) the vb which it is replacing. It made more 'sense' to do both in the same place because it is then 'obvious' when one is wrong. In this case (very pseudo code!) D3D9 SetStreamSource (idx, d3d9_vb): Call WineD3D SetStreamSource(idx, d3d9_vb->wined3d_vb) WineD3D SetStreamSource: In an array store the new vb and addref, and release the old one. If I just addref/release the wined3d interface, I am not maintaining correct reference counting for the d3d9 object (Think: Create, SetStreamSource, Release. We would release the d3d9 one when we shouldn't). The alternative is to pass back the thing I have freed, which is both very unintuitive and also may cause problems later on when the same function needs calling from within wined3d. It also means the caller needs to know more of the internals whereas I have tried to keep the d3d9 code as trivial as possible. Suggestions welcome - I spent ages trying to get my head around how to keep the dual reference counting correct, and that's the only model I cam up with which worked! Jason

Oct. 26, 2004

Re: [dx9-12] Major change to desgin

by Alexandre Julliard

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > I think this patch should keep you happy (It doesn't do any of the > IWineUserDevice stuff as the code isn't ready for it, but does the dual ref > count + adds Set/Get Stream source). Let me know if you have problems with > it. Looks much better yes, thanks. There's still something strange here: > + /* Not recording... */ > + if (oldSrc != NULL) { > + IWineD3DVertexBuffer_Release(oldSrc); > + IUnknown_Release((IUnknown *)((IWineD3DVertexBufferImpl *)oldSrc)->resource.parent); /* Released an internal reference to a VB */ > + } > + if (pStreamData != NULL) { > + IWineD3DVertexBuffer_AddRef(pStreamData); > + IUnknown_AddRef((IUnknown *)((IWineD3DVertexBufferImpl *)pStreamData)->resource.parent); /* Gained an internal reference to a VB */ > + } You shouldn't need to AddRef the parent, that's up to the object that holds the pointer (also you should do the AddRef before the Release in case old and new are the same object). -- Alexandre Julliard julliard(a)winehq.org

Oct. 26, 2004

rsaenh

by Michael Jung

Hello, this is an updated version of the rsaenh implementation from yesterday. Updates: 1.) Broke long lines to not exceed a length of 100 characters. 2.) Substituted tabs with spaces. 3.) Removed magic constants. 4.) Rsaenh now uses MD4, MD5 and SHA from advapi32. 5.) Regression tests should work now without failures even if OpenSSL is not available. 6.) Fixed filenames in comments. If you want to try the patch note the following: - After you have applied the patch you have to run autoheader and autoconf. Then cd dlls ; make_dlls ; cd .. ; configure. - After you have compiled and installed wine, you have to unregister rsabase and register rsaenh (regsvr32 /U rsabase ; regsvr32 rsaenh). rsaenh.dll is meant to replace rsabase.dll sometime (Windows XP also has rsaenh.dll only). Greetings, Michael

Oct. 26, 2004

Re: WSCEnumProtocols

by Alexandre Julliard

Hans Leidekker <hans(a)it.vu.nl> writes: > On Tuesday 26 October 2004 02:51, Alexandre Julliard wrote: >> You cannot cast a WSAPROTOCOL_INFOA* to a WSAPROTOCOL_INFOW*, the >> structures don't have the same size. > > Not generally no, but here I can because the size difference comes > from the last element of the structure which is either a unicode > string or an ansi string. The FALSE parameter signals that we want > an ansi string. But the function is dealing with an array of them so that doesn't work, the size of the structure really matters. -- Alexandre Julliard julliard(a)winehq.org

Oct. 26, 2004

Re: rsaenh

by Hans Leidekker

On Tuesday 26 October 2004 17:20, Michael Jung wrote: > There is also a DES implementation in dlls/advapi32/crypt_des.c. However, this > one is not exported by advapi32.dll. I could copy the code over to The DES code is used internally to produce LanManager password hashes. I doubt if you could use it for general DES encryption purposes, not straight away at least. It's also encryption only, so no DES decryption. -Hans

Oct. 26, 2004

Re: shell32: shellpath tests failing greatly

by Juan Lang

Hi Rolf, try reregistering shell32; those entries are supposed to be created by wine.inf when it registers it. --Juan __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

Oct. 26, 2004

shell32: shellpath tests failing greatly

by Rolf Kalbermatter

The recently added tests for shellpath are failing almost completely on my system as it is missing the according registry entries. Not sure how one is supposed to get those registry entries properly. Maybe there is an install script? Although the current documentation talks about an utility wineinstall this seems to have gone completely and I doubt it would take care of those settings. Rolf Kalbermatter

Oct. 26, 2004

FW: GetEnvironmentVariableW regression?

by Rolf Kalbermatter

I suddenly happen to get an error when starting up any application in Wine after having upgraded to current CVS yesterday night from a version a few days ago. The error message is about: "Warning: The specified Windows directory L"c:\\windows" is not accessible" and the same applies for the system directory with the message: "Warning: The specified System directory L"c:\\windows\\system" is not accessible". Looking in the sources I can find the according message in dlls/kernel/process.c and the paths seem to get extracted with GetEnvironmentVariableW(). It seems to me that there is a problem with bad variable expanding or something as the double backslashes in the path in the warning text definitely look wrong. I'm using SUSE Linux 9.0 with XFree 4.3.99. Has this to do with some changes where the .wine/config is supposed to be moved to the registry? If so how do we get the right settings into the registry for common users? Rolf Kalbermatter

Oct. 26, 2004

Re: WineHQ: Assorted spelling fixes

by Walt Ogburn

s/concensus/consensus On Tue, 26 Oct 2004, Filip Navara wrote: > Francois Gouget wrote: > > >Index: wwn/wn20041015_244.xml > >=================================================================== > >RCS file: /var/cvs/lostwages/wwn/wn20041015_244.xml,v > >retrieving revision 1.1 > >diff -u -r1.1 wn20041015_244.xml > >--- wwn/wn20041015_244.xml 15 Oct 2004 03:59:52 -0000 1.1 > >+++ wwn/wn20041015_244.xml 25 Oct 2004 23:10:22 -0000 > >@@ -185,7 +185,7 @@ > > <p>We discussed Jason Edmeades plans to work on > > Direct3D 9 a few weeks ago (see WWN issue > > <a href="http://www.winehq.com/?issue=240#DirectX%209%20Roadmap">#240</a>). > >-The concensus seemed to be created a shared library between > >+The concensus seemed to be ro create a shared library between > > > s/to be ro/to be to/ > >

Oct. 26, 2004