November 2004 - Wine-Devel - list.winehq.org

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Robert van Herk

Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

Nov. 30, 2004

Re: misc. crypt test mem leak fixes

by James Hawkins

On Tue, 30 Nov 2004 21:35:31 +0800, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > "James Hawkins" <truiken(a)gmail.com> wrote: > > > Changelog > > * misc. crypt test mem leak fixes > > Apparently lines with LocalAlloc were added by mistake instead > of LocalFree. > > -- > Dmitry. > > wow....yea those are supposed to be LocalFree. I apologize, it was 3 in the morning at the time. -- James Hawkins

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Robert Shearman

Dmitry Timoshkov wrote: >"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote: > > > >>On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: >> >> >>>The following seemingly simple and harmless change caused a regression >>>in IE6. The toolbar icons are no longer displayed and the error message >>>below appears in the log. >>> >>>err:imagelist:ImageList_LoadImageW Error loading image! >>> >>> >>It's probably not a "regression" in the standard sense, I guess. >> >>Rather something like IE6 choosing to use more modern API mechanisms >>or a different execution path due to the higher version number we just set. >> >>IOW, we should fix Wine to support these API updates. >> >> > >Of course Wine should be fixed. But until then the patch should be reverted. >That's exactly the same kind of patch like adding a stub to a .spec file, >and upgrading a dll version is not really harmless as it seems at the first >glance. > > > WinXP stores the toolbar bitmaps in shell32 in WinXP. I assume previous versions, stored them in some other DLL. Rob

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Dmitry Timoshkov

"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote: > On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: > > > > The following seemingly simple and harmless change caused a regression > > in IE6. The toolbar icons are no longer displayed and the error message > > below appears in the log. > > > > err:imagelist:ImageList_LoadImageW Error loading image! > It's probably not a "regression" in the standard sense, I guess. > > Rather something like IE6 choosing to use more modern API mechanisms > or a different execution path due to the higher version number we just set. > > IOW, we should fix Wine to support these API updates. Of course Wine should be fixed. But until then the patch should be reverted. That's exactly the same kind of patch like adding a stub to a .spec file, and upgrading a dll version is not really harmless as it seems at the first glance. -- Dmitry.

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Andreas Mohr

Hi, On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote: > > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. > > err:imagelist:ImageList_LoadImageW Error loading image! It's probably not a "regression" in the standard sense, I guess. Rather something like IE6 choosing to use more modern API mechanisms or a different execution path due to the higher version number we just set. IOW, we should fix Wine to support these API updates. Andreas Mohr

Nov. 30, 2004

Re: Winecfg -> browse for folder

by Francois Gouget

On Sat, 27 Nov 2004, Robert van Herk wrote: [...] > Internally though, the SHBrowseForFolder dialog (dlls/shell32/brsfolder.c) > uses pidls, which, as far as I know, are a specific win32 thing for > identifying paths uniqually. > > Thus, if I'd make an extra flag in the dialog, I would have to extent pidls > to, so that they can hold unix paths. Is that a wise thing to do? Or should I > take another approach? Is there actually anything that prevents us from storing a Unix path in a PIDL? It's been quite some time since I looked at PIDLs and my memory is a bit fuzzy but I believe it would be quite feasible. If there's something preventing it, wouln't a Shell Namespace extension be the right solution? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Stefan Dösinger

> Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack: > > The following seemingly simple and harmless change caused a regression > > in IE6. The toolbar icons are no longer displayed and the error message > > below appears in the log. > > I can confirm the symptom. I'll test if reversing the patch helps for me. Reversing the patch fixes the problem. Perhaps we should set the shell32 version according to the configured Windows version. Stefan

Nov. 30, 2004

Re: Problem with file dialog

by Stefan Dösinger

Hello, > Changelog: > Store the new style before redrawing and repositioning the control. This patch fixes the problem! Thanks, Stefan

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Stefan Dösinger

Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack: > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. I can confirm the symptom. I'll test if reversing the patch helps for me. Stefan Dösinger

Nov. 30, 2004

Re: Porting SmartWin a Windows API GUI library...

by Dimitrie O. Paun

On Tue, Nov 30, 2004 at 02:06:01PM +0100, Thomas Hansen wrote: > Comments sombody...? I think its a good idea, but before you can consider a WineLib port, you need a MinGW port under Windows. So does it build with the MinGW toolchain? Do you have MinGW Makefiles? If yes, I can take a look, the port may be quite easy. -- Dimi.

Nov. 30, 2004