December 2004 - Wine-Devel - list.winehq.org

Re: [AppDB] screenshot patch

by Chris Morgan

Please convert tabs to spaces. Chris On Saturday 11 December 2004 1:07 pm, Jonathan Ernst wrote: > This patch let user click on the random screenshot displayed for an app > so that he can see the whole gallery by version. The patch displays the > name of the application in the gallery as well (even if we choose a > particular gallery). > > Screenshot gallery's screenshot: http://ernstfamily.ch/screenshot.png > > File changed: > - appview.php > - screenshots.php

Dec. 11, 2004

Re: questionable code

by Eric Pouech

> You can submit a patch for me, or wait until Monday and I'll submit one. submitted. thx A+

Dec. 11, 2004

Re: [AppDB] TODO patch

by tony_lambregts＠telusplanet.net

Jonathan Ernst wrote: [snip] > Index: CODING_STANDARD > =================================================================== > RCS file: /home/wine/appdb/CODING_STANDARD,v > retrieving revision 1.1 > diff -u -r1.1 CODING_STANDARD > --- CODING_STANDARD 11 Dec 2004 03:42:43 -0000 1.1 > +++ CODING_STANDARD 11 Dec 2004 18:56:07 -0000 > @@ -62,4 +62,11 @@ > } > } > > +- use long php tags (<?php ?>) instead of short ones (<? ?>) as : > + 1) it could be removed from future versions of php > + 2) if conflicts with tags like <?xml version=1.0 ?> that are used in xhtml [snip] Should be it not if oops//: + 2) it conflicts with tags like <?xml version=1.0 ?> that are used in xhtml

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by James Hawkins

> > Is it possible that it is broken by this patch instead, > http://cvs.winehq.org/patch.py?id=14371, that Paul van Schayck reported > broke Foobar2000? > The bug I was getting where the whole window is garbage is not caused by this patch, but the error message I was getting: err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! does not show up anymore. However, the map viewer still does not show up as it should, and it sounds like this is that GL problem Lionel talked about. -- James Hawkins

Dec. 11, 2004

Re: ntdll / kernel32: #52

by Eric Pouech

> Rtl* functions should generally avoid doing server calls. You should > implement the Rtl* functions on top of the Nt* functions, not the other > way around. the "real" fix would mean (which I decided not to implement) - not moving local atom tables to wineserver (and handling them in the local memory) - that would by the way allow to use the internal representation of local atom tables - then, just Nt atom related functions would call wineserver Deciding to keep the code in one place (wineserver) leads to the Nt -> Rtl calls. A+

Dec. 11, 2004

Re: C++ iostream compilation problems

by Dimitrie O. Paun

On Sat, Dec 11, 2004 at 10:17:38AM -0600, Geoff Hart wrote: > I'm trying to compile some C++ code, but hit a basic problem > with some of the headers. Example, even just the single include: > > #include <iostream> > > yields > > wineg++ -c -mno-cygwin -I. -o cxx_iostream.o cxx_iostream.cpp > In file included from > error: `::vscanf' has not been declared > /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:171: > > Are the GCC C++ includes incompatible with the winelib headers? Yes, the msvcrt headers (invoked via -mno-cygwin) are. You need to use the glibc headers (try to get rid of -mno-cygwin). -- Dimi.

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by Robert Shearman

James Hawkins wrote: >>Are these messages output in the 2004-10-12 version of Wine, where it >>mostly displayed properly? >> >> > >Yea these are from 2004-10-12. > > Then that means there was already some problem with the app that has now been exposed. We should find out why the app isn't calling BeginPaint like it should. Rob

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by James Hawkins

On Sat, 11 Dec 2004 17:51:58 +0100, Lionel Ulmer <lionel.ulmer(a)free.fr> wrote: > > This message happens every time the editor needs a repaint like when > > it gets covered by another window. Any ideas about what's going on > > here? > > Is it using OpenGL do display the map ? If yes, it may be yet again the > known incompatibility between GL and Wine regarding multi-windowed > applications (which requires some 'hacks' in the code which may get broken > on code refactoring). > > Lionel > > -- > Lionel Ulmer - http://www.bbrox.org/ > Yes it's using OpenGL. Can you catch me up to speed on this problem? btw the source is available on sourceforge. -- James Hawkins

Dec. 11, 2004

Re: Includes [4] shlwapi

by Alexandre Julliard

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > Since the process of removing the unneeded headers is automated, and > most files that include non-sdk headers already have the missing > includes, I can't see that its any more work one way or the other > (well, it takes several hours to run the script, but thats the > computer working, not me). Well, it's more work for the poor slob who has to review, test, and commit the resulting patches <g> (not to mention for people who maintain local changes and need to fix merge conflicts after each commit). -- Alexandre Julliard julliard(a)winehq.org

Dec. 11, 2004

Re: Includes [1] ntdll

by Jon Griffiths

Hi, > >>Do the patches take into account that a header might only be > >>included to > >>check that an exported function matches the declaration in the > >>header file? I've extended my script to handle this case. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by Lionel Ulmer

> This message happens every time the editor needs a repaint like when > it gets covered by another window. Any ideas about what's going on > here? Is it using OpenGL do display the map ? If yes, it may be yet again the known incompatibility between GL and Wine regarding multi-windowed applications (which requires some 'hacks' in the code which may get broken on code refactoring). Lionel -- Lionel Ulmer - http://www.bbrox.org/

Dec. 11, 2004

Re: [AppDB] First step to integrating the AppDB with Bugzilla

by tony_lambregts＠telusplanet.net

Paul van Schayck wrote: > Hey Tony, > > A few comments. > > On Fri, 10 Dec 2004 21:52:45 -0700, Tony Lambregts > <tony_lambregts(a)telusplanet.net> wrote: > >>+ <td> <input type="text" name="ext_email" value="<?=$ext_email;?>"> > > > Shorttags. I don't like them. They can be turned of in php.ini to > allow the (now more often appearing) <?xml tag. Debugging Cruft (from the original code) > > >>+/* $bugzilla_db_port = 3306; is this needed? I dont think so.*/ > > > 3306 is default. So, no not really needed. > > >>+Contributors: >>+ Paul van Schayck <info(a)wwwdesign.tmfweb.nl> > > > Can this be changed to polleke(a)gmail.com? Or just removed. Can do. > > Kind regards, > Paul van Schayck > >

Dec. 11, 2004

Re: ntdll / kernel32: #52

by Robert Shearman

Eric Pouech wrote: > Moving atom implementation to: > - dlls/kernel32/atom16.c for the 16 bit part > - dlls/ntdll/ntdll.c for the 32 bit part > > A+ > >------------------------------------------------------------------------ > >Name: ntkrnl_52 >ChangeLog: > - moved 16 bit atom support in (16bit) dlls/kernel/atom16.c > - added atom support to NTDLL > - made 32 bit atom support in kernel32 call ntdll's brand new one > - copied the atom tests for global atom so that we can test local atoms too >License: X11 >GenDate: 2004/12/11 12:59:19 UTC >ModifiedFiles: dlls/kernel/Makefile.in dlls/kernel/atom.c dlls/kernel/tests/atom.c dlls/ntdll/Makefile.in dlls/ntdll/ntdll.spec include/winternl.h server/protocol.def server/atom.c >AddedFiles: dlls/kernel/atom16.c dlls/ntdll/atom.c > > ... >--- /dev/null 1970-01-01 01:00:00.000000000 +0100 >+++ dlls/ntdll/atom.c 2004-12-04 15:31:03.000000000 +0100 >@@ -0,0 +1,331 @@ >+/* >+ * Atom table functions >+ * >+ * Copyright 1993, 1994, 1995 Alexandre Julliard >+ * Copyright 2004 Eric Pouech >+ * >+ * This library is free software; you can redistribute it and/or >+ * modify it under the terms of the GNU Lesser General Public >+ * License as published by the Free Software Foundation; either >+ * version 2.1 of the License, or (at your option) any later version. >+ * >+ * This library is distributed in the hope that it will be useful, >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >+ * Lesser General Public License for more details. >+ * >+ * You should have received a copy of the GNU Lesser General Public >+ * License along with this library; if not, write to the Free Software >+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA >+ */ >+ >+#include "config.h" >+#include "wine/port.h" >+ >+#include <stdlib.h> >+#include <stdarg.h> >+#include <stdio.h> >+#include <string.h> >+#include <ctype.h> >+ >+#include "windef.h" >+#include "winbase.h" >+#include "ntstatus.h" >+ >+#include "wine/server.h" >+#include "wine/unicode.h" >+ >+#include "wine/debug.h" >+ >+WINE_DEFAULT_DEBUG_CHANNEL(atom); >+ >+#define DEFAULT_ATOMTABLE_SIZE 37 >+#define MAX_ATOM_LEN 255 >+ >+/****************************************************************** >+ * is_integral_atom >+ * Returns STATUS_SUCCESS if integral atom and 'pAtom' is filled >+ * STATUS_INVALID_PARAMETER if 'atomstr' is too long >+ * STATUS_MORE_ENTRIES otherwise >+ */ >+static NTSTATUS is_integral_atom( LPCWSTR atomstr, ATOM* pAtom ) >+{ >+ ATOM atom; >+ >+ if (HIWORD( atomstr )) >+ { >+ const WCHAR* ptr = atomstr; >+ if (*ptr++ == '#') >+ { >+ atom = 0; >+ while (*ptr >= '0' && *ptr <= '9') >+ { >+ atom = atom * 10 + *ptr++ - '0'; >+ } >+ if (ptr > atomstr + 1 && !*ptr) goto done; >+ } >+ if (strlenW( atomstr ) > MAX_ATOM_LEN) return STATUS_INVALID_PARAMETER; >+ return STATUS_MORE_ENTRIES; >+ } >+ else atom = LOWORD( atomstr ); >+done: >+ if (atom >= MAXINTATOM) return STATUS_INVALID_PARAMETER; >+ *pAtom = atom; >+ return STATUS_SUCCESS; >+} >+ >+/****************************************************************** >+ * RtlDeleteAtomFromAtomTable (NTDLL.@) >+ */ >+NTSTATUS WINAPI RtlDeleteAtomFromAtomTable( void* table, ATOM atom ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "%p %x\n", table, atom ); >+ SERVER_START_REQ( delete_atom ) >+ { >+ req->atom = atom; >+ req->table = table; >+ status = wine_server_call( req ); >+ } >+ SERVER_END_REQ; >+ return status; >+} > > Rtl* functions should generally avoid doing server calls. You should implement the Rtl* functions on top of the Nt* functions, not the other way around. ... >+/****************************************************************** >+ * NtDeleteAtom (NTDLL.@) >+ */ >+NTSTATUS WINAPI NtDeleteAtom(ATOM atom) >+{ >+ return RtlDeleteAtomFromAtomTable( GLOBAL_ATOM_TABLE, atom ); >+} > > Rob

Dec. 11, 2004

Re: questionable code

by Robert Shearman

Eric Pouech wrote: > *** dlls/ole32/hglobalstream.c line 602 > the test "if (newPosition.QuadPart < 0)" is always false as QuadPart > is unsigned > Before the call to RtlLargeIntegerAdd we need to add a line with: if ((dlibMove.QuadPart < 0) && (newMove < -dlibMove.QuadPart)) return STG_E_INVALIDFUNCTION; And remove the offending < 0 line. You can submit a patch for me, or wait until Monday and I'll submit one. Rob

Dec. 11, 2004

C++ iostream compilation problems

by Geoff Hart

I'm trying to compile some C++ code, but hit a basic problem with some of the headers. Example, even just the single include: #include <iostream> yields wineg++ -c -mno-cygwin -I. -o cxx_iostream.o cxx_iostream.cpp In file included from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/i386-redhat-linux/bits/c++locale.h:42, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/iosfwd:46, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/ios:44, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/ostream:45, from /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/iostream:45, from cxx_iostream.cpp:1: /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:167: error: `::snprintf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:168: error: `::vfscanf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:169: error: `::vscanf' has not been declared /usr/lib/gcc/i386-redhat-linux/3.4.0/../../../../include/c++/3.4.0/cstdio:171: error: `::vsscanf' has not been declared .... The error list goes on for a few pages. This is with Winelib 20041019 on FC2 (gcc 3.4). Do I need some #defines to correct this? I tried scanning the gcc headers with that in mind, but couldn't find any which solved this. Are the GCC C++ includes incompatible with the winelib headers? Geoff

Dec. 11, 2004

Re: Includes [4] shlwapi

by Jon Griffiths

Hi, > It's the same issue, I took 16-bit headers as example but you can > have > the same problem with SDK headers, it's quite possible that a file > doesn't need winuser.h by itself. So you would first have to move > the > includes out of the non-sdk header into the source files, and then > once you get rid of the non-sdk header go back and remove the > unneeded headers again. > It's a lot easier to wait until the non-sdk header > gets removed and then do everything in one step. Since the process of removing the unneeded headers is automated, and most files that include non-sdk headers already have the missing includes, I can't see that its any more work one way or the other (well, it takes several hours to run the script, but thats the computer working, not me). However I'm happy to run the script periodically as the headers are reorganised/removed. Meanwhile I'll try to reduce the dependencies on dll internal headers. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

Dec. 11, 2004

Re: [AppDB] First step to integrating the AppDB with Bugzilla

by Paul van Schayck

Hey Tony, A few comments. On Fri, 10 Dec 2004 21:52:45 -0700, Tony Lambregts <tony_lambregts(a)telusplanet.net> wrote: > + <td> <input type="text" name="ext_email" value="<?=$ext_email;?>"> Shorttags. I don't like them. They can be turned of in php.ini to allow the (now more often appearing) <?xml tag. > +/* $bugzilla_db_port = 3306; is this needed? I dont think so.*/ 3306 is default. So, no not really needed. > +Contributors: > + Paul van Schayck <info(a)wwwdesign.tmfweb.nl> Can this be changed to polleke(a)gmail.com? Or just removed. Kind regards, Paul van Schayck

Dec. 11, 2004

Re: msacm: pcm compatibility patch

by Christian Costa

Eric Pouech wrote: > Christian Costa a écrit : > >> Hi Robert, >> >> Robert Reif wrote: >> >>> Makes the PCM conversion routines of msacm produce identical results >>> to the native dll. >>> Allow any PCM to PCM conversion, not just advertised ones. >>> >>> The algorithms used by Microsoft in this dll are very crude and >>> produce an output of much poorer quality than what is currently >>> in wine. This is unfortunate but unavoidable if we are to be >>> compatible. >> >> >> >> I don't see how improving the quality of the conversion could cause >> problems. >> Is there an app out there that refuses to run or crashes because of >> that? >> The algorithms may have slightly changed across all versions of this >> dll. >> And if we can do better job than Microsoft, I think we should do it. > > > > I'd agree that what we don't need byte compatibility for the audio > conversions. We should be compatible OTOH on the size of the buffers > sent out (not sure it's always the case), which may cause some > problems in some cases. Agreed. :-) Bye, Christian

Dec. 11, 2004

Re: Allow output in winedbg to be redirected to a file

by Eric Pouech

Jeremy White a écrit : > Eric Pouech wrote: > >> Jeremy White a écrit : >> >>> Changelog: >>> Allow > and >> output redirection on winedbg commands to capture >>> output to a file. >> >> >> again (it's my bad day for Jer), I think we should stick to gdb >> commands: see 'set logging' and friends. > > > Hmm. I've never liked the gdb 'set logging' interface, > but I see your point. > > I guess the question for winedbg is whether our goal is > pure gdb only, or if we want to be able to add things > to the interface. > > Consider the gdb way: > (gdb) set logging overwrite off > (gdb) set logging file /tmp/foo > (gdb) set logging redirect on > (gdb) set logging on > Redirecting output to /tmp/foo. > (gdb) bt > (gdb) set logging off > Done logging to /tmp/foo. > > vs what I proposed: > Wine-dbg> bt >>/tmp/foo IMO, if you just need the output of one command (which is what your patch does), copy & paste is much easier. A good use case I can think of is when you started a debugging session (or winedbg has been started after a crash), and you want to capture all the output from now, which what gdb tends to do, which requires a session oriented type of handling (which gdb does) and not command oriented (which your patch does). A+

Dec. 11, 2004

Re: some description for ExtTextOut

by Shachar Shemesh

Vitaly Lipatov wrote: >+ * ETO_GRAYED - undocumented on MSDN >+ * ETO_OPAQUE - use background color for fill the rectangle >+ * ETO_CLIPPED - clipping text to the rectangle >+ * ETO_GLYPH_INDEX > + * ETO_GLYPH_INDEX - Buffer is of glyph locations in fonts rather than encoded characters. Implies ETO_IGNORELANGUAGE >+ * ETO_RTLREADING > + * ETO_RTLREADING - Paragraph is basically a right-to-left paragraph. Affects BiDi ordering >+ * ETO_IGNORELANGUAGE > + * ETO_IGNORELANGUAGE - Undocumented in MSDN - instructs ExtTextOut not to do BiDi reordering >+ * ETO_PDY - unimplemented >+ * ETO_NUMERICSLATIN - unimplemented >+ * ETO_NUMERICSLOCAL - unimplemented > > + * ETO_NUMERICSLATIN - unimplemented always assumed - do not translate numbers into locale representations + * ETO_NUMERICSLOCAL - unimplemented - Numerals in Arabic/Farsi context should assume local form Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

Dec. 11, 2004

Re: msacm: pcm compatibility patch

by Robert Reif

Eric Pouech wrote: > > I'd agree that what we don't need byte compatibility for the audio > conversions. We should be compatible OTOH on the size of the buffers > sent out (not sure it's always the case), which may cause some > problems in some cases. > A+ > > The number of bytes read and written was the original issue that I was investigating. The original code actually wrote past the end of the buffer at one point before I corrected that a long time ago. The Microsoft code will not read and/or write the entire contents of the buffers under some circumstances. Duplicating this behavior lead to the code I have presented. Any audio programmer concerned about the quality of conversions will stay as far away from Microsoft code as possible.

Dec. 11, 2004

Re: msacm: pcm compatibility patch

by Eric Pouech

Christian Costa a écrit : > Hi Robert, > > Robert Reif wrote: > >> Makes the PCM conversion routines of msacm produce identical results >> to the native dll. >> Allow any PCM to PCM conversion, not just advertised ones. >> >> The algorithms used by Microsoft in this dll are very crude and >> produce an output of much poorer quality than what is currently >> in wine. This is unfortunate but unavoidable if we are to be compatible. > > > I don't see how improving the quality of the conversion could cause > problems. > Is there an app out there that refuses to run or crashes because of that? > The algorithms may have slightly changed across all versions of this dll. > And if we can do better job than Microsoft, I think we should do it. I'd agree that what we don't need byte compatibility for the audio conversions. We should be compatible OTOH on the size of the buffers sent out (not sure it's always the case), which may cause some problems in some cases. A+

Dec. 11, 2004

Re: msacm: pcm compatibility patch

by Christian Costa

Hi Robert, Robert Reif wrote: > Makes the PCM conversion routines of msacm produce identical results > to the native dll. > Allow any PCM to PCM conversion, not just advertised ones. > > The algorithms used by Microsoft in this dll are very crude and > produce an output of much poorer quality than what is currently > in wine. This is unfortunate but unavoidable if we are to be compatible. I don't see how improving the quality of the conversion could cause problems. Is there an app out there that refuses to run or crashes because of that? The algorithms may have slightly changed across all versions of this dll. And if we can do better job than Microsoft, I think we should do it. > > I have a test program that was used to verify compatibility and can > make it available by request. I hope to integrate some of it into > the regression tests someday. > Bye, Christian

Dec. 11, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Arjen Nienhuis

> > Hmm. For the winecfg use case though we have to pass back a Unix path, > as by definition it might not be mapped to a Windows path. I suspect > most code that uses the browse folder API converts the PIDL straight > into a path that it can use with CreateFileEx and so on so it might > break stuff if we invented a new PIDL extension that contained a raw > Unix path. > No, you shouldn't convert a PIDL to path. Shell extensions create temporary files on SHGetPathFromIDList. SHGetPathFromIDList is implemented by shell extensions. Maybe we can return names like \\.\unix\usr\doc\ or whatever devicepaths look like in windows. You can hide shell extensions by not registering them as part of 'my computer'. You can acess any them simply by creating a shortcut or a directory named Dirname.{CLSID}. I don't know if you can access them without creating a file.

Dec. 11, 2004

winsock:WS_setsockopt

by MediaHost (TM)

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

Dec. 11, 2004

questionable code

by Eric Pouech

still toying with various compilers, here's two new questions (to whom it may concern): **** dlls/gdi/freetype.c line 1467 the test for "(offset < 0)" is always false. I'm not sure changing it into "offset == -1" is the right solution. *** dlls/ole32/hglobalstream.c line 602 the test "if (newPosition.QuadPart < 0)" is always false as QuadPart is unsigned A+

Dec. 11, 2004

winsock:WS_setsockopt

by StartCom Ltd.

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by James Hawkins

> Is it possible that it is broken by this patch instead, > http://cvs.winehq.org/patch.py?id=14371, that Paul van Schayck reported > broke Foobar2000? I'll do a more regression testing to see which patch exactly broke it completely. > > Are these messages output in the 2004-10-12 version of Wine, where it > mostly displayed properly? Yea these are from 2004-10-12. -- James Hawkins

Dec. 11, 2004

Re: BeginPaint not called on WM_PAINT

by Robert Shearman

James Hawkins wrote: >I'm trying to get a program running called BZEdit. Under the latest >cvs, the program shows a scrambled mess over the whole screen (I think >that is a result of this patch >http://cvs.winehq.org/patch.py?id=14725) but when I went back in time >to 2004-10-12, the only part of the screen I cant see is the part of >the screen where the map you're editing is shown. > Is it possible that it is broken by this patch instead, http://cvs.winehq.org/patch.py?id=14371, that Paul van Schayck reported broke Foobar2000? >See > >http://www.artemisgames.com/BZEdit/ > >for screenshots. This is the error output I'm getting. > >err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! > >This message happens every time the editor needs a repaint like when >it gets covered by another window. Any ideas about what's going on >here? > Are these messages output in the 2004-10-12 version of Wine, where it mostly displayed properly? Rob

Dec. 11, 2004

BeginPaint not called on WM_PAINT

by James Hawkins

I'm trying to get a program running called BZEdit. Under the latest cvs, the program shows a scrambled mess over the whole screen (I think that is a result of this patch http://cvs.winehq.org/patch.py?id=14725) but when I went back in time to 2004-10-12, the only part of the screen I cant see is the part of the screen where the map you're editing is shown. See http://www.artemisgames.com/BZEdit/ for screenshots. This is the error output I'm getting. err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! This message happens every time the editor needs a repaint like when it gets covered by another window. Any ideas about what's going on here? -- James Hawkins

Dec. 11, 2004

[AppDB] First step to integrating the AppDB with Bugzilla

by Tony Lambregts

Over two years ago this was disccused and the concensus at the time was that integrating the AppDB and Bugzilla would be a Good Idea (TM). This patch is my attempt to get it started. I am submitting this to wine devel first because I KNOW this patch can be controversial. I have tried to make this patch as small as possible but it still covers quite a few files. I am useing Globals and that should be improved. and I am sure there are other things that are wrong with it. ;^) Also the code in preferences.php does not do anything except show that this works. Finally in order for it to work Jeremy Newman will need to set up the include/config.php in the appdb directory. Please try it out and get back to me.. Change Log: Integrate AppDB with Bugzilla to use the versions table from Buzilla. Files changed: preferences.php include/config.php.sample include/util.php Files Added: tables/bugzilla_tables.sql tables/create_bugzilla_tables Index: preferences.php =================================================================== RCS file: /home/wine/appdb/preferences.php,v retrieving revision 1.2 diff -u -r1.2 preferences.php --- preferences.php 10 Dec 2004 01:07:45 -0000 1.2 +++ preferences.php 11 Dec 2004 04:45:44 -0000 @@ -50,6 +50,16 @@ $ext_email = $user->lookup_email($_SESSION['current']->userid); include(BASE."include/"."form_edit.php"); + $version = "unspecified"; + echo "<tr><td>  wine version </td><td>"; + make_bugzilla_version_list("version", $version); + echo "</td></tr>"; +/* <tr> + <td>   Email Address </td> + <td> <input type="text" name="ext_email" value="<?=$ext_email;?>"> </td> + </tr> +*/ + } if($HTTP_POST_VARS) Index: include/config.php.sample =================================================================== RCS file: /home/wine/appdb/include/config.php.sample,v retrieving revision 1.2 diff -u -r1.2 config.php.sample --- include/config.php.sample 24 Mar 2004 15:51:49 -0000 1.2 +++ include/config.php.sample 11 Dec 2004 04:45:45 -0000 @@ -24,4 +24,14 @@ $userdb_dbhost = "localhost"; $userdb_db = "apidb"; +/* + * Bugzilla database info + */ +$bugzilla_dbuser = "root"; +$bugzilla_dbpass = ""; +$bugzilla_dbhost = "localhost"; +$bugzilla_db = "bugs"; +/* $bugzilla_db_port = 3306; is this needed? I dont think so.*/ +$bugzilla_product_id = 1; + ?> Index: include/util.php =================================================================== RCS file: /home/wine/appdb/include/util.php,v retrieving revision 1.7 diff -u -r1.7 util.php --- include/util.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/util.php 11 Dec 2004 04:45:45 -0000 @@ -171,6 +171,69 @@ } } +/* bugzilla functions */ + +function openbugzilladb() +{ + global $bugzilla_dbuser, $bugzilla_dbpass, $bugzilla_dbhost, $bugzilla_db, $bugzilla_product_id; + global $dbcon, $dbref; + + $dbref++; + + if($dbcon) + return $dbcon; + + $dbcon = mysql_connect($bugzilla_dbhost, $bugzilla_dbuser, $bugzilla_dbpass); + if(!$dbcon) + { + echo "An error occurred: ".mysql_error()."<p>\n"; + exit; + } + mysql_select_db($bugzilla_db); + return $dbcon; +} + +function closebugzilladb() +{ + global $dbcon, $dbref; + + if(--$dbref) + return; + + mysql_close($adbcon); +} + +function make_bugzilla_version_list($varname, $cvalue) +{ + global $bugzilla_db, $bugzilla_product_id; + + $table = $bugzilla_db.".versions"; + $where = "WHERE product_id=".$bugzilla_product_id; + $query = "SELECT value FROM $table $where ORDER BY value"; + + openbugzilladb(); + + $result = mysql_query($query); + + if(!$result) + { + closebugzilladb(); + + return; // Oops + } + echo "<select name='$varname'>\n"; + echo "<option value=0>Choose ...</option>\n"; + while(list($value) = mysql_fetch_row($result)) + { + if($id == $cvalue) + echo "<option value=$value selected>$value\n"; + else + echo "<option value=$value>$value\n"; + } + echo "</select>\n"; + closebugzilladb(); +} + /* get the number of applications in the appQueue table */ function getQueuedAppCount() { --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/create_bugzilla_tables 2004-12-10 13:41:28.000000000 -0700 @@ -0,0 +1,4 @@ +#! /bin/sh + +echo Creating fake Bugzilla tables +mysql -u root < bugzilla_tables.sql --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/bugzilla_tables.sql 2004-12-10 14:10:49.000000000 -0700 @@ -0,0 +1,62 @@ +create database if not exists bugs; + +use bugs; + +drop table if exists versions; + + +/* + * versions information + */ +create table versions ( + value tinytext, + product_id smallint not null +); + +INSERT INTO versions VALUES ('unspecified', 1 ); +INSERT INTO versions VALUES ('20010112', 1 ); +INSERT INTO versions VALUES ('20010216', 1 ); +INSERT INTO versions VALUES ('20010305', 1 ); +INSERT INTO versions VALUES ('20010326', 1 ); +INSERT INTO versions VALUES ('20010418', 1 ); +INSERT INTO versions VALUES ('20010510', 1 ); +INSERT INTO versions VALUES ('20010629', 1 ); +INSERT INTO versions VALUES ('20010824', 1 ); +INSERT INTO versions VALUES ('20011004', 1 ); +INSERT INTO versions VALUES ('20011108', 1 ); +INSERT INTO versions VALUES ('20020228', 1 ); +INSERT INTO versions VALUES ('20020310', 1 ); +INSERT INTO versions VALUES ('20020411', 1 ); +INSERT INTO versions VALUES ('20020509', 1 ); +INSERT INTO versions VALUES ('20020605', 1 ); +INSERT INTO versions VALUES ('20020710', 1 ); +INSERT INTO versions VALUES ('20020804', 1 ); +INSERT INTO versions VALUES ('20020904', 1 ); +INSERT INTO versions VALUES ('20021007', 1 ); +INSERT INTO versions VALUES ('20021031', 1 ); +INSERT INTO versions VALUES ('20021125', 1 ); +INSERT INTO versions VALUES ('20021219', 1 ); +INSERT INTO versions VALUES ('20030115', 1 ); +INSERT INTO versions VALUES ('20030219', 1 ); +INSERT INTO versions VALUES ('20030318', 1 ); +INSERT INTO versions VALUES ('20030408', 1 ); +INSERT INTO versions VALUES ('20030508', 1 ); +INSERT INTO versions VALUES ('20030618', 1 ); +INSERT INTO versions VALUES ('20030709', 1 ); +INSERT INTO versions VALUES ('20030813', 1 ); +INSERT INTO versions VALUES ('20030911', 1 ); +INSERT INTO versions VALUES ('20031016', 1 ); +INSERT INTO versions VALUES ('20031118', 1 ); +INSERT INTO versions VALUES ('20031212', 1 ); +INSERT INTO versions VALUES ('20040121', 1 ); +INSERT INTO versions VALUES ('20040213', 1 ); +INSERT INTO versions VALUES ('20040309', 1 ); +INSERT INTO versions VALUES ('20040408', 1 ); +INSERT INTO versions VALUES ('20040505', 1 ); +INSERT INTO versions VALUES ('20040615', 1 ); +INSERT INTO versions VALUES ('20040716', 1 ); +INSERT INTO versions VALUES ('20040813', 1 ); +INSERT INTO versions VALUES ('20040914', 1 ); +INSERT INTO versions VALUES ('20041019', 1 ); +INSERT INTO versions VALUES ('20041201', 1 ); +INSERT INTO versions VALUES ('CVS', 1 ); Index: README =================================================================== RCS file: /home/wine/appdb/README,v retrieving revision 1.3 diff -u -r1.3 README --- README 25 Mar 2004 16:29:47 -0000 1.3 +++ README 11 Dec 2004 05:10:49 -0000 @@ -1,32 +1,70 @@ -WineHQ Application Database ------------------------------------------------------------------------- -Authors: - Jeremy Newman <jnewman(a)codeweavers.com> - Charles Leop <charles(a)codeweavers.com> - -Contributors: - Paul van Schayck <info(a)wwwdesign.tmfweb.nl> - Chris Morgan <cmorgan(a)alum.wpi.edu> +WineHQ Application Database +------------------------------------------------------------------------ +Authors: + Jeremy Newman <jnewman(a)codeweavers.com> + Charles Leop <charles(a)codeweavers.com> + +Contributors: + Paul van Schayck <info(a)wwwdesign.tmfweb.nl> + Chris Morgan <cmorgan(a)alum.wpi.edu> + + +To install locally for testing/hacking: +------------------------------------------------------------------------ + +- Symlink from /var/www to the appdb directory + +- Copy include/config.php.sample to include/config.php + +- Edit include/config.php as you see fit, the default name of the database + used in the table creation step below is "apidb", you'll have to modify + these files if you change this in config.php + +- cd tables, run ./create_tables to create the database tables + +- Try to open up localhost/appdb, if you get a directory listing + Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php + so apache will open index.php after not finding index.html/index.htm etc + +- Check your /etc/php/php.ini to ensure that + 'register_globals = On' (variables won't get passed) + 'magic_quotes_gpc = Off' (you would end up with \ everywhere) + 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +------------------------------------------------------------------------ +You can create ether set up a real bugzilla database or a fake one + +- cd tables, run ./create_bugzilla_tables to create the fake bugzilla tables -To install locally for testing/hacking: ------------------------------------------------------------------------- +- installing a real bugzilla database (hope this helps) -- Symlink from /var/www to the appdb directory +# download buzilla (password for cvs is cvs) -- Copy include/config.php.sample to include/config.php +cd /var/www/html +export CVSROOT=:pserver:cvs(a)cvs.winehq.org:/home/wine +cvs login +cvs -z 0 checkout bugzilla -- Edit include/config.php as you see fit, the default name of the database - used in the table creation step below is "apidb", you'll have to modify - these files if you change this in config.php +# change directory to bugzilla and change the group ownership to apache. -- cd tables, run ./create_tables to create the database tables +cd bugzilla +chgrp -R apache . +chmod -R g+rX . -- Try to open up localhost/appdb, if you get a directory listing - Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php - so apache will open index.php after not finding index.html/index.htm etc -- Check your /etc/php/php.ini to ensure that - 'register_globals = On' (variables won't get passed) - 'magic_quotes_gpc = Off' (you would end up with \ everywhere) - 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +# change to su and run ./checksetup.pl and fix up what it finds wrong. +# this may take several runs + +su +./checksetup.pl + +# in the /etc/httpd/conf/hppt.conf file find "AddHandler cgi-script .cgi" and add the following. + +<Directory "/var/www/html/bugzilla"> +Options ExecCGI +AllowOverride Limit +Order allow,deny +Allow from all +</Directory> + +# edit local config as nessary to allow access.

Dec. 10, 2004

Re: "Debugging" a password dialog

by Robert Shearman

David Gümbel wrote: >Hi everybody, > > > > >I am trying to get an application to run under Wine that requires a login >with a username and a password. The program runs all fine, however I can't >login with data that should work (and AFAIK works under Windows). > >Having entered the password, in the corresponding part of the dialog I only >see "*****" (which is correct). However, when I change focus to some other >part of that dialog afterwards, the password field shows >"*************" (way more asterisks than before). The previous (i.e. >correct) length of ****s is restored when setting the focus back onto the >password field. > > Are you sure this isn't a security feature of the program? Does the program exhibit this behaviour in Windows? >I have reason to believe that the password I entered is not correctly passed >on to the login procedure of the program. However, I am sort of badly >lacking a nice idea how to efficiently debug this thingy and verify >(falsify ;) that I'm right. So, does anybody have an idea? > > It is unlikely, but not impossible to be a bug in the edit control. That code has been around for ages and is well tested, but then again this program could be using some really weird side effects. I would look elsewhere though. What is the password being checked against? Is it going over the network? Is it reading in a file off the disk and processing it? Is it using cryptography functions? Answering these will give you some clues with which to start debugging with. Rob

Dec. 10, 2004

Re: "Debugging" a password dialog

by Walt Ogburn

Dump a trace into a file, then grep for the username and password you entered? On Fri, 10 Dec 2004, David [iso-8859-15] G�mbel wrote: > Hi everybody, > > > > > I am trying to get an application to run under Wine that requires a login > with a username and a password. The program runs all fine, however I can't > login with data that should work (and AFAIK works under Windows). > > Having entered the password, in the corresponding part of the dialog I only > see "*****" (which is correct). However, when I change focus to some other > part of that dialog afterwards, the password field shows > "*************" (way more asterisks than before). The previous (i.e. > correct) length of ****s is restored when setting the focus back onto the > password field. > > I have reason to believe that the password I entered is not correctly passed > on to the login procedure of the program. However, I am sort of badly > lacking a nice idea how to efficiently debug this thingy and verify > (falsify ;) that I'm right. So, does anybody have an idea? > > > > Bye, > > > > David >

Dec. 10, 2004

"Debugging" a password dialog

by David Gümbel

Hi everybody, I am trying to get an application to run under Wine that requires a login with a username and a password. The program runs all fine, however I can't login with data that should work (and AFAIK works under Windows). Having entered the password, in the corresponding part of the dialog I only see "*****" (which is correct). However, when I change focus to some other part of that dialog afterwards, the password field shows "*************" (way more asterisks than before). The previous (i.e. correct) length of ****s is restored when setting the focus back onto the password field. I have reason to believe that the password I entered is not correctly passed on to the login procedure of the program. However, I am sort of badly lacking a nice idea how to efficiently debug this thingy and verify (falsify ;) that I'm right. So, does anybody have an idea? Bye, David

Dec. 10, 2004

Re: Problems using WineDbg

by Eric Pouech

> There are some other strage missbehaviors, like printing 10000 times > 'Wine-dbg>' before being killed using kill -kill <wine-pids>, or even not > printing the register dump + back trace in the first place like shown > above (same application, startup phase). So not even every time I try > winedbg, everything happens identical. a few questions: - do you have some other applications running (in the background) on the same unix console? - can you rerun with -debugmsg +winedbg and send the trace. TIA A+

Dec. 10, 2004

Re: [AppDB] remove blahblahblah from /include/comments.php

by Chris Morgan

Hahah. Oops.... Chris > > From: tony_lambregts(a)telusplanet.net > Date: 2004/12/10 Fri AM 01:09:35 EST > To: wine-patches(a)winehq.org > Subject: [AppDB] remove blahblahblah from /include/comments.php > > Change log: remove blahblahblah from /include/comments.php > > Files Changed: /include/comments.php > > > Index: include/comments.php =================================================================== RCS file: /home/wine/appdb/include/comments.php,v retrieving revision 1.7 diff -u -r1.7 comments.php --- include/comments.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/comments.php 10 Dec 2004 06:58:22 -0000 @@ -75,7 +75,6 @@ echo "<input type=hidden name='commentId' value=$ob->commentId>"; echo "<input type=hidden name='appId' value=$ob->appId>"; echo "<input type=hidden name='versionId' value=$ob->versionId></form></td>","\n"; - echo "blahblahblah $apidb_root"; echo "</td></tr>"; }

Dec. 10, 2004

Re: Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg

by Marcus Meissner

On Fri, Dec 10, 2004 at 10:05:33AM -0600, Robert Shearman wrote: > Erich Hoover wrote: > > >dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in > >_copy_arg, this causes InstallShield to crash when attempting to > >install the demo for "Prince of Persia: Warrior Within" (and probably > >other InstallShield programs as well). Installation can complete with > >this fix under Win9x w/ Desktop (2K and XP options still fail due to > >"unimplemented function imagehlp.dll.StackWalk64" and non-Desktop > >fails for unknown reason). .... > >--- 4543,4554 ---- > > memcpy(argpos, &V_UNION(arg,lVal), 4); > > hres = S_OK; > > break; > >+ case VT_BYREF | VT_I4: > >+ *argpos = V_UNION(arg,iVal); > >+ hres = S_OK; > >+ break; VT_BYREF|VT_I4 should probably use *argpos = *V_UNION(arg,plVal);. Ciao, Marcus

Dec. 10, 2004

Re: Hang in usr1_handler (ptrace issue?)

by Mike Hearn

On Thu, 2004-12-09 at 15:00 -0700, Jesse Allen wrote: > I can't tell if there is any similarity cause that function doesn't show up. > If anyone wants the log it's here: > http://www.chez.com/alors/loop.log.bz2 > (copy and paste url into browser, don't click, it won't work) > > Anyone has any clue what is going on here? This is still related to the > ptrace changes. When it hangs (at 100% on the loading screen) get a backtrace using winedbg, eg: winedbg --command 'bt all' and post the results here. thanks -mike

Dec. 10, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Vincent Béron

Le ven 10/12/2004 à 10:40, Ferenc Wagner a écrit : [snip] > Yes. But will sticking to a fixed directory name (and > possibly file name) help, or does ZoneAlarm check eg. MD5 > sums to thwart any countermeasure from our side? Anyway, I > have the feeling that this should be solved by configuring > ZoneAlarm instead of throwing in kludges. Don't you know if > it's possible to disable this warning for an application or > a directory? Isn't there an md5 duplicate exploit now? :) More seriously, I don't use ZoneAlarm and hence have no idea if it is possible, but I also think configuring ZoneAlarm is a better fix (if it can be done). Else, would it be possible to LoadLibrary() the .exe and launch their main() this way? If needed, I guess we can generate .dll instead of .exe files for the tests... Of course, that's only if ZoneAlarm doesn't also check the files loaded via LoadLibrary(), but it might be useful. Vincent

Dec. 10, 2004

Re: Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg

by Robert Shearman

Erich Hoover wrote: > dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in > _copy_arg, this causes InstallShield to crash when attempting to > install the demo for "Prince of Persia: Warrior Within" (and probably > other InstallShield programs as well). Installation can complete with > this fix under Win9x w/ Desktop (2K and XP options still fail due to > "unimplemented function imagehlp.dll.StackWalk64" and non-Desktop > fails for unknown reason). It sounds like it is crashing further down the line. Using +seh debug flags will confirm or deny this. >------------------------------------------------------------------------ > >*** typelib.c 2004-12-09 21:09:07.000000000 -0700 >--- typelib.c.new 2004-12-09 21:18:10.202385336 -0700 >*************** >*** 4543,4550 **** > memcpy(argpos, &V_UNION(arg,lVal), 4); > hres = S_OK; > break; > default: >! FIXME("vt 0x%x -> TKIND_ENUM unhandled.\n",V_VT(arg)); > hres = E_FAIL; > break; > > > } >--- 4543,4554 ---- > memcpy(argpos, &V_UNION(arg,lVal), 4); > hres = S_OK; > break; >+ case VT_BYREF | VT_I4: >+ *argpos = V_UNION(arg,iVal); >+ hres = S_OK; >+ break; > default: >! FIXME("vt 0x%x 0x%x -> TKIND_ENUM unhandled.\n", V_VT(arg), VT_BYREF | VT_I4); > hres = E_FAIL; > break; > } > > Please generate patches using diff -u -p and send them to wine-patches. Rob

Dec. 10, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Ferenc Wagner

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Le ven 10/12/2004 à 07:26, Francois Gouget a écrit : >> On Fri, 10 Dec 2004, Ferenc Wagner wrote: >> >> > Francois Gouget <fgouget(a)free.fr> writes: >> [...] >> >> I've had some dealings with ZoneAlarm and I thought it >> >> also saved an md5 checksum of the executable. >> > >> > Yes, please clear this issue up for me! After some >> > discussion on IRC I almost started changing the code :) >> > Also, can't ZoneAlarm use wildcards perhaps? I couldn't >> > find out from the webpage... >> >> Well... this is not on a machine I have access to. What you could do is >> take an old verion of one of Wine's conformance tests (wininet should >> do) that accesses the net, run it and configure ZoneAlarm to let it >> through, then download a newer version and put it in exactly the same >> place and try again. I strongly suspect that ZoneAlarm is going to ask >> you again. > > Newer ZoneAlarm don't only warn on accessing the network but also on > launching unknown applications. So merely launching winetests (which > launches the other .exe itself via CreateProcess) will get the question > to let it run or not asked, in part because the path to the test changes > with each release (the temp dir name is random). Yes. But will sticking to a fixed directory name (and possibly file name) help, or does ZoneAlarm check eg. MD5 sums to thwart any countermeasure from our side? Anyway, I have the feeling that this should be solved by configuring ZoneAlarm instead of throwing in kludges. Don't you know if it's possible to disable this warning for an application or a directory? -- Feri.

Dec. 10, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Vincent Béron

Le ven 10/12/2004 à 07:26, Francois Gouget a écrit : > On Fri, 10 Dec 2004, Ferenc Wagner wrote: > > > Francois Gouget <fgouget(a)free.fr> writes: > [...] > >> I've had some dealings with ZoneAlarm and I thought it > >> also saved an md5 checksum of the executable. > > > > Yes, please clear this issue up for me! After some > > discussion on IRC I almost started changing the code :) > > Also, can't ZoneAlarm use wildcards perhaps? I couldn't > > find out from the webpage... > > Well... this is not on a machine I have access to. What you could do is > take an old verion of one of Wine's conformance tests (wininet should > do) that accesses the net, run it and configure ZoneAlarm to let it > through, then download a newer version and put it in exactly the same > place and try again. I strongly suspect that ZoneAlarm is going to ask > you again. Newer ZoneAlarm don't only warn on accessing the network but also on launching unknown applications. So merely launching winetests (which launches the other .exe itself via CreateProcess) will get the question to let it run or not asked, in part because the path to the test changes with each release (the temp dir name is random). Vincent

Dec. 10, 2004

Re: Includes [4] shlwapi

by Alexandre Julliard

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > Right, but the 16 bit header are non SDK headers. what I'm talking > about as the first step is removing SDK headers included from the non > SDK headers in include/. With your example of not removing winuser.h > since it will need to be added in again to the files that use the > private headers, I am suggesting removing the inclusion of winuser.h > from e.g. winpos.h and win.h, and including them in the files that > need them directly. It's the same issue, I took 16-bit headers as example but you can have the same problem with SDK headers, it's quite possible that a file doesn't need winuser.h by itself. So you would first have to move the includes out of the non-sdk header into the source files, and then once you get rid of the non-sdk header go back and remove the unneeded headers again. It's a lot easier to wait until the non-sdk header gets removed and then do everything in one step. -- Alexandre Julliard julliard(a)winehq.org

Dec. 10, 2004

Re: Visual studio 6 build fix.

by Alexandre Julliard

Rein Klazes <wijn(a)wanadoo.nl> writes: > @@ -210,7 +212,12 @@ static int set_process_console( struct p > if (process->create_flags & CREATE_NEW_CONSOLE) > { > /* let the process init do the allocation */ > - return 1; > + /* unless the startup info specifies to use */ > + /* the io handles in the startup info */ > + if( !info || !info->data || > + !((((RTL_USER_PROCESS_PARAMETERS *)info->data)->dwFlags) & > + STARTF_USESTDHANDLES)) > + return 1; The server must not know about the process parameters structure, the STARTF_USESTDHANDLES flag has to be handled on the client side. -- Alexandre Julliard julliard(a)winehq.org

Dec. 10, 2004

Re: Includes [4] shlwapi

by Jon Griffiths

Hi, > No, I don't think we want to do that in two steps, since we don't > want to add headers that are only needed to build a private header. > For instance many private headers still contain 16-bit stuff, and we > definitely don't want to start including Win16 headers all over the > place. Right, but the 16 bit header are non SDK headers. what I'm talking about as the first step is removing SDK headers included from the non SDK headers in include/. With your example of not removing winuser.h since it will need to be added in again to the files that use the private headers, I am suggesting removing the inclusion of winuser.h from e.g. winpos.h and win.h, and including them in the files that need them directly. If we hide the source files dependencies in header files its impossible to remove any uneeded dependencies from them. I'll post the script I'm using to clean up the headers and as the private headers are removed (or periodically) it can be run to weed out any uneeded dependencies remaining. In the meantime, I've updated my script to only remove headers that reduce a files dependencies and will be posting the revised patches shortly. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Jazz up your holiday email with celebrity designs. Learn more. http://celebrity.mail.yahoo.com

Dec. 10, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Francois Gouget

On Fri, 10 Dec 2004, Ferenc Wagner wrote: > Francois Gouget <fgouget(a)free.fr> writes: [...] >> I've had some dealings with ZoneAlarm and I thought it >> also saved an md5 checksum of the executable. > > Yes, please clear this issue up for me! After some > discussion on IRC I almost started changing the code :) > Also, can't ZoneAlarm use wildcards perhaps? I couldn't > find out from the webpage... Well... this is not on a machine I have access to. What you could do is take an old verion of one of Wine's conformance tests (wininet should do) that accesses the net, run it and configure ZoneAlarm to let it through, then download a newer version and put it in exactly the same place and try again. I strongly suspect that ZoneAlarm is going to ask you again. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ A particle is an irreducible representation of the Poincar\xE9 Group - Eugene Wigner

Dec. 10, 2004

Re: Fwd: Foobar2000 audio player Regression

by Paul van Schayck

Hey Rob, On Wed, 08 Dec 2004 17:08:03 -0600, Robert Shearman <rob(a)codeweavers.com> wrote: > The drawing issues look like a regression in the toolbar code. I'll take > a look. A regression test showed the "menu not being drawed" issue was caused by this patch: http://cvs.winehq.org/patch.py?id=14371 http://www.winehq.org/hypermail/wine-cvs/2004/10/0395.html Hope that helps you, Paul van Schayck

Dec. 10, 2004

Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg

by Erich Hoover

dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in _copy_arg, this causes InstallShield to crash when attempting to install the demo for "Prince of Persia: Warrior Within" (and probably other InstallShield programs as well). Installation can complete with this fix under Win9x w/ Desktop (2K and XP options still fail due to "unimplemented function imagehlp.dll.StackWalk64" and non-Desktop fails for unknown reason).

Dec. 9, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Ferenc Wagner

Francois Gouget <fgouget(a)free.fr> writes: > On Thu, 9 Dec 2004, Tero Tamminen wrote: > [...] >> So would it be possible to start all the tests from same >> directory (I mean, every version of the tests would start >> in same directory). It would save me some time because I >> wouldn't have to click through all the messages. > > I've had some dealings with ZoneAlarm and I thought it > also saved an md5 checksum of the executable. Yes, please clear this issue up for me! After some discussion on IRC I almost started changing the code :) Also, can't ZoneAlarm use wildcards perhaps? I couldn't find out from the webpage... -- Feri.

Dec. 9, 2004

Re: Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)

by Francois Gouget

On Thu, 9 Dec 2004, Tero Tamminen wrote: [...] > So would it be possible to start all the tests from same directory (I mean, > every version of the tests would start in same directory). It would save me > some time because I wouldn't have to click through all the messages. I've had some dealings with ZoneAlarm and I thought it also saved an md5 checksum of the executable. Otherwise it would be too easy for an application to pretend to be another one and gain access that way. And if a checksum is really used, then running the new tests in the same directory is not going to help. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

Dec. 9, 2004