December 2004 - Wine-Devel - list.winehq.org

Re: wine-preloader defunct

by James Hawkins

On Thu, 02 Dec 2004 20:01:48 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > I've now got several instances of "[wine-preloader] <defunct>" in my ps > listing from a game server that's died in some strange way. Anyone have > experience in clearing these short of bouncing the whole box? They're > holding onto a couple of TCP ports that I'd like to use. The ports are > stuck in CLOSE_WAIT, because the processes are stuck in memory so the > sockets can't close. > > Does 'kill -9 processnum' not work? -- James Hawkins

Dec. 2, 2004

wine-preloader defunct

by Kenneth Porter

I've now got several instances of "[wine-preloader] <defunct>" in my ps listing from a game server that's died in some strange way. Anyone have experience in clearing these short of bouncing the whole box? They're holding onto a couple of TCP ports that I'd like to use. The ports are stuck in CLOSE_WAIT, because the processes are stuck in memory so the sockets can't close.

Dec. 2, 2004

Re: Suggestions for fixing test?

by Dmitry Timoshkov

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > Well, I tried now marking the service as interactive, but that didn't > make any difference. > > So, what follows, deprecate Winrash? If it really breaks the tests then definitely yes. -- Dmitry.

Dec. 2, 2004

Re: shell32: reduce version to win2k

by Dmitry Timoshkov

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > I hope this removes the IE6 regression. No, it doesn't. It turned out that it's something different that causes a regression, lowering down version of shell32 changes nothing. It seems that a better solution is to add missing images to shell32. We need at least the following bitmaps to make IE display images on toolbars: id 230/231 - they are the same with different brightness, 20x20 1 image id 227/228 - they are the same with different brightness, 24x24 6 images id 204/205 - they are the same with different brightness, 24x24 16 images id 214/215 - they are the same with different brightness, 24x24 47 images id 240 - 22x22 50 vertical images (animated windows logo) -- Dmitry.

Dec. 2, 2004

Re: Suggestions for fixing test?

by Jakob Eriksson

Dmitry Timoshkov skrev: >"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > > > >>Yes, that's one way of course. But winrash is a service. Do you suggest we >>make it so winrash is no longer a service? >> >>What I want is not it merely make it _possible_ to run winetest with no >>red on: >> >>http://test.winehq.org/data/ >> >>I want the list to be all green! >> >>So, should we just stop using winrash or what? >> >> > >We already discussed this problem some time ago. The conclusion was to instruct >a tester to mark the service as interactive or run the tests manually. > > Yeah, that's right! Good thing you have a good memory when I come here whining. :-) Well, I tried now marking the service as interactive, but that didn't make any difference. So, what follows, deprecate Winrash? regards, Jakob

Dec. 2, 2004

RE: Treeview +/-

by Ge van Geldorp

> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this works for me. Thanks. Ge van Geldorp.

Dec. 2, 2004

Re: Wine book

by Brian Vincent

On Wed, 1 Dec 2004 20:57:09 +0100, Lionel Ulmer <lionel.ulmer(a)free.fr> wrote: > > 4. Installing Applications [35 pages] > [...] > > Using Native DirectX > > I was just wondering what would be convered by this particular topic. I don't know. I was totally hung over when I wrote all that. Just kidding. I remember Tom saying last year that native DirectX actually works under Wine. Maybe it's worth covering? Am I way off base? -Brian

Dec. 2, 2004

2nd attemp at DllCanUnloadNow

by James Hawkins

This time I respect heap-based objects, leaving there internal ref counts and respective HeapFree's. I also took Alexandre's suggestions and changed Un/LockServer to DMCOMPOS_LockServer etc and change cLocks to refCount. Let me know if this is any closer to what it needs to be. Thanks. -- James Hawkins

Dec. 2, 2004

Re: automatic tests screwed up again

by Ferenc Wagner

Paul Millar <paulm(a)astro.gla.ac.uk> writes: > All things being equal tomorrow's build (presuming they'll > be one) will include binaries that refer to themselves > correctly. Looks like you got it right. Thank you very much! -- Feri.

Dec. 2, 2004

Kernel 2.6.10... and amd64

by Jose Alberto Reguero

I can't use wine with kernels 2.6.10-rc2.... With kernel 2.6.9 it works. My system is an amd64 linux. Thanks. Jose Alberto

Dec. 2, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Steven Edwards

Hi, --- Alexandre Julliard <julliard(a)winehq.org> wrote: > Well, there's an IShellFolder interface, and it should probably be > doing something with that. In any case it should definitely be more > integrated into the shell way of doing things, there shouldn't be a > need for a whole new set of APIs. This needs more thought IMO... It can be done with only a little work as this guy even did it for Gmail <g> http://www.viksoe.dk/code/gmail.htm Rather than mapping the network filesystem as a shell folder we just need to the root of the Unix fs. It can't be too hard I guess but I MSDN documentation on how to do it sucks and I can't find any example code anywhere. I have been wanting to do this for a while for another project I am working on where I need to create a shell view of the NT Object Manager. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

Dec. 2, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Alexandre Julliard

Mike Hearn <mh(a)codeweavers.com> writes: > On Thu, 02 Dec 2004 15:19:27 +0900, Mike McCormack wrote: > > How about creating a new object class or interface to an existing object > > that exposes these interfaces? That way you won't need to export any > > extra functions from shell32. > > What's wrong with additional APIs? The browse folder API isn't COM based > anyway. Well, there's an IShellFolder interface, and it should probably be doing something with that. In any case it should definitely be more integrated into the shell way of doing things, there shouldn't be a need for a whole new set of APIs. This needs more thought IMO... -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Dmitry Timoshkov wrote: > > >Perhaps it would be better to prefix both a variable and lock/unlock > >interfaces with a module name, in this case "DEVENUM_" since they are > >global and externally visible. > > > > Do we still need to worry about that crap even though we don't link > directly to other DLLs anymore? We don't have to use separate names, but it's a good idea anyway, since it makes life easier with grep, winedbg, etags, etc. In any case, please don't make internal functions look like Windows APIs; if you don't want a DEVENUM_ prefix, then name it lock_module() or something like that. Also please change the "cLocks" name, that's really confusing ("what has a clock got to do with the ref count?"). -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2004

Re: IME window class update

by Ivan Leo Puoti

> You mean 65535, in which case it'd be 0xffff? Nope, just doubled checked and with the value is 65553, or 0x10011. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

Dec. 2, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Steven Edwards

--- Mike Hearn <mh(a)codeweavers.com> wrote: > What's wrong with additional APIs? The browse folder API isn't COM based > anyway. It would be much better to use the API provided to create a namespace for the Unix filesystem. The Control Panel and Network Neighborhood are good examples of this. Quite a few third party apps create a virtual namespace for things like CVS so I don't see why we can't work in the existing API to do this with the Unix fs. Thanks Steven __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

Dec. 2, 2004

Re: IME window class update

by Andreas Mohr

Hi, On Thu, Dec 02, 2004 at 04:38:39PM +0100, Ivan Leo Puoti wrote: > This patch is based on the IME window class implemented in windows 2000 and xp. > On both OSes hCursor is 65553, but I don't know what that is, maybe it's a > custom IME cursor? You mean 65535, in which case it'd be 0xffff? No idea what kind of cursor that is, but it looks like an invalid/unused one... Andreas Mohr

Dec. 2, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Mike Hearn

On Thu, 02 Dec 2004 15:19:27 +0900, Mike McCormack wrote: > How about creating a new object class or interface to an existing object > that exposes these interfaces? That way you won't need to export any > extra functions from shell32. What's wrong with additional APIs? The browse folder API isn't COM based anyway.

Dec. 2, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Mike Hearn

On Wed, 01 Dec 2004 21:41:42 -0600, Robert Shearman wrote: > Do we still need to worry about that crap even though we don't link > directly to other DLLs anymore? I don't think we do, winelib DLLs are linked using -Bsymbolic meaning global symbols internal to the library cannot be overridden by other libraries like you would be able to normally. If we still have problems with symbol interference we should apply a versioning script to suppress ELF exports. So I'd stick with just LockModule(). In fact the DLLNAME_ prefixes are quite ugly, maybe it should be a janitorial task to get rid of them. thanks -mike

Dec. 2, 2004

Re: attemp at implementing DllCanUnload now for dcompos

by Mike Hearn

On Wed, 01 Dec 2004 22:13:23 -0500, James Hawkins wrote: > ULONG WINAPI IDirectMusicChordMapImpl_IUnknown_AddRef (LPUNKNOWN iface) { > ICOM_THIS_MULTI(IDirectMusicChordMapImpl, UnknownVtbl, iface); > - TRACE("(%p): AddRef from %ld\n", This, This->ref); > - return ++(This->ref); > + TRACE("(%p): AddRef\n", This); > + > + LockModule(); > + > + return 2; /* non-heap based object */ > } What makes you think this is a non-heap object? Almost all COM objects are heap based except classfactories and process-wide singletons (internal to COM typically). In particular this one maintains its own ref count. You shouldn't be modifying the way objects to refcounting, you should just be adding the LockModule/UnlockModule calls.

Dec. 2, 2004

Re: systray rewrite part 2

by Mike Hearn

On Wed, 2004-12-01 at 21:37 +0100, Grant Williamson wrote: > err:systray:send_to_tray Could not start wineshell, error 0x2 Did you rerun autoconf + ./configure before doing a "make depend && make && make install" ? It seems you don't have the wineshell program installed.

Dec. 2, 2004

Re: Winecfg -> browse for folder

by Mike Hearn

On Wed, 2004-12-01 at 20:32 +0100, Robert van Herk wrote: > What do you mean? Does s/x/y/ mean that I should change x into y? Yep, it's from vi regex syntax. Rather obscure geek notation I agree ... > I did that, because the original code had some weird indentation and > didn't want to change that where possible. So I kept the weird > indentation where applicable. Overall, it gives it a bit a strange look, > I agree. OK, this is all a bit of a grey area. Generally when modifying existing code you want to keep the differential to a minimum so it's easy to review, so don't modify indentation/code style etc alongside functional changes. Patches which are functional no-ops and just clean up code are OK but they should be separate. When writing new code though don't feel obliged to be consistent with the oddness in the rest of the code. Choose a style and stick to it. The rest of the code can always be adjusted later. > Yes, this is the way MS intended SHBrowseForFolder to work, so I tried > to stay consistent: > > From > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…: OK. I can't say whether you're right or wrong to do this, I don't have a strong opinion either way. Consistency with existing APIs is good because we can recycle the MSDN documentation for it, but it's bad because to quote Alexandre "Win32 is a textbook case of how not to design an API". So I'll pass the buck on this one. AJ can decide. > Another solution would be to let the API indeed allocate the buffer, > though the user will have to free it, which he might forget more easily, > since he didn't do the allocation. Quite a lot of native APIs work this way, and I wouldn't say it's all that easy to forget. > Also, in the future, the pszDisplayName could perhaps be use to > preselect an entry, or, the way it works in win32, define the root of > the dialog. OK, that makes sense. So maybe keep it like that. thanks -mike

Dec. 2, 2004

Re: Suggestions for fixing test?

by Dmitry Timoshkov

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > Yes, that's one way of course. But winrash is a service. Do you suggest we > make it so winrash is no longer a service? > > What I want is not it merely make it _possible_ to run winetest with no > red on: > > http://test.winehq.org/data/ > > I want the list to be all green! > > So, should we just stop using winrash or what? We already discussed this problem some time ago. The conclusion was to instruct a tester to mark the service as interactive or run the tests manually. -- Dmitry.

Dec. 2, 2004

Re: Implement GetLayout

by Rémi Assailly

Shachar Shemesh a écrit : > Rémi Assailly wrote: > >> Shachar Shemesh wrote : >> >>> Thanks for spotting another one for my growing heap of BiDi TODOs.... >>> >>> http://bugs.winehq.org/show_bug.cgi?id=2584 >>> >>> Shachar >>> >> I know that there is no effect... > > > I'm sorry if I came off cynical. There was no cynicism in that > comment. I opened 2584 as a result of seeing your patch. I was not > aware of this particular missing functionality. > > I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the > ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a > good thing, as it documents things that are still to be done. > >> What is wrong ? > > > It seems that this flag reverses the meaning of several common > conventions (left/right etc.). The idea is probably so that > applications that are natively right to left not have to change their > design too much. > > I can't tell you exactly what it means, however, as I don't know > myself. It will probably be a matter of comparing behaviors to the > real Windows. I have some doubts about whether anyone is even using > this flag at all. Maybe on localized Hebrew Windows, where the whole > window decorations are reversed (Ughh. My GF has localized XP Home > installed. This thing is horrible, but I didn't spot any non-Windows > native applications that were affected by it). > >> Tell me and I will help you, if you want... > > > I'll gladly accept all the help I can get. Basically, this particular > unimplemented bit requires writing small test programs on Windows, and > then running them on Wine until they produce the same results. The > idea is that you read the MSDN page for the function (linked from the > bug). That page also links to > http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, > which gives more details on what this flag is supposed to mean. If you > check out 2584 again, you will see I added this new information there. > > The steps one takes is to read all the relevant manuals, and try to > understand what this means. Next, you write a small test program that > does stuff with and without this flag, showing where this flag takes > effect on Windows. Next, you move this test program to Wine and start > tweaking Wine until it behaves the same there. > > There is also a last step, which is to make this program into a test > suite, returning success or failure. I'm not sure, however, how that > is supposed to be done for programs where success and failure are > measured with graphical output. > > Hope this helps you help me help everyone..... :-) > > Shachar Sorry, I prefer that ;) What I wanted to know was if my implementation of GetLayout was correct before trying to implement SetLayout ( and add mirroring in all functions which need to check it ... ) or what was incorrect to fix it ! Okay, I will do what you advise me to do. I found that SetProcessDefaultLayout is not implemented, I think it will something like BOOL WINAPI SetProcessDefaultLayout( DWORD ); in winuser.h I will send a patch which include it and a stub implementation in windows/win.c then I write a program and try to implement mirroring support, how interesting... Rémi

Dec. 2, 2004

Re: Suggestions for fixing test?

by Jakob Eriksson

Dmitry Timoshkov wrote: >"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > > > >>http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt >> >> >>Any suggestions for fixing this? >> >> > >Run the tests from not a service? > > > Yes, that's one way of course. But winrash is a service. Do you suggest we make it so winrash is no longer a service? What I want is not it merely make it _possible_ to run winetest with no red on: http://test.winehq.org/data/ I want the list to be all green! So, should we just stop using winrash or what? regards, Jakob

Dec. 2, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

by Mike McCormack

Robert van Herk wrote: > Added functionality to browse for a UNIX folder. > This is done by making two new funtions in dlls/shell32/brsfolder.c, namely > wine_shell_browse_for_UNIX_directoryA > wine_shell_browse_for_UNIX_directoryW > These functions are exported in shlobj.h. How about creating a new object class or interface to an existing object that exposes these interfaces? That way you won't need to export any extra functions from shell32. Mike

Dec. 2, 2004

Re: visual studio 6 not happy?

by Dan Kegel

Jerry Geis wrote: > I am trying to use wine 12-01-04 release with Visual Studio. > I am getting the vcspawn error. Have you ever found a solution to that? > [http://www.winehq.com/hypermail/wine-devel/2003/02/0335.html] Nope. I didn't look very hard, though. > If not I am trying to use the command line nmake. I can export the make file > but how do I build it after that. I know 'wine nmake /f project.mak > CFG="project - Win32 Release"' but that > doesnt exactly do it. From what directory do you execute that? I did it > in the release directory. Have you read http://codingstyle.com/articles/using-ms-vcpp-with-gnu-wine.html ? It might explain that. I haven't really used nmake much, so I've forgotten how I ran it. I usually ignore the .mak file and just build things by hand, as described in http://kegel.com/wine/cl-howto.html, because I do such small things (Wine unit tests, mostly). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

Dec. 2, 2004

Re: [OLE #3] Tests For COM Functions

by Dmitry Timoshkov

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > Under Win95 the tests don't run due to missing APIs CoResumeClassObjects > and CoInitializeEx. Win98 results: marshal.c test doesn't run either, but this time due to missing kernel32.OpenThread; moniker.c tests pass. -- Dmitry.

Dec. 1, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Robert Shearman

Dmitry Timoshkov wrote: >"Robert Shearman" <rob(a)codeweavers.com> wrote: > > > >>>Perhaps it would be better to prefix both a variable and lock/unlock >>>interfaces with a module name, in this case "DEVENUM_" since they are >>>global and externally visible. >>> >>> >>> >>> >>Do we still need to worry about that crap even though we don't link >>directly to other DLLs anymore? >> >> > >That's not a crap in the ELF world, > It is because it makes loader performance suck and it makes us programmers have to worry about implementation details of other shared objects. Rob

Dec. 1, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > >Perhaps it would be better to prefix both a variable and lock/unlock > >interfaces with a module name, in this case "DEVENUM_" since they are > >global and externally visible. > > > > > > Do we still need to worry about that crap even though we don't link > directly to other DLLs anymore? That's not a crap in the ELF world, and I'm not sure whether Wine DLLs aren't affected by it. -- Dmitry.

Dec. 1, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Robert Shearman

Dmitry Timoshkov wrote: >"Robert Shearman" <rob(a)codeweavers.com> wrote: > > > >>-DWORD dll_ref = 0; >>+LONG cLocks; >> >> >... > > >>+/********************************************************************** >>+ * Dll lifetime tracking declaration >>+ */ >>+void LockModule() >>+{ >>+ InterlockedIncrement(&cLocks); >>+} >>+ >>+void UnlockModule() >>+{ >>+ InterlockedDecrement(&cLocks); >>+} >> >> > >Perhaps it would be better to prefix both a variable and lock/unlock >interfaces with a module name, in this case "DEVENUM_" since they are >global and externally visible. > > Do we still need to worry about that crap even though we don't link directly to other DLLs anymore? Rob

Dec. 1, 2004

Re: attemp at implementing DllCanUnload now for dcompos

by James Hawkins

On Wed, 01 Dec 2004 17:44:55 -0600, Robert Shearman <rob(a)codeweavers.com> wrote: > James Hawkins wrote: > > > > >Hey all, > > > >It would really help me out if you could look over this patch and see > >if I've incorrectly implemented ref-counting and DllCanUnloadNow for > >dcompos. I used suggestions from Rob and a sample implementation > >written by him. The only concern I have is that I'm not sure if all > >of these classes are non-heap based. > > > > > > > >------------------------------------------------------------------------ > > > >Index: dlls/dmcompos/chordmap.c > >=================================================================== > >RCS file: /home/wine/wine/dlls/dmcompos/chordmap.c,v > >retrieving revision 1.7 > >diff -u -r1.7 chordmap.c > >--- dlls/dmcompos/chordmap.c 23 Aug 2004 19:39:57 -0000 1.7 > >+++ dlls/dmcompos/chordmap.c 1 Dec 2004 21:15:24 -0000 > >@@ -54,18 +54,20 @@ > > > > ULONG WINAPI IDirectMusicChordMapImpl_IUnknown_AddRef (LPUNKNOWN iface) { > > ICOM_THIS_MULTI(IDirectMusicChordMapImpl, UnknownVtbl, iface); > >- TRACE("(%p): AddRef from %ld\n", This, This->ref); > >- return ++(This->ref); > >+ TRACE("(%p): AddRef\n", This); > >+ > >+ LockModule(); > >+ > >+ return 2; /* non-heap based object */ > > } > > > > ULONG WINAPI IDirectMusicChordMapImpl_IUnknown_Release (LPUNKNOWN iface) { > > ICOM_THIS_MULTI(IDirectMusicChordMapImpl, UnknownVtbl, iface); > >- ULONG ref = --This->ref; > >- TRACE("(%p): ReleaseRef to %ld\n", This, This->ref); > >- if (ref == 0) { > >- HeapFree(GetProcessHeap(), 0, This); > >- } > >- return ref; > >+ TRACE("(%p): ReleaseRef\n", This); > >+ > >+ UnlockModule(); > >+ > >+ return 1; /* non-heap based object */ > > } > > > > > > No, this isn't a non-heap based object. The code you removed actually > frees the object from the heap and further down in the file the > constructor "DMUSIC_CreateDirectMusicChordMapImpl" allocates it on the > heap. A sure sign of something being heap-based instead of non-heap > based is that it does stuff when its ref count goes to zero, as in the > case above. > > Rob > Here is the second go round at DllCanUnloadNow. I changed LockModule and UnlockModule to return the changed ref count. I use this to implement AddRef and Release for chordmaptrack. This is just an idea I had, so let me know if this works. -- James Hawkins

Dec. 1, 2004

Re: Suggestions for fixing test?

by Dmitry Timoshkov

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt > > > Any suggestions for fixing this? Run the tests from not a service? -- Dmitry.

Dec. 1, 2004

Re: [OLE #3] Tests For COM Functions

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned CO_E_SERVER_STOPPING instead of 0x80040154 Under Win95 the tests don't run due to missing APIs CoResumeClassObjects and CoInitializeEx. -- Dmitry.

Dec. 1, 2004

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > -DWORD dll_ref = 0; > +LONG cLocks; ... > +/********************************************************************** > + * Dll lifetime tracking declaration > + */ > +void LockModule() > +{ > + InterlockedIncrement(&cLocks); > +} > + > +void UnlockModule() > +{ > + InterlockedDecrement(&cLocks); > +} Perhaps it would be better to prefix both a variable and lock/unlock interfaces with a module name, in this case "DEVENUM_" since they are global and externally visible. -- Dmitry.

Dec. 1, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;

by Shachar Shemesh

Robert van Herk wrote: > So yes, I could put it all in a structure on the stack and then pass > it to the dlgproc, but it will only arrive there on WM_INITDIALOG. > However, I will also need the structure when the other messages come > in. So where do I save it then, if I cannot put it in a global var? Am > I missing something? > > Robert One option is to store it inside the dialog itself. Use "SetWindowsLong" to store the pointer. Just make sure that you pass the right parameter on to WM_INITDIALOG, and that you deallocate the struct (if it's allocated dynamically from the heap) before the window is destroyed (WM_DESTROY is a good bet). Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

Dec. 1, 2004

Re: attemp at implementing DllCanUnload now for dcompos

by Robert Shearman

James Hawkins wrote: >Hey all, > >It would really help me out if you could look over this patch and see >if I've incorrectly implemented ref-counting and DllCanUnloadNow for >dcompos. I used suggestions from Rob and a sample implementation >written by him. The only concern I have is that I'm not sure if all >of these classes are non-heap based. > > > >------------------------------------------------------------------------ > >Index: dlls/dmcompos/chordmap.c >=================================================================== >RCS file: /home/wine/wine/dlls/dmcompos/chordmap.c,v >retrieving revision 1.7 >diff -u -r1.7 chordmap.c >--- dlls/dmcompos/chordmap.c 23 Aug 2004 19:39:57 -0000 1.7 >+++ dlls/dmcompos/chordmap.c 1 Dec 2004 21:15:24 -0000 >@@ -54,18 +54,20 @@ > > ULONG WINAPI IDirectMusicChordMapImpl_IUnknown_AddRef (LPUNKNOWN iface) { > ICOM_THIS_MULTI(IDirectMusicChordMapImpl, UnknownVtbl, iface); >- TRACE("(%p): AddRef from %ld\n", This, This->ref); >- return ++(This->ref); >+ TRACE("(%p): AddRef\n", This); >+ >+ LockModule(); >+ >+ return 2; /* non-heap based object */ > } > > ULONG WINAPI IDirectMusicChordMapImpl_IUnknown_Release (LPUNKNOWN iface) { > ICOM_THIS_MULTI(IDirectMusicChordMapImpl, UnknownVtbl, iface); >- ULONG ref = --This->ref; >- TRACE("(%p): ReleaseRef to %ld\n", This, This->ref); >- if (ref == 0) { >- HeapFree(GetProcessHeap(), 0, This); >- } >- return ref; >+ TRACE("(%p): ReleaseRef\n", This); >+ >+ UnlockModule(); >+ >+ return 1; /* non-heap based object */ > } > > No, this isn't a non-heap based object. The code you removed actually frees the object from the heap and further down in the file the constructor "DMUSIC_CreateDirectMusicChordMapImpl" allocates it on the heap. A sure sign of something being heap-based instead of non-heap based is that it does stuff when its ref count goes to zero, as in the case above. Rob

Dec. 1, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;

by Robert van Herk

>However I can definitely see your point here but since the functions are >all internal to shell32 at this point and can accept any parameters you >may like, I would consider it a cleaner solution to allocate a structure >on the stack which contains such helper variables together with the pointer >to the user supplied BROWSEINFOA structure and pass its pointer as custom >long variable to the dialog procedure instead of lpbi only. > > There is something I don't understand though. According to msdn: INT_PTR DialogBoxParam( HINSTANCE hInstance, LPCTSTR lpTemplateName, HWND hWndParent, DLGPROC lpDialogFunc, LPARAM dwInitParam ); dwInitParam [in] Specifies the value to pass to the dialog box in the lParam parameter of the WM_INITDIALOG message. So yes, I could put it all in a structure on the stack and then pass it to the dlgproc, but it will only arrive there on WM_INITDIALOG. However, I will also need the structure when the other messages come in. So where do I save it then, if I cannot put it in a global var? Am I missing something? Robert

Dec. 1, 2004

MAP_ANON support on HPUX

by Warren_Baird/CSI＠cimmetry.com

Hi All, I've just discovered that HP-UX's mmap implementation doesn't define MAP_ANON, it only defines MAP_ANONYMOUS. linux defined both, as does solaris (and solaris's manpage actually states that MAP_ANON is deprecated), but MacOS X seems to only define MAP_ANON MAP_ANON is only used in two source files: libs/wine/mmap.c and loader/preloader.c. My proposed patch involves slightly different changes in both places : in mmap.c, I just add a new #elif to handle the case, and in preloader.c I add a #ifdef block at the top to define MAP_ANON to be MAP_ANONYMOUS if MAP_ANON is undefined, but MAP_ANONYMOUS is defined. The other possible solution would be to put the #ifdef block from preloader.c into a common header... It's not obvious to me where to put it, though, which is why I'm proposing this patch. Should I rework it to use a common header? If so - any suggestions as to which header would be appropriate? Thanks, Warren

Dec. 1, 2004

Re: Bugzilla in CVS

by Dimitrie O. Paun

On Wed, Dec 01, 2004 at 04:51:35PM -0600, Jeremy Newman wrote: > http://cvs.winehq.org/cvsweb/bugzilla/ > > I have imported our buzilla into CVS for anyone to start submitting > patches on. If I remember correctly, it is a fairly straight branch of > version 2.17.4. All I modified was the templates in: > /template/en/default/global You should have set up a vendor branch with a pristine 2.17.4, so we can track the upstream Bugzilla, and track what we change. -- Dimi

Dec. 1, 2004

Bugzilla in CVS

by Jeremy Newman

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

Dec. 1, 2004

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;

by Robert van Herk

Rolf Kalbermatter wrote: >Robert van Herk wrote: > > > >>I guess you are right, but the strange thing is that this was already >>the case in the original code. The hwnd of the tree view and the >>pointer to the browseinfo structure are copied into a global variable, >>so at least my code is not worse here :-). >> >> > >Well, existing code doesn't necessarily need to be a nice and clean >implementation as it may have been at some point more important to get >anything workable into the CVS tree than having nothing at all. > > > >>By the way, isn't it so that a copy of shell32.dll gets loaded for each >>application anyway? If so, then the variable is at least application >>local, and, c'mon, who is going to show two modal browsing dialog boxes >>at the same time :-)? >> >> > >I'm not sure if the shell32 dll is really loaded multiple times in Windows. > >However I can definitely see your point here but since the functions are >all internal to shell32 at this point and can accept any parameters you >may like, I would consider it a cleaner solution to allocate a structure >on the stack which contains such helper variables together with the pointer >to the user supplied BROWSEINFOA structure and pass its pointer as custom >long variable to the dialog procedure instead of lpbi only. > > Aaaaaaaaah <<little light bulb>>. You see, I have been spoiled with Java :-) and never thought of that solution. But it is much better, you're right. I will put it in the new version of the patch. Thanks, Robert

Dec. 1, 2004

Fwd: Re: Bug Busters

by Peter Hartshorn

May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <adam(a)nemesys.ca> wrote: > > James Hawkins wrote: > > > I have a totally non-original idea for sessions called Bug Busters > > > where, at a designated time, a group of wine developers would get > > > together on #winehackers (or some other channel). We would pick a bug > > > (or maybe more) from wine's bug tracker and work together to fix the > > > bug(s). This would serve several good purposed. First, we would be > > > giving more attention to wine's bugzilla and getting rid of a lot of > > > those bugs. Second, many newcomers can witness and take part in the > > > wine development process. I'm sure everyone can remember how daunting > > > it is to jump into wine development. Anyway, if anyone has any ideas > > > or would like to take part in this, let me know and we'll get this > > > started. > > > > This is a good idea, same idea as Gentoo Bug Days, and those have been > > extremely successful. > > Awesome, I think it could be really successful with wine too. -------------------------------------------------------

Dec. 1, 2004

RE: <<PATCH>> Added shell32.dll functions to browse for unix directory;

by Rolf Kalbermatter

Robert van Herk wrote: > I guess you are right, but the strange thing is that this was already > the case in the original code. The hwnd of the tree view and the > pointer to the browseinfo structure are copied into a global variable, > so at least my code is not worse here :-). Well, existing code doesn't necessarily need to be a nice and clean implementation as it may have been at some point more important to get anything workable into the CVS tree than having nothing at all. > By the way, isn't it so that a copy of shell32.dll gets loaded for each > application anyway? If so, then the variable is at least application > local, and, c'mon, who is going to show two modal browsing dialog boxes > at the same time :-)? I'm not sure if the shell32 dll is really loaded multiple times in Windows. However I can definitely see your point here but since the functions are all internal to shell32 at this point and can accept any parameters you may like, I would consider it a cleaner solution to allocate a structure on the stack which contains such helper variables together with the pointer to the user supplied BROWSEINFOA structure and pass its pointer as custom long variable to the dialog procedure instead of lpbi only. In the end it mist probably wouldn't really matter for practical use since it is a modal dialog, but who knows who is going to extend on that API at some point and stumbling over this. Rolf Kalbermatter

Dec. 1, 2004

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table

by Jeremy Newman

This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Changed: include/sidebar_admin.php include/util.php > > > Index: include/sidebar_admin.php > =================================================================== > RCS file: /home/wine/appdb/include/sidebar_admin.php,v > retrieving revision 1.4 > diff -u -r1.4 sidebar_admin.php > --- include/sidebar_admin.php 10 Nov 2004 16:36:25 -0000 1.4 > +++ include/sidebar_admin.php 21 Nov 2004 07:50:43 -0000 > @@ -19,7 +19,7 @@ > $g->add("List Users", $apidb_root."admin/"); > $g->add("View App Queue (".getQueuedAppCount().")", $apidb_root."admin/adminAppQueue.php"); > $g->add("View Maintainer Queue (".getQueuedMaintainerCount().")", $apidb_root."admin/adminMaintainerQueue.php"); > - $g->add("View Maintainers", $apidb_root."admin/adminMaintainers.php"); > + $g->add("View Maintainers (".getMaintainerCount().")", $apidb_root."admin/adminMaintainers.php"); > $g->done(); > > } > Index: include/util.php > =================================================================== > RCS file: /home/wine/appdb/include/util.php,v > retrieving revision 1.4 > diff -u -r1.4 util.php > --- include/util.php 9 Nov 2004 22:51:38 -0000 1.4 > +++ include/util.php 21 Nov 2004 07:50:43 -0000 > @@ -189,4 +189,13 @@ > return $ob->queued_maintainers; > } > > +/* get the total number of maintainers and applications in the appMaintainers table */ > +function getMaintainerCount() > +{ > + $qstring = "SELECT count(*) as maintainers FROM appMaintainers"; > + $result = mysql_query($qstring); > + $ob = mysql_fetch_object($result); > + return $ob->maintainers; > +} > + > ?> > > > >

Dec. 1, 2004

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does

by pvriens＠xs4all.nl

Hi, just wanted to mention the fact that after this fix, my ZooTycoon demo installs like a charm. It doesn't run yet, but I will look into this and hopefully come up with some answers/patches. I guess several Microsoft Game Installers will work as well now. Good stuff. Cheers, Paul Vriens.

Dec. 1, 2004

Re: systray rewrite part 2

by Grant Williamson

Mike, does this help any? Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:crypt:CRYPT_VerifyImage (rsaenh.dll, 0x77e2a488): not verifying image fixme:crypt:CRYPT_LoadProvider Failed to load dll "rsaenh.dll" fixme:iphlpapi:NotifyAddrChange :stub trace:systray:send_to_tray message=0 trace:systray:send_to_tray iconsize = 2208, icon = 0x12b6 trace:systray:send_to_tray No tray window found, starting wineshell err:systray:send_to_tray Could not start wineshell, error 0x2 Mike Hearn wrote: >On Tue, 30 Nov 2004 19:14:15 +0100, Grant Williamson wrote: > > >>Mike, >> ok the rewrite, applies & compiles cleanly on 20041019, however, >>running SIP Phone-lite, it does not show on the systray, the older >>patch did. >>I am running gnome-2.8 on rhel4, what program do you want us to test >>with it. >> >> > >Can you post a +systray trace please? > >I tested this with the CoolTrayTest demo program, but the XEMBED docking >code is ridiculously race prone and flaky. It doesn't surprise me at all >you don't see anything. > >What may have happened is that it did dock but GNOME assigned it a 1pixel >width area. Last time I talked to Anders about this he seemed to think it >was a bug in the EggTrayManager code, but it never seems to show up with >native apps so presumably we could hack around it in Wine. > >thanks -mike > > > >

Dec. 1, 2004

attemp at implementing DllCanUnload now for dcompos

by James Hawkins

Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if all of these classes are non-heap based. -- James Hawkins

Dec. 1, 2004

Re: gdi/mfdrv BS_PATTERN brushes

by Walt Ogburn

Hi Huw, You're right, it's a META_DIBCREATEPATERNBRUSH under XP at least. I think I understand this better now. I'll hold off on the patch and try to write some tests. I don't think there's any easy way to fix the problems in the current code without changing it to META_CREATEPATTERNBRUSH. Thanks. Walter On Tue, 30 Nov 2004, Huw D M Davies wrote: > On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > > problem. With this patch BS_PATTERN brushes get created correctly and > > don't cause a locking problem. > > > > Changelog: > > Fix creation of BS_PATTERN brushes in mfdrv > > > > > > Index: dlls/gdi/mfdrv/objects.c > > =================================================================== > > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > > retrieving revision 1.14 > > diff -u -r1.14 objects.c > > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > > > > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > > + mr->rdFunction = META_CREATEPATTERNBRUSH; > > Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record > under Windows? > > Huw. > -- > Huw Davies > huw(a)codeweavers.com >

Dec. 1, 2004

Re: Wine book

by Lionel Ulmer

> 4. Installing Applications [35 pages] [...] > Using Native DirectX I was just wondering what would be convered by this particular topic. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Dec. 1, 2004

Re: Winecfg -> browse for folder

by Robert van Herk

Hi Mike, I have some questions about your comments: >>@@ -46,7 +48,8 @@ >> shpolicy.c \ >> shv_bg_cmenu.c \ >> shv_item_cmenu.c \ >>- systray.c >>+ systray.c \ >>+ unixTools.c >> >> > >s/unixTools.c/unix_tools.c/ for consistency > > What do you mean? Does s/x/y/ mean that I should change x into y? >Also consistent indentation would be good. > > I did that, because the original code had some weird indentation and didn't want to change that where possible. So I kept the weird indentation where applicable. Overall, it gives it a bit a strange look, I agree. >+ /*For UNIX browsing, we always use the pszDiplayName to RETURN >+ the chosen path in, thus:*/ >+ if (!lpbi->pszDisplayName) >+ { >+ ERR("pszDisplayName must be set for UNIX browsing.\n"); >+ return FALSE; >+ } > >How does this work? Is the pszDisplayName pointing to a preallocated >buffer (if so how do you know how big it should be?). > > Yes, this is the way MS intended SHBrowseForFolder to work, so I tried to stay consistent: >From http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…: *pszDisplayName* Address of a buffer to receive the display name of the folder selected by the user. The size of this buffer is assumed to be MAX_PATH characters. Of course, MAX_PATH might be different from the UNIX max path constant, though I am hoping to get away with that :-). When I copy the resulting path back into pszDisplayName, I truncate at MAX_PATH, just to be sure. Another solution would be to let the API indeed allocate the buffer, though the user will have to free it, which he might forget more easily, since he didn't do the allocation. > > >>+ bi->hwndOwner = dialog; >>+ bi->pszDisplayName = HeapAlloc(GetProcessHeap(), 0, MAX_PATH); >>+ bi->lpszTitle = "Please choose a directory"; /*FIXME: Get this multilingual*/ >> >> > >Oh, I see. This is a rather unintuitive API design, why not simply return >the path or have a char ** out parameter instead of setting the input >structure? > > See above. Also, in the future, the pszDisplayName could perhaps be use to preselect an entry, or, the way it works in win32, define the root of the dialog. Robert

Dec. 1, 2004