December 2004 - Wine-Devel - list.winehq.org

Re: Get rid of DPRINTF in winedos

by Dimitrie O. Paun

On Thu, Dec 30, 2004 at 12:22:18PM +0100, Diego 'Flameeyes' Pettenò wrote: > Hi, > The attached patch replaces DPRINTF -> TRACE in winedos dll, joining the near > DPRINTF used to tace dos interrupts. This looks good, but do we still need the explicit 'if (TRACE_ON(relay))'? I think we can use the explicit one from TRACE(), no? -- Dimi.

Dec. 30, 2004

Re: Get rid of DPRINTF in x11drv/opengl.c

by Dimitrie O. Paun

On Thu, Dec 30, 2004 at 12:04:23PM +0100, Diego 'Flameeyes' Pettenò wrote: > I had some spare time, and I wanted to do some mostly non-designing code, so I > took the time to look at wine's janitorial projects, and I took a look at the > DPRINTF -> TRACE conversion. > > The attached patch removes DPRINTFs from x11drv/opengl.c (which is the only > file in x11drv which uses them), and replacing the 6 different following > calls with a single call for bits and buffer counters. This is a good project to work on, but the reason it's not done yet it's because it is not a simple replacement of DPRINTF with TRACE. Doing stuff like: + TRACE(" - size / version : %d / %d\n", ppfd->nSize, ppfd->nVersion); + TRACE(" - dwFlags : "); Will not work correctly in a multitreaded environment, where the lines may get intertwinded on output with statements from other threads. The way to do it is to prepare the output in a memory buffer, and output it at once. This can be done with the wine_dbg_sprintf() function. In cases where you need logic to construct the output (like testing for flags, etc), you can do it by first printing to a local buffer, and then printing the content of the buffer to a debug buffer via wine_dbg_sprintf(). A simple example of this technique can be found in the dlls/kernel/locale.c file, in the debugstr_lang() function. -- Dimi. -- Dimi.

Dec. 30, 2004

Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation

by Mike Hearn

On Thu, 30 Dec 2004 15:25:20 +0100, Michael Stefaniuc wrote: > Now i get the stupid "make the whole display black" Quicktime thingy That's a bug in DirectDraw, we have a bad hack in CrossOver for it but it needs to be fixed properly. Word on the street is that we need an implementation of the DirectDraw clipper, but I have no idea if that's correct or if so, how much of it we need. thanks -mike

Dec. 30, 2004

Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation

by Michael Stefaniuc

Eric Pouech wrote: >> Is anyone still looking into this? >> >> I'm seeing the same problem here (below messages repeated and 100% CPU >> usage) >> on RH 9 with the direct sound regression test and some games. > > does this (new) patch help ? Well, i don't know if it fixes their problem but at least it makes Quicktime stop looping (wineserver and a wine-preloader process are maxing out the CPU) for me. Now i get the stupid "make the whole display black" Quicktime thingy and then it crashes: wine: Unhandled exception (thread 001d), starting debugger... WineDbg starting on pid 0x1c Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00000000 ESP:7791fdd5 EBP:7791fe34 EFLAGS:00010202( - 00 - -RI1) EAX:6e4f8a00 EBX:00000000 ECX:00000000 EDX:77c86284 ESI:7791fe58 EDI:7791fdf5 Stack dump: 0x7791fdd5: 6e31fbec 00000000 06000000 00000002 0x7791fde5: 7174696d 7791feb0 0046d24e 00000000 0x7791fdf5: bb7791fe 0077c511 00030000 05000000 0x7791fe05: 00c00000 00004000 1f000000 00000000 0x7791fe15: 00000000 f8030000 b97791fd 947791f9 0x7791fe25: 587791fe 686e35c6 006e43ad a0000000 Backtrace: =>1 0x00000000 (0x7791fe34) 2 0x00448e51err:dbghelp_msc:pdb_process_internal -Unable to peruse .PDB file C:\qtml\buildresults\nosym\QuickTimePlayer.pdb in quicktimeplayer (+0x48e51) (0x7791fea0) 3 0x0046d32e EntryPoint+0xe0 in quicktimeplayer (0x7791ff2c) 4 0x77baf49b start_process+0xc3(arg=0x0) [/home/michi/work/wine/dlls/kernel/process.c:1046] in kernel32 (0x7791fff4) 5 0xb7fcb69d wine_pthread_abort_thread+0x29(status=0x0) [/home/michi/work/wine/libs/wine/port.c:85] in libwine.so.1 (0x00000000) 0x00000000: addb %al,0x0(%eax) Wine-dbg> Hope this helps (if it's related). bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Dec. 30, 2004

Re: another build problem on current cvs

by Ferenc Wagner

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Le mer 29/12/2004 à 05:38, Joris Huizer a écrit : > >> In debian the package is called libasound2-dev, version >> "0.9.0beta10.9.0beta1" which should be the 0.9 branch of alsa > > Either update to alsa 1.0, downgrade Wine to prior > 20040505, or switch to the wineoss driver. For Debian stable I've got some unofficial ALSA packages (among others) at http://afavant.elte.hu/~wferi/debian/ which may come handy. -- Feri.

Dec. 30, 2004

Re: ptrace single-stepping change breaks Wine

by Mike Hearn

On Thu, 2004-12-30 at 11:09 +0100, Thomas Sailer wrote: > On Wed, 2004-12-29 at 20:15 -0800, Andrew Morton wrote: > > You can globally disable flex-mmap with > > > > echo 1 > /proc/sys/vm/legacy_va_layout > > > > Does it fix things? > > Haven't tried. But setarch i386 -L /usr/bin/wine ... did fix it. > > Tom Tom, does this patch against Wine help? It should do the same thing as the setarch program, so if that fixes it then this should also (if I've understood how this mechanism works of course). Mike Hearn <mh(a)codeweavers.com> Set the Linux ABI personality to get a legacy VM layout

Dec. 30, 2004

NLS/IME functions

by Diego 'Flameeyes' Pettenò

Hi, I'm still trying to figure out how nls/ime functions are placed in windows systems to fix up the patch I sent some days ago. I haven't had the time to find out if YuGiOh calls GetProcAddress (because isn't mine, it's of a friend of mine which is trying to get it working, so I need him to test), so I'm fooling around checking for a way to fix this up. At least Win98's and Win2k's user32.dll have the functions defined into winnls32.h, also if they are defined as compatibility with winnt3. At the moment on wine these functions are commented out also as stubs so they are completely missing. On Windows I'm not able to find a winnls32.dll which is instead present on wine, and seems to define similar functions (but they are quite all spec-stubs, but three functions which are defined (stubbing), without a STUB trace. How should be this done? Implement stub-functions for every nls/ime function? Or simply ignore them for now? Thanks for the time, -- Diego "Flameeyes" Pettenò flameeyes(a)users.berlios.de - http://flameeyes.web.ctonet.it/

Dec. 30, 2004

Re: ptrace single-stepping change breaks Wine

by Mike Hearn

On Wed, 2004-12-29 at 18:10 -0800, Linus Torvalds wrote: > Some wine person would need to inform us about what the seh exception > thing means.. "code c0000005"? STATUS_ACCESS_VIOLATION, or the Win32 equivalent of a segfault. It would appear that the ptrace changes are not responsible here, though if changing the kernel really does change this crash then maybe there is another issue we haven't uncovered yet. thanks -mike

Dec. 30, 2004

Re: ptrace single-stepping change breaks Wine

by Thomas Sailer

On Wed, 2004-12-29 at 20:15 -0800, Andrew Morton wrote: > You can globally disable flex-mmap with > > echo 1 > /proc/sys/vm/legacy_va_layout > > Does it fix things? Haven't tried. But setarch i386 -L /usr/bin/wine ... did fix it. Tom

Dec. 30, 2004

Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation

by Eric Pouech

> Is anyone still looking into this? > > I'm seeing the same problem here (below messages repeated and 100% CPU > usage) > on RH 9 with the direct sound regression test and some games. does this (new) patch help ? A+

Dec. 30, 2004