February 2004 - Wine-Devel - list.winehq.org

Re: implement fixme in CreateAcceleratorTable

by Pabs

On Sat, 2004-02-28 at 09:46, Dmitry Timoshkov wrote: > "Pabs" <pabs3(a)bonedaddy.net> wrote: > > > ChangeLog > > > > Added some checks to CreateAcceleratorTableA/W (removes fixmes) > > IMO it's better to use > > if (!MapVirtualKeyW(lpaccel[i].key, 0)) > { > WARN("Invalid VK\n"); > SetLastError(ERROR_INVALID_PARAMETER); > return NULL; > } > > for a check whether VK is a valid one. This being the first time I have looked at the wine source code I didn't think of that. I agree, this is a better idea. It would be interesting to know how windows does it though. -- Bye, Pabs

Feb. 28, 2004

Re: implement fixme in CreateAcceleratorTable

by Dmitry Timoshkov

"Pabs" <pabs3(a)bonedaddy.net> wrote: > ChangeLog > > Added some checks to CreateAcceleratorTableA/W (removes fixmes) IMO it's better to use if (!MapVirtualKeyW(lpaccel[i].key, 0)) { WARN("Invalid VK\n"); SetLastError(ERROR_INVALID_PARAMETER); return NULL; } for a check whether VK is a valid one. -- Dmitry.

Feb. 28, 2004

RE: Authors.c Won't Compile

by Robert Shearman

Hans Leidekker wrote: > On Friday 27 February 2004 14:21, Robert Shearman wrote: > > > > > $ LC_ALL=C sed -e '1,2d' -e 's/$.*$/ \"\1\",/' ../../AUTHORS > > > | grep Ove > > > > "Ove K\x{FFFF}ven", > > I'm lost as to where the \x{FFFF} comes from (is it grep?), but as > such this looks like a valid C string. So it should compile if this > is the literal source we're seeing. Or could it be that your terminal > inserts the \x{FFFF}? Anyone else have a clue? It comes from pasting the lines into my mail program. > To exclude grep, are there any \x{FFFF}s when you do: > > $ cat authors.c No, there are just blanks spaces where the characters should be. Rob

Feb. 27, 2004

Re: catching first chance exception question

by Eric Pouech

Robert Reif a écrit : > I'm looking at how windows deals with invalid > parameters in some of the winmm functions and > it raises some questions. Sometimes they will check > the parameters and return an error code and > sometimes they will let a bad parameter cause > a first-chance exception and catch it and return > an error code. > > Is it ok to do a simple NULL pointer check and return an > error rather than letting it cause an exception and catching > it? If not, what's the best way to catch the exception and > return the proper error code? the normal rule of thumbs is: - don't use exception unless you have to (ie, we have a clear case of an application requiring that feature) => first implementation should be only based on NULL pointer testing - if you need to go further, then setting an exception handler is the thing to do (using IsBadReadPtr or IsBadWritePtr is a not 100% safe, especially in multi-threaded environments) A+

Feb. 27, 2004

Sibelius 2

by Andrew L. Bereson

Sibelius is an app for scoring music. Sibelius 1 runs fine with wine. Sibelius 2 crashes on startup. When it crashes there is no useful message, only "Unhandled exception". Using winedbg I have found that Sibelius appears to be following a NULL pointer. I haven't yet managed to track down where it's getting the bad pointer from... any suggestions would be appreciated. I've got some time and energy to try to make this work, but first... Has anyone else worked or is some else currently working on this? What did you find? How far did you get? -- Andrew L. Bereson bereson(a)sea-ware.com (800)307-5754

Feb. 27, 2004

Re: build: avoid Unix file on MinGW

by Lionel Ulmer

On Fri, Feb 27, 2004 at 09:19:08AM -0500, Dimitrie O. Paun wrote: > BTW, why do we need the {GLU32,GLUT32,OPENGL}FILES cases? > Should those just be listed under X files? And shouldn't > we just build those, and dload() the Unix libs at run time? We need these special cases as an user can have X installed but not GLU / GLUT or OpenGL. And as to why we cannot dload the Unix lib at run time, it would be a bit like 'why do we not build the X11DRV library all the time and dlsym all the X11 symbols'. Basically, if you do not have OpenGL installed, there is no way you will be able to get Wine's OpenGL library to run. So there is no point to offer some special 'dlopen' magic to be able to load it on these boxes. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Feb. 27, 2004

Re: winemaker: use winegcc

by Dimitrie O. Paun

On Fri, 27 Feb 2004, Francois Gouget wrote: > Does winegcc systematically link applications and dlls to advapi32, > comdlg32, etc? How does one do if one does not want to link with gdi32 > for instance? Yes, it does, those are the defaults for MinGW. More specifically, all apps are linked by default against these DLLs: advapi32 user32 kernel32 additionally, GUI apps are also linked against: shell32 comdlg32 gdi32 If you don't want these defaults, you specify the -nodefaultlibs on the command line. -- Dimi.

Feb. 27, 2004

Re: Authors.c Won't Compile

by Hans Leidekker

On Friday 27 February 2004 14:21, Robert Shearman wrote: > > > $ LC_ALL=C sed -e '1,2d' -e 's/$.*$/ \"\1\",/' ../../AUTHORS > > | grep Ove > > > "Ove K\x{FFFF}ven", I'm lost as to where the \x{FFFF} comes from (is it grep?), but as such this looks like a valid C string. So it should compile if this is the literal source we're seeing. Or could it be that your terminal inserts the \x{FFFF}? Anyone else have a clue? To exclude grep, are there any \x{FFFF}s when you do: $ cat authors.c -Hans

Feb. 27, 2004

Re: winemaker: use winegcc

by Francois Gouget

On Fri, 27 Feb 2004, Dimitrie O. Paun wrote: [...] > @@ -801,7 +753,7 @@ > $basename=~ s/\.(dll|exe)$//i; > # This is the default link list of Visual Studio, except odbccp32 > # which we don't have in Wine. > - my @std_imports=qw(advapi32 comdlg32 gdi32 kernel32 odbc32 ole32 oleaut32 shell32 user32 winspool); > + my @std_imports=qw(odbc32 ole32 oleaut32 winspool); > my @std_libraries=qw(uuid); Does winegcc systematically link applications and dlls to advapi32, comdlg32, etc? How does one do if one does not want to link with gdi32 for instance? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

Feb. 27, 2004

RE: Authors.c Won't Compile

by Robert Shearman

Hans Leidekker wrote: > On Friday 27 February 2004 13:07, Robert Shearman wrote: > > > $ echo $LANG > > en_GB.UTF-8 > > > > $ echo $LC_ALL > > > > $ LC_ALL=C sed -e '1,2d' -e 's/$.*$/ \"\1\",/' ../../AUTHORS > | grep Ove > > "Ove K\x{FFFF}ven", > > > > $ sed -e '1,2d' -e 's/$.*$/ \"\1\",/' ../../AUTHORS | grep Ove > > "Ove K",\x{FFFF}ven > > Right, my orignal patch to fix this did LANG=C before the sed. Alexandre > changed this to LC_ALL=C recently, probably to get C sorting > order as well. > > When I use your settings I can't reproduce what you get (I have sed 4.0.8 > on Fedora Core 2 test 1). What does it say when you do this: > > $ LANG=C sed -e '1,2d' -e 's/$.*$/ \"\1\",/' ../../AUTHORS | grep Ove "Ove K\x{FFFF}ven", Rob > > -Hans >

Feb. 27, 2004