June 2004 - Wine-Devel - list.winehq.org

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by Nicolai Kuntze

Is it possible that you got confused with the wine versions? I think you have permuted the names of your uploaded pictures .... Maybe I am wrong. Am 25.06.2004 um 18:31 schrieb Gabriele Giorgetti: > Hello, I've noticed a problem with scrollbars in the > latest Wine's release (20040615). With wine version > 20040505 everything was just fine. > > I've attacched a zip file with two screenshots > (pls. see wine BUG #2314 @ bugs.winehq.org ) > the first one is the correct behavior of the app using > wine 20040505 the second one is wine 20040615 and the > app in its wrong behavior. > > Trying to describe the problem: > The application show up with a bottom scrollbar and > a right scrollbar even if they are not needed. When > executing the very same application, with the very > same settings and size with wine 20040505 the scrollbars > are not there. > > I hope you get it > > Thanks. > > NB: BUG #2314 at bugs.winehq.org > > > > ---- Diese Nachricht wurde auf Viren und andere gefaehrliche Inhalte sowie Spam untersucht.

June 29, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by Nicolai Kuntze

Am 29.06.2004 um 09:20 schrieb George Marshall: > Gabriele Giorgetti wrote: > > <snip> > >> Trying to describe the problem: >> The application show up with a bottom scrollbar and >> a right scrollbar even if they are not needed. When >> executing the very same application, with the very >> same settings and size with wine 20040505 the scrollbars >> are not there. > > I've also noticed that some unresizable windows are drawn > with the scrollbars. > > > Me too. I submitted the bug as 2302 and added a demo application for download from a web server. ---- Diese Nachricht wurde auf Viren und andere gefaehrliche Inhalte sowie Spam untersucht.

June 29, 2004

Temporary moderator needed

by Duane Clark

Howdy, Someone is needed for the period June 30-July 5 to handle moderation of the Wine lists. If you are willing to do it, please email me off list. Thanks.

June 29, 2004

Re: Missing declaration for MSVCRT_div_t and MSVCRT_ldiv_t

by Dimitrie O. Paun

On Tue, Jun 29, 2004 at 01:27:23PM +0200, Pierre d'Herbemont wrote: > Hi! > > On non-i386 we have to define MSVCRT_div_t and MSVCRT_ldiv_t. Please also add the appropriate tests to tests/headers.c. -- Dimi.

June 29, 2004

Re: A wine magic trace key

by Andrei Barbu

Thanks, Why doesn't this get committed to the main tree? It'd help developers, and wouldn't hurt anyone else. If they don't want it they can just not set the environment variable. Andrei On Tue, 2004-06-29 at 09:59, Mike Hearn wrote: > On Tue, 29 Jun 2004 12:02:26 -0400, Andrei Barbu wrote: > > Is there another way, possibly existing, to do this? > > Is this a really bad idea? > > I already implemented this some time ago. You'll need to use > -p1 to patch. To use it set WINEDELAY=1 in the environment. You can then toggle > tracing with the F12 key - it starts as being off. > > thanks -mike > > > --- orig/dlls/ntdll/debugtools.c > +++ mod/dlls/ntdll/debugtools.c > @@ -244,6 +244,7 @@ > return res; > } > > + > /*********************************************************************** > * NTDLL_dbg_vprintf > */ > @@ -300,7 +301,7 @@ > ret += wine_dbg_printf( "%s:%s:%s ", classes[cls], channel + 1, function ); > } > if (format) > - ret += NTDLL_dbg_vprintf( format, args ); > + ret += __wine_dbg_vprintf( format, args ); > return ret; > } > > @@ -313,5 +314,6 @@ > __wine_dbgstr_wn = NTDLL_dbgstr_wn; > __wine_dbg_vsprintf = NTDLL_dbg_vsprintf; > __wine_dbg_vprintf = NTDLL_dbg_vprintf; > + if (getenv("WINEDELAY")) wine_dbg_toggle_block(); > __wine_dbg_vlog = NTDLL_dbg_vlog; > } > --- orig/dlls/x11drv/keyboard.c > +++ mod/dlls/x11drv/keyboard.c > @@ -1171,6 +1171,11 @@ > KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, event->type, event_time ); > TRACE("State after : %#.2x\n",pKeyStateTable[vkey]); > break; > + case VK_F12: > + if ((event->type == KeyPress) && getenv("WINEDELAY")) { > + /* we get this event repeatedly if we hold down the key (keyboard repeat) */ > + wine_dbg_toggle_block(); > + } > default: > /* Adjust the NUMLOCK state if it has been changed outside wine */ > if (!(pKeyStateTable[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) > --- orig/include/wine/debug.h > +++ mod/include/wine/debug.h > @@ -145,6 +145,7 @@ > extern int wine_dbg_printf( const char *format, ... ) __WINE_PRINTF_ATTR(1,2); > extern int wine_dbg_log( unsigned int cls, const char *ch, const char *func, > const char *format, ... ) __WINE_PRINTF_ATTR(4,5); > +extern void wine_dbg_toggle_block(); > > static inline const char *wine_dbgstr_guid( const GUID *id ) > { > --- orig/libs/wine/debug.c > +++ mod/libs/wine/debug.c > @@ -54,6 +54,9 @@ > > static const char * const debug_classes[] = { "fixme", "err", "warn", "trace" }; > > +static int disabled_dbg_vprintf( const char *format, va_list args ); > +static void* old_vprintf = &disabled_dbg_vprintf; /* used when blocking debug output */ > + > static int cmp_name( const void *p1, const void *p2 ) > { > const char *name = p1; > @@ -140,6 +143,16 @@ > } > } > > +static int disabled_dbg_vprintf( const char *format, va_list args ) { > + return 0; > +} > + > +/* prevents printing of debug messages temporarily */ > +void wine_dbg_toggle_block() { > + fprintf(stderr, "wine: toggling tracing\n"); > + old_vprintf = interlocked_xchg_ptr((void**)&__wine_dbg_vprintf, old_vprintf); /* fixme: is this thread safe? */ > +} > + > /* parse a set of debugging option specifications and add them to the option list */ > int wine_dbg_parse_options( const char *str ) > { > @@ -412,3 +425,4 @@ > { > return __wine_dbgstr_wn( s, -1 ); > } > + > --- orig/libs/wine/wine.def > +++ mod/libs/wine/wine.def > @@ -9,6 +9,7 @@ > __wine_dbgstr_an > __wine_dbgstr_wn > __wine_dll_register > + wine_dbg_toggle_block > __wine_main_argc > __wine_main_argv > __wine_main_environ > --- orig/libs/wine/wine.map > +++ mod/libs/wine/wine.map > @@ -6,6 +6,7 @@ > __wine_dbg_vlog; > __wine_dbg_vprintf; > __wine_dbg_vsprintf; > + wine_dbg_toggle_block; > __wine_dbgstr_an; > __wine_dbgstr_wn; > __wine_dll_register; > > > >

June 29, 2004

A wine magic trace key

by Andrei Barbu

I'm about to implement a set of keys that lets me enable disable traces any time. Seems to me like it's a good idea, like that I can get traces for exactly what I need. Especially when I'm faced with weird debugger output that's 10 minutes into the game and I can't turn traces on to begin with. Is there another way, possibly existing, to do this? Is this a really bad idea? If people are interested I can post a patch later on today or tomorrow with it. It'll be implemented in the x11 driver and calling the existing wine_dbg_parse_options with a new options string. It can even be made a commandline option to enable and disable that key combination (and possibly the key combination could be set in wineconfig) but that's if enough people are interested in the idea. Thanks, Andrei

June 29, 2004

Re: parameter checking in CoMarshalInterface

by Uwe Bonnes

>>>>> "Aric" == Aric Stewart <aric(a)codeweavers.com> writes: Aric> Changlog: return an error if the IUnknown pointer is NULL and dont Aric> crash tested with win2k and this is proper behavior Index: The test is welcome in the test suite... Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

June 29, 2004

Re: A wine magic trace key

by Mike Hearn

On Tue, 2004-06-29 at 12:39 -0400, Andrei Barbu wrote: > Thanks, > Why doesn't this get committed to the main tree? > It'd help developers, and wouldn't hurt anyone else. If they don't want > it they can just not set the environment variable. Alexandre felt it would dictate policy too much (I feel that's an acceptable tradeoff given the performance impact of doing it externally, but he's the boss). I think it may also break DLL separation, but am not sure on that point. We really, medically, need a place to dump all these sort of patches/ideas/files etc. Maybe a wiki? Jeremy? :D

June 29, 2004

Re: Mandrake RPMs

by Mike Hearn

On Tue, 29 Jun 2004 16:12:04 +0200, Ivan wrote: > No, wine segfaulted, so it probably wasn't a packaging related problem. Yeah that was almost certainly just bugs in the preloader ...

June 29, 2004

Re: Typo in winedbg

by Mike Hearn

On Mon, 28 Jun 2004 20:45:35 -0400, Andrei Barbu wrote: > This fixes debuggee to debugger. I think debuggee is the right word, it means "the one that is being debugged". Ctrl-C doesn't interrupt winedbg, it interrupts the process you are currently attached to.

June 29, 2004