August 2004 - Wine-Devel - list.winehq.org

Re: Windows Default Button Observations

by Ferenc Wagner

Mike Hearn <mike(a)navi.cx> writes: > On Sun, 15 Aug 2004 11:23:07 +0200, Ferenc Wagner wrote: > >> Once you remembered the current (possibly inactive) default >> button in DIALOGINFO, this should come for free. I hope at >> most one button can be default in a dialog... > > http://weblogs.asp.net/oldnewthing/archive/2004/08/02/205624.aspx > > I'm afraid it's possible for dialogs to have more than one > default button. No, there is no hope. :( This fancy feature is definitely worth supporting in Wine. Thanks for the correction. -- Cheers, Feri.

Aug. 15, 2004

Re: Windows Default Button Observations

by Mike Hearn

On Sun, 15 Aug 2004 11:23:07 +0200, Ferenc Wagner wrote: > Once you remembered the current (possibly inactive) default > button in DIALOGINFO, this should come for free. I hope at > most one button can be default in a dialog... http://weblogs.asp.net/oldnewthing/archive/2004/08/02/205624.aspx I'm afraid it's possible for dialogs to have more than one default button. That is a good post on management of default buttons in dialog boxes, here's another related to focus: http://weblogs.asp.net/oldnewthing/archive/2004/08/04/208005.aspx#FeedBack thanks -mike

Aug. 15, 2004

Large memory reporting

by Ivan Leo Puoti

> /* work around for broken photoshop 4 installer */ You may have to consider handling this like Microsoft does. If you read trough m$ blogs, you'll find that what microsoft usually does is have all sort of workarounds for broken apps, without them lots of stuff would not run on window xp. To work like windows, wine will have to do the same. For example, at some point m$ found that a game called "The sims" didn't work on recent versions of windows, because it freed some heap memory, and then immediately tried to access it. The M$ guys had to reverse engineering the game to find this out, and then introduced a hack that would make windows compensate for the apps bug. The game did work on previous versions of windows. M$ has it's code full of this stuff, they give priority to m$ apps, followed by stuff from big vendors like IBM, adobe, macomedia and so on. Wine will have to unfortunately do the same to achieve 100% compatibility for all the apps that work on windows only thanks to specific hacks. I'm not saying that it's a good solution in this case, but at some point this sort of stuff will have to be done. Ivan.

Aug. 15, 2004

Re: Large memory reporting

by Dmitry Timoshkov

"Shachar Shemesh" <wine-devel(a)shemesh.biz> wrote: > If so, is there a way for me, when at the heap.c code, to know whether > that flag was set on loading the current process? (copied from dlls/ntdll/loader.c): PEB *peb = NtCurrentTeb()->Peb; IMAGE_NT_HEADERS *nt = RtlImageNtHeader( peb->ImageBaseAddress ); if (nt->FileHeader.Characteristics & IMAGE_FILE_LARGE_ADDRESS_AWARE) { return full_address_range_of_the_application; } else return 2Gb_of_adderess_space; or even better reimplement GlobalMemoryStatus via VirtualQuery and leave all system dependent code to ntdll.NtQueryVirtualMemory. -- Dmitry.

Aug. 15, 2004

Re: Windows Default Button Observations

by Ferenc Wagner

"Zach Gorman" <zach(a)archetypeauction.com> writes: > My impression is that (1) could be handled by remembering > the default button (which, as Krishna Murthy has shown, is > not the same as the default button id) in the DIALOGINFO > structure. > > Number (2), however, is more difficult. When a button > receives the capture, it can send a BM_SETSTATE to itself > easily enough to make itself a DEFPUSHBUTTON, but how does > it determine which other buttons to query and make > non-default as necessary? Once you remembered the current (possibly inactive) default button in DIALOGINFO, this should come for free. I hope at most one button can be default in a dialog... -- Feri.

Aug. 15, 2004

Large memory reporting

by Shachar Shemesh

Hi list, I have a Windows program that tries to find out how much memory it has at its disposal using "GlobalMemoryStatus". The machine has 4GB of physical memory and about 100MB of swap. GlobalMemoryStatus returns 2GB of physical memory and 0 available swap. It seems the problem is at dlls/kernel/heap.c, around lines 1150. First we make sure we never report more than 2GB of total or available memory, and then we make sure that we never report more than 2GB combined available physical+swap memory (which effectively zeros the available swap if there is more than 2GB of available memory). The comment next to this is: /* work around for broken photoshop 4 installer */ While I understand the need for the workaround, this significantly reduces the usefulness of the whole function. My question: Can we make these two rounding conditional on the application not wishing to work with more than 2GB? I.e. - can we let applications that were linked with LARGEADDRESSAWARE see the true state of the machine? If so, is there a way for me, when at the heap.c code, to know whether that flag was set on loading the current process? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

Aug. 15, 2004

Re: console message encoding

by Eric Pouech

Vitaly Lipatov a écrit : > Is it known that console message printed to output in wine > internal encoding (OEM?), not in locale encoding. Is it bug or > just needed coding right behavior? > For example, I have koi8-r as locale encoding, cp866 as OEM CP > and cp1251 as ANSI CP. In windows, the default CP for consoles is OEM. This can be changed. The CP you described are windows' or Linux ones ? A+

Aug. 15, 2004

Re: Debugger crash

by Eric Pouech

Mike Hearn a écrit : > Hi, [snip] > Eric, any ideas? I don't understand what this code is doing. I think that Dimitry's patch fixed it, doesn't it. A+

Aug. 15, 2004

Re: wave tests patch

by Eric Pouech

Francois Gouget a écrit : > Francois Gouget wrote: > [...] > >> Anyway, assuming that we need to round up I propose to modify the >> implementation as in the attached patch. The advantage is that it does >> not rely on ceil(). In fact it doesn't even use floating point >> arithmetic so we cannot get any rounding error. > > > The code that performs TIME_SMPTE calculations is the same for all > drivers. It is even the same for the input and output devices (assuming > the SMPTE rounding is the same for both) which means it is currently > duplicated 12 times. > > Would it be better to have waveOutGetPosition() in winmm.c simply query > either the TIME_MS from the underlying driver and then perform the > conversion? This would be something like: > > ... > if (lpTime->wType==TIME_SMPTE) > { > LPMMTIME myTime; > myTime.wType=TIME_MS; > rc=MMDRV_Message(wmld, WODM_GETPOS, (DWORD_PTR)&myTime, > sizeof(myTime), TRUE); > if (rc!=TIME_SAMPLES) > return rc; > { > ms_to_smpte(myTime.u.ms,lpTime); > return TIME_SMPTE; > } > } > return MMDRV_Message(wmld, WODM_GETPOS, (DWORD_PTR)lpTime, > uSize, TRUE); > } > > Then we can move the SMPTE calculation to the ms_to_smpte() helper > function in winmm.c. The only drawback is performing SMPTE starting from > the TIME_MS data which may have been rounded down a bit. We could > eliminate this problem if we had access to the driver's wwo->format > data. And then we could also move the TIME_MS calculation to winmm.c and > even the TIME_SAMPLES one. Is there any (potential) driver for which > this calculation would not work? > > lpTime->u.sample = bytes / (wwo->format.wBitsPerSample / 8 * > wwo->format.wf.nChannels); > > coming back from vacation, and starting browsing thru the pile of e-mail (I'm not sure of the final output of this discussion). How about, letting the drivers decide which format they support (in ???_GETPOS message handling) and have the fallback code in winmm.c ? This would help the factorisation of the code. A+

Aug. 15, 2004

Re: More winecfg todos

by Jacek Caban

> You probably want to increase the size of the drive mappings list so it > fills the tab, currently there is just a lot of empty space at the top of > the pane now you removed the old stuff. I have almost ready patch. I've attached screenshot. Is it a good idea? Thanks, Jacek

Aug. 15, 2004