August 2004 - Wine-Devel - list.winehq.org

Re: RSABASE/TESTS: Fix signed/unsigned comparison warnings

by Hans Leidekker

On Monday 09 August 2004 12:17, Hans Leidekker wrote: > variable. We somehow have to live with the fact that NTE_BAD_KEYSET > is defined as ((HRESULT)0x80090016L), which is signed, and GetLastError() > returning DWORD, i.e unsigned. On a related note, I am looking at the last testsuite with signed/unsigned comparison warnings, ntdll, and I'm trying to deal with constructs like this one: NTSTATUS ntstatus; ok(ntstatus == STATUS_SUCCESS, "Call failed (%lu)\n", ntstatus); where Wine defines STATUS_SUCCESS like so: #define STATUS_SUCCESS 0x00000000 which means STATUS_SUCCESS is handled by gcc as an unsigned value. This generates a warning because NTSTATUS is signed. If we look at the SDK definition we see something different: #define STATUS_SUCCESS ((NTSTATUS)0x00000000L) Which would get rid of the warnings for us if we add the cast there too. Should I submit a patch to do this? To add a cast in every such code sequence is not a good alternative if you ask me, as it's a very common idiom. Any other solutions? -Hans

Aug. 9, 2004

Re: rsabase and itunes

by Robert Shearman

On Wed, 2004-08-04 at 03:31, Michael Jung wrote: > Rob, > > I've seen the press release concerning the CrossOver Office iTunes preview and > I've noticed that it depends on libcrypto. Im just wondering if your effort > with rsabase is related to this? The initial effort was to do with a Codeweavers project, as I suspected some problems with the application were due to missing functionality in rsabase, but it soon became obvious that this was not the problem. I then decided to continue development on rsabase in my own time. Hopefully, I will have some usable patches in the next week or so. Rob

Aug. 9, 2004

"Call Identifier" -- MSRPC ??

by Auge Mike

Hi all, I really like to know hot to change the "call identifier" in a MSRPC call??? Please help me, I already wasted too long time searching for this info with no luck??? Thank you in advance!!! _________________________________________________________________ Add photos to your messages with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/featuredemail

Aug. 9, 2004

Re: RSABASE/TESTS: Fix signed/unsigned comparison warnings

by Hans Leidekker

On Monday 09 August 2004 11:17, Dmitry Timoshkov wrote: > > - if (GetLastError()==NTE_BAD_KEYSET) > > + LONG gle = GetLastError(); > > + if (gle==NTE_BAD_KEYSET) > > This is ugly. This kind of "fixes" clutters Wine code and should be > deprecated. What do you propose then? I could do something like this: if (GetLastError()==(DWORD)NTE_BAD_KEYSET) But I consider a cast even uglier then introducing an intermediate variable. We somehow have to live with the fact that NTE_BAD_KEYSET is defined as ((HRESULT)0x80090016L), which is signed, and GetLastError() returning DWORD, i.e unsigned. -Hans

Aug. 9, 2004

Re: RSABASE/TESTS: Fix signed/unsigned comparison warnings

by Dmitry Timoshkov

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > +static const int size_of_wchar = sizeof(WCHAR); > + ... > - ok(!memcmp(bufW, stringW, 5 * sizeof(WCHAR)), "bufW/stringW mismatch\n"); > + ok(!memcmp(bufW, stringW, 5 * size_of_wchar), "bufW/stringW mismatch\n"); > - if (GetLastError()==NTE_BAD_KEYSET) > + LONG gle = GetLastError(); > + if (gle==NTE_BAD_KEYSET) This is ugly. This kind of "fixes" clutters Wine code and should be deprecated. -- Dmitry.

Aug. 9, 2004

Re: Add debugstr_rect alias for consistency with other debugging functions.

by Alexandre Julliard

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > Apart for much cleaner code, it's also useful, as I can see many > people do: > #ifdef WINE > # define ERR WINE_ERR > # define TRACE WINE_TRACE > ... > #else > # define ERR printf > # define TRACE printf > ... > #endif > > I have a sentimental attachment to the Wine's debugging API, as it was > the first project that I undertook in Wine. It was what "hooked" me in. > This may be a small issue, and probably I shouldn't care, but I can't > help it. I truely think requiring the WINE_/wine_ prefix inside of Wine > for commonly used symbols in the debugging API is not a good direction, > and I really hope we can revisit this decision. I agree for the ERR etc. macros, but I don't think the debugstr functions are the same issue at all. You can't really #define them to something else anyway, you need to link with libwine to make them available. So I think it makes much more sense to keep the wine_ prefix for them, so that usage is consistent between Wine and Winelib code. -- Alexandre Julliard julliard(a)winehq.org

Aug. 8, 2004

Re: Fix crash in dsound test

by Kevin Koltzau

On Thursday 29 July 2004 01:17 pm, Ferenc Wagner wrote: > Yes, there was a short discussion about this on 23-24 July > on wine-devel. It reached no conclusion, though, and I > didn't try the various MinGW libraries recommended there. > The abundance of MinGW packages always confused me, and at > the moment I don't even know where I got mine from. But it > can't compile the dsound tests, that's for sure. Comments > welcome. My build is now working again as of today, thanks to Hans Leidekker What worked for me was removing w32api_directx.patch and adding his w32api_lib_uuid_c.patch

Aug. 8, 2004

RE: patch: shell32.dll - SHELL_ArgifyW expands env-vars

by Jens Collin

Hi Steven, yes, that's why I only merged enough to solve the problem to ros, and not the whole lib :) I'll see what I can do on regressiontests. / Jens -----Original Message----- From: Steven Edwards [mailto:steven_ed4153(a)yahoo.com] Sent: den 8 augusti 2004 18:34 To: wine-devel(a)winehq.org; wine-patches(a)winehq.org Cc: jens.collin(a)lakhei.com Subject: Re: patch: shell32.dll - SHELL_ArgifyW expands env-vars Hi Jens, --- Jens Collin <jens.collin(a)lakhei.com> wrote: > * lookup of envoronment-vars in SHELL_ArgifyW in shell32.dll added. > (Such as %SystemRoot%). Do you think you could write some test cases for the shellexecute functions using the wine regression tests? I would like to try and merge the rest of shell32 in to ReactOS but am worried that we may overwrite fixes Martin made in the ReactOS tree. Thanks Steven __________________________________ Do you Yahoo!? Y! Messenger - Communicate in real time. Download now. http://messenger.yahoo.com

Aug. 8, 2004

Re: patch: shell32.dll - SHELL_ArgifyW expands env-vars

by Steven Edwards

Hi Jens, --- Jens Collin <jens.collin(a)lakhei.com> wrote: > * lookup of envoronment-vars in SHELL_ArgifyW in shell32.dll added. > (Such as %SystemRoot%). Do you think you could write some test cases for the shellexecute functions using the wine regression tests? I would like to try and merge the rest of shell32 in to ReactOS but am worried that we may overwrite fixes Martin made in the ReactOS tree. Thanks Steven __________________________________ Do you Yahoo!? Y! Messenger - Communicate in real time. Download now. http://messenger.yahoo.com

Aug. 8, 2004

Re: Wine's OLE/COM doesn't work, and I can no longer use native COM

by Mike Hearn

On Sun, 2004-08-08 at 10:56 -0500, David D. Hagood wrote: > Mike Hearn wrote: > > Install it all as Win98 if possible, and native DCOM like this: > > > > WINEDLLOVERRIDES=ole32,oleaut32,rpcrt4=n wine DCOM98.EXE > > Well, having done so, and having tried setting all the OLE* and RPC* > DLLs to native, I am still having the same problem with that app - so I > am forced to conjecture that it is not a direct problem with OLE but > some other aspect of the program. That sounds likely. The OLE trace you provided didn't show much activity.

Aug. 8, 2004