August 2004 - Wine-Devel - list.winehq.org

Re: [QUARTZ] Some bug fixes

by Robert Shearman

Christian Costa wrote: > Hi, > > This is the first of a serie of patches that implement an audio > (dsound) & video (ddraw) renderers, a decoder (a VFW wrapper filter) > and the IGraphBuilder interface. Cool. I wish I had more time to work on this area. > Actually I can do a playback of a MSVC/CRAM avi file with a winetest > app but the code is very ugly (especially the IGraphBuilder interface > which is somewhat harcoded) and I need to clean it a bit. Looking forward to the patches :) > Changelog: > Added missing initialization of the filesource output pin critical > section. Good catch. > Avoid indefinite wait when calling GetOverlappedResult. This shouldn't happen. GetOverlappedResult should do a wait on the event object, just like the wait above that succeeds (and GetOverlappedResult is called) or times out (and GetOverlappedResult is not called). I suspect that the bug is elsewhere, perhaps an event should be created for each request and then WaitForMultipleObjects used. > Fixed initial refcount of the IMemAllocator object. Good catch again. This was originally correct, but I believe I changed the class factory to avoid this silly convention. Rob

Aug. 14, 2004

WWN 235

by Tom

Hello, <li><a href="?issue=235#" class="small"></a></li> Needs to be removed from the side bar. Tom

Aug. 14, 2004

Re: NTDLL: Fix signed/unsigned comparison warnings

by Mike McCormack

Dimitrie O. Paun wrote: > Any gadge on if/when will be able to turn this warning on > by default? How many warnings are currently left? I'm compiling with this warning on at the moment and there's still loads of warnings. It may be hard to clean up every warning without making the code messy (ie. using casts or intermediate variables). Secondly, if we turn on the warning people may start "fixing" it the wrong way and hiding bugs. So I think case it may be reasonable to just have a janitorial task to check and fix sign compare warnings warnings, but not turn on the warning in the CVS. Mike

Aug. 14, 2004

Re: Acknowledgment page

by Tom

> > But I suspect if I dug around I could find a list of additional > names to add there. > The list I have was from the old faq-o-matic way before the current faq. and from one of the pages that dimi use to have on his site. Donations to the MFC docs? and the money went to the wpf? So should we list people or not? I added the part : Below is a short list of people who have given money to the wpf. If you have given money to this fund and would like to be included on this page just send a e-mail to wine-devel and ask for inclusion. This way if someone wants to be addded they can simpley ask for inclusion. Do you want me to also add if your name is listed here and you would prefere not to be listed just send a e-mail and we will glady remove your name from this list. If and when this page is ever done I was going to send a patch to remove the people from the faq as it would only be duplication. Tom > Cheers, > > Jeremy > > > -- http://www.anti-tshirts.com/

Aug. 13, 2004

Re: Fix compilation of the wininet generated tests

by Francois Gouget

On Fri, 13 Aug 2004, Hans Leidekker wrote: > On Friday 13 August 2004 13:55, Francois Gouget wrote: > > > * compiling the test with the Windows headers may result in different > > sizes/alignments if the Wine headers got the packign wrong. If that's > > the case, the compiler will put in different values for sizeof(struct X) > > which will result in something like ok(4==8,"..."); > > Changing the compiler but keeping the same set of headers may also > result in different sizes/alignments. Our headers are supposed to compensate for that. If that's not the case then one of the compilers will produce code that is not binary compatible with Windows applications. I.e. Wine will be unusable. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: the choice of a GNU generation

Aug. 13, 2004

Re: Acknowledgment page

by Alexandre Julliard

Brian Vincent <brian.vincent(a)gmail.com> writes: > 5) On our FAQ page we say this: > People and organizations who have given generous contributions of > money, equipment, or licenses, include: > David L. Harper > Bob Hepple > Mark A. Horton > Kevin P. Lawton > The Syntropy Institute > James Woulfe > > Pardon my ignorance, but I don't know any of these people. Maybe we > should add them to that page but it might help to have an explanation > of why. This dates from the very beginning of the project, when Bob Amstadt was in charge. I have no idea what these people have donated. They probably wouldn't get mortally offended if we were to drop their names from the FAQ... -- Alexandre Julliard julliard(a)winehq.org

Aug. 13, 2004

Re: wineoss mmap fail error message

by Alexandre Julliard

Robert Reif <reif(a)earthlink.net> writes: > This patch doesn't fix the problem but gives a possible solution. > > If/when the config file goes away, where will we be able to > set [dsound] parameters? It will be in the registry under HKLM\Software\Wine\dsound or something like that; but clearly we need to find a better way to deal with that than printing a message on the console telling people to change their config. -- Alexandre Julliard julliard(a)winehq.org

Aug. 13, 2004

Re: comctl ipaddress enable not working

by Dimitrie O. Paun

On Fri, Aug 13, 2004 at 03:10:01PM -0400, Robert Reif wrote: > I have a program which will not gray out an IP address control when it > is not enabled. ipaddress is a distant memory :) I can look at it in a few days, I'll be leaving for the weekend in a few hours, so I can not do it sooner. -- Dimi.

Aug. 13, 2004

Re: NTDLL: Fix signed/unsigned comparison warnings

by Dimitrie O. Paun

On Fri, Aug 13, 2004 at 03:14:21PM +0200, Hans Leidekker wrote: > > This time I have tried to be more careful, by not watching a > football match at the same time for example ;) And with this > patch all tests still succeed, although they would not detect > every signedness change of course. Any gadge on if/when will be able to turn this warning on by default? How many warnings are currently left? -- Dimi.

Aug. 13, 2004

comctl ipaddress enable not working

by Robert Reif

I have a program which will not gray out an IP address control when it is not enabled.

Aug. 13, 2004

RE: usb support in ROS

by Steven Edwards

Hi, --- Ge van Geldorp <gvg(a)reactos.com> wrote: > No, not yet. Some work is being done on USB but it will take a while > before support is finished. Right now some very basic support accessing HID devices has been implemented but I am sure it does not work on ROS. I assume Thomas just developed it on Windows. I am sure he also would be willing to relicense it LGPL if someone needed it. http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/hid/hid.c?rev=1.3&con… Thanks Steven __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

Aug. 13, 2004

Re: [GDI] - More Leaks

by Dmitry Timoshkov

"Jon Griffiths" <jon_p_griffiths(a)yahoo.com> wrote: > Changelog: > +controls/button.c controls/combo.c controls/desktop.c > controls/edit.c controls/icontitle.c controls/listbox.c > controls/menu.c controls/scroll.c controls/static.c > dlls/gdi/gdi_main.c dlls/gdi/gdiobj.c dlls/gdi/gdi_private.h > dlls/user/cache.c dlls/user/controls.h dlls/user/user_main.c > dlls/user/winproc.h include/user.h windows/class.c > windows/cursoricon.c windows/dce.c windows/dialog.c > windows/mdi.c windows/syscolor.c windows/sysmetrics.c > Don't leak GDI objects on exit. Of course the patch is correct, but shouldn't that be a job for gdi32 on DLL_PROCESS_DETACH or even DLL_THREAD_DETACH? -- Dmitry.

Aug. 13, 2004

Re: dlls/kernel/heap.c breakage

by Gerald Pfeifer

On Fri, 13 Aug 2004, Robert Reif wrote: >> the following change to dlls/kernel/heap.c broke FreeBSD, both 4.10 >> and 5.2: > Here is the bsd fix. Thanks! Builds like a charm now. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

Aug. 13, 2004

Re: Acknowledgment page

by Jeremy White

> Here's a question for you - should money contribution's credit expire? > If someone donated 100$ some five years ago, should we still list them? Another comment on this - - I have a list of names that have donated to Wine over the past 2 years - some folks quite generously - and yet I don't feel it's appropriate to publish their names without their permission. I try, when I thank them, to ask if they want it to be an anonymous donation, or if they want credit, but I don't always succeed. But I suspect if I dug around I could find a list of additional names to add there. Cheers, Jeremy

Aug. 13, 2004

Re: Fix compilation of the wininet generated tests

by Hans Leidekker

On Friday 13 August 2004 13:55, Francois Gouget wrote: > * compiling the test with the Windows headers may result in different > sizes/alignments if the Wine headers got the packign wrong. If that's > the case, the compiler will put in different values for sizeof(struct X) > which will result in something like ok(4==8,"..."); Changing the compiler but keeping the same set of headers may also result in different sizes/alignments. This was the case some time ago when MinGW appeared to align structures containing a double to 8 bytes whereas gcc would align those to 4 bytes. -Hans

Aug. 13, 2004

Re: dlls/kernel/heap.c breakage

by Robert Reif

Gerald Pfeifer wrote: > Robert, > > the following change to dlls/kernel/heap.c broke FreeBSD, both 4.10 > and 5.2: Here is the bsd fix. Index: dlls/kernel/heap.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/heap.c,v retrieving revision 1.10 diff -u -r1.10 heap.c --- dlls/kernel/heap.c 13 Aug 2004 00:41:34 -0000 1.10 +++ dlls/kernel/heap.c 13 Aug 2004 12:25:44 -0000 @@ -1124,13 +1124,13 @@ lpmemex->ullAvailPhys = *tmp; lpmemex->ullTotalPageFile = *tmp; lpmemex->ullAvailPageFile = *tmp; - lpmemex->ullMemoryLoad = lpmemex->ullTotalPhys - lpmemex->ullAvailPhys; + lpmemex->dwMemoryLoad = lpmemex->ullTotalPhys - lpmemex->ullAvailPhys; } else { lpmemex->ullAvailPhys = lpmemex->ullTotalPhys; lpmemex->ullTotalPageFile = lpmemex->ullTotalPhys; lpmemex->ullAvailPageFile = lpmemex->ullTotalPhys; - lpmemex->ullMemoryLoad = 0; + lpmemex->dwMemoryLoad = 0; } free(tmp);

Aug. 13, 2004

wine tests

by Ivan Leo Puoti

On our sf page we now have, under the winetest-200408071000 release, 6 copies of the same file, same name and same size, with the exemption of winetest-200408071000-kevin-mingw.zip that has 6 different sizes. Why is this? Ivan.

Aug. 13, 2004

Re: Development model/versioning stuff: Interesting essay on why decentralised versioning is a bad idea

by Mike McCormack

Mike Hearn wrote: > http://web.mit.edu/ghudson/thoughts/bitkeeper.whynot > > What are peoples thoughts on this? It's not (despite appearances) an > argument against BitKeeper due to licensing concerns, but rather a short > paper on why the author believes the "pyramid" patch/development system > is a bad idea. From the article: "For Linux, the consequences of these limitations have been slow and unpredictable release schedules, poor stability of release branches, and a lack of important standards (for instance, no consistent kernel module ABI or even API within a release branch)." I think that the above is incorrect... IMO: * mainline linux kernels have not been unstable. Kernels released by distros, which are presumably done with multiple committers are far more unstable than that released by Linus. * the kernel->user space ABI is extremely stable. The internal kernel ABI is not stable, because supporting 3rd drivers is not a goal of Linux. The release schedule of the kernel is slightly irregular, but I don't think that it's holding back development. The advantage of having a single maintainer is that it reduces the level of politics in the project. We follow Alexandre's goals, which I think are pretty clear and consistent. Multiple maintainers would have multiple goals, and thus create conflict. There's always the option to fork the project if you think that you have a better way of doing things, but nobody has successfully done that so far. The current development model for Wine is achieving good results. I don't think there's any need to mess with it. CVS has it's problems (mostly for maintainers), but there's no better tool at the moment. Mike

Aug. 13, 2004

Re: ADVAPI32: implement SetThreadToken using NtSetInformationThread

by Dmitry Timoshkov

"Mike McCormack" <mike(a)codeweavers.com> wrote: > @@ -545,6 +545,12 @@ > case ThreadBasePriority: > case ThreadAffinityMask: > case ThreadImpersonationToken: > + { > + const HANDLE *phToken = data; > + if (length != sizeof(HANDLE)) return STATUS_INVALID_PARAMETER; > + FIXME("Set ThreadImpersonationToken handle to %p\n", *phToken ); > + return STATUS_SUCCESS; > + } Probably ThreadImpersonationToken handling should be isolated from other thread class identifiers otherwise FIXME will be printed for all them as well. -- Dmitry.

Aug. 13, 2004

dlls/kernel/heap.c breakage

by Gerald Pfeifer

Robert, the following change to dlls/kernel/heap.c broke FreeBSD, both 4.10 and 5.2: revision 1.10 date: 2004/08/13 00:41:34; author: julliard; state: Exp; lines: +115 -88 Robert Reif <reif(a)earthlink.net> Use GlobalMemoryStatusEx in GlobalMemoryStatus rather than the other way around. The failure mode is the following: /sw/gcc-3.3.2/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -DETCDIR="\"/tmp/WINE/etc\"" -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o heap.o heap.c heap.c: In function `GlobalMemoryStatusEx': heap.c:1127: error: structure has no member named `ullMemoryLoad' heap.c:1133: error: structure has no member named `ullMemoryLoad' gmake: *** [heap.o] Error 1 Would you mind fixing this? Gerald

Aug. 13, 2004

Re: Fixed some ref handling

by Jacek Caban

I've sent today patch called "Fixed some ref handling". It should be called "Added polish translation to notepad". Sory for that. Jacek

Aug. 13, 2004

Re: Development model/versioning stuff: Interesting essay on why decentralised versioning is a bad idea

by Mike Hearn

> Well, if you agree with the article, you are basically saying that Alexandre > should let other people commit to the tree. Another way to read the article > is to say that 'wow, BK is exactly that we need in Wine because it matches > exactly the way we work' :-) I never said I agree with it, just that it was an interesting perspective on the cons of pyramid development that I hadn't seen before. I don't have a strong opinion either way (for once ;). Currently distributed development models are all the rage it seems so it's nice to have an alternate perspective. > Anyway, we already discussed this to death about one or two years ago. True :)

Aug. 13, 2004

Re: Acknowledgment page

by Shachar Shemesh

Brian Vincent wrote: >4) Who's Who does need an update, and I can think of quite a few >people who deserve to be on there. I'd encourage anyone who isn't on >there to speak up and add themselves (patch to wine-patches, or email >to me). The most likely for someone not being on there is simply an >oversight on my part. Names that immediately come to mind include Rob >Shearman, Robert Reif, and Filip Navara. There's probably a dozen >more. The guideline for a Who's Who entry is shameless >self-promotion. > > The problem with wine hackers is that they are too modest. They appreciate the publicity, but won't typically go looking for it. I think it would be best to call upon all wine hackers to think of names of people who deserve to be there and are not. >5) On our FAQ page we say this: > People and organizations who have given generous contributions of >money, equipment, or licenses, include: > David L. Harper > Bob Hepple > Mark A. Horton > Kevin P. Lawton > The Syntropy Institute > James Woulfe > > Here's a question for you - should money contribution's credit expire? If someone donated 100$ some five years ago, should we still list them? This is not about code contribution. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

Aug. 13, 2004

Re: Acknowledgment page

by Brian Vincent

On Thu, 12 Aug 2004 14:25:26 -0400, Tom <twickline(a)sitestar.net> wrote: > Jeremy White wrote: > > Hmm. I have several thoughts on this. First, I think > > that corporate sponsors get enough 'props'. While I appreciate > > the gesture, I'd rather the acknowledgements page highlight > > the many people who do good work for Wine without > > pay or other recompense. > > Hello Jer, > > But that would just be a copy of the who's who? > http://www.winehq.org/site/who Random thoughts.. 1) Tom - you sent me a preview of an acknowledgement page a few months ago and I thought it was an excellent start. I have it laying around somewhere still. 2) Companies definitely need to be mentioned. Corporate sponsors _don't_ get enough props. 3) A quick glance at the AUTHORS file shows tons of names I don't recognize and some that I happen to recognize but I know their contributions were a line or two here and there. I think a decent guideline for an acknowledgement page is to scan wine-patches for the past 2 or 3 years and pick out anyone who submitted more than, say, 4 (or Insert-Favorite-Random-Number-Here) patches. I suspect it's smaller than you'd think. (cat the files together | grep From | uniq | sort -rn) From there, add in some folks who had contributions (Bertho Stultiens, et al). Finally put out a call for people to add themselves to care of any oversights. No, the end result won't be perfect but it's better than nothing. 4) Who's Who does need an update, and I can think of quite a few people who deserve to be on there. I'd encourage anyone who isn't on there to speak up and add themselves (patch to wine-patches, or email to me). The most likely for someone not being on there is simply an oversight on my part. Names that immediately come to mind include Rob Shearman, Robert Reif, and Filip Navara. There's probably a dozen more. The guideline for a Who's Who entry is shameless self-promotion. 5) On our FAQ page we say this: People and organizations who have given generous contributions of money, equipment, or licenses, include: David L. Harper Bob Hepple Mark A. Horton Kevin P. Lawton The Syntropy Institute James Woulfe Pardon my ignorance, but I don't know any of these people. Maybe we should add them to that page but it might help to have an explanation of why. -Brian

Aug. 12, 2004

Re: Development model/versioning stuff: Interesting essay on why decentralised versioning is a bad idea

by Lionel Ulmer

> What are peoples thoughts on this? It's not (despite appearances) an > argument against BitKeeper due to licensing concerns, but rather a short > paper on why the author believes the "pyramid" patch/development > system is a bad idea. Well, if you agree with the article, you are basically saying that Alexandre should let other people commit to the tree. Another way to read the article is to say that 'wow, BK is exactly that we need in Wine because it matches exactly the way we work' :-) Anyway, we already discussed this to death about one or two years ago. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Aug. 12, 2004