September 2004 - Wine-Devel

Re: SystemFunction036 debugging problem

by Andreas Mohr

Hi, On Mon, Sep 27, 2004 at 05:38:10PM -0400, James Hawkins wrote: > It turns out that SystemFunction036 is actually required to do > something for MyPhotoCalendars.exe to install correctly because the > installer exits with a program-level exception (ie not wine) What I > would like to do is run MyPhot...exe with winedbg and then set a > breakpoint for SystemFunction036 so that execution will stop when that > function is called so I can see who is calling it or something along > those lines, but I set the break point and when SystemFunction036 is > called, the program doesnt stop at all. Why not use the native DLL, then do a +relay,+snoop trace, remember the function return address and then in a new winedbg session, do a disas around that location to find out everything you ever wanted about SystemFunction036? (you might need to set a breakpoint to a common function such as GetVersion and run the program first, in order to actually get the program part loaded into memory that calls SystemFunction036; some more c'ontinues on GetVersion might be needed to finally get that part loaded) Andreas Mohr

Sept. 28, 2004

Re: missing advapi32 prototype: SystemFunction036

by Mike Hearn

At least some are now documented on MSDN. I believe I submitted a patch to document what 40/41 do (they are crypto related). The fact that an app is using the API strongly implies it's documented *somewhere*, don't you think? I would check for forward exports from other DLLs, for some reason Microsoft enjoy moving code around between DLLs and then using forwarding to make the changes transparent. thanks -mike James Hawkins wrote: > While trying to install MyPhotoCalendars, an exception is raised > because of a call to the unimplemented function > advapi32.dll.SystemFunction036. > > > From reading the following post, > > http://www.winehq.com/hypermail/wine-devel/2003/09/0265.html > > I can see that it won't be very easy to even stub this function > because it's a hidden api. What methods could I use to track down any > information about this function or its prototype? >

Sept. 28, 2004

Re: urlmon: IInternetSecurityManager

by Mike Hearn

> The convention with COM interfaces is to use the CoTaskMemAlloc / > CoTaskMemFree memory management functions instead of the Heap ones (even > though they are the same). This is just a slight nit-pick. Hmm, I don't think we should encourage using these APIs. It just makes the code less clear and people will waste time wondering what they're for. It's just legacy cruft from a bygone age and there's not a huge amount of point unless people are desperate to use the +olemalloc channel (I suspect not). thanks -mike

Sept. 28, 2004

Re: rpcrt4.dll NdrGetUserMarshalInfo() problem

by Mike Hearn

J. Grant wrote: > Hello, > > I am getting the attached error when running an install of Overnet v0.52. > > Basically it cannot find NdrGetUserMarshalInfo(), despite it being in > the dll at entry point: 77d43452h, order 199. Any ideas what this > problem could be? I'm expecting this to be the symptom of some wider > problem. Run it like this WINEDLLOVERRIDES=ole32,oleaut32,rpcrt4=n wine ... > p.s. Is there any way to get these mangled function names to be > displayed un-mangled please? Yes, use the winedump program. thanks -mike

Sept. 28, 2004

Re: PATCH: imagelist: change ERR to TRACE

by Michael Stefaniuc

On Tue, Sep 28, 2004 at 09:42:32AM +0200, Andreas Mohr wrote: > On Tue, Sep 28, 2004 at 06:44:16AM +0200, Michael Stefaniuc wrote: > > License: LGPL, X11 > > Changelog: > > Michael Stefaniuc <mstefani(a)redhat.com> > > - native ImageList_Remove dosn't spit out an error message when > > deleting an index out of range so don't do that either > Probably true, but native ImageList_Remove doesn't have its whole > Windows environment completely buggy either. ;-) > IOW: this was perhaps meant for Wine code bug tracking purposes > (AFAIK Wine uses imagelists a lot internally, e.g. shell code or so). > While an ERR is too verbose, TRACE is ill-suited for that (a wrong index > certainly is an anomaly); thus I'd say it should be a WARN. Well, that can be done too. The only reason i used TRACE is because till now i've seen those ERRs only in the imagelist test output and in one of FreeSolitaire's solitaire games. That's all application code, never seen it in Wine code but i don't realy use the shell code. I figure that i won't have to send in a new patch; if Alexandre likes WARN more it's an easy fix to my patch. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Sept. 28, 2004

Re: PATCH: imagelist: change ERR to TRACE

by Andreas Mohr

Hi, On Tue, Sep 28, 2004 at 06:44:16AM +0200, Michael Stefaniuc wrote: > Hello, > > License: LGPL, X11 > Changelog: > Michael Stefaniuc <mstefani(a)redhat.com> > - native ImageList_Remove dosn't spit out an error message when > deleting an index out of range so don't do that either Probably true, but native ImageList_Remove doesn't have its whole Windows environment completely buggy either. ;-) IOW: this was perhaps meant for Wine code bug tracking purposes (AFAIK Wine uses imagelists a lot internally, e.g. shell code or so). While an ERR is too verbose, TRACE is ill-suited for that (a wrong index certainly is an anomaly); thus I'd say it should be a WARN. Greetings, Andreas Mohr

Sept. 28, 2004

Re: ez-cdda sleep

by Marcus Meissner

On Mon, Sep 27, 2004 at 01:45:29PM -0400, James Hawkins wrote: It is doing: > 0025:Starting process L"C:\\Program Files\\Easy CD-DA Extractor 7\\ezcddax.exe" (entryproc=0x 761060) But "0025" never appears again (just as you pressed ctrl-c at the end). So this ezcddax.exe hangs somewhere, perhaps a copyprotection or similar. Ciao, Marcus

Sept. 28, 2004

Re: MakeSureDirectoryPathExists improvement

by Alexandre Julliard

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > @@ -91,13 +91,28 @@ > */ > BOOL WINAPI MakeSureDirectoryPathExists(LPCSTR DirPath) > { > - if (CreateDirectoryA(DirPath, NULL)) return TRUE; > - if (GetLastError() == ERROR_ALREADY_EXISTS) > + char path[MAX_PATH]; > + const char *p = DirPath; > + int n; > + > + if (strchr(p, ':') != NULL) > + p = strchr(p, ':'); > + while ((p = strchr(p, '\\')) != NULL) > { > - SetLastError(ERROR_SUCCESS); > - return TRUE; > + n = p - DirPath + 1; > + strncpy(path, DirPath, n); > + path[n] = '\0'; > + if( !CreateDirectoryA(path, NULL) && > + (GetLastError() != ERROR_ACCESS_DENIED) && > + (GetLastError() != ERROR_ALREADY_EXISTS)) > + return FALSE; > + p++; > } > - return FALSE; > + if (GetLastError() == ERROR_ACCESS_DENIED || > + (GetLastError() == ERROR_ALREADY_EXISTS)) > + SetLastError(ERROR_SUCCESS); > + > + return TRUE; I don't think you want to simply ignore ERROR_ACCESS_DENIED. You should fix your algorithm to not try to create the drive root and then ignore only ERROR_ALREADY_EXISTS. -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2004

Re: winecfg: Add Makefile rules to rebuild resource file when translations change

by Alexandre Julliard

Mike Hearn <mike(a)navi.cx> writes: > Add Makefile rules to rebuild resource file when translations change 'make depend' is a convenient way to do that, maybe you should give it a try ;-) -- Alexandre Julliard julliard(a)winehq.org

Sept. 28, 2004

Re: stub implementation SystemFunction036

by James Hawkins

> If you really want to stub this function then please don't print the > buffer contents Should it be FIXME("(%p, %i): stub\n", Buffer, BufferSize); instead? Or should it just not be there at all? On Tue, 28 Sep 2004 02:10:06 +0200, Filip Navara <xnavara(a)volny.cz> wrote: > James Hawkins wrote: > > >+ > >+VOID WINAPI SystemFunction036(PCHAR Buffer, INT BufferSize) > >+{ > >+ FIXME("(%s, %i): stub\n", Buffer, BufferSize); > >+} > >+ > > > > > If you really want to stub this function then please don't print the > buffer contents. It's an output buffer and contains garbage (maybe the > garbage means something, but still it's garbage). > > - Filip > > -- James Hawkins

Sept. 28, 2004