December 2005 - Wine-Devel - list.winehq.org

Re: Preliminary CD-Rom support on MacOS X #5 (take 2)

by emmanuel maillard

Hi, Le 30 déc. 05 à 01:39, Markus Amsler a écrit : > Hi, > > I took a look at your patches, here's what i've found: > > ntdll_cdrom.diff: > >> # >> >> @ cdecl MODULE_DllThreadAttach(ptr) >> @ cdecl MODULE_GetLoadOrderW(ptr wstr wstr) >> +@ cdecl CDROM_InitCDDevices() >> +@ cdecl CDROM_FoundDevices() >> +@ cdecl CDROM_BSDPathForMedia(ptr) >> +@ cdecl CDROM_GetMountPointForBSDDevice(ptr) >> +@ cdecl CDROM_BSDPathForHandle(long) >> \ No newline at end of file > > - You shouldn't add more seperation hacks. Besides that, if _APPLE_ > is not defined, the linker doesn't find these symbols. I tried to reduce them to the maximum. Sorry about that i correct it to the attached patch. > - Gcc spits out warnings about the missing newlines at the end of > files. > > Markus > Thanks Emmanuel Changelog: ntdll/cdrom.c, ntdll.spec : - preliminary CD-Rom support on Darwin

Dec. 30, 2005

Re: potential bug in winecfg

by Jesse Allen

On 12/29/05, Joseph Garvin <k04jg02(a)kzoo.edu> wrote: > For the audio freeze, try uninstalling arts if you have it. That's what > seems to cause the freeze on my box. I also get output on the terminal > saying "unable to create mcop directory." > Well in my case it seems to be wineoss.drv based on relay logs. Removing it and using alsa makes the lockup go away.

Dec. 30, 2005

Re: WineTools is in need of some major house cleaning!

by Sven Paschukat

I'll contact Joachim to get a statement. But plz give us some days... Sven Marcus Meissner schrieb: >>Could some one from the WineTools project give us a update on our concerns here? > > > I am not even sure Joachim von Thadden is subscribed here. > > Ciao, Marcus

Dec. 30, 2005

Re: SPARC assembly won't compile, problems with NT headers

by Segin

Alexandre Julliard wrote: >Troy Rollo <wine(a)troy.rollo.name> writes: > > > >>1. Modify the executable after the link phase; >>2. Put what we can into SizeOfImage (which could only be one part of the >>calculation - presumably "_end") and adjust at load time; or >>3. Don't rely on the assembler to put anything meaningful in there and >>calculate the whole thing at load time. >> >> > >4. Define an _end symbol in .data, that's good enough for what we > need. > > > Could you guys fill me in on what's going on with this? Is someone trying to compile Wine on a SPARC? I thought Wine was only for x86 and x86_64...

Dec. 30, 2005

Re: [bug 4004] MenuItemInfo vs GetMenuString - Try 2

by Rein Klazes

On Mon, 26 Dec 2005 21:50:54 -0000, you wrote: >Glancing through the patch, I see what you are trying to do, and some >comments (and remember this is just from a glance so far) > >1. I'm not sure the MENU_SetItemData for the ownerdraw case is correct as it >doesn't actually take a copy of the data, it saves the pointer. I'm pretty >sure Windows would take a copy (It does when inserting). In fact the >ownerdraw code doesn't set text, just dwitemdata in this routine I do not understand where the problem is. As you say, In the ownerdraw case only the dwItemData field is filled, which is not supposed to be a pointer to something the code should know or care about. > >2. SetMenuItemInfo_common, In the MIIM_TYPE case for ownerdraw - You would >lose the dwtypedata value for ownerdraw with text Yup that bit was suspect but my testing framework was not able to test that. Now it is and indeed the text is preserved, unless new text overwrites it. >3. Unrelated but just spotted, GetMenuItemInfo_common doesn't return >dwTypeData for ownerdraw what TYPE is used, can we add a test to confirm >that? Tests added, I could not find anything wrong with the behavior. I have sent the updated patch to wine-patches this time. Rein.

Dec. 30, 2005

Re: Preliminary CD-Rom support on MacOS X #2

by Robert Shearman

emmanuel maillard wrote: > Changelog : > kernel/proces.c : Initialize darwin removable devices I appreciate you splitting up your patches for easier review, but patches are meant to be independent atomic changes that improve the code. However, if Alexandre applied this patch alone then Wine wouldn't compile any more and this isn't acceptable. -- Rob Shearman

Dec. 30, 2005

Re: MSI: Change some FIXME messages to comments.

by Robert Shearman

Mike McCormack wrote: > ChangeLog: > Change some FIXME messages to comments. How hard would it be to do the work to really fix these FIXMEs? By changing these to comments I think they are going to be forgotten. -- Rob Shearman

Dec. 30, 2005

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

by Robert Shearman

Mike McCormack wrote: > } > hr=IStream_Read(pStm,header,8,&xread); >- if (hr || xread!=8) { >+ if (FAILED(hr) || xread!=8) { > FIXME("Failure while reading picture header (hr is %lx, nread is %ld).\n",hr,xread); > return hr; > } >@@ -1128,10 +1128,10 @@ static HRESULT WINAPI OLEPictureImpl_Loa > while (xread < origsize) { > hr = IStream_Read(pStm,xbuf+xread,origsize-xread,&nread); > xread+=nread; >- if (hr || !nread) >+ if (FAILED(hr) || !nread) > break; > } >- if (!nread || hr) /* done, or error */ >+ if (!nread || FAILED(hr)) /* done, or error */ > break; > if (xread == origsize) { > origsize += sizeinc; >@@ -1139,7 +1139,7 @@ static HRESULT WINAPI OLEPictureImpl_Loa > xbuf = HeapReAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, xbuf, origsize); > } > } >- if (hr) >+ if (FAILED(hr)) > TRACE("hr in no-stat loader case is %08lx\n", hr); > TRACE("loaded %ld bytes.\n", xread); > This->datalen = xread; >@@ -1155,7 +1155,7 @@ static HRESULT WINAPI OLEPictureImpl_Loa > ULONG nread; > hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > xread+=nread; >- if (hr || !nread) >+ if (FAILED(hr) || !nread) > break; > } > if (xread != This->datalen) > > > These changes are wrong. IStream_Read can return S_FALSE, which means that the call was successful, but didn't do what was intended. From MSDN: S_FALSE The data cannot be read from the stream object. Depending on the implementation, either S_FALSE or an error code could be returned when reading past the end of the stream. -- Rob Shearman

Dec. 30, 2005

Re: [comctl32] Reduce memory usage of the syslink control

by Robert Shearman

Thomas Weidenmueller wrote: >@@ -135,16 +141,16 @@ > SL_ITEM_TYPE type, PDOC_ITEM LastItem) > { > PDOC_ITEM Item; >- Item = Alloc(sizeof(DOC_ITEM) + ((textlen + 1) * sizeof(WCHAR))); >+ >+ textlen = min(textlen, lstrlenW(Text)); >+ Item = Alloc(FIELD_OFFSET(DOC_ITEM, Text[0]) + ((textlen + 1) * sizeof(WCHAR))); > > This line can be written simpler as: Item = Alloc(FIELD_OFFSET(DOC_ITEM, Text[textlen + 1])); -- Rob Shearman

Dec. 30, 2005

Re: winecfg: Added "Use PRIMARY selection" option

by Stefan Dösinger

> ChangeLog: > > Added support for "Use PRIMARY selection" clipboard option. One question: Why not make this the default? This would be the unix way to use the clipboard. Or use the primary selection on a middle mouse button click, and the other clipboard value on paste / CTRL-V? This is the behavior I'm used to from native apps. Is this possible?

Dec. 30, 2005