December 2005 - Wine-Devel - list.winehq.org

Re: Suggested changes to the menubuilder etc.

by Scott Ritchie

On Wed, 2005-12-14 at 14:51 -0800, Bill Medland wrote: > I am intending doing some work and submitting some patches to > "improve" the integration with the operating system desktop > integration. Rather than waste time coding up my ideas and > having Alexandre reject them I thought I'd start by specifying > what I intend and awaiting a barrage of complaints. So please > do comment. > > 1. I reckon it would be a good idea if somewhere we actually > wrote some prose that actually declared what it was we were > trying to achieve. I have a real issue with trying to decide if > the code does what it does because of a deliberate decision, > because either Windows or Linux or ... changed or because we > just had not got around to implementing what we want. Prose is > much better for that. I could put it in the Wine Developer's > Guide, in the Wiki (where?), or as a text file in the > winemenubuilder directory (my preference). Any comments? > > 2. My main issue is that we do not replicate the menu structure > under the start menu (and presumably the desktop too but I > haven't looked there). The program I am working with goes > several layers below the Programs directory. I see that > wineshelllink is able to take a path for the link but > winemenubuilder doesn't use that. I intend adding to > winemenubuilder so that it passes a more complete link, with > path, to get the depth. If you want prose, check out my (draft) spec for a super-cool integrated Wine in Ubuntu: https://wiki.ubuntu.com/BetterIntegratedWineSpec I would be forever grateful if you could help me get this working nice by doing what can be done upstream. As for where Wine needs to put .desktop files to put new entries in the applications menu, the standard place from what I hear is in ~/.local/share/applications. As for adding a new "Windows" program group, that has to be done somewhere else, but I believe that's out of the scope of Wine at the moment (ie: in another package). Thanks, Scott Ritchie

Dec. 15, 2005

Re: PATCH: msvcrt.wctime

by Alexandre Julliard

Marcus Meissner <marcus(a)jet.franken.de> writes: > Used by Google Earth. If anyone has a better > idea on the static buffer handling please speak up.. ;) It should go in the per-thread data structure (cf. msvcrt_get_thread_data). -- Alexandre Julliard julliard(a)winehq.org

Dec. 15, 2005

Re: Suggested changes to the menubuilder etc.

by Alexandre Julliard

Bill Medland <billmedland(a)mercuryspeed.com> writes: > 1. I reckon it would be a good idea if somewhere we actually > wrote some prose that actually declared what it was we were > trying to achieve. I have a real issue with trying to decide if > the code does what it does because of a deliberate decision, > because either Windows or Linux or ... changed or because we > just had not got around to implementing what we want. Prose is > much better for that. I could put it in the Wine Developer's > Guide, in the Wiki (where?), or as a text file in the > winemenubuilder directory (my preference). Any comments? It should go into the source file. It won't be maintained if it's a separate file. -- Alexandre Julliard julliard(a)winehq.org

Dec. 15, 2005

Re: question regarding FindWindow

by Marcus Meissner

> Look at why the message loop for 0x10024 doesn't process the message. > This may be one of the things that Windows handles in the server rather > than sending messages to each window. The window its trying to WM_GETTEXT is created by ole32.CoInitializeEx(0,2) (called by Google Earth startup code), and hangs only some lines later in a kernel32.WaitForSingleObject() (also called by a google earth supplied dll). WFSO does not do windows messageloop handling. :/ So, is CoInitializeEx(NULL,COINIT_APARTMENTTHREADED) is perhaps doing the wrong thing here. Ciao, Marcus

Dec. 15, 2005

Re: setupapi: Added stubs for SetupGetInfInformation and SetupQueryInfFileInformation [RESEND]

by Alexandre Julliard

James Hawkins <truiken(a)gmail.com> writes: > Is there anything wrong with this patch? Yes, the patch file is truncated. -- Alexandre Julliard julliard(a)winehq.org

Dec. 15, 2005

Re: CoCreateInstance not working without TLS libraries

by Alexandre Julliard

Cihan Altinay <cihan(a)uq.edu.au> writes: > Hi, > A very basic C++ program fails with > > err:ntdll:RtlpWaitForCriticalSection section 0x7f64c560 "x11drv_main.c: > X11DRV_CritSection" wait timed out in thread 001c, blocked by 001e, retrying (60 > sec) > > when the Linux TLS libraries are not in the library path (it works fine > otherwise). Non-TLS libraries in recent glibc versions are not compatible with Wine. What are you trying to do that requires not using TLS? -- Alexandre Julliard julliard(a)winehq.org

Dec. 15, 2005

Re: comctl32: Create the compatible bitmap from the screen, not the bitmap we're copying

by James Hawkins

On 12/15/05, Paul Vriens <paul.vriens(a)xs4all.nl> wrote: > > > > > Hi James, > > somehow you managed to attach an empty file. (I think). > Hmm that is strange :-\. Thanks for the heads up. -- James Hawkins

Dec. 15, 2005

Re: comctl32: Create the compatible bitmap from the screen, not the bitmap we're copying

by Paul Vriens

> Hi, > > This patch fixes bug 1715. > > Changelog > * Create the compatible bitmap from the screen, not the bitmap we're > copying. > > dlls/comctl32/toolbar.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > -- > James Hawkins > > Hi James, somehow you managed to attach an empty file. (I think). Paul.

Dec. 15, 2005

Re: Fix dsiplay of fonts with Symbol codepages (codepage 42) as well

by David Moore

Dmitry Timoshkov wrote: > "David Moore" <davidm(a)sjsoft.com> wrote: > >> The patch below first checks to see if the codepage is one of the >> exceptions, and if it is, passes in NULLs for the last two arguments. > > > I wonder how did you build the list of exceptions: why CP_UTF7 is there > but CP_UTF8 is not? Why 50xxx,52xxx,57xxx code pages are there? > > I'd suggest as a start to have only CP_UTF7, CP_UTF8 and CP_SYMBOL in > the exception list. > I did miss CP_UTF8, as that wasn't part of the main list of exceptions. I will fix that and resubmit. I didn't build the list of exceptions. If you take a look at the documentation here: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/intl/unico…. Under the description for dwflags, it lists all the codepages I have made the exception for. Under the descriptions for lpDefaultChar and lpUsedDefaultChar, it has the following line: "For the code pages mentioned in /dwFlags/, /lpUsedDefaultChar/ must be NULL, otherwise the function fails with ERROR_INVALID_PARAMETER." Thus, the list of exceptions comes straight from the documentation for this function. I will change the patch to only CP_UTF7, CP_UTF8 and CP_SYMBOL if you still suggest I do - this solves my problem. I just thought that my patch as currently stands (and more so with the addition of CP_UTF8) is more correct. Please advise. thanks, David Moore

Dec. 15, 2005

Re: Fix dsiplay of fonts with Symbol codepages (codepage 42) as well

by Dmitry Timoshkov

"David Moore" <davidm(a)sjsoft.com> wrote: > The patch below first checks to see if the codepage is one of the > exceptions, and if it is, passes in NULLs for the last two arguments. I wonder how did you build the list of exceptions: why CP_UTF7 is there but CP_UTF8 is not? Why 50xxx,52xxx,57xxx code pages are there? I'd suggest as a start to have only CP_UTF7, CP_UTF8 and CP_SYMBOL in the exception list. -- Dmitry.

Dec. 15, 2005