December 2005 - Wine-Devel - list.winehq.org

Re: Robert Reif : winecfg: Added support for auto detecting all drivers by attempting to

by Eric Pouech

> It is not typical for an application to bypass winmm and communicate > directly with a driver. Only a control panel or device manager type > application would ever even try something like this. Winecfg is one of > those unusual programs. Opening a driver more than once will not cause > any problems. The open functions in all the drivers are just stubs. > Loading a driver is what causes a drivers state to be initialized and > there is no way going through winmm to load the same driver more than > once. Trying to open a specific driver's device through for example > waveOutOpen more than once either through winmm or directly to the > driver will only allow the first open to succeed because all attempts > after the first will see that the device is already opened and fail. this depends on the driver: for example in wineoss, for the wod part, it will work if you specify the same format in the same thread (as we do ref counting on open). Winealsa on the other hand should be ok. However, since winmm doesn't regenerate its internal status after an OpenDriver, one cannot use waveOut* to access that driver. A+ -- Eric Pouech

Dec. 12, 2005

Re: WIDL: Zero Initialize Server Parameters

by Robert Shearman

Robert Shearman wrote: > ChangeLog: > Zero initialize parameters in the generated code. Based on a patch by > Eric Kohl. Oops. Looks like this patch was already accepted and the patch I just sent was a merge conflict. Please ignore. -- Rob Shearman

Dec. 12, 2005

Re: [NDR] Implement NdrClientCall2 and NdrServerCall2

by Robert Shearman

Detlef Riekenberg wrote: >Am Donnerstag, den 01.12.2005, 00:39 -0600 schrieb Robert Shearman: > > > >>[NDR] Implement NdrClientCall2 and NdrServerCall2 >>[NDR] Fix handle support for stubless objects >>[NDR] Fix Accessing Arguments in NdrClientCall2 >> >> > > >Hi Rob. >I tested your Patches with printui.dll and winspool.drv (from w2k) >and got only "RPC_X_WRONG_STUB_VERSION" > > Thanks for giving them a try. >--- cut --- >trace:rpc:NdrClientCall2 MIDL stub version = 0x5030117 >fixme:rpc:NdrClientCall2 RPC_FC_BIND_GENERIC >--- cut --- > > Generic binding handles are unimplemented. The two that are implemented so far are implicit and explicit binding handles, where the handle is already setup and initialized before the function is called. Generic binding handles are auto-initializing, meaning that we should call a function to get the appropriate handle where this FIXME is. This isn't implemented yet, due to me not having a test program for it. >Then i commented out the RpcRaiseException() after the fixme and run: > >wine rundll32 printui.dll,PrintUIEntry /s > >The Server-Properties-Window opens and react on the Mouse, >but the Fields are Empty or filled with Garbage. >(same garbage as buildin winspool.drv with my patch for OpenPrinter) > > This would probably be because the RPC call is failing. I think NdrSendReceive should throw an exception on failure, but currently doesn't so it silently fails, causing the garbage you describe. The failure is caused by not having a handle to the server. The one question I have about this is: what should be acting as the server? If it is a service on NT then that means this still won't work on Wine, until that service is implemented (perhaps it is implemented by spoolsvc.dll, I can't remember the exact name of it). >I attached an updated log to bug 3105 > >Thanks for your work on RPC. > No problem! -- Rob Shearman

Dec. 12, 2005

Re: Wine: DirectDraw over Direct3D

by Stefan Dösinger

Hello, > Following your mail on wine-devel about DDRAW, I now understand better > what's going on behind the scenes. Below is the result of an experiment I > did at the beginning of this month. Reading your message, I wanted to share > it with you. First, thanks for your comments, and one suggestion: You should also CC the mails to wine-devel(a)winehq.org, so others can read it too. > I'm an occasional wine user for games, and an experienced developper in > other projects. Age of Empires II has always been really slow, so I finally > decided to run an oprofile session. The results are attached to this > message (wine cvs of 2005-12-04). When I saw the results, I immediately > thought "put that conversion on the GPU". It seems you found that solution > long ago :) Yes, this is known quite well, and if you search the archives, you'll see that it has been mentioned over and over > Of course, there still are the ~35% used by X11, but even if these are not > compressible (DC stuff), a potential x5 increase in game speed due to DIB > would make it much more playable. The need for a better DIB engine is also known, and there are 2 DIB engines ready to be included into Wine: One was sponsored by Transgaming, and the other one is the DIB engine from ReactOS. The ReactOS engine is said to be faster, and it's favored. We'll see, perhaps we can include it with the DirectDraw re-work. The other problem is hardware 2D accelleration: Most DirectDraw functionality is handled by the GPU on Windows, since the beginning of DirectDraw, long before 3D accellerators were around. In Wine, there are 2 ways: The first is to use X calls, which is safe, but slow. The other one is the use of DGA, which is as fast as the Windows way, but it requires root preveliges, or at least write access to /dev/mem, which is a HORRIBLE security risk. That's were OpenGL comes into play: It is hardware accellerated, and doesn't require /dev/mem access. But the drawback is, that it needs a 3D accellerator, and a decent driver. It works fine for nvidia cards, but it is horribly slow for ati cards. > it seems using 3D as > the 2D backend it the only option that makes sense nowadays and in the near > future. In Wine case, this supports your DDraw using D3D idea. Yeah, that perfectly true for current hardware, rumors even have it, that today's GPUs don't have a 2D engine any more, and whatever you do, it will make use of the 3D functionality. The problem are older cards: It would be nice, if games worked on systems for which they were designed for, for example, I'd love to see Anno 1602 working in Wine on my old Acer Extensa 660 with an 120 MHZ Pentium CPU, and a Chips and Technologies 65000 GPU. Thanks for your interest, and I'd appreciate performance tests once my work is stable ;) Stefan

Dec. 12, 2005

Re: Alexandre Julliard : server: Added access rights mapping to synchronization objects.

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > How about adding a new structure that contains the ops structure and the > data then to not mix them then? I don't see any reason to make the data structure more complex. The amount of code is really pretty much the same, putting it in a table won't make much difference. Also a function is a lot more flexible, even if the results don't depend on the specific object we may at some point want to make them depend on something else, and using a constant table would needlessly limit our options. -- Alexandre Julliard julliard(a)winehq.org

Dec. 12, 2005

Re: Alexandre Julliard : server: Added access rights mapping to synchronization objects.

by Robert Shearman

Alexandre Julliard wrote: >Robert Shearman <rob(a)codeweavers.com> writes: > > > >>Why did you decide to rely on another function to map the access rights? >>It seems that none of the objects' mappings depend on any state in the >>object, so couldn't you have just put the access rights that >>GENERIC_READ, GENERIC_WRITE, GENERIC_EXECUTE and GENERIC_ALL map to >>somewhere associated with the object and have just one mapping function. >> >> > >I think it's cleaner to use functions in the ops structure rather than >starting to mix various data pointers in there too. > How about adding a new structure that contains the ops structure and the data then to not mix them then? -- Rob Shearman

Dec. 12, 2005

Re: gethostbyname(my_name) and IL2-Sturmovik

by Christoph Frick

On Mon, Dec 12, 2005 at 04:44:23PM +0100, David Nolden wrote: > But if it is desired that gethostbyname(own_name) preferrably returns > the public IP-Adress, then this code should solve the problem, > although maybe a bit more checking should be done which IP-Adress > should be chosen as the public one for cases with multiple > non-loopback-interfaces. i dont know if this helps for your problem (i never tried IL2 and PF multiplayer, but i have a similar network problem with NR2003, GPL, LFS,...). this games check the registry for the ip-address and so forth. i entered some keys described by microsoft[1] to help this games find their "way to the net". maybe your "localhost" problem is only a result from not finding the proper address in the first place (you can find this out by ``WINEDEBUG=+reg ./il2fb.exe''. @all: AFAIK there where some talk/patch about WINE beeing able to detect/set this settings while starting wineserver in the registry by itself? [1] http://support.microsoft.com/default.aspx?scid=kb;en-us;120642 -- cu

Dec. 12, 2005

Re: Alexandre Julliard : server: Added access rights mapping to synchronization objects.

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Why did you decide to rely on another function to map the access rights? > It seems that none of the objects' mappings depend on any state in the > object, so couldn't you have just put the access rights that > GENERIC_READ, GENERIC_WRITE, GENERIC_EXECUTE and GENERIC_ALL map to > somewhere associated with the object and have just one mapping function. I think it's cleaner to use functions in the ops structure rather than starting to mix various data pointers in there too. -- Alexandre Julliard julliard(a)winehq.org

Dec. 12, 2005

Re: Alexandre Julliard : server: Added access rights mapping to synchronization objects.

by Robert Shearman

Alexandre Julliard wrote: >@@ -132,6 +133,15 @@ static int event_satisfied( struct objec > return 0; /* Not abandoned */ > } > >+static unsigned int event_map_access( struct object *obj, unsigned int access ) >+{ >+ if (access & GENERIC_READ) access |= STANDARD_RIGHTS_READ | SYNCHRONIZE | EVENT_QUERY_STATE; >+ if (access & GENERIC_WRITE) access |= STANDARD_RIGHTS_WRITE; >+ if (access & GENERIC_EXECUTE) access |= STANDARD_RIGHTS_EXECUTE; >+ if (access & GENERIC_ALL) access |= STANDARD_RIGHTS_ALL | EVENT_ALL_ACCESS; >+ return access & ~(GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE | GENERIC_ALL); >+} >+ > static int event_signal( struct object *obj, unsigned int access ) > { > struct event *event = (struct event *)obj; > Why did you decide to rely on another function to map the access rights? It seems that none of the objects' mappings depend on any state in the object, so couldn't you have just put the access rights that GENERIC_READ, GENERIC_WRITE, GENERIC_EXECUTE and GENERIC_ALL map to somewhere associated with the object and have just one mapping function. -- Rob Shearman

Dec. 12, 2005

Re: crypt32: decode cleanups

by Alexandre Julliard

Juan Lang <juan_lang(a)yahoo.com> writes: > ChangeLog: > - implement a helper to decode sequences of like types > - use helper functions wherever applicable when decoding > - fix a few other small bugs This breaks the test: encode.c:790: Test failed: Expected OID Juan Lang, got NULL encode.c:790: Test failed: Expected OID Juan Lang, got NULL encode.c:790: Test failed: Expected OID Juan Lang, got NULL -- Alexandre Julliard julliard(a)winehq.org

Dec. 12, 2005