December 2005 - Wine-Devel - list.winehq.org

Re: git patch to gmail draft script

by James Hawkins

On 12/5/05, James Hawkins <truiken(a)gmail.com> wrote: > Hey all, > > I've hacked up a little script that takes your committed git changes > and puts a draft in your gmail draft folder for each committ that > contains a changelog and the attached diff. To use the script, make > sure you have python installed. I knew I forgot something. You'll also need libgmail for python installed as well: http://libgmail.sourceforge.net/ -- James Hawkins

Dec. 5, 2005

git patch to gmail draft script

by James Hawkins

Hey all, I've hacked up a little script that takes your committed git changes and puts a draft in your gmail draft folder for each committ that contains a changelog and the attached diff. To use the script, make sure you have python installed. You'll also need to change the variables at the top of the script to match your specifics. The script is pretty simple, so if you don't like the format of the email it wouldn't be hard to change. The process goes like so: 1) make your committs, but when you're writing the changelog entry for the committ, make sure to put all the changes you would have in the Changelog section of the email ie for one of my recent patches, the committ message was, * Use DelNode itself for the directory recursion. * Handle the dwFlags parameter. * Factor out file creation and deletion. * Add test cases for DelNode and make them pass. you can use asterisks if you like or not, it won't affect the script. 2) ./makedraft.py 3) the script calls git-format-patch for you and loops through all the committs 4) the script asks you for a subject (of the email) for each committ 5) if you don't want to send a patch to wine-patches, enter 'stop' as the subject (minus the quotes) 6) the diffs will be in diff_dir and the drafts will be in your gmail drafts folder 7) append anything you need to the email and press send If you have any comments or suggestions, I'd like to hear them (I think the script is rather ugly myself, but it gets the job done :)) -- James Hawkins

Dec. 5, 2005

Re: shell32: Bind to correct drop target after drag scrolling

by Michael Jung

Hi Alexandre, seems like you rejected this patch. Is it too hack'ish? At a first glance it seems like it would be enough to figure out the IDropTarget belonging to the hwnd and call a DragOver on this interface. The problem is that the drop source (or the DoDragDrop function) might have to change the cursor. Could you please give me a tip on how to do this the right way? Index: dlls/shell32/shlview.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shlview.c,v retrieving revision 1.123 diff -u -p -r1.123 shlview.c --- dlls/shell32/shlview.c 2 Dec 2005 13:14:58 -0000 1.123 +++ dlls/shell32/shlview.c 2 Dec 2005 16:44:38 -0000 @@ -2190,6 +2190,8 @@ static ULONG WINAPI ISVDropTarget_Releas #define IDT_RIGHT 0x8u VOID CALLBACK scroll_timer_proc(HWND hwnd, UINT uMsg, UINT_PTR idTimer, DWORD dwTimer) { + INPUT input; + switch (idTimer) { case IDT_UP: SendMessageW(hwnd, WM_VSCROLL, SB_LINEUP, 0); @@ -2204,6 +2206,14 @@ VOID CALLBACK scroll_timer_proc(HWND hwn SendMessageW(hwnd, WM_HSCROLL, SB_LINEDOWN, 0); break; } + + /* The cursor might now hover over a different item in the listview than + * prior to the scrolling. Send a dummy mouse event (with a (x=0, y=0) + * relative movement) to initiate the apropriate Drag & Drop calls. */ + ZeroMemory(&input, sizeof(input)); + input.type = INPUT_MOUSE; + input.u.mi.dwFlags = MOUSEEVENTF_MOVE; + SendInput(1, &input, sizeof(input)); } /****************************************************************************** Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

Dec. 5, 2005

Re: Implement Old Names Option

by Dimi Paun

From: "Robert Shearman" <rob(a)codeweavers.com> > Implement '-o' option. This is equivalent to MIDLs '/oldnames' option. Not a good choice, '-o' is used for output typically. How about --oldnames? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Dec. 5, 2005

Re: Why Steam fails

by Kuba Ober

> > > I think I'm the only one with that problem... and I can't figure out > > > what's wrong :( > > > > How's your swapfile size? Maybe your system doesn't do overcommits, thus > > there must be enough physical ram + swapfile for all virtual allocations. > > That'd be the only thing that I could think of, although whether > > overcommits can be disabled and so on I don't know. So I might be just > > rambling insanely ;-) > > overcommitting is default and I knew that there was a way top turn it off, > so a find /proc -name "*commit*" found: > > /proc/sys/vm/overcommit_ratio > /proc/sys/vm/overcommit_memory > > Oh wait, it seems it's not default: > > $ cat /proc/sys/vm/overcommit_memory > 0 Nevertheless I acknowledge that a compounding issue is VM fragmentation of a process. Redoing the prelink & friends would be one way to attack that. Another issue is how safe it really is to allow overcommits. They are off on my FC4 system too. Cheers, Kuba

Dec. 5, 2005

Re: winspool: Add Documentation for the Port-Functions (without line-wrap)

by Vitaliy Margolen

Monday, December 5, 2005, 7:03:46 AM, Detlef Riekenberg wrote: > Second try with git. This Time without line-wrap > Changelog: > - Add Documentation for the Port-Functions > Content-Disposition: attachment; filename=document_port_functions.diff > Content-Type: text/x-patch; name=document_port_functions.diff; charset=UTF-8 > Content-Transfer-Encoding: 7bit Could you drop "; charset=UTF-8" part? It's not UTF-8 at all (since it's 7-bit and text/x-path). Vitaliy

Dec. 5, 2005

Re: winspool: Add Documentation for the Port-Functions

by James Hawkins

On 12/5/05, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > /****************************************************************** > * DeletePortA [WINSPOOL.@] > * > + * Delete a specific Port (ANSI) > + * > + * See DeletePortW. > + * ... > /****************************************************************** > * DeletePortW [WINSPOOL.@] > * > + * Delete a specific Port (UNICODE) > + * The (ANSI) and (UNICODE) are superfluous. For the ansi version, all you need is the 'See DeletePortW' instead of reusing 'Delete a specific port' as well. -- James Hawkins

Dec. 5, 2005

Re: Why Steam fails

by Andreas Mohr

Hi, On Mon, Dec 05, 2005 at 09:07:45AM -0500, Kuba Ober wrote: > On Saturday 03 December 2005 15:02, Ivan Gyurdiev wrote: > > I think I'm the only one with that problem... and I can't figure out > > what's wrong :( > > How's your swapfile size? Maybe your system doesn't do overcommits, thus there > must be enough physical ram + swapfile for all virtual allocations. That'd be > the only thing that I could think of, although whether overcommits can be > disabled and so on I don't know. So I might be just rambling insanely ;-) overcommitting is default and I knew that there was a way top turn it off, so a find /proc -name "*commit*" found: /proc/sys/vm/overcommit_ratio /proc/sys/vm/overcommit_memory Oh wait, it seems it's not default: $ cat /proc/sys/vm/overcommit_memory 0 Andreas Mohr

Dec. 5, 2005

Re: ddraw: make some driver info not const

by Rein Klazes

On Mon, 05 Dec 2005 12:07:32 +0100, you wrote: > >You can't return from inside a __TRY block. I did not know. Here is the next attempt: Changelog: dlls/ddraw : main.c, Makefile.in Catch access violations when calling the DirectDrawEnumerateProc. Rein.

Dec. 5, 2005

Re: Why Steam fails

by Kuba Ober

On Saturday 03 December 2005 15:02, Ivan Gyurdiev wrote: > Stefan Dösinger wrote: > > Hello, > > > >> It doesn't seem to check the retval of the first alloc, which fails > >> about half of the time in > >> wine_anon_mmap (mmap() call) with ENOMEM. If the allocation succeeds, > >> Steam proceeds to run. > >> If it fails, Steam dies with the message above. > > > > I just started Steam 5 times without a single failure. I can't reproduce > > the problem. > > I think I'm the only one with that problem... and I can't figure out > what's wrong :( How's your swapfile size? Maybe your system doesn't do overcommits, thus there must be enough physical ram + swapfile for all virtual allocations. That'd be the only thing that I could think of, although whether overcommits can be disabled and so on I don't know. So I might be just rambling insanely ;-) Cheers, Kuba

Dec. 5, 2005