December 2005 - Wine-Devel - list.winehq.org

Re: opengl support in wine

by Tomas Carnecky

Stefan Dösinger wrote: > How is the nvidia driver doing recently? Does it have acpi suspend support? Seems like ACPI suspend isn't supported under amd64 :( $ cat /sys/power/state standby mem

Dec. 2, 2005

Re: opengl support in wine

by Tomas Carnecky

Stefan Dösinger wrote: > How is the nvidia driver doing recently? Does it have acpi suspend support? Can't comment, because my computer is a desktop computer, not a laptop and I havent tried suspend or sleep (I don't even know how to configure it). > How is the speed compared to the Windows drivers? Can't comment either, I haven't windows installed here. Besides, do you know a relibale opengl test application for both windows and linux? glxgears isn't really a test application. tom

Dec. 2, 2005

Re: DBGRID32.OCX fix - RFC

by Alex Villacís Lasso

Robert Shearman wrote: > > What hRefType is passed to the function? I don't think the above is > quite correct. Can you try changing the if statement to something like > this: > > if (hRefType == -1 && > (This->TypeAttr.typekind == TKIND_DISPATCH) && > (This->TypeAttr.wTypeFlags & > (TYPEFLAG_FDUAL|TYPEFLAG_FDISPATCHABLE))) > > That would not keep the app from crashing. For the case of DBGRID32.OCX, hRefType is systematically == 19, and it says so in the ERR message just before the crash. However, on a second look, maybe the problem is not that the function performs the wrong action, but that it returns the wrong value (E_FAIL, should be TYPE_E_ELEMENTNOTFOUND). I have to check this alternate theory on my home machine. Alex Villacís Lasso

Dec. 2, 2005

Re: DBGRID32.OCX fix - RFC

by Robert Shearman

Alex Villacís Lasso wrote: > I would like to know if the attached patch (which prevents > DBGRID32.OCX from crashing, as well as adding additional debugging > information when a reference is not found) would step on anybody's > toes (especially Robert Shearman, since he is sending several oleaut32 > patches himself). As of 2005-12-01 CVS, any VisualBasic application > that tries to use DBGRID32.OCX will systematically crash unless the > patch is applied. However, since Robert Shearman is sending oleaut32 > fixes, I think he might implement some functionality that will, as a > side effect, fix the DBGRID32.OCX bug. No, I have no plans to change anything that should affect this. > ITypeInfoImpl *This = (ITypeInfoImpl *)iface; > HRESULT result = E_FAIL; > >- if (hRefType == -1 && >- (((ITypeInfoImpl*) This)->TypeAttr.typekind == TKIND_DISPATCH) && >- (((ITypeInfoImpl*) This)->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL)) >+ if ( >+ ( >+ hRefType == -1 && >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL) >+ ) >+ || >+ ( >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDISPATCHABLE) >+ ) >+ ) > { > > What hRefType is passed to the function? I don't think the above is quite correct. Can you try changing the if statement to something like this: if (hRefType == -1 && (This->TypeAttr.typekind == TKIND_DISPATCH) && (This->TypeAttr.wTypeFlags & (TYPEFLAG_FDUAL|TYPEFLAG_FDISPATCHABLE))) -- Rob Shearman

Dec. 2, 2005

DBGRID32.OCX fix - RFC

by Alex Villacís Lasso

I would like to know if the attached patch (which prevents DBGRID32.OCX from crashing, as well as adding additional debugging information when a reference is not found) would step on anybody's toes (especially Robert Shearman, since he is sending several oleaut32 patches himself). As of 2005-12-01 CVS, any VisualBasic application that tries to use DBGRID32.OCX will systematically crash unless the patch is applied. However, since Robert Shearman is sending oleaut32 fixes, I think he might implement some functionality that will, as a side effect, fix the DBGRID32.OCX bug. Alex Villacís Lasso

Dec. 2, 2005

Re: opengl support in wine

by Stefan Dösinger

> My approach is: > ... I can't comment on the technical details, because I am not an OpenGL expert at all. But I'd like to test it when you're finished. There may be a workaround for the glReadPixels slowlyness. I've seen that both mplayer and xine can draw a 2D movie fast onto an OpenGL texture, as long as the player window isn't overlapped too much. At least they pretend to use OpenGL to render the video. Once the window is overlapped, it becomes slow as hell( 1 fps, if not less). > One note though, just one week ago I've had a nVidia 6800 on a 8x AGP > bus. And I still could get ~500MB/s readback using glReadPixels(), that > makes ~100 fps. This 1fps glReadPixels() is clearly an ATI issue. That's > also why I would never buy an ATI card, because, honestly, they suck > (I've had one, and it sucked badly, their drivers crashed the whole > computer hardly when I've tried to play World of Warcraft). Sure it's an ATI driver bug. But I can't change my notebooks graphics chip ;) To be fair: The ATI driver is constantly improving, and it's really useable now. The only thing that bothers me right now, is the recent regression on old cards introduced with fglrx 8.19.10. I really hope they fix it. How is the nvidia driver doing recently? Does it have acpi suspend support? How is the speed compared to the Windows drivers? Stefan

Dec. 2, 2005

Re: Steam regression of the day

by Ivan Gyurdiev

Stefan Dösinger wrote: > Hello, > >> The relevant bugzilla is here: >> http://bugs.winehq.org/show_bug.cgi?id=2926 >> >> I'm just curious if this patch has been forgotten, or if this issue is >> just too difficult to fix at this time. >> > The problem Steam shows is common to all boarderless Apps which don't specify > the WS_EX_APPWINDOW flag. Fixing it is quite tricky, Ok, so maybe I should stop asking about it then :) Just making sure it isn't forgotten... The other problem I mentioned, by the way, (invisible fonts) has been fixed, and Steam now appears to work (you still have to re-try 10 or so times to get past the memory assertion bug...). I'm downloading HL2 quickly, before it breaks again!

Dec. 2, 2005

Re: [RESEND] riched20: register ListBox & ComboBox classes

by Alexandre Julliard

Cihan Altinay <cihan(a)uq.edu.au> writes: > It seems this patch was ignored and I would appreciate some comments because > I haven't done much wine development yet (and probably made a lot of mistakes). > Basically, I did some reverse engineering to see what is going on under Windows > and implemented the (de)registration of the two classes accordingly. The effect > of the patch can be seen in the attached screenshots which is the Options > dialog of MS PowerPoint 2003. The bit about the magic flag values is quite ugly, you should use one boolean variable for each registered class instead. -- Alexandre Julliard julliard(a)winehq.org

Dec. 2, 2005

Re: msvidc32: Remove unused DllMain() function

by Dmitry Timoshkov

"Francois Gouget" <fgouget(a)free.fr> wrote: > msvideo1.c defines a DllMain() function but: > * it is not exported in the spec file > * it is not referenced in any way anywhere else > * the native dll does not export a DllMain function either DllMain does not need to be exported to define an entry point of the DLL. Moreover, DllMain of msvidc32 initializes MSVIDC32_hModule which is used later on. -- Dmitry.

Dec. 2, 2005

Unnormal slowness in Heroes 4 (X11DRV_BitBlt?)

by Marinescu-Ghetau Iulian

See http://bugs.winehq.org/show_bug.cgi?id=3902 Hey guys, a bit of help here! I did the following changes: -added member to X_PHYSBITMAP: XRectangle modified_rect; -added 2 functions: /*********************************************************************** * X11DRV_SetBoundRect */ void X11DRV_SetBoundRect(X_PHYSBITMAP *physBitmap, INT x, INT y, INT width, INT height) { XRectangle *t; INT xMin,yMin,xMax,yMax; if (!physBitmap) return; t = &(physBitmap->modified_rect); if ( t->width && t->height && /*already a valid rect inside*/ width && height ) /*not trying to invalidate rect*/ { //calculate the union of the two rectangles xMin = ((t->x < x)?t->x:x); yMin = ((t->y < y)?t->y:y); xMax = ((t->x + t->width > x + width)?(t->x + t->width):(x + width)); yMax = ((t->y + t->height > y + height)?(t->y + t->height):(y + height)); t->x = xMin; t->y = yMin; t->width = xMax - xMin; t->height = yMax - yMin; } else { t->x = x; t->y = y; t->width = width; t->height = height; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, t->x, t->y, t->width, t->height); } /*********************************************************************** * X11DRV_GetBoundRect */ UINT X11DRV_GetBoundRect(X_PHYSBITMAP *physBitmap, INT *x, INT *y, INT *width, INT *height) { DIBSECTION dib; XRectangle *t; if (!physBitmap || GetObjectW( physBitmap->hbitmap, sizeof(dib), &dib ) != sizeof(dib)) { ERR("called for non-DIBSection!?\n"); return 1; } t = &(physBitmap->modified_rect); /* we should check for oversize values */ if ( (t->width > 0) && (t->height > 0) && (t->x < dib.dsBm.bmWidth) && (t->y < dib.dsBm.bmHeight) ) { *x = t->x; *y = t->y; if (t->x + t->width > dib.dsBm.bmWidth) *width = dib.dsBm.bmWidth - t->x; else *width = t->width; if (t->y + t->height > dib.dsBm.bmHeight) *height = dib.dsBm.bmHeight - t->y; else *height = t->height; } else { *x = 0; *y = 0; *width = dib.dsBm.bmWidth; *height = dib.dsBm.bmHeight; } TRACE("(%p,%d,%d,%d,%d)\n", physBitmap->hbitmap, *x, *y, *width, *height); return 0; } -changed X11DRV_DIB_DoUpdateDIBSection like this: static void X11DRV_DIB_DoUpdateDIBSection(X_PHYSBITMAP *physBitmap, BOOL toDIB) { INT x,y,width,height; if ( X11DRV_GetBoundRect(physBitmap,&x,&y,&width,&height) ) return; /*invalidate bound rect*/ X11DRV_SetBoundRect(physBitmap,0,0,0,0); X11DRV_DIB_DoCopyDIBSection(physBitmap, toDIB, physBitmap->colorMap, physBitmap->nColorMap, physBitmap->pixmap, x, y, x, y, width, height); } - and finally, a GDI function calls it like this (for example bitblt): X11DRV_SetBoundRect(physDevDst->bitmap,xDst,yDst,width,height); X11DRV_CoerceDIBSection( physDevDst, DIB_Status_GdiMod, FALSE ); if (physDevDst != physDevSrc) { X11DRV_SetBoundRect(physDevSrc->bitmap,xSrc,ySrc,width,height); X11DRV_CoerceDIBSection( physDevSrc, DIB_Status_GdiMod, FALSE ); } result = BITBLT_InternalStretchBlt( physDevDst, xDst, yDst, width, height, physDevSrc, xSrc, ySrc, width, height, rop ); END: if (physDevDst != physDevSrc) X11DRV_UnlockDIBSection( physDevSrc, FALSE ); X11DRV_UnlockDIBSection( physDevDst, TRUE ); What am i doing wrong, i mean is my logic correct ?

Dec. 2, 2005