February 2005 - Wine-Devel - list.winehq.org

free fonts

by Brian Vincent

The issue of fonts came up a while ago and I know some people are working on free replacements for some of the core fonts. Anyway, I stumbled on this resource tonight with a huge listing of fonts: http://cgm.cs.mcgill.ca/~luc/originalfonts.html Seems like there's got to be a few decent ones in there the authors would be willing to let us use and relicense. -Brian

Feb. 28, 2005

Re: [PATCH] Added 2 functions to shell32

by Gianluigi Tiesi

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dmitry Timoshkov wrote: | "Gianluigi Tiesi" <sherpya(a)netfarm.it> wrote: | | |>+BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) |>+{ |>+ int i; |>+ int len; |>+ if (!path1 || !path2) return FALSE; |>+ |>+ len = strlenW(path1); |>+ if (len > strlenW(path2)) return FALSE; |>+ |>+ for (i=0; i < len; i++) |>+ if (path1[i] != path2[i]) return FALSE; |>+ return TRUE; |>+} | | | You need to do a case insensitive comparison of paths. | | Also, if you could use a usual for Wine formatting style with 4 space | indentation that would be very nice. | This version does case insensitive check, I'm using tolowerW instead of standard windows towlower, hope it's correct. I've used one tab indentation since the other code uses the same indentation. I may provide other documented/undocumented functions if you like. Bye - -- Gianluigi Tiesi <sherpya(a)netfarm.it> EDP Project Leader Netfarm S.r.l. - http://www.netfarm.it/ Free Software: http://oss.netfarm.it/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCIoqy3UE5cRfnO04RAlAiAJ4igIRlGRlXKSaRyi5VJsL/UzdVzwCgkn2c vB/SAxWHX1hkDn2BEe6MEUo= =449f -----END PGP SIGNATURE----- Index: dlls/shell32/shell32.spec =================================================================== RCS file: /home/wine/wine/dlls/shell32/shell32.spec,v retrieving revision 1.96 diff -u -r1.96 shell32.spec --- dlls/shell32/shell32.spec 23 Feb 2005 15:41:14 -0000 1.96 +++ dlls/shell32/shell32.spec 28 Feb 2005 03:03:45 -0000 @@ -250,6 +250,7 @@ # >= NT5 714 stdcall @(ptr) SHELL32_714 # PathIsTemporaryW 730 stdcall -noname RestartDialogEx(long wstr long long) + 755 stdcall -noname PathIsEqualOrSubFolder(wstr wstr) 1217 stub FOOBAR1217 # no joke! This is the real name!! @@ -456,3 +457,4 @@ # _WIN32_IE >= 0x600 @ stdcall SHDefExtractIconA(str long long ptr ptr long) @ stdcall SHDefExtractIconW(wstr long long ptr ptr long) +@ stub SHCreateShellItem Index: dlls/shell32/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shellpath.c,v retrieving revision 1.98 diff -u -r1.98 shellpath.c --- dlls/shell32/shellpath.c 14 Feb 2005 11:07:55 -0000 1.98 +++ dlls/shell32/shellpath.c 28 Feb 2005 03:03:49 -0000 @@ -411,6 +411,23 @@ } /************************************************************************* + * PathIsEqualOrSubFolder [SHELL32.755] + */ +BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) +{ + int i; + int len; + if (!path1 || !path2) return FALSE; + + len = strlenW(path1); + if (len > strlenW(path2)) return FALSE; + + for (i=0; i < len; i++) + if (tolowerW(path1[i]) != tolowerW(path2[i])) return FALSE; + return TRUE; +} + +/************************************************************************* * PathFileExists [SHELL32.45] */ BOOL WINAPI PathFileExistsAW (LPCVOID lpszPath) Index: dlls/shell32/undocshell.h =================================================================== RCS file: /home/wine/wine/dlls/shell32/undocshell.h,v retrieving revision 1.28 diff -u -r1.28 undocshell.h --- dlls/shell32/undocshell.h 13 Dec 2004 21:19:01 -0000 1.28 +++ dlls/shell32/undocshell.h 28 Feb 2005 03:03:49 -0000 @@ -410,6 +410,8 @@ BOOL WINAPI PathIsExeAW(LPCVOID lpszPath); +BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2); + BOOL WINAPI PathIsDirectoryAW(LPCVOID lpszPath); BOOL WINAPI PathFileExistsAW(LPCVOID lpszPath);

Feb. 28, 2005

Re: New uninstaller

by Dmitry Timoshkov

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > With some help I'll be able to improve it (more unicodification, etc.) > when I'll come back. You can't really convert to unicode partially, you have to do it in one go. That not only will simplify things a lot, but also will save you a lot of time. > + for (i=0; i < numentries; i++) > + { > + len = WideCharToMultiByte(CP_UNIXCP, 0, entries[i].descr, -1, NULL, 0, NULL, NULL); > + descr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + WideCharToMultiByte(CP_UNIXCP, 0, entries[i].descr, -1, descr, len, NULL, NULL); > + printf("%s|||%s\n", entries[i].key, descr); There is no need to allocate len * sizeof(WCHAR) bytes, len works just fine. > +int wmain(int argc, char *argv[]) wmain takes 'WCHAR *argv[]' list. All remaining problems are caused by the fact that now argv[] array is passed in unicode but you still handle argv[] strings as ASCII and pass them around to internal functions which accept 'char *' not 'WCHAR *' strings. -- Dmitry.

Feb. 28, 2005

Re: vartest.c - major pain in the build process

by Dmitry Timoshkov

"Ferenc Wagner" <wferi(a)afavant.elte.hu> wrote: > I was under the impression that most of the tests are > independent of desktop visibility. Not really. Any API which directly or indirectly creates windows or uses GDI is affected by the desktop visibility. Also, as I already pointed out, Wine doesn't run in that mode at all, so we can't compare apples to apples in that case. And the apps most of the developers/users care about should be run on a visible desktop anyway. > And the winrash service > is the only way to get several reports quickly for a new > test. Why? What prevents someone to run the tests manually in interactive mode once a day? If that someone can't or won't do it, then we have to find another someone. I'm pretty sure that there are enough not lazy people wishing to help we could to choose from. > If it wasn't automatic, it would take a good while > until the tests are run. So I wanted to keep the best of > both ways by introducing a new flag according to your > recommendation: > > static int running_on_visible_desktop () > { > return (GetWindowLongA (GetDesktopWindow (), GWL_STYLE) & WS_VISIBLE) != 0; > } > > Looks like it doesn't quite work, though: it returns 1 all > the time under Win9x and NT. Can you perhaps tell why? I don't know. And figuring out why it doesn't work is completely useless IMO, since the results of the tests running on an invisible desktop can't be used for a reasonable comparison. -- Dmitry.

Feb. 28, 2005

Re: [PATCH] Added 2 functions to shell32

by Dmitry Timoshkov

"Gianluigi Tiesi" <sherpya(a)netfarm.it> wrote: > +BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) > +{ > + int i; > + int len; > + if (!path1 || !path2) return FALSE; > + > + len = strlenW(path1); > + if (len > strlenW(path2)) return FALSE; > + > + for (i=0; i < len; i++) > + if (path1[i] != path2[i]) return FALSE; > + return TRUE; > +} You need to do a case insensitive comparison of paths. Also, if you could use a usual for Wine formatting style with 4 space indentation that would be very nice. -- Dmitry.

Feb. 28, 2005

Re: vartest.c - major pain in the build process

by Ferenc Wagner

"Dmitry Timoshkov" <dmitry(a)baikal.ru> writes: > I'd actually rise the question of sending the results of running winetest > on an invisible desktop under Windows. For instance I'm interested to see > how my recently added user32 tests behave on different Windows platforms, > but the tests which currently present on http://test.winehq.org/data are > completely unusable. I strongly ask to stop posing tests running on an > invisible desktop and consider that tests broken, since almost all win32 > APIs are influenced by the fact of running in that environment. Moreover, > Wine doesn't run in that mode at all, so we can't compare apples to apples > in that case. And the apps most of the developers/users care about should be > run on a visible desktop anyway. I was under the impression that most of the tests are independent of desktop visibility. And the winrash service is the only way to get several reports quickly for a new test. If it wasn't automatic, it would take a good while until the tests are run. So I wanted to keep the best of both ways by introducing a new flag according to your recommendation: static int running_on_visible_desktop () { return (GetWindowLongA (GetDesktopWindow (), GWL_STYLE) & WS_VISIBLE) != 0; } Looks like it doesn't quite work, though: it returns 1 all the time under Win9x and NT. Can you perhaps tell why? -- Feri.

Feb. 28, 2005

Re: comctl32 - SB_SETBORDERS

by Thomas Weidenmueller

Dimitrie O. Paun wrote: >Why? There's little harm in supporting it, if some versions of the >real thing does. It's neither difficult, nor complex... > > Because applications using them behave differently than on contemporary versions of windows, just like the Local/GlobalSize issue - just not as severe.

Feb. 28, 2005

[SOLVED] Re: Picasa2- works great, one font issue

by Matthew Mastracci

Okay - I checked out the latest Wine from CVS and it seems to be fixed. I think this patch was the one that fixed it: revision 1.82 date: 2005/02/25 13:59:22; author: julliard; state: Exp; lines: +9 -9 TANABE Hiroshi <hirokun_dayomon(a)infoseek.to> wrote: Remove (buf && !buflen) checking. Fixed outline rendering with GGO_GRAY?_BITMAP option. Improved fixed-pitch fonts detection. Here's some screenshots from the program while running: http://www.grack.com/news/Picasa2underWine.html Note that clicking the "email" button in Picasa will crash it - probably the MAPI stubs that cause it: err:mapi:MAPILogon Stub fixme:seh:EXC_RtlRaiseException call (from 0x53e297) to unimplemented function mapi32.dll.MAPISendMail Thanks, Matt. Matthew Mastracci wrote: > I tried out the latest Picasa2 (picasa2-setup-1884.exe) on a whim > against the Wine 20050111 package and it works great. There don't > seem to be any major functionality issues and the app is very > responsive - it almost feels like a native gnome app. > > The one visual issue with the program is that certain fonts within the > program seem to be blitted incorrectly: > > http://www.grack.com/news/Picasa2underWine.html > > It appears that Picasa 2 might ship with some pre-computed > alpha-blended fonts in the form of ".ytf" files in the runtime > directory. When I move these fonts out of the way, all the fonts > (including those fonts used to create the > Import/Slideshow/Timeline/etc. buttons) within the program appear > screwed up like the album-title fonts do when those files are > present. Note that after copying the generated .ytf files from a > Windows '98 installation, all of the characters within Picasa are > rendered perfectly. > > Where might I start looking for the problem? I think it has something > to do with drawing to backbuffer that eventually gets flushed to disk, > since copying the cached font files from a standard Windows install > seems to fix the problem. WINEDEBUG=+gdi doesn't yield much, but I > think WINEDEBUG=+bitmap or WINEDEBUG=+font is where I'm supposed to be > looking. > > Matt. >

Feb. 28, 2005

Re: comctl32 - SB_SETBORDERS

by Dimitrie O. Paun

On Mon, Feb 28, 2005 at 01:04:23AM +0100, Thomas Weidenmueller wrote: > Even though Office tries to use them I oppose implementing it. Why? There's little harm in supporting it, if some versions of the real thing does. It's neither difficult, nor complex... -- Dimi.

Feb. 28, 2005

Re: status of winetest.exe

by Paul Millar

Hi Stefan, Yes, things are broken due some behind-the-scenes that turned out not to be the case. I've been a bit busy these past five days, but I'm back in the country (and, more importantly, with net connectivity) so should get these problems fixed soon. Cheers, Paul. On Friday 25 February 2005 22:13, Stefan Leichter wrote: > i have noticed that the winetest are not longer built since the > middle of the week. Can you take a look if something is broken?

Feb. 28, 2005