February 2005 - Wine-Devel - list.winehq.org

Re: comctl32 - SB_SETBORDERS

by Thomas Weidenmueller

Steven Edwards wrote: >Filip implemented this for me when I was testing Office97 under ReactOS and I never got around to >merging it to the ros tree. > > SB_SETBORDERS does not exist in current versions of NT. It might be a something from the old 3.x days. NT 5.0 and 5.1 for sure don't implement them. Even though Office tries to use them I oppose implementing it. Best Regards, Thomas

Feb. 28, 2005

Re: shell32: formatting and unicodification

by Juan Lang

--- Alexandre Julliard <julliard(a)winehq.org> wrote: > Please don't mix formatting changes with other things, it makes it > very painful to review. You're right. Sorry about that. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

Feb. 27, 2005

Re: shell32: formatting and unicodification

by Alexandre Julliard

Juan Lang <juan_lang(a)yahoo.com> writes: > Mike's formatting changes got in, so here's one of my own. > > ChangeLog: convert tabs to spaces, make indenting consistent, convert more > calls to Unicode Please don't mix formatting changes with other things, it makes it very painful to review. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2005

Re: setupapi: enumerate serial ports

by Alexandre Julliard

Juan Lang <juan_lang(a)yahoo.com> writes: > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } There's no reason to limit to 4 serial ports (and winspool should be fixed too). Probably the best way is to do a QueryDosDevice(NULL) which gets you a full device list and the return every COM device in that list. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2005

Re: Fix a race condtition in the server startup

by Bill Medland

On February 26, 2005 03:43 pm, Francois Gouget wrote: > There is a race condition in the server startup code which arises if two > I propose the following fix: > > if (lstat( name, st ) == -1) > { > if (errno != ENOENT) fatal_perror( "lstat %s", name ); > if (mkdir( name, 0700 ) == -1 && errno != EEXIST) fatal_perror( > "mkdir %s", name ); > > Using the existing directory is ok because we then check its ownership, > permissions, etc. (which we have to do anyway in case it already existed). How about simply mkdir and if the error is already existed then fine.? Unchecked, but something like: if (mkdir (name, 0700) == -1) { if (errno != EEXIST) fatal_perror ("Ensuring directory %s", name) } > > > Changelog: > > * server/request.c > > Francois Gouget <fgouget(a)codeweavers.com> > Fix a race condition in create_dir(). -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

Feb. 27, 2005

Re: vartest.c - major pain in the build process

by Mike Hearn

On Sun, 27 Feb 2005 17:52:44 +0800, Dmitry Timoshkov wrote: > Alexandre already stated many times that there is no point to have > anything in the CVS tree if it's not compiled by default. A not used > code tends to be rotten very fast. Winetest is built though, as part of the nightly test winrash infrastructure. There's no point building in stock developer/end user installs but that doesn't mean it'd never be built at all. thanks -mike

Feb. 27, 2005

Re: riched20 patch preview

by Krzysztof Foltman

Krzysztof Foltman wrote: > WinXP WordPad doesn't work either, as it uses RICHEDIT50W window class > (what I provide is RichEdit20W control, haven't tried to fake it's 5.0). I've checked it now. It crashes somewhere in wordpad code, in something involving string operations. I've though it might be related to missing implementation of OLE interfaces, but it isn't. I'm investigating the problem, but it's not of top priority. Krzysztof

Feb. 27, 2005

Re: New uninstaller

by Dmitry Timoshkov

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > I'm thinking to send it as is to wine-patches if nobody complains before > tonight (tomorrow I'll be leaving for one week). First of all thanks for your efforts. Since this is your first Win32 app I personally understand all the difficulties you faced with. Please do not be offenced by critical comments below, they are supposed to help you better understand your mistakes and should serve as a guide for further improvements. > +int list_need_update = 1; > +int oldsel = -1; > +int FetchUninstallInformation(void); > +char *sFilter; I'd suggest to not mix variables and function declarations. Another suggestion is to use static modifier for everything since nothing is supposed to be externally visible. If you could use unicode for everything internally that would be another great bonus for us poor non latin1 using people. You are rewriting the app almost entirely anyway. Just replace main by wmain and Wine startup code will pass unicode strings to it, but make sure to use CP_UNIXCP to convert strings from unicode to unix locale before printing them to the unix console. Please use Win32 APIs for string comparisons since Wine and unix locales are almost always not the same. Using unicode will drop this requirement. Avoid using c++ comments, they are deprecated for Wine code. Use consistent formatting through the code. > + if(sFilter != NULL && stristr(wine_dbgstr_w(entries[numentries-1].descr),sFilter)==NULL) > + numentries--; wine_dbgstr_w is not supposed for the above use. Using unicode will help to avoid such ugly constructs. > + RemoveSpecificProgram( argv[i++] ); argv[] list is passed in the unix locale while the code expects to see it in the win32 locale. Using unicode will fix it as well. > +char *stristr(const char *String, const char *Pattern) > +{ > + char *pptr, *sptr, *start; > + uint slen, plen; > + > + for (start = (char *)String, > + pptr = (char *)Pattern, Why not simply use "const char *" for pptr, sptr, start instead of silencing compiler warnings and hiding potential bugs? > + { > + /* find start of pattern in string */ > + while (toupper(*start) != toupper(*Pattern)) Again an issue with unix/win32 locale mixup. -- Dmitry.

Feb. 27, 2005

Re: New uninstaller

by Jonathan Ernst

Here is a new version. I'm thinking to send it as is to wine-patches if nobody complains before tonight (tomorrow I'll be leaving for one week). Thanks everyone for your help. Changelog: - new uninstaller - "find as you type" search - use dialog instead of window - internationalization - if the uninstaller cannot be found the user can choose to remove the entry from the registry

Feb. 27, 2005

Re: New uninstaller

by Dmitry Timoshkov

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > > It's better to avoid using string tables, since now you have converted > > code to use dialog box instead. > > How can I do it for messageboxes ? Is there a way to define them in the > resource files or do I have to make a dialog instead of messageboxes ? Yes, one of the possibilities to use dialog boxes instead of message boxes. But if it's inconvenient for you, then using string tables and LoadString is the only option. -- Dmitry.

Feb. 27, 2005