May 2005 - Wine-Devel - list.winehq.org

Re: Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs

by Robert Shearman

Evan Deaubl wrote: >ChangeLog: > * Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs > > I cleaned up the patch a little. Does this still work for you? Changelog: Evan Deaubl <wine(a)warpedview.com> Robert Shearman <rob(a)codeweavers.com> - Implement RtlGetControlSecurityDescriptor - Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs -- Rob Shearman

May 31, 2005

Re: tab: Shift selected tab text up instead of down [RESEND]

by Mike McCormack

> + if (iItem == infoPtr->iSelected) > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) - infoPtr->uVItemPadding) / 2; > + else > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) + infoPtr->uVItemPadding) / 2; Wouldn't it be clearer as: center_offset_v = (drawRect->bottom - drawRect->top) + (rcText.bottom - rcText.top); if (iItem == infoPtr->iSelected) center_offset_v -= infoPtr->uVItemPadding; else center_offset_v += infoPtr->uVItemPadding; center_offset_v /= 2; That breaks up the long lines, and eliminates the common sub-expressions... Mike

May 31, 2005

Re: ntdll.dll: mark dirlink as REPARSE_POINT (v2)

by Dimi Paun

On Tue, 2005-05-31 at 06:21 +0200, Detlef Riekenberg wrote: > - if (S_ISDIR( st.st_mode ) && !show_dir_symlinks) return NULL; > + if (S_ISDIR( st.st_mode )) > + { > + if (!show_dir_symlinks) return NULL; > + name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; > + } > } Hmm, thinking more about it, if windows has support for dir symlinks (I'm sure they made sure there are no problems with that), should we even bother having this show_dir_symlinks option? Maybe we should just nuke it, and just have: if (S_ISDIR( st.st_mode )) name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; On a different note, are the brackets above indented properly? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

May 31, 2005

ntdll.dll: mark dirlink as REPARSE_POINT (v2)

by Detlef Riekenberg

Changelog: Mark links to dir with "FILE_ATTRIBUTE_REPARSE_POINT", so modern Applications can use this additional Information. Supported by ntdll.dll since win2000. (Application as Example: totalcmd.exe >6.50) v2: Reformatted as suggested by Dimi Paun -- By By ... ... Detlef

May 31, 2005

generic.ppd isn't installed anymore

by Vincent Béron

Hi, wineps/generic.ppd isn't installed anymore since a couple weeks ago (didn't had time yet to pinpoint exact patch). I think it's because only __install-lib__ and __install-dev__ is done in dlls/ now, and not __install__, which is the target actually installing wineps/generic.ppd. A quick'n dirty way is to run make -C dlls/wineps install after make install but it should really be fixed properly I guess. Vincent

May 31, 2005

Re: wine/dlls/x11drv keyboard.c

by Dmitry Timoshkov

"Francois Gouget" <fgouget(a)free.fr> wrote: > > Fix Estonian keyboard layout to better match the X11 one. > > I have noticed that we get a steady trickle of these. Shouldn't it be > possible to get the definitions of all keyboards from the XFree sources > and find some way to automatically import them? Probably. But actually I need to find some time and fix the source of the problem: fill keyc2vkey and keyc2scan tables with actual data reported by X11, not values from hardcoded keyboard layouts. -- Dmitry.

May 31, 2005

Re: [Fwd: Re: Extending File Dialog to include unix file paths]

by Michael Lin

Hi Alexandre, I haven't got a reply from you on this issue yet. Please let me know what you think of the patch. Thanks, Michael Michael Lin wrote: > Hi Alexandre, > > I have made the changes as you suggested to put all the entry point in > one single library. > > Basically, I have created a new library called wineunixfs. > It currently contain modified version of filedlg.c and > filedlgbrowser.* and all their dependent files from commdlg. > > I have attached the diff file for the rest of the changes that's on > the core libraries. > I didn't attach the files in wineunixfs as you seems ok with > duplicating code there and modify it there. > > Most of the changes are contained within shell32 libraries to make it > aware of whether it is in unix or dos path mode. > There is only one exported function been added and that is > SHUnixFSGetDesktopFolder() in shell32. > > Could you please take a look at the patch and let me know if this is > "clean" and acceptable. > > Thanks, > Michael >

May 31, 2005

Re: Borland C++ 4.5

by Troy Rollo

On Tue, 31 May 2005 06:12, Andrew Neil Ramage wrote: > When I tried to install BC++ 4.5, the installation proceeded normally. > However, when I clicked "Finish", it trashed my X server, causing the > system to stop responding to key presses and the mouse. I could not > even kill the X server, and so had to pull the power cord out. Is this > a known problem, and will I still be able to use my Development identity ? There probably aren't many people still using BC++4.5, but those that do don't particularly care about this problem. If you copy over your bc45 directory from a native Windows installation it should just work(tm).

May 31, 2005

Re: ntdll.dll: mark dirlink as REPARSE_POINT

by Dimi Paun

On Tue, 2005-05-31 at 00:00 +0200, Detlef Riekenberg wrote: > - if (S_ISDIR( st.st_mode ) && !show_dir_symlinks) return NULL; > + if (S_ISDIR( st.st_mode )) > + { > + if (!show_dir_symlinks) > + { > + return NULL; > + }else > + { > + name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; > + } > + } Minor point, but it would be more in the Wine style to code above as: + if (S_ISDIR( st.st_mode )) + { + if (!show_dir_symlinks) return NULL; + name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; + } -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

May 30, 2005

Borland C++ 4.5

by Andrew Neil Ramage

When I tried to install BC++ 4.5, the installation proceeded normally. However, when I clicked "Finish", it trashed my X server, causing the system to stop responding to key presses and the mouse. I could not even kill the X server, and so had to pull the power cord out. Is this a known problem, and will I still be able to use my Development identity ? -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

May 30, 2005