May 2005 - Wine-Devel - list.winehq.org

Re: OLEAUT32 (resend) Floating point locale, no negative zero

by Alex Villacís Lasso

Alexandre Julliard wrote: > Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > > > >> Changelog: >> * Force Single|Double conversion to BSTR to use the decimal separator >> defined by the current locale, because that is what native oleaut32 >> does, and to be consistent with later parsing of floating-point >> numbers, which uses current locale. Failure to apply this patch causes >> vartype test to fail in non-US locales with a decimal separator other >> than a period. >> * The number form "-0" is *not* allowed to be returned in a >> Single|Double conversion to BSTR in case of numeric undeflow, use >> unsigned zero instead. Some applications depend on this. Test included. >> > > > That's ugly, I think we really want to do our own formatting instead > of using the system printf and hacking the string afterwards. > > > By "our own formatting", do you mean to reimplement the %f and %lf functionality of the system printf() in a Wine-specific function? It can be done, of course, but I thought there was a good reason for the original code to rely on the system printf() for the floating-point formatting. Then there is the question of whether the potential patch is still allowed to use GetNumberFormatW for the (dwFlags & LOCALE_USE_NLS) case. This function seems to relay on the decimal separator being a period (as built by sprintfW). A more recent patch I sent used GetNumberFormatW for the non-NLS case to achieve the substitution of the period for whatever the decimal separator was in the current locale. However, GetNumberFormatW() cannot do anything about the negative zero issue, so that was still handled in the VARIANT_BstrFromReal() function of vartype.c. How much formatting should the new formatting function do? Is it enough to handle the negative zero and the decimal separator, and use sprintfW() for the LOCALE_USE_NLS case (as the current code does), or does it have to reimplement the functionality currently delegated to GetNumberFormatW()? I will start making a patch assuming the first scenario (use new function just for non-NLS case). Please answer if anybody thinks it should be done otherwise. Alex Villacís Lasso

May 30, 2005

Re: wine/dlls/x11drv keyboard.c

by Rein Klazes

On Mon, 30 May 2005 11:14:01 +0200 (CEST), you wrote: > The other trickle we're seeing is with timezones. So in a similar way > maybe we could get the data from the site below and import it all: > http://www.timeanddate.com/library/abbreviations/timezones/ That is a very limited number of timezone abbreviations. You should use go for the timezone data in ftp://elsie.nci.nih.gov/pub/tzdata*.tar.gz which is the source for the timezone data in Linux, *BSD and probably others. I am working to get this data - as far as Window's limited timezone information allows - converted. That means that in Wine there will be a same timezones (e.g. Europe/Amsterdam) as under Linux including the daylight saving transition times. Rein.

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Andrew Neil Ramage

Works fine for me - I use the attached scripts. Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Pavel Troller wrote: >>Hello, >> >>have you done a cvs update -Pd ? >> > > Hello, > of course, it's in my .cvsrc . cvs doesn't show any M'ed nor C'ed files, > the update is clean. > I also did a make clean in dlls, as suggested by Mike, but the problem is > still there. > Of course I know a standard procedure of ./configure ; make depend && make > and I'm always following it. > Now I'm trying 'make distclean' before anything else... Yes, the problem > is still there. Now I'm posting all the output from crypt32: > > make[2]: Entering directory `/usr/src/emul/wine/dlls/crypt32' > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o cert.o cert.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o commctrl.o commctrl.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o encode.o encode.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o protectdata.o protectdata.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o datetime.o datetime.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o main.o main.c > ../../tools/winebuild/winebuild -D__WINESRC__ -D_CRYPT32_ -o crypt32.dll.dbg.c --debug -C. cert.c encode.c protectdata.c main.c > make[3]: Entering directory `/usr/src/emul/wine/dlls/crypt32/tests' > gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o protectdata.o protectdata.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o draglist.o draglist.c > gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o testlist.o testlist.c > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o flatsb.o flatsb.c > ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole protectdata.o testlist.o -o crypt32_test.exe.so -L../../../libs/port -lwine_port -L../../../dlls -L../../../dlls/crypt32 -L../../../libs -lcrypt32 -s -L/opt/ungif/lib > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o header.o header.c > protectdata.o(.text+0x3b5): In function `test_cryptunprotectdata': > /usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:114: undefined reference to `CryptUnprotectData' > protectdata.o(.text+0x42f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:120: undefined reference to `CryptUnprotectData' > protectdata.o(.text+0x4b9):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:129: undefined reference to `CryptUnprotectData' > protectdata.o(.text+0x54f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:140: undefined reference to `CryptUnprotectData' > protectdata.o(.text+0x702):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:160: undefined reference to `CryptUnprotectData' > protectdata.o(.text+0x782):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:167: more undefined references to `CryptUnprotectData' follow > collect2: ld returned 1 exit status > > So, still no luck. > With regards, Pavel Troller > > > export CVSROOT=:pserver:cvs(a)rhlx01.fht-esslingen.de:/home/wine echo CVSROOT=$CVSROOT export TEMP=cvs echo TEMP=$TEMP echo $TEMP | cvs login cvs update cd wine ./configure make depend && make su -c make install

May 30, 2005

Hint for Wine + Type1 + FrameMaker / Update for the Font HOWTO

by Dag Wieers

Hi Avi, Having spend endless hours looking for how to make Wine and Type1 fonts working together. I finally decided to convert my Type1 fonts to Truetype (after a hint by someone that Wine does not have Type1/Adobe support). Note: I'm not sure if this is true since there is a wine [afmdirs] section in the wine config. Wine still had troubles with (at least) some of the files. Converting Type1 fonts to Truetype fonts was easy and Framemaker actually has a hidden feature to find out which fonts are missing. When you load your FrameMaker document and you have missing fonts, it wants to reformat your file. After you allow that, just look at the available fonts, suddenly you have a few extra ones in the list that have been disabled. These are the fonts FrameMaker requires and couldn't find. Note down the names as they appear in the list, quit the document without saving (!), then go look for the Type1 fonts that match the name using grep. Open them in fontforge (http://fontforge.sourceforge.net/) if necessary change the Family Name to what you wrote down and safe it as a Truetype font. If you do that for all the files involved, everything works fine. I added this explanation to my document bits (for google) http://dag.wieers.com/howto/bits/wine-framemaker-type1.php So fontforge should definitely be part of the Font HOWTO and maybe something about Wine and Type1 support (and FrameMaker) too ? PS I included the Wine list too, as I looked there for answers first. I bet some more people will do the same and come across this thread. Hope this helps and thanks for a great resource, -- dag wieers, dag(a)wieers.com, http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power]

May 30, 2005

Re[2]: tab: Shift selected tab text up instead of down

by Vitaliy Margolen

Monday, May 30, 2005, 1:20:31 AM, you wrote: > On 5/29/05, Vitaliy Margolen <wine-patch(a)kievinfo.com> wrote: >> Sunday, May 29, 2005, 2:17:12, Vitaliy Margolen wrote: >> > Hi, >> >> > Changelog >> > * Shift selected tab text up instead of down. >> >- drawRect->>bottom += 3; >> >+ drawRect->>bottom -= 3; >> >> This does not shift tab up. > The location of the tab stays the same. The text is shifted up. I'm not talking about tab itself. But interior of the tab. Selected tab interior is 3 pixels bigger then none selected one. Here is a test app I'm using to test this things: http://www.kievinfo.com/Tab_size.tar.bz2 It displays all kinds of tabs and prints tab dimensions for owner drawn once to stdout. It's a Delphi app so if you want to modify it you'll need Delphi to compile it. This test clearly shows you patch is incorrect. Vitaliy

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Michael Stefaniuc

Pavel Troller wrote: >>solution is to: >> >>cd dlls >>rm *.def >>cd .. >>make >> >>Ciao, Marcus > > > Hi Marcus, > yes, Your solution is the Right One! Thanks! > However, I think that something is wrong with make distclean, because it > should erase all the generated files including these .def's ? Or is there > a reason to keep them in (and possibly cause problems) ? No, the problem is the make system changed and those .def's are needed anymore and also not generated anymore. There is no reason for make [dist]clean to get rid of them. That's why i love out of source tree builds: rm -rf on the wine build tree is a very good 'make realyclean' command ;) bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Marcus Meissner

On Mon, May 30, 2005 at 03:23:13PM +0200, Pavel Troller wrote: > > solution is to: > > > > cd dlls > > rm *.def > > cd .. > > make > > > > Ciao, Marcus > > Hi Marcus, > yes, Your solution is the Right One! Thanks! > However, I think that something is wrong with make distclean, because it > should erase all the generated files including these .def's ? Or is there > a reason to keep them in (and possibly cause problems) ? You need to run "make distclean" BEFORE doing cvs update, this would have avoided it I guess. This is just a temporary hickup. Ciao, Marcus

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Pavel Troller

> solution is to: > > cd dlls > rm *.def > cd .. > make > > Ciao, Marcus Hi Marcus, yes, Your solution is the Right One! Thanks! However, I think that something is wrong with make distclean, because it should erase all the generated files including these .def's ? Or is there a reason to keep them in (and possibly cause problems) ? With regards, Pavel Troller

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Marcus Meissner

On Mon, May 30, 2005 at 02:40:20PM +0200, Michael Stefaniuc wrote: > Hello, > > have you done a cvs update -Pd ? No, solution is to: cd dlls rm *.def cd .. make Ciao, Marcus

May 30, 2005

Re: CryptUnprotectData undeclared - cannot compile

by Pavel Troller

> Hello, > > have you done a cvs update -Pd ? > Hello, of course, it's in my .cvsrc . cvs doesn't show any M'ed nor C'ed files, the update is clean. I also did a make clean in dlls, as suggested by Mike, but the problem is still there. Of course I know a standard procedure of ./configure ; make depend && make and I'm always following it. Now I'm trying 'make distclean' before anything else... Yes, the problem is still there. Now I'm posting all the output from crypt32: make[2]: Entering directory `/usr/src/emul/wine/dlls/crypt32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o cert.o cert.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o commctrl.o commctrl.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o encode.o encode.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o protectdata.o protectdata.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o datetime.o datetime.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o main.o main.c ../../tools/winebuild/winebuild -D__WINESRC__ -D_CRYPT32_ -o crypt32.dll.dbg.c --debug -C. cert.c encode.c protectdata.c main.c make[3]: Entering directory `/usr/src/emul/wine/dlls/crypt32/tests' gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o protectdata.o protectdata.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o draglist.o draglist.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o testlist.o testlist.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o flatsb.o flatsb.c ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole protectdata.o testlist.o -o crypt32_test.exe.so -L../../../libs/port -lwine_port -L../../../dlls -L../../../dlls/crypt32 -L../../../libs -lcrypt32 -s -L/opt/ungif/lib gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_COMCTL32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I/opt/ungif/include -I/opt/ungif/include -O2 -march=i586 -mcpu=i586 -o header.o header.c protectdata.o(.text+0x3b5): In function `test_cryptunprotectdata': /usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:114: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x42f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:120: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x4b9):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:129: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x54f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:140: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x702):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:160: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x782):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:167: more undefined references to `CryptUnprotectData' follow collect2: ld returned 1 exit status So, still no luck. With regards, Pavel Troller

May 30, 2005