May 2005 - Wine-Devel - list.winehq.org

Re: rundll32.exe shell32.dll,SHHelpShortcuts_RunDLL

by Detlef Riekenberg

Am Montag, den 30.05.2005, 10:29 +0900 schrieb Dmitry Timoshkov: > > + > > + return StrCmpW(e1->name, e2->name); > > I strongly suspect that this comparison should be case insensitive. Sorry for not written this comment: * The Commands are Case-Sensitive! (Checked with Win98SE and Win2000) * You are not allowed to put a Space before or behind the Command. -- By By ... ... Detlef

May 30, 2005

Re: question about standalone tests

by Dimi Paun

On Wed, 2005-05-25 at 09:13 -0700, Dan Kegel wrote: > Now somebody should update > > http://www.winehq.com/site/docs/wine-devel/testing-windows > > with a new section sorta like the following > (Yeah, I should check this text in, but I gotta run. At least I wrote > a first draft, eh?): Thanks for the docs Dan, I've checked them in. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

May 30, 2005

Re: Make more of the OLE interface vtables const

by Dmitry Timoshkov

"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote: > On Sun, May 29, 2005 at 07:05:49PM +0900, Dmitry Timoshkov wrote: > > Hello, > > > > Changelog: > > Dmitry Timoshkov <dmitry(a)codeweavers.com> > > Make more of the OLE interface vtables const. > You do know that those will *not* end up const? > > filemoniker.c:static const IClassFactoryVtbl FileMonikerCFVtbl = > objdump -x ole32.dll.so: > 0008efb0 l O .data 00000014 FileMonikerCFVtbl > > My suspicion is that this is due to winegcc compile, all other binaries > with normal compile (e.g. winedump, ...) have all their const data in .rodata segment... > > So, does anybody know what seems to be wrong with winegcc or why it chose to do that? It appears to be not a winegcc problem. That's how gcc generates pointer tables (regardless of the pointer type). Although it (gcc) correctly produces warnings about losing 'const' attribute while passing a pointer to a const table around, it still places contents of the table into r/w section. I'd call it a gcc limitation, if not a bug. Still, IMO that shouldn't prevent us to do the right thing, and declare all not writeable data as const. > BTW, I already completely constified programs/ and tools/, will send a patch soon. Great! Let's make Wine a better place on the planet :-) -- Dmitry.

May 30, 2005

Re: rundll32.exe shell32.dll,SHHelpShortcuts_RunDLL

by Dmitry Timoshkov

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > Changelog: > Partial Implementation of shell32/SHHelpShortcuts_RunDLL > Connect and Disconnect: Forwarded to mpr.dll > AddPrinter: Forwarded to printui.dll > +static int shrundll_compare(const void *p1, const void *p2) > +{ > + struct shrundll_entry *e1 = (struct shrundll_entry *) p1; > + struct shrundll_entry *e2 = (struct shrundll_entry *) p2; > + > +/* > + TRACE("(%p:%p (%ld:%ld) %s:%s)\n",e1, e2, (e1 == NULL) ? 0 : e1->my_id, (e2 == NULL) ? 0 : e2->my_id, debugstr_w((e1 == NULL) ? NULL : e1->name), debugstr_w((e2 == NULL) ? NULL : e2->name)); > +*/ > + > + if((e1 == NULL) | (e2 == NULL)) > + { > + return -1; > + } > + > + return StrCmpW(e1->name, e2->name); I strongly suspect that this comparison should be case insensitive. -- Dmitry.

May 30, 2005

Re: Optionally map the unix filesystem instead of drive letters into the shell namespace

by Michael Lin

Hi Michael, > >Please consider the configure based global flag only an option. That's >actually what I said several times. It could be a per application option as >well. And there is no problem in activating it via a wine-specific API, which >would override the config on a per process basis. > > Please explain on the per process basis. If you mean let winelib application change the global flags via wine API, there will be synchronization and threading issues. Say application A turn on unix path, application B turn on unix path, application B exit and turn off unix path, then application A will now be back in dos path. Or do you mean each application would have their own registry setting and this per application setting is set when application is installed? Then there is problem of how wine get to this application specific settings. >Modifying shfldr_unixfs to parse unix path in addition to dos paths is >trivial: Just remove the (pUnixFolder->m_dwPathMode == PATHMODE_UNIX) test >in line 339. The real problem is the test for invalid chars in the filedialog, >which '/' is one of. The solution is obvious: If wine is configured to >display unix paths, then accept '/' as a valid char in paths in comdlg32. You >will have to do this for your solution as well, don't you? > > What I mean here is when user is browsing unix path and be able to type in dos path seems a bit strange. Just the little things that doesn't make it feel really in unix mode for winlib app. >Actually, we are tackling two slightly different problems here: I would like >to have existend applications, for which I don't have the source, to display >unix paths instead of dos paths in their file dialogs. > > Oh .. ok .. I didn't know that. >I don't want to offend, but I think this just isn't fair. I have contributed a >lot of my free time working on this stuff, and I think I would have deserved >to be informed on discussions and decisions in this matter. > Sorry if I offended you, that wasn't my intention. Initially it was just a direct email sent to Alexandre to ask the status of the patch I previously sent. If it has been rejected, I would like to know the reason so I can make changes and send in another patch. Should have cc wine-devel, my apologies.

May 30, 2005

Re: Half Life 2 error -- err:mmio:MMIO_ParseExtA

by Ivan Gyurdiev

On Sun, 2005-05-29 at 21:10 +0100, J. Grant wrote: > Hello, > > I am getting this error when trying to run Half Life2 in > err:mmio:MMIO_ParseExtA. Could someone tell me if this is a problem in > in WINE, or a problem in my setup? Or not an error at all..? > > Also if there is already a document on setting up Half Life2 could > someone direct me to it please, I could not find one already. I'm not sure about your specific error, but I was able to get HL2 to start with Oliver Stieber's d3d patches. However, it was far from playable for me. Models were missing, and there were other glitches. I made a web site about it, but nobody has contacted me since then to help debug. For info, please see appdb (http://appdb.winehq.org/appview.php?versionId=2890) I really need to re-test all of this, but as of right now wine cvs doesn't compile. preloader.c: In function ‘is_in_preload_range’: preloader.c:863: error: ‘union <anonymous>’ has no member named ‘a_ptr’ preloader.c:864: error: ‘union <anonymous>’ has no member named ‘a_ptr’ make[1]: *** [preloader.o] Error 1 make[1]: Leaving directory `/home/phantom/src/wine/loader' make: *** [loader] Error 2 -- Ivan Gyurdiev <ivg2(a)cornell.edu> Cornell University

May 29, 2005

Re: UT2003 Regression - Patch at last :-))

by Josef Drexler

On Thu, 26 May 2005 22:06:30 +0200, Alexandre Julliard wrote: > Alexandre Julliard <julliard(a)winehq.org> writes: > >> "Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: >> >> > What about instead of the send_ncpaind/send_erase when child==prev (assuming >> > this to be the more 'unusual' case and not the norm) I build a list of the >> > hwnds and validate their update region. When the loop completes, for each >> > hwnd left in the list I do the send_ncpaint/send_erase processing? >> > >> > Without removing the update region there's no way to step further in the >> > list, if I understand the problem correctly? >> >> Yes, but that's what needs to be fixed, we need to make progress even >> if the update region is not validated. We will then get a WM_PAINT in >> the main message loop, which I believe is what we want. > > Try something like this: [snip patch] Thanks for that! I just thought I'd mention that this also fixes problems with Transport Tycoon Deluxe, another game that had a blank window and put wine in an infinite loop since the changes from 2004-12-07. With this patch it works again, so it'd be great if this could make it into CVS soon. Thanks again! -- Josef Drexler | http://jdrexler.com/home/ ---------------------------------+--------------------------------------- Please help Conserve Gravity | Email address is *valid*. Play Chess, not Basketball. | Don't remove the "nospam" part.

May 29, 2005

Re: Default setting for RelayExclude

by Mike Hearn

On Thu, 26 May 2005 01:15:45 +0100, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Default setting for RelayExclude Alexandre, any reason this didn't get in? thanks -mike

May 29, 2005

Re: dlls/oleaut32/olepicture.c won't compile

by Joris Huizer

Marcus Meissner wrote: >>Hmm, this seems weird, I looked into the config.log after running >>configure, but the tests for libgif already do fail when using the wrong >>library version (DGifOpen (); is missing; it reads: >> >>configure:15519: checking for -lungif soname >>configure:15549: gcc -o conftest -g -O2 conftest.c -lungif >&5 >>/tmp/ccie7Kbp.o(.text+0xa): In function `main': >>/home/jorishuizer/.wine-source/wine/conftest.c:176: undefined reference >>to `DGifOpen' >>collect2: ld returned 1 exit status >>configure:15555: $? = 1 >>configure: failed program was: >>... >>configure:15584: result: libungif.so > > > This is a result of the dynamically loaded libungif.so / libgif.so, it expects > that it has this symbol. > > So exactly what distro has this problem, all modern ones should not have it. > > Ciao, Marcus > > This is debian, with the giflib3g-dev package; with the libungif4-dev package the problem is gone, but I was trying what was wrong with configure in that it didn't detect this (I proposed configure could ensure gif library would only be enabled when the correct library was installed); I have no idea why configure ignores this error? HTH, Joris

May 29, 2005

err:dsound:DSOUND_MixOne underrun on sound buffer 0x40407e50

by J. Grant

Hi, I am getting this underrun when running Call of Duty v1.5. fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. err:dsound:DSOUND_MixOne underrun on sound buffer 0x40407e50 It turned out there were some processes hanging around, wine server and also /usr/lib/wine/wine-preloader /usr/lib/wine/wine-pthread ./CoDMP.exe Killing them and re-starting allowed it to work. I wonder if that err a WINE problem? as CoDMP.exe has workd flawlessly since. Maybe something to do with the existing wine-preloader left running? (Is that process left running a known problem..?) Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/blog.rss Radio: http://jguk.org/#radio

May 29, 2005