June 2005 - Wine-Devel - list.winehq.org

Re: dlls/ntdll/cdrom.c breakage

by Gerald Pfeifer

On Thu, 30 Jun 2005, Dmitry Timoshkov wrote: >> cdrom.c: In function `CDROM_ScsiPassThroughDirect': >> drom.c:1423: error: invalid application of `sizeof' to an incomplete type >> cdrom.c: In function `CDROM_ScsiPassThrough': >> cdrom.c:1543: error: invalid application of `sizeof' to an incomplete type > I don't see how it worked before then, you need to investigate why > '#ifdef SENSEBUFLEN' case doesn't work for you. I checked, and there is no occurrence of SENSEBUFLEN in /usr/include on a SUSE 9.2 machine nor on FreeBSD nor in the entire Wine source tree. How shall we proceed on this one? Gerald

June 30, 2005

Re: unixfs registered by default now in cvs

by Michael Jung

On Thursday 30 June 2005 21:21, Brian Vincent wrote: > Does this mean there's no longer a need to map a Z: drive to /? You still can only access the parts of the filesystem, which are accessible by a wine drive. You will see the complete unix directory structure, but you will only be able to select files, which are accessible by wine. The unix directories, which are not accessible, are much like the MyComputer folder in that they don't map to a windows filesystem location. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

June 30, 2005

Bug in dlls/comctl32/comctl32undoc.c

by Sascha Cunz

Hi, playing around a bit with wine, i found a thing that is obviously a bug. In lines 1944 and 1977 of dlls/comctl32/comctl32undoc.c the value "0x7FFF" is used to check for the boundary of a 32 bit integer. However, there should be used MAX_INT instead. By the way: Looking at current MSDN, DPA and DSA looks rather documented than "undoc" :-) Regards Sascha P.S.: Please CC me on answers as i'm not subscribed here.

June 30, 2005

Re: dlls/ntdll/cdrom.c breakage

by Gerald Pfeifer

On Thu, 30 Jun 2005, Dmitry Timoshkov wrote: >> Alexandre, please find below another patch which does not fix this either, >> but gets rid of some unused variable warnings. >> ChangeLog: >> Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and >> CDROM_ScsiPassThrough(). > This means that HAVE_SCSIREQ_T_CMD is not defined for you, i.e. scsireq_t > has not been detected. Very likely this is caused by a wrong/missing header > includes in the configure.ac test, please fix it, it's easy enough. I found that FreeBSD does not have this type defined anywhere, so I hope Alexandre will take my patch. Gerald

June 30, 2005

Re: Wine avitools/aviplay fails with CO_E_NOTINITIALIZED for any AVI file

by Alex Villacís Lasso

>It worked in the past. When pclsidHandler is set to NULL it performs >a registry lookup as the native version does it. If these registry >entries are missing it has a problem and could perhaps return the >mentioned error - don't know as I have never tested it. > >In the past these informations were part of the default registry of >wine but with the addition of the self-registration of many libraries >this has been removed. Don't ask me how to get the library to >register itself - guess it has to do with regsrv32.exe, but I am not >sure. I am already too long out of the substance. > > Based on a certain verification in the source code, I made aviinfo to work by adding the following to the registry: [Software\\Classes\\CLSID\\{00020000-0000-0000-C000-000000000046}\\InProcServer32] 1110571609 @="avifil32.dll" "LoadWithoutCOM"=dword:00000000 As far as I can see, the key "LoadWithoutCOM" only needs to exist; it does not need to be set to any particular value. The aviplay program has yet to work because the 128x128 AVI file I was using for the test in one machine (apparently) mandates a 128x128 screen resolution which is (yet) unsupported by my X configuration, and the ideal 640x480 test AVI is on the other (currently inaccessible) machine: trace:x11settings:X11DRV_Settings_AddOneMode initialized mode 128: 320x240x16 @60 Hz (XRandR) trace:x11settings:X11DRV_Settings_AddOneMode initialized mode 129: 360x200x16 @85 Hz (XRandR) trace:x11settings:X11DRV_Settings_AddOneMode initialized mode 130: 320x200x16 @85 Hz (XRandR) trace:x11settings:X11DRV_Settings_AddOneMode initialized mode 131: 320x175x16 @85 Hz (XRandR) trace:x11settings:X11DRV_Settings_CreateDriver Setting up display settings for DDRAW (XRandR) fixme:avifile:AVIFileInit (): stub! [Stream 0: vids.cvid, cineapk.avi v�eo #0] trace:x11settings:X11DRV_ChangeDisplaySettingsExW ((null),0x707bf768,(nil),0x00000004,(nil)) trace:x11settings:X11DRV_ChangeDisplaySettingsExW flags=FULLSCREEN trace:x11settings:X11DRV_ChangeDisplaySettingsExW DM_fields=BITSPERPEL,PELSWIDTH,PELSHEIGHT trace:x11settings:X11DRV_ChangeDisplaySettingsExW width=128 height=128 bpp=24 freq=1887172668 (XRandR) err:x11settings:X11DRV_ChangeDisplaySettingsExW No matching mode found! (XRandR) ddraw.SetDisplayMode: 0x88760078 (change resolution!) But this raises the following questions: * Why is not avifil32.dll adding this key on registration by regsvr32? (I could submit a patch to do it, but see next questions) * Is this the correct usage of avifil32.dll? The loading of this dll occurs via SHCoCreateInstance in shell32/shellole.c, and the comment on the usage of the LoadWithoutCOM key goes like this: //* if a special registry key is set, we load a shell extension without help of OLE32 *// bLoadWithoutCOM = (ERROR_SUCCESS == SHQueryValueExW(hKey, sLoadWithoutCOM, 0, 0, 0, 0)); Is this the correct (or even supported) usage for avifil32.dll? This LoadWithoutCOM kludge does not appear anywhere else in my registry, and it looks like it is intended for shell extensions only. What is the meaning of "shell extension" here? Does avifil32.dll qualify? (I think not, because avifil32 is concerned with AVI file handling, not with user interface. However, I might be wrong.) The last thing I want is to submit a patch, only to be rejected because it attempts to use a DLL in a way not intended by its design. So, is this approach correct (adding LoadWithoutCOM as part or regsvr32 initialization of avifil32.dll), or should an apartment actually be initialized in full COM style? Do you know if LoadWithoutCOM is used anywhere else in Wine? Alex Villacís Lasso

June 30, 2005

Re: unixfs registered by default now in cvs

by Brian Vincent

On 6/30/05, Michael Jung <mjung(a)iss.tu-darmstadt.de> wrote: > With the current CVS version, the unixfs shell namespace extension is now > registered by default at the desktop. So if you do a 'regsvr32 shell32' you Does this mean there's no longer a need to map a Z: drive to /? -Brian

June 30, 2005

Re: Anybody looking for a pet Wine project?

by Jacek Caban

I forgot to attach hh.exe... #include <windows.h> typedef int WINAPI DOWINMAIN(HMODULE hMod, LPSTR cmdline); int WINAPI WinMain(HINSTANCE hInst, HINSTANCE hPrevInst, LPSTR cmdline, int cmdshow) { HMODULE hModule; DOWINMAIN *doWinMain; hModule = LoadLibrary("hhctrl.ocx"); doWinMain = GetProcAddress(hModule, "doWinMain"); return doWinMain(hInst, cmdline); }

June 30, 2005

Wine avitools/aviplay fails with CO_E_NOTINITIALIZED for any AVI file

by Alex Villacís Lasso

I recently downloaded Wine-20050628 (self contained install with fake Windows drive) and tried to use the aviplay program in programs/avitools directory. However, this program fails with this odd error trace: [bash$] WINEDEBUG=shell,ole wine ~/temp/wine/wine-20050628-patch/programs/aviplay.exe.so blur24.avi ... trace:shell:SIC_IconAppend L"c:\\windows\\system\\shell32.dll" 37 0x1126 0x112e trace:shell:SHAlloc 20 bytes at 0x65f43068 trace:shell:SIC_IconAppend L"c:\\windows\\system\\shell32.dll" -38 0x1126 0x112e trace:shell:SHAlloc 20 bytes at 0x65f430d0 trace:shell:SIC_Initialize hIconSmall=0x65f2f5e0 hIconBig=0x65f31190 fixme:avifile:AVIFileInit (): stub! trace:shell:HCR_RegOpenClassIDKey CLSID\{00020020-0000-0000-c000-000000000046} trace:shell:HCR_GetClassNameA -- trace:shell:HCR_RegOpenClassIDKey CLSID\{00020000-0000-0000-c000-000000000046} trace:shell:HCR_GetClassNameA -- Microsoft AVI Files trace:shell:SHCoCreateInstance ((nil), {00020000-0000-0000-c000-000000000046} (Microsoft AVI Files),unk:(nil), {00020020-0000-0000-c000-000000000046} (unknown),0x65cbf8fc) trace:shell:SHQueryValueExW (hkey=0x64,(null),(nil),(nil),0x65cbf338,0x65cbf330=520) trace:shell:SHQueryValueExW (hkey=0x64,L"LoadWithoutCOM",(nil),(nil),(nil),(nil)=0) trace:shell:PathFindFileNameW (L"avifil32.dll") trace:shell:SHCoCreateInstance WithoutCom=0 FromShell=0 trace:shell:HCR_RegOpenClassIDKey CLSID\{00020020-0000-0000-c000-000000000046} trace:shell:HCR_GetClassNameA -- trace:shell:HCR_RegOpenClassIDKey CLSID\{00020000-0000-0000-c000-000000000046} trace:shell:HCR_GetClassNameA -- Microsoft AVI Files err:shell:SHCoCreateInstance failed (0x800401f0) to create CLSID: {00020000-0000-0000-c000-000000000046} (Microsoft AVI Files) IID: {00020020-0000-0000-c000-000000000046} (unknown) err:shell:SHCoCreateInstance class not found in registry trace:shell:SHCoCreateInstance -- instance: (nil) AVIFileOpen: 0x800401f0 I looked up in the include files, and the value of 0x800410f0 is CO_E_NOTINITIALIZED. This is confirmed by a check in the source code that indicates that the apartment was not initialized (please correct me if I get the terminology wrong). The code for aviplay and aviinfo does not attempt to initialize any apartment prior to calling AVIFileOpen with /pclsidHandler/ set to NULL. I looked up in MSDN, and the documentation for AVIFileOpen does not suggest (to me at least), that an apartment should be initialized by the caller. This seems odd, since this means that the program should never have worked in the first place, yet the comments in the source suggest that it worked at least once. Are these avitools maintained? If so, does this result from a misconfiguration (the same one in two different machines so far), or from a genuine incomplete implementation? I would like to hear any comment on this. The original purpose of messing with aviplay was to test whether the Indeo video codecs are actually usable after being installed under Wine, but this problems affects even files not encoded with Indeo. Alex Villacís Lasso

June 30, 2005

Re: MSHTML: fix blank.htm resources

by Jacek Caban

Alexandre Julliard wrote: >That's a feature ;-) We can't support loading builtins as datafiles, >so the idea is that it's more likely that the app will be happy with >loading the native as datafile than loading the builtin in normal >mode. It does make the behavior a bit surprising I agree. > > > Good to know that Wine doesn't have such bug in so important place:-) Maybe it would be better to point it out somewhere in the documentation so that people like me won't have to cover such things themselves. Thanks, Jacek

June 30, 2005

Re: Anybody looking for a pet Wine project?

by Jacek Caban

Hello. I think it will be great to have it done. I'd like to point out one thing for the way to implement it: the most important is to have it working with native shdocvw.dll and mshtml.dll. It won't work with built in in the current state of them, but it will be fixed soon and I believe it can be in CVS even if it doesn't work without these dlls. While implementing then we shouldn't pay too much attention to get it working with Mozilla ActiveX Control - it will never work perfectly and I hope to get rid of its dependency soon. Of course you may do it working, but, as my tests show, it's far from compatible with MS. Also, we need to use itss.dll, which is impossible with Mozilla ActiveX (I'm not sure if Mozilla has support for chm protocol, but even if so it's worse to use it). About implementing hh.exe... it seams to be pretty easy. Attached is (not tested) implementation:-) Another related idea is, as I have spoken with Mike on irc, to use html help in winecfg. It looks like a nice way to have a complex and integrated help. This would mean that we need to implement the chm compiler. To do so we may use chmlib: http://66.93.236.84/~jedwin/projects/chmlib/ that Mike used in itss to decompress chm. As a conclusion: it would be really good to have this working in Wine. It uses most of IE related API (I didn't mension URLMoniker here, which also needs some work) and getting it to work out of box will be a great test for Wine. Thanks, Jacek

June 30, 2005

Re: MSHTML: fix blank.htm resources

by Alexandre Julliard

Jacek Caban <jack(a)itma.pwr.wroc.pl> writes: > This patch depends on my patch to wrc. Alexandre, > I discovered why the test didn't fail for me. There is > a bug in Wine that causes loading of the native dll instead > of builtin when you load it as a data file, so I tested the > builtin dll with native resources. That's a feature ;-) We can't support loading builtins as datafiles, so the idea is that it's more likely that the app will be happy with loading the native as datafile than loading the builtin in normal mode. It does make the behavior a bit surprising I agree. -- Alexandre Julliard julliard(a)winehq.org

June 30, 2005

Re: Sony Station

by Oliver Stieber

--- Chuck Hall <chall(a)bcrl.stcloudstate.edu> wrote: > Was there a specific game that you wanted to test > here? > Well, I've just got a copy of Everquest II, but it would be nice to get any of the Sony Station games working. It looks like I can just change a setting in the registry so long as I've run the post-scan file update under windows. > I have not tried to install any game that required > it, but I can if you > want something tested. > > Have Fun! > Chuck Hall > > On Wed, 29 Jun 2005, Oliver Stieber wrote: > > > Hi, > > > > Has anyone managed to get sony's station > > (http://www.station.sony.com/en/) past the file > scan? > > > > > > > > > > > > > ___________________________________________________________ > > > Yahoo! Messenger - NEW crystal clear PC to PC > calling worldwide with voicemail > http://uk.messenger.yahoo.com > > > > -- > > > ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

June 30, 2005

Re: Fix ntdll compilation in Darwin

by Phil Krylov

Hi Dmitry, On Thu, 30 Jun 2005 22:27:01 +0900 "Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > "Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > > > Index: dlls/ntdll/cdrom.c > > =================================================================== > > RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v > > retrieving revision 1.59 > > diff -p -u -r1.59 cdrom.c > > --- dlls/ntdll/cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 > > +++ dlls/ntdll/cdrom.c 30 Jun 2005 11:27:41 -0000 > > @@ -75,6 +75,11 @@ > > # include <sys/scsiio.h> > > #endif > > > > +#ifdef __APPLE__ > > +# include <IOKit/IOKitLib.h> > > +# include <IOKit/scsi/SCSICmds_REQUEST_SENSE_Defs.h> > > +#endif > > + > > #define NONAMELESSUNION > > #define NONAMELESSSTRUCT > > #include "ntstatus.h" > > @@ -1418,6 +1423,8 @@ static NTSTATUS CDROM_ScsiPassThroughDir > > > > #ifdef SENSEBUFLEN > > if (pPacket->SenseInfoLength > SENSEBUFLEN) > > +#elif defined( __APPLE__ ) > > + if (pPacket->SenseInfoLength > kSenseDefaultSize) > > #else > > if (pPacket->SenseInfoLength > sizeof(struct request_sense)) > > #endif > > Please do not introduce even more platform dependent #ifdefs into cdrom.c, > currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/ > (__NetBSD__). Add proper configure checks for headers and structures your > platform needs. To be sure I get you right: would changing __APPLE__ to HAVE_IOKIT (and adding HAVE_IOKIT detection to configure) be sufficient? -- Ph.

June 30, 2005

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

by Saulius Krasuckas

* On Thu, 30 Jun 2005, Paul Vriens wrote: > > > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > > - Break from the loop to restore SM_SWAPBUTTON metrics. ... > > --- dlls/user/tests/sysparams.c 20 Jun 2005 15:36:17 -0000 1.38 > > +++ dlls/user/tests/sysparams.c 30 Jun 2005 07:36:40 -0000 > > @@ -1011,7 +1011,7 @@ static void test_SPI_SETMOUSEBUTTONSWAP( > > rc=SystemParametersInfoA( SPI_SETMOUSEBUTTONSWAP, vals[i], 0, > > SPIF_UPDATEINIFILE | SPIF_SENDCHANGE ); > > if (!test_error_msg(rc!=vals[i],"SPI_{GET,SET}MOUSEBUTTONSWAP")) > > - return; > > + break; > > It's nice to break but the the end-result will be that the test fails on > all windows versions I could my hands on Test fails because of flawed logic at if-statement, which I have no time to debug for. So I chose to have flawed check instead of having mouse-buttons swapped (which isn't so visible from the test results). > and that the previous setting is restored. Not very useful it seams. So if the buttons were standard mapped, then they got swapped during test and then test failed, you think it is OK to leave buttons swapped?

June 30, 2005

Question about deadlock in winmm

by Vitaliy Margolen

Lately I'm seeing a lot of deadlocks in wine's sound system. Most notably winealsa. But the code in question affects all (in my case oss since it's working better for me then others). I'm not sure what exactly happens (deadlock because of race condition or else) but code bellow deadlocks with other heap functions (like GetHeap). Removing HeapValidate didn't cause any problems for as of yet. And I haven't seen a single deadlock here at all. Is there are reasons we perform this heap validation here? Could someone comment on this? If someone interested I could reproduce backtrace of the deadlock. -- Best regards, Vitaliy Index: dlls/winmm/lolvldrv.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/lolvldrv.c,v retrieving revision 1.68 diff -u -p -r1.68 lolvldrv.c --- dlls/winmm/lolvldrv.c 22 Jun 2005 11:59:43 -0000 1.68 +++ dlls/winmm/lolvldrv.c 29 Jun 2005 14:54:42 -0000 @@ -441,7 +441,7 @@ LPWINE_MLD MMDRV_Get(HANDLE _hndl, UINT hndl = hndl & ~0x8000; if (hndl < sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0])) { mld = MM_MLDrvs[hndl]; - if (!mld || !HeapValidate(GetProcessHeap(), 0, mld) || mld->type != type) + if (!mld || mld->type != type) mld = NULL; } hndl = hndl | 0x8000;

June 30, 2005

Re: Fix ntdll compilation in Darwin

by Dmitry Timoshkov

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: >> > #ifdef SENSEBUFLEN >> > if (pPacket->SenseInfoLength > SENSEBUFLEN) >> > +#elif defined( __APPLE__ ) >> > + if (pPacket->SenseInfoLength > kSenseDefaultSize) >> > #else >> > if (pPacket->SenseInfoLength > sizeof(struct request_sense)) >> > #endif >> >> Please do not introduce even more platform dependent #ifdefs into cdrom.c, >> currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/ >> (__NetBSD__). Add proper configure checks for headers and structures your >> platform needs. > > To be sure I get you right: would changing __APPLE__ to HAVE_IOKIT (and > adding HAVE_IOKIT detection to configure) be sufficient? I'd assume it's enough, yes. kSenseDefaultSize requires another test I think. -- Dmitry.

June 30, 2005

Re: Fix ntdll compilation in Darwin

by Dmitry Timoshkov

"Phil Krylov" <phil(a)newstar.rinet.ru> wrote: > Index: dlls/ntdll/cdrom.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v > retrieving revision 1.59 > diff -p -u -r1.59 cdrom.c > --- dlls/ntdll/cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 > +++ dlls/ntdll/cdrom.c 30 Jun 2005 11:27:41 -0000 > @@ -75,6 +75,11 @@ > # include <sys/scsiio.h> > #endif > > +#ifdef __APPLE__ > +# include <IOKit/IOKitLib.h> > +# include <IOKit/scsi/SCSICmds_REQUEST_SENSE_Defs.h> > +#endif > + > #define NONAMELESSUNION > #define NONAMELESSSTRUCT > #include "ntstatus.h" > @@ -1418,6 +1423,8 @@ static NTSTATUS CDROM_ScsiPassThroughDir > > #ifdef SENSEBUFLEN > if (pPacket->SenseInfoLength > SENSEBUFLEN) > +#elif defined( __APPLE__ ) > + if (pPacket->SenseInfoLength > kSenseDefaultSize) > #else > if (pPacket->SenseInfoLength > sizeof(struct request_sense)) > #endif Please do not introduce even more platform dependent #ifdefs into cdrom.c, currently it already has enough mess with all that #if defined(linux)/(__FreeBSD__)/ (__NetBSD__). Add proper configure checks for headers and structures your platform needs. -- Dmitry.

June 30, 2005

Re: unixfs registered by default now in cvs

by Michael Jung

On Thursday 30 June 2005 15:01, Dimi Paun wrote: > This is fantastic! Way to go Michael, you've nailed an important > integration issue. BTW, if it is registered by default, why do we > need to 'regsvr32 shell32'? Thanks. If you start without a .wine directory, you won't need the 'regsvr32 shell32'. So for a fresh install, you will end up with unixfs. But if you already have a '.wine' directory and want unixfs to be registered, you'll have to do it by hand. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

June 30, 2005

The wine-patches archives

by Tom Wickline

Looks like ""Downloadable version" is stuck at 9 MB last time I checked we were at a new record of 10.2 MB ......... Newman to the rescue ? Cheers, Tom

June 30, 2005

Re: unixfs registered by default now in cvs

by Dimi Paun

On Thu, 2005-06-30 at 14:05 +0200, Michael Jung wrote: > With the current CVS version, the unixfs shell namespace extension is > now registered by default at the desktop. So if you do a 'regsvr32 > shell32' you will see the unix filesystem in the file dialogs. This is fantastic! Way to go Michael, you've nailed an important integration issue. BTW, if it is registered by default, why do we need to 'regsvr32 shell32'? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

June 30, 2005

unixfs registered by default now in cvs

by Michael Jung

Hi, With the current CVS version, the unixfs shell namespace extension is now registered by default at the desktop. So if you do a 'regsvr32 shell32' you will see the unix filesystem in the file dialogs. It's probably still quite buggy though. It would be cool if we could get the biggest problems sorted out before the next release. So if you have an application, which doesn't work due to unixfs, please report to wine-devel. If you don't want to use unixfs, because you don't like it or because it totally breaks your setup, you can delete the following registry-key and you should be back to the old behaviour: HKLM\Software\Microsoft\Windows\CurrentVersion\Explorer\Desktop\Namespace\ {9D20AAE8-0625-44B0-9CA7-71889C2254D9} This will also help you to figure out if a problem is due to unixfs. If you do 'regsvr32 shell32' again, the key will be re-created. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

June 30, 2005

Re: Delays in FileOpen

by Uwe Bonnes

>>>>> "Michael" == Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: Michael> On Wednesday 29 June 2005 23:36, Uwe Bonnes wrote: >> File Open Dialogs for me have some noticable initial delay when >> starting up. For example, try in internet explorer "Save under". I >> don't remember seeing that delay some time before. Dif recent >> shfolder changes cause that delay? Michael> There was a problem in SHGetPathFromIDList, which caused a Michael> delay in the file dialogs. I hope it was fixed with this patch, Michael> applied at the 2005/06/25. Michael> http://cvs.winehq.org/patch.py?id=18448 Michael> Does your local tree already contain this patch? Yes, my local tree contains the patch. But my first impression was incorrect, the delay is _not_ new. The test with ie6 where done with a wine-200410xx setup, and "save as" shows the delay too. But also other programs run against recent CVS wine show that initial delay until the file selection box starts up. Do other notice that delay too? E.g. the file -> open box from wordview97 takes several seconds on an Athlon2500. (about 500 file/directories including dot files/directory in $HOME where the file open box starts up). Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

June 30, 2005

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

by jakov＠vmlinux.org

> Saulius Krasuckas wrote: >>>ChangeLog: Fix bug that left mouse buttons swapped after tests >>> >>>Ivan. >> >> >> I think your patch causes test to fail on Wine, Ivan. My try goes next. > > Maybe that isn't a bad thing, the results from the latest build of > winetest shows this test fails > on windows 2000, windows nt, windows me, and windows 98se, so I somewhat > doubt the wine behaviour is > correct. > > Ivan. And this is exactly why no part of winetest should be allowed to fail. //Jakob

June 30, 2005

Fwd: Anybody looking for a pet Wine project?

by Vijay Kiran Kamuju

---------- Forwarded message ---------- From: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Jun 30, 2005 3:42 PM Subject: Re: Anybody looking for a pet Wine project? To: Mike McCormack <mike(a)codeweavers.com> typelib info of hhctrl.ocx of winxp (used pe explorer) -------------------------------------------------------------------------- //HHCtrl 4.0 Type Library //Version: 4.0 HHCTRLLib; GUID = {ADB880A2-D8FF-11CF-9377-00AA003B7A11}; //Event interface for HHCtrl Dispatch _HHCtrlEvents; GUID = {ADB880A3-D8FF-11CF-9377-00AA003B7A11}; function Click(out ParamString: BSTR); stdcall; //HHCtrl Class CoClass HHCtrl; GUID = {52A2AAAE-085D-4187-97EA-8C30DB990436}; //IHHCtrl Interface Dispatch IHHCtrl; GUID = {ADB880A1-D8FF-11CF-9377-00AA003B7A11}; function QueryInterface(riid: ^GUID; out ppvObj: ^^VOID); stdcall; function AddRef: UI4; stdcall; function Release: UI4; stdcall; function GetTypeInfoCount(out pctinfo: ^UINT); stdcall; function GetTypeInfo(itinfo: UINT; lcid: UI4; out pptinfo: ^^VOID); stdcall; function GetIDsOfNames(riid: ^GUID; rgszNames: ^^I1; cNames: UINT; lcid: UI4; out rgdispid: ^I4); stdcall; function Invoke(dispidMember: I4; riid: ^GUID; lcid: UI4; wFlags: UI2; pdispparams: ^DISPPARAMS; out pvarResult: ^Variant; out pexcepinfo: ^EXCEPINFO; out puArgErr: ^UINT); stdcall; property-put Image(: BSTR); stdcall; property-get Image: BSTR; stdcall; //Click method function Click; stdcall; //Click method function HHClick; stdcall; //Print method function Print; stdcall; //syncURL method function syncURL(out pszUrl: BSTR); stdcall; //TCard method function TCard(out wParam: UINT_PTR; out lParam: LONG_PTR); stdcall; //Text Popup method function TextPopup(out pszText: BSTR; out pszFont: BSTR; out horzMargins: INT; out vertMargins: INT; out clrForeground: UI4; out clrBackground: UI4); stdcall; Alias UINT_PTR; UI4 Alias LONG_PTR; I4 //Deprecated HHCtrl Class 2 CoClass OldHHCtrl2; GUID = {41B23C28-488E-4E5C-ACE2-BB0BBABE99E8}; //Deprecated HHCtrl Class 1 CoClass OldHHCtrl1; GUID = {ADB880A6-D8FF-11CF-9377-00AA003B7A11}; On 6/30/05, Mike McCormack <mike(a)codeweavers.com> wrote: > > Hi All, > > If anybody is looking for a small project, I've got just the thing for you! > > hh.exe and hhctrl.ocx are two components of the Microsoft HTML help > engine. hh.exe is a small wrapper around hhctrl.ocx, which is the HTML > help viewer. > > hhctrl.ocx embeds IE and feeds it HTML documents decoded from .chm files > with itss.dll (the Infotech storage system). Implementing hhctrl.ocx > would make an excellent test case for IE embedding that Jacek is working > on, and for itss.dll. > > So most of the components are already in place (or will be soon) to make > HTML help work... any takers to fill in the dots? > > The reward is, like most of Wine code, to say "I made that work" :) > > Let me know if you're interested. > > Mike > > >

June 30, 2005

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

by Ivan Leo Puoti

Saulius Krasuckas wrote: >>ChangeLog: Fix bug that left mouse buttons swapped after tests >> >>Ivan. > > > I think your patch causes test to fail on Wine, Ivan. My try goes next. Maybe that isn't a bad thing, the results from the latest build of winetest shows this test fails on windows 2000, windows nt, windows me, and windows 98se, so I somewhat doubt the wine behaviour is correct. Ivan.

June 30, 2005

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

by Paul Vriens

>> ChangeLog: Fix bug that left mouse buttons swapped after tests >> >> Ivan. > > I think your patch causes test to fail on Wine, Ivan. My try goes next. > > > ChangeLog: > Saulius Krasuckas <saulius.krasuckas(a)ieee.org> > - Break from the loop to restore SM_SWAPBUTTON metrics. > - SetLastError() to see if restoration changes it. > > > Index: dlls/user/tests/sysparams.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/tests/sysparams.c,v > retrieving revision 1.38 > diff -p -u -r1.38 sysparams.c > --- dlls/user/tests/sysparams.c 20 Jun 2005 15:36:17 -0000 1.38 > +++ dlls/user/tests/sysparams.c 30 Jun 2005 07:36:40 -0000 > @@ -1011,7 +1011,7 @@ static void test_SPI_SETMOUSEBUTTONSWAP( > rc=SystemParametersInfoA( SPI_SETMOUSEBUTTONSWAP, vals[i], 0, > SPIF_UPDATEINIFILE | SPIF_SENDCHANGE ); > if (!test_error_msg(rc!=vals[i],"SPI_{GET,SET}MOUSEBUTTONSWAP")) > - return; > + break; It's nice to break but the the end-result will be that the test fails on all windows versions I could my hands on and that the previous setting is restored. Not very useful it seams. Cheers, Paul.

June 30, 2005

Re: Delays in FileOpen

by Michael Jung

On Wednesday 29 June 2005 23:36, Uwe Bonnes wrote: > File Open Dialogs for me have some noticable initial delay when starting > up. For example, try in internet explorer "Save under". I don't remember > seeing that delay some time before. Dif recent shfolder changes cause that > delay? There was a problem in SHGetPathFromIDList, which caused a delay in the file dialogs. I hope it was fixed with this patch, applied at the 2005/06/25. http://cvs.winehq.org/patch.py?id=18448 Does your local tree already contain this patch? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

June 30, 2005

Re: Using ReactOS Registry format

by Jürgen Schmied

Hi! Wine had support for reading win2000 registry files once. It was dropped some time ago. I had implemented it around 1999/2000. Have a look in the CVS. Bye Juergen > Hi Martin, > Thanks for this info. It looks like this might work. How do I contact > Eric Kohl? > > Thanks, > James > > On Tue, 2005-06-21 at 17:57 +0200, Martin Fuchs wrote: > > Hi James, > > > > > Last night Martin Fuchs suggested that we look into using ReactOS's > > > registry format in order to be compatible with Windows registry > > > databases. I have the latest release of ReactOS running on QEMU on my > > > box, so I checked it out. Basically, they're using the same regedit > > > program from Wine, missing find command and all (Which I too feel is a > > > pain in the neck). > > > > A bunch of dlls and applications are synced between Wine and ROS from > > time to time, also including regedit. What about implemting the > > missing find functionality at your own to bring both projects a little > > foreward? ;-) > > > > > > > I looked at the config stuff, and I found what looked > > > like some binary database files for each of the main registry sections. > > > Unfortunately, there's no documentation at all on any of this on their > > > website. > > > > I can forward you a mail from Steven Edwards to bring a bit light into > > this issue: > > > > S> I think ReactOS's registry is binary compatible with NT4. It and > > the windows 2000 format was > > S> documented/reversed for samba and the linux ntchpwd bootdisk > > projects. If I remeber right Eric > > S> Kohl offered to release some of his work to Wine for the binary > > format so you might want to ping > > S> him about the implementation details. > > > > So Eric Kohl would be the right man to ask about the internals of NT's > > registry format. > > > > > If we decide to go this route, we may be in for a hell of a lot > > > of work. But, I do agree with all of your points. I think the current > > > system could use some improvement, especially in the area of searching. > > > Let me know what you think of all this. > > > > > > Regards, > > > > Martin > > >

June 30, 2005

Re: Mouse-buttons swapped after winetest

by Saulius Krasuckas

* On Fri, 24 Jun 2005, Paul Vriens wrote: > * On Fri, 2005-06-24 at 17:44, Saulius Krasuckas wrote: > > > > Then would be nice to print "err" in following format "err=%0x%08lx" or > > such after a restoration. Any more ideas? Sorry, I meant 0x%08lx. > Why do you want to change that? I thought %08lx is pretty common in most > of the Wine code. (I remember seeing your email on wine-devel about that > though). I just see two versions of formatting in Wine and want to get rid of one of it. Not a large difference which. OTOH, which one case brings you more clearness while reading logs: 00000021 or 0x0000021 ? I prefer the latter one.

June 30, 2005

Anybody looking for a pet Wine project?

by Mike McCormack

Hi All, If anybody is looking for a small project, I've got just the thing for you! hh.exe and hhctrl.ocx are two components of the Microsoft HTML help engine. hh.exe is a small wrapper around hhctrl.ocx, which is the HTML help viewer. hhctrl.ocx embeds IE and feeds it HTML documents decoded from .chm files with itss.dll (the Infotech storage system). Implementing hhctrl.ocx would make an excellent test case for IE embedding that Jacek is working on, and for itss.dll. So most of the components are already in place (or will be soon) to make HTML help work... any takers to fill in the dots? The reward is, like most of Wine code, to say "I made that work" :) Let me know if you're interested. Mike

June 30, 2005

Re: [MSXML] : add declarations for XMLDOM

by Mike McCormack

Hi Vijay, Vijay Kiran Kamuju wrote: > I am sending a new patch for th XMLDOM stuff > ChangeLog > ---------------- > add definitions and declarations for XMLDOM stuff Thanks for sending the patch in. After looking through it, here are my notes: * try cut it up into small bits, the smaller the better. Alexandre checks every line before applying a patch, so if you reduce the size of you patches, you'll reduce Alexandre's work and increase the chance that they go into Wine. So I'd suggest cut this patch up into two patches, one to add the DISPIDs and one to add the interface code. * you should add your own copyright line, instead of adding to the end of mine. eg. * Copyright (C) 2005 Mike McCormack * Copyright (c) 2005 Vijay Kiran Kamuju looks like good, Mike

June 30, 2005

Re: Fix libGL.a check on configure

by Anderson Lizardo

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ove Kaaven wrote: > ons, 29,.06.2005 kl. 20.11 -0400, skrev Anderson Lizardo: > >>Changelog: Check for common broken nVidia+Mesa OpenGL library setups. >>http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… >> >>The current "test" check definitely does not ensure the system doesn't >>have this "broken" setup. As you said, it should be better to let >>autoconf do the check properly with AC_CHECK_LIB. > > > Certainly does. The broken setup is as follows: > > /usr/lib/libGL.so <- belongs to nvidia > /usr/lib/libGL.a <- no such thing > /usr/X11R6/lib/libGL.so <- deleted by nvidia installer > /usr/X11R6/lib/libGL.a <- still exists, belongs to Mesa > > Linking will succeed whatever you do, but if you don't check for this > setup, Wine will be statically linked to Mesa here, and users will > complain about no hardware acceleration. The AC_MSG_ERROR just puts this > in terms that users understand, even though it's not an accurate > message, and probably why you didn't see the point of the check. Hi, Based on your broken setup description, I've made a simple test case that (hopefully) correctly checks if the OpenGL setup is broken or not. Can you run it and return the results? I've attached both the configure.ac file and the already assembled configure script (gzipped). I would expect "OpenGL setup is OK!" on a correct setup, "OpenGL setup is broken!" on a broken one and "OpenGL support is not compilable" if OpenGL dev files are not installed. Based on your results, I'll send the (hopefully) final patch. Thanks, - -- Anderson Lizardo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCw4kNtyCO/xz4QpMRAnQAAJ4yZaWvfV19t7nfm6/nqqZDKIk56ACeJHbs PXMNRRSsdII19+rSes26LLo= =RjjN -----END PGP SIGNATURE----- AC_PREREQ(2.53) AC_INIT([TestCase],0.1,[none]) AC_PATH_XTRA AC_CHECK_HEADERS(GL/gl.h GL/glx.h) if test "$ac_cv_header_GL_gl_h" = "yes" -a "$ac_cv_header_GL_glx_h" = "yes" then AC_CHECK_LIB(GL,glXCreateContext,OPENGL_LIBS="-lGL",, $X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS) if test "$ac_cv_lib_GL_glXCreateContext" = "yes" then AC_MSG_NOTICE([OpenGL setup is OK!]) else AC_MSG_ERROR([OpenGL setup is broken!]) fi else AC_MSG_NOTICE([OpenGL support is not compilable]) fi

June 30, 2005

Re: dlls/ntdll/cdrom.c breakage

by Dmitry Timoshkov

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > Thanks for the quick response, Dmitry! Unfortunately, the patch that > Alexandre now committed does not solve the problem for me, and my > autoconf foo is a bit rusty: > > cdrom.c: In function `CDROM_ScsiPassThroughDirect': > drom.c:1423: error: invalid application of `sizeof' to an incomplete type > cdrom.c: In function `CDROM_ScsiPassThrough': > cdrom.c:1543: error: invalid application of `sizeof' to an incomplete type I don't see how it worked before then, you need to investigate why '#ifdef SENSEBUFLEN' case doesn't work for you. > Alexandre, please find below another patch which does not fix this either, > but gets rid of some unused variable warnings. > > Gerald > > ChangeLog: > Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and > CDROM_ScsiPassThrough(). This means that HAVE_SCSIREQ_T_CMD is not defined for you, i.e. scsireq_t has not been detected. Very likely this is caused by a wrong/missing header includes in the configure.ac test, please fix it, it's easy enough. -- Dmitry.

June 30, 2005

Re: Fix libGL.a check on configure

by Ove Kaaven

ons, 29,.06.2005 kl. 20.11 -0400, skrev Anderson Lizardo: > Changelog: Check for common broken nVidia+Mesa OpenGL library setups. > http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… > > The current "test" check definitely does not ensure the system doesn't > have this "broken" setup. As you said, it should be better to let > autoconf do the check properly with AC_CHECK_LIB. Certainly does. The broken setup is as follows: /usr/lib/libGL.so <- belongs to nvidia /usr/lib/libGL.a <- no such thing /usr/X11R6/lib/libGL.so <- deleted by nvidia installer /usr/X11R6/lib/libGL.a <- still exists, belongs to Mesa Linking will succeed whatever you do, but if you don't check for this setup, Wine will be statically linked to Mesa here, and users will complain about no hardware acceleration. The AC_MSG_ERROR just puts this in terms that users understand, even though it's not an accurate message, and probably why you didn't see the point of the check.

June 30, 2005

Re: ntdll: Fix add_access_ace

by Mike McCormack

Hi James, James Hawkins wrote: > These changes make the advapi32 tests pass as well. > > Changelog > * Fix calculation of generic pointers. > * Minor cleanups. Thanks for the fixes. This makes Office 2003 work again for me. > if ((DWORD)(pAceHeader + dwAceSize) > (DWORD)(pAcl + pAcl->AclSize)) > return STATUS_ALLOTTED_SPACE_EXCEEDED; I think you might have missed one here. The above pointer arithmetic seems like it will make the wrong calculation. Maybe something like the following would work better: if ( &((char*)pAceHeader)[dwAceSize] > &((char*)pAcl)[pAcl->AclSize] ) Mike

June 30, 2005

Re: [Bugzilla/AppDB] www.winehq.org/appview.php -> appdb.winehq.org/appview.php

by Tony Lambregts

June 30, 2005

Re: Fix libGL.a check on configure

by Anderson Lizardo

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexandre Julliard wrote: > It would be much better to try the actual linking and see what > happens. Indeed, I was thinking on that myself... Why we just don't remove this (incorrect IMHO) file presence check and let autoconf do the check itself, which it already does as evidenced on the following snippet from configure.ac: dnl Check for the presence of the library AC_CHECK_LIB(GL,glXCreateContext, OPENGL_LIBS="-lGL" ,, $X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS) Additionally, looking at the commit message that added the "test -e" check: Changelog: Check for common broken nVidia+Mesa OpenGL library setups. http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… The current "test" check definitely does not ensure the system doesn't have this "broken" setup. As you said, it should be better to let autoconf do the check properly with AC_CHECK_LIB. So here goes my latest patch which incorporates your suggestion (it just removes the broken check). I've tested it with both NVidia libraries (nvidia-glx and nvidia-glx-dev on Ubuntu 5.04) and Mesa "pure" libraries, and wine compiled with OpenGL on both setups. For tests, I've used: make -C dlls/ddraw/tests/ test Although I'm not sure this is the ideal test to check if OpenGL is working with Wine. Best regards, - -- Anderson Lizardo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCwzi4tyCO/xz4QpMRAs9VAKCD5tilfTy6ePu7TY1z6qTXEUNk/gCfX/WO 5tHT6L0oSA1X8bdqQ0SGGac= =UqUn -----END PGP SIGNATURE-----

June 30, 2005

Re: World of Warcraft

by Christoph

Christoph schrieb: > > > Joseph Garvin schrieb: > >> The test realms are up, which lets players test the next patch. Anyone >> tried it to see if the problem is fixed? No, it is not fixed. >> > > Yes, I'm going to test. > > first gotcha the bizzard char copy page. The page did not work in > Firefox. Clicking in a circle, not accepting a new char name. Looked at > page source. What a joy. The europe/german Version of the page contains > a bag full of typos ... such as not closed tags ! Thanks to the > Webdeveloper plugin in Firefox I got finally a test char :-P > > second download tool. 100% cpu and 'nothing' happens until winedbg came > up with seg fault. Simply retried 5 times, now it's downloading and > uploading with 3040MB/s . Great speedup :=) > > third, ... hey I have to cvs the latest wine ;-) K. First test run with wine-20050628 with WoW-1.5.1 The "I cannnot click on any NPC" is still there. Audio is not working (artsdrv) also not with sndrec32.exe ("no sound device"). artsd is running and no conn from wine. Mh, something rotten with wineconfig/registry?! I can see wine is loading wineoss.drv instead. Regedit shows me correctly WineMM/Drivers=winearts.drv Tried alsa, that is working. New bug in wine-20050628: if WoW looses focus, it minimizes and maximizes automatically and steals focus again (I'm using WMaker) more worse graphics becomes shifted about +1px+1px every time. Makes game unplayable after this. Is the option "UseTakeFocus" = "n" no more working?! So, now I'm going to patch the game. K. patched fine. creates a new folder WoWTest with empty wtf/ config-Folder so have to adjust settings after a quick run. Game is up. Still has the "cannot click on NPC" The cheap wrapper trick is still making it working. further testing needs now lots more time ;) > > > chris > >

June 29, 2005

Re: Sony Station

by Chuck Hall

Was there a specific game that you wanted to test here? I have not tried to install any game that required it, but I can if you want something tested. Have Fun! Chuck Hall On Wed, 29 Jun 2005, Oliver Stieber wrote: > Hi, > > Has anyone managed to get sony's station > (http://www.station.sony.com/en/) past the file scan? > > > > > > ___________________________________________________________ > Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com > --

June 29, 2005

Re: dlls/ntdll/cdrom.c breakage

by Gerald Pfeifer

On Wed, 29 Jun 2005, Dmitry Timoshkov wrote: >> breaks on FreeBSD >> >> cdrom.c: In function `CDROM_ScsiPassThroughDirect': >> cdrom.c:1419: error: invalid application of `sizeof' to an incomplete type >> cdrom.c:1411: warning: unused variable `io' >> cdrom.c: In function `CDROM_ScsiPassThrough': >> cdrom.c:1534: error: invalid application of `sizeof' to an incomplete type >> cdrom.c:1526: warning: unused variable `io' >> which does not have struct request_sense, but does have struct >> scsi_request_sense in /usr/include/cam/scsi/scsi_all.h. > Attached patch is a workaround for the problem. A correct approach is to > add a test for presence of the 'struct request_sense' to configure and > add appropriate #ifdef's in the code. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > A workaround for missing struct request_sense on FreeBSD. Thanks for the quick response, Dmitry! Unfortunately, the patch that Alexandre now committed does not solve the problem for me, and my autoconf foo is a bit rusty: cdrom.c: In function `CDROM_ScsiPassThroughDirect': drom.c:1423: error: invalid application of `sizeof' to an incomplete type cdrom.c: In function `CDROM_ScsiPassThrough': cdrom.c:1543: error: invalid application of `sizeof' to an incomplete type Alexandre, please find below another patch which does not fix this either, but gets rid of some unused variable warnings. Gerald ChangeLog: Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and CDROM_ScsiPassThrough(). Index: cdrom.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v retrieving revision 1.59 diff -u -3 -p -r1.59 cdrom.c --- cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 +++ cdrom.c 29 Jun 2005 21:36:26 -0000 @@ -1405,10 +1405,11 @@ static NTSTATUS CDROM_ScsiPassThroughDir int ret = STATUS_NOT_SUPPORTED; #ifdef HAVE_SG_IO_HDR_T_INTERFACE_ID sg_io_hdr_t cmd; + int io; #elif defined HAVE_SCSIREQ_T_CMD scsireq_t cmd; -#endif int io; +#endif if (pPacket->Length < sizeof(SCSI_PASS_THROUGH_DIRECT)) return STATUS_BUFFER_TOO_SMALL; @@ -1524,10 +1525,11 @@ static NTSTATUS CDROM_ScsiPassThrough(in int ret = STATUS_NOT_SUPPORTED; #ifdef HAVE_SG_IO_HDR_T_INTERFACE_ID sg_io_hdr_t cmd; + int io; #elif defined HAVE_SCSIREQ_T_CMD scsireq_t cmd; -#endif int io; +#endif if (pPacket->Length < sizeof(SCSI_PASS_THROUGH)) return STATUS_BUFFER_TOO_SMALL;

June 29, 2005

Delays in FileOpen

by Uwe Bonnes

Hallo (Michael?), File Open Dialogs for me have some noticable initial delay when starting up. For example, try in internet explorer "Save under". I don't remember seeing that delay some time before. Dif recent shfolder changes cause that delay? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

June 29, 2005

Re: [Fwd: QUARTZ: initialize AM_MEDIA_TYPE to prevent crash]

by Christian Costa

I have already sent a fix (applied) for that 3 weeks ago. You should have updated you tree before sending a patch. ;-) Bye, Christian Alex Villacís Lasso wrote: > I am (still) trying to run a Japanese RPG program in Wine, and it > requires 1) the Indeo video codecs, fortunately downloadable, and 2) > this patch, to prevent crashing on an attempt to IUnknown_Release on a > bogus interface. > > Second attempt - first one never appeared on the mail list. > > Changelog: > * Initialize mtCurrent structure to NULL to prevent calling > IUnknown_Release on an uninitialized interface > > >------------------------------------------------------------------------ > >--- wine-20050524/dlls/quartz/pin.c 2005-05-06 09:34:44.000000000 -0500 >+++ wine-20050524-patch/dlls/quartz/pin.c 2005-06-26 20:48:48.000000000 -0500 >@@ -153,6 +153,7 @@ > pPinImpl->pin.fnQueryAccept = pQueryAccept; > pPinImpl->pin.pUserData = pUserData; > pPinImpl->pin.pCritSec = pCritSec; >+ memset(&(pPinImpl->pin.mtCurrent), 0, sizeof(AM_MEDIA_TYPE)); > Copy_PinInfo(&pPinImpl->pin.pinInfo, pPinInfo); > > /* Input pin attributes */ >@@ -176,6 +177,7 @@ > pPinImpl->pin.fnQueryAccept = pQueryAccept; > pPinImpl->pin.pUserData = pUserData; > pPinImpl->pin.pCritSec = pCritSec; >+ memset(&(pPinImpl->pin.mtCurrent), 0, sizeof(AM_MEDIA_TYPE)); > Copy_PinInfo(&pPinImpl->pin.pinInfo, pPinInfo); > > /* Output pin attributes */ > >

June 29, 2005

Re: World of Warcraft

by Christoph

Joseph Garvin schrieb: > The test realms are up, which lets players test the next patch. Anyone > tried it to see if the problem is fixed? > Yes, I'm going to test. first gotcha the bizzard char copy page. The page did not work in Firefox. Clicking in a circle, not accepting a new char name. Looked at page source. What a joy. The europe/german Version of the page contains a bag full of typos ... such as not closed tags ! Thanks to the Webdeveloper plugin in Firefox I got finally a test char :-P second download tool. 100% cpu and 'nothing' happens until winedbg came up with seg fault. Simply retried 5 times, now it's downloading and uploading with 3040MB/s . Great speedup :=) third, ... hey I have to cvs the latest wine ;-) chris

June 29, 2005

Re: MSHTML: Implemented res protocol

by Juan Lang

Hi Jacek, > +/* FIXME: What does it mean? */ > +#define UNKNOWN_RES_ERR1 0x8007007E This is HRESULT_FROM_WIN32(ERROR_MOD_NOT_FOUND). Any 0x8007* error code is an HRESULT_FROM_WIN32 of a Win32 error. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

June 29, 2005

Sony Station

by Oliver Stieber

Hi, Has anyone managed to get sony's station (http://www.station.sony.com/en/) past the file scan? ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

June 29, 2005

Modifying windows registry

by Serge NOEL

Hello, i' am searching a way to change windows registry from Linux (not the copy but the real windows registry) Has someone an idea on how to do this ? Serge

June 29, 2005

Re: Fix libGL.a check on configure

by Chuck Hall

On Tue, 28 Jun 2005, Anderson Lizardo wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Alexandre Julliard wrote: > > Anderson Lizardo <andersonlizardo(a)yahoo.com.br> writes: > >>Fixed the libGL.a configure check for systems where > >>/usr/X11R6/lib/libGL.so is a symbolic link. > >> > >> > >>PS.: I've not used a simple "test -e" because > >>http://www.winehq.org/hypermail/wine-patches/2002/01/0206.html says this > >>does not work on Solaris. > > > > > > My guess is that if test -e doesn't work, test -L won't work either... > > What about the attached patch? It uses "ls" instead of "test" to test > for file presence (assuming ls returns non-zero code on a non-present > file, which is true for a POSIX compliant system). > > Snippet: > > - - if test -f /usr/X11R6/lib/libGL.a -a ! -f > /usr/X11R6/lib/libGL.so -a ! -f /usr/X11R6/lib/libGL.dylib > + if ls /usr/X11R6/lib/libGL.a >/dev/null 2>&1 -a \ > + ! ls /usr/X11R6/lib/libGL.so >/dev/null 2>&1 -a \ > + ! ls /usr/X11R6/lib/libGL.dylib >/dev/null 2>&1 > > Best regards, > - -- > Anderson Lizardo On Solaris 9 and Solaris 10 the man page for test say -e checks if the file exists, and -L checks if the file exists and is a symbolic link. -e is not avaliable in the shell sh, there is no mention if -L works or not in sh. It might be a problem for just Solaris 8, or the tests are/were ran in the sh shell. -- Have Fun! Chuck Hall

June 29, 2005

Re: Fix libGL.a check on configure

by Alexandre Julliard

Anderson Lizardo <andersonlizardo(a)yahoo.com.br> writes: > What about the attached patch? It uses "ls" instead of "test" to test > for file presence (assuming ls returns non-zero code on a non-present > file, which is true for a POSIX compliant system). It would be much better to try the actual linking and see what happens. -- Alexandre Julliard julliard(a)winehq.org

June 29, 2005

Re: implement EM_GETTEXTEX in riched20

by Marcus Meissner

On Wed, Jun 29, 2005 at 09:02:34AM -0500, Aric Stewart wrote: > implementation for EM_GETTEXTEX in riched20 > Index: dlls/riched20/editor.c > =================================================================== > RCS file: /home/wine/wine/dlls/riched20/editor.c,v > retrieving revision 1.32 > diff -u -r1.32 editor.c > --- dlls/riched20/editor.c 21 Jun 2005 20:53:14 -0000 1.32 > +++ dlls/riched20/editor.c 29 Jun 2005 14:00:17 -0000 > @@ -845,7 +845,6 @@ > UNSUPPORTED_MSG(EM_GETRECT) > UNSUPPORTED_MSG(EM_GETREDONAME) > UNSUPPORTED_MSG(EM_GETSCROLLPOS) > - UNSUPPORTED_MSG(EM_GETTEXTEX) > UNSUPPORTED_MSG(EM_GETTEXTLENGTHEX) > UNSUPPORTED_MSG(EM_GETTEXTMODE) > UNSUPPORTED_MSG(EM_GETTYPOGRAPHYOPTIONS) > @@ -1184,6 +1183,30 @@ > return RichEditANSIWndProc(hWnd, EM_GETTEXTRANGE, 0, (LPARAM)&tr); > } > case EM_GETSELTEXT: > + case EM_GETTEXTEX: > + { I do not think this is what you want. You now have both cases in one ... Ciao, Marcus

June 29, 2005

Re[2]: shell32/tests: ILFree is not exported on all versions

by Vitaliy Margolen

Wednesday, June 29, 2005, 7:47:38 AM, you wrote: > * On Wed, 29 Jun 2005, Vitaliy Margolen wrote: >> >> By a looks of it wine using same IMalloc interface for both. Native, >> including XP and server 2003 still export SHGetMalloc. >> >> In other words I don't see a problem using SHGetMalloc on wine and all >> of native versions. > Not a problem, just a message from MSDN [1]: > | SHGetMalloc Function > | Not currently supported. > | > | Remarks > | This function should no longer be used. Use the CoTaskMemFree and > | CoTaskMemAlloc functions in its place. > Plus CoTaskMemFree() lets us get rid of one global variable. :-P > No, this isn't a persuading act. This might be more of my question: > --Why MS decided to write about stopping to support this function? That's what they do - screwing people up. > [1] > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… Yeh, I read that. There is no way they can delete SHGetMalloc without braking huge number of programs. BTW on Win CE it's still what they suggest. And the last note: this patch made it in :P Vitaliy

June 29, 2005