June 2005 - Wine-Devel - list.winehq.org

Re: [MSXML] : add declarations for XMLDOM

by Mike McCormack

Hi Vijay, Vijay Kiran Kamuju wrote: > I am sending a new patch for th XMLDOM stuff > ChangeLog > ---------------- > add definitions and declarations for XMLDOM stuff Thanks for sending the patch in. After looking through it, here are my notes: * try cut it up into small bits, the smaller the better. Alexandre checks every line before applying a patch, so if you reduce the size of you patches, you'll reduce Alexandre's work and increase the chance that they go into Wine. So I'd suggest cut this patch up into two patches, one to add the DISPIDs and one to add the interface code. * you should add your own copyright line, instead of adding to the end of mine. eg. * Copyright (C) 2005 Mike McCormack * Copyright (c) 2005 Vijay Kiran Kamuju looks like good, Mike

June 30, 2005

Re: Fix libGL.a check on configure

by Anderson Lizardo

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ove Kaaven wrote: > ons, 29,.06.2005 kl. 20.11 -0400, skrev Anderson Lizardo: > >>Changelog: Check for common broken nVidia+Mesa OpenGL library setups. >>http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… >> >>The current "test" check definitely does not ensure the system doesn't >>have this "broken" setup. As you said, it should be better to let >>autoconf do the check properly with AC_CHECK_LIB. > > > Certainly does. The broken setup is as follows: > > /usr/lib/libGL.so <- belongs to nvidia > /usr/lib/libGL.a <- no such thing > /usr/X11R6/lib/libGL.so <- deleted by nvidia installer > /usr/X11R6/lib/libGL.a <- still exists, belongs to Mesa > > Linking will succeed whatever you do, but if you don't check for this > setup, Wine will be statically linked to Mesa here, and users will > complain about no hardware acceleration. The AC_MSG_ERROR just puts this > in terms that users understand, even though it's not an accurate > message, and probably why you didn't see the point of the check. Hi, Based on your broken setup description, I've made a simple test case that (hopefully) correctly checks if the OpenGL setup is broken or not. Can you run it and return the results? I've attached both the configure.ac file and the already assembled configure script (gzipped). I would expect "OpenGL setup is OK!" on a correct setup, "OpenGL setup is broken!" on a broken one and "OpenGL support is not compilable" if OpenGL dev files are not installed. Based on your results, I'll send the (hopefully) final patch. Thanks, - -- Anderson Lizardo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCw4kNtyCO/xz4QpMRAnQAAJ4yZaWvfV19t7nfm6/nqqZDKIk56ACeJHbs PXMNRRSsdII19+rSes26LLo= =RjjN -----END PGP SIGNATURE----- AC_PREREQ(2.53) AC_INIT([TestCase],0.1,[none]) AC_PATH_XTRA AC_CHECK_HEADERS(GL/gl.h GL/glx.h) if test "$ac_cv_header_GL_gl_h" = "yes" -a "$ac_cv_header_GL_glx_h" = "yes" then AC_CHECK_LIB(GL,glXCreateContext,OPENGL_LIBS="-lGL",, $X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS) if test "$ac_cv_lib_GL_glXCreateContext" = "yes" then AC_MSG_NOTICE([OpenGL setup is OK!]) else AC_MSG_ERROR([OpenGL setup is broken!]) fi else AC_MSG_NOTICE([OpenGL support is not compilable]) fi

June 30, 2005

Re: dlls/ntdll/cdrom.c breakage

by Dmitry Timoshkov

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > Thanks for the quick response, Dmitry! Unfortunately, the patch that > Alexandre now committed does not solve the problem for me, and my > autoconf foo is a bit rusty: > > cdrom.c: In function `CDROM_ScsiPassThroughDirect': > drom.c:1423: error: invalid application of `sizeof' to an incomplete type > cdrom.c: In function `CDROM_ScsiPassThrough': > cdrom.c:1543: error: invalid application of `sizeof' to an incomplete type I don't see how it worked before then, you need to investigate why '#ifdef SENSEBUFLEN' case doesn't work for you. > Alexandre, please find below another patch which does not fix this either, > but gets rid of some unused variable warnings. > > Gerald > > ChangeLog: > Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and > CDROM_ScsiPassThrough(). This means that HAVE_SCSIREQ_T_CMD is not defined for you, i.e. scsireq_t has not been detected. Very likely this is caused by a wrong/missing header includes in the configure.ac test, please fix it, it's easy enough. -- Dmitry.

June 30, 2005

Re: Fix libGL.a check on configure

by Ove Kaaven

ons, 29,.06.2005 kl. 20.11 -0400, skrev Anderson Lizardo: > Changelog: Check for common broken nVidia+Mesa OpenGL library setups. > http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… > > The current "test" check definitely does not ensure the system doesn't > have this "broken" setup. As you said, it should be better to let > autoconf do the check properly with AC_CHECK_LIB. Certainly does. The broken setup is as follows: /usr/lib/libGL.so <- belongs to nvidia /usr/lib/libGL.a <- no such thing /usr/X11R6/lib/libGL.so <- deleted by nvidia installer /usr/X11R6/lib/libGL.a <- still exists, belongs to Mesa Linking will succeed whatever you do, but if you don't check for this setup, Wine will be statically linked to Mesa here, and users will complain about no hardware acceleration. The AC_MSG_ERROR just puts this in terms that users understand, even though it's not an accurate message, and probably why you didn't see the point of the check.

June 30, 2005

Re: ntdll: Fix add_access_ace

by Mike McCormack

Hi James, James Hawkins wrote: > These changes make the advapi32 tests pass as well. > > Changelog > * Fix calculation of generic pointers. > * Minor cleanups. Thanks for the fixes. This makes Office 2003 work again for me. > if ((DWORD)(pAceHeader + dwAceSize) > (DWORD)(pAcl + pAcl->AclSize)) > return STATUS_ALLOTTED_SPACE_EXCEEDED; I think you might have missed one here. The above pointer arithmetic seems like it will make the wrong calculation. Maybe something like the following would work better: if ( &((char*)pAceHeader)[dwAceSize] > &((char*)pAcl)[pAcl->AclSize] ) Mike

June 30, 2005

Re: [Bugzilla/AppDB] www.winehq.org/appview.php -> appdb.winehq.org/appview.php

by Tony Lambregts

June 30, 2005

Re: Fix libGL.a check on configure

by Anderson Lizardo

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexandre Julliard wrote: > It would be much better to try the actual linking and see what > happens. Indeed, I was thinking on that myself... Why we just don't remove this (incorrect IMHO) file presence check and let autoconf do the check itself, which it already does as evidenced on the following snippet from configure.ac: dnl Check for the presence of the library AC_CHECK_LIB(GL,glXCreateContext, OPENGL_LIBS="-lGL" ,, $X_LIBS -lXext -lX11 -lm $X_EXTRA_LIBS) Additionally, looking at the commit message that added the "test -e" check: Changelog: Check for common broken nVidia+Mesa OpenGL library setups. http://cvs.winehq.org/cvsweb/wine/Attic/configure.in.diff?r1=1.247&r2=1.248… The current "test" check definitely does not ensure the system doesn't have this "broken" setup. As you said, it should be better to let autoconf do the check properly with AC_CHECK_LIB. So here goes my latest patch which incorporates your suggestion (it just removes the broken check). I've tested it with both NVidia libraries (nvidia-glx and nvidia-glx-dev on Ubuntu 5.04) and Mesa "pure" libraries, and wine compiled with OpenGL on both setups. For tests, I've used: make -C dlls/ddraw/tests/ test Although I'm not sure this is the ideal test to check if OpenGL is working with Wine. Best regards, - -- Anderson Lizardo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCwzi4tyCO/xz4QpMRAs9VAKCD5tilfTy6ePu7TY1z6qTXEUNk/gCfX/WO 5tHT6L0oSA1X8bdqQ0SGGac= =UqUn -----END PGP SIGNATURE-----

June 30, 2005

Re: World of Warcraft

by Christoph

Christoph schrieb: > > > Joseph Garvin schrieb: > >> The test realms are up, which lets players test the next patch. Anyone >> tried it to see if the problem is fixed? No, it is not fixed. >> > > Yes, I'm going to test. > > first gotcha the bizzard char copy page. The page did not work in > Firefox. Clicking in a circle, not accepting a new char name. Looked at > page source. What a joy. The europe/german Version of the page contains > a bag full of typos ... such as not closed tags ! Thanks to the > Webdeveloper plugin in Firefox I got finally a test char :-P > > second download tool. 100% cpu and 'nothing' happens until winedbg came > up with seg fault. Simply retried 5 times, now it's downloading and > uploading with 3040MB/s . Great speedup :=) > > third, ... hey I have to cvs the latest wine ;-) K. First test run with wine-20050628 with WoW-1.5.1 The "I cannnot click on any NPC" is still there. Audio is not working (artsdrv) also not with sndrec32.exe ("no sound device"). artsd is running and no conn from wine. Mh, something rotten with wineconfig/registry?! I can see wine is loading wineoss.drv instead. Regedit shows me correctly WineMM/Drivers=winearts.drv Tried alsa, that is working. New bug in wine-20050628: if WoW looses focus, it minimizes and maximizes automatically and steals focus again (I'm using WMaker) more worse graphics becomes shifted about +1px+1px every time. Makes game unplayable after this. Is the option "UseTakeFocus" = "n" no more working?! So, now I'm going to patch the game. K. patched fine. creates a new folder WoWTest with empty wtf/ config-Folder so have to adjust settings after a quick run. Game is up. Still has the "cannot click on NPC" The cheap wrapper trick is still making it working. further testing needs now lots more time ;) > > > chris > >

June 29, 2005

Re: Sony Station

by Chuck Hall

Was there a specific game that you wanted to test here? I have not tried to install any game that required it, but I can if you want something tested. Have Fun! Chuck Hall On Wed, 29 Jun 2005, Oliver Stieber wrote: > Hi, > > Has anyone managed to get sony's station > (http://www.station.sony.com/en/) past the file scan? > > > > > > ___________________________________________________________ > Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com > --

June 29, 2005

Re: dlls/ntdll/cdrom.c breakage

by Gerald Pfeifer

On Wed, 29 Jun 2005, Dmitry Timoshkov wrote: >> breaks on FreeBSD >> >> cdrom.c: In function `CDROM_ScsiPassThroughDirect': >> cdrom.c:1419: error: invalid application of `sizeof' to an incomplete type >> cdrom.c:1411: warning: unused variable `io' >> cdrom.c: In function `CDROM_ScsiPassThrough': >> cdrom.c:1534: error: invalid application of `sizeof' to an incomplete type >> cdrom.c:1526: warning: unused variable `io' >> which does not have struct request_sense, but does have struct >> scsi_request_sense in /usr/include/cam/scsi/scsi_all.h. > Attached patch is a workaround for the problem. A correct approach is to > add a test for presence of the 'struct request_sense' to configure and > add appropriate #ifdef's in the code. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > A workaround for missing struct request_sense on FreeBSD. Thanks for the quick response, Dmitry! Unfortunately, the patch that Alexandre now committed does not solve the problem for me, and my autoconf foo is a bit rusty: cdrom.c: In function `CDROM_ScsiPassThroughDirect': drom.c:1423: error: invalid application of `sizeof' to an incomplete type cdrom.c: In function `CDROM_ScsiPassThrough': cdrom.c:1543: error: invalid application of `sizeof' to an incomplete type Alexandre, please find below another patch which does not fix this either, but gets rid of some unused variable warnings. Gerald ChangeLog: Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and CDROM_ScsiPassThrough(). Index: cdrom.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/cdrom.c,v retrieving revision 1.59 diff -u -3 -p -r1.59 cdrom.c --- cdrom.c 29 Jun 2005 19:18:54 -0000 1.59 +++ cdrom.c 29 Jun 2005 21:36:26 -0000 @@ -1405,10 +1405,11 @@ static NTSTATUS CDROM_ScsiPassThroughDir int ret = STATUS_NOT_SUPPORTED; #ifdef HAVE_SG_IO_HDR_T_INTERFACE_ID sg_io_hdr_t cmd; + int io; #elif defined HAVE_SCSIREQ_T_CMD scsireq_t cmd; -#endif int io; +#endif if (pPacket->Length < sizeof(SCSI_PASS_THROUGH_DIRECT)) return STATUS_BUFFER_TOO_SMALL; @@ -1524,10 +1525,11 @@ static NTSTATUS CDROM_ScsiPassThrough(in int ret = STATUS_NOT_SUPPORTED; #ifdef HAVE_SG_IO_HDR_T_INTERFACE_ID sg_io_hdr_t cmd; + int io; #elif defined HAVE_SCSIREQ_T_CMD scsireq_t cmd; -#endif int io; +#endif if (pPacket->Length < sizeof(SCSI_PASS_THROUGH)) return STATUS_BUFFER_TOO_SMALL;

June 29, 2005