June 2005 - Wine-Devel - list.winehq.org

Re: MSCMS: testing with no support for color management

by Hans Leidekker

On Tuesday 28 June 2005 22:11, Saulius Krasuckas wrote: > | [s2(a)katleriai wine]$ wine dlls/mscms/tests/mscms_test.exe.so 2>&1 | head -n 6 > | This version of Wine was compiled without support for color management > | functions. This means many color functions are empty stubs and you should > | expect your application to fail. To enable Wine to use LittleCMS for color > | management please install a liblcms development package version 1.13 or > | higher and rebuild Wine. > | http://www.littlecms.com > > I want to fix this by avoiding to upgrade my liblcms and install dev-pkg. What version do you have? 1.09 is reported to work too, so maybe we should change our requirement. 1.13 is just the version I developed against so I was sure Wine worked with that version. > Would it be OK to put some #ifdef-s in some unimplemented function, let > say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)? Well, I think Wine tests are supposed to identify Windows behavior, and no version of Windows does what you propose for these functions AFAIK. We could fail to load mscms.dll if it was compiled without lcms support, but then your app (or test) would fail too and as a whole. In the current situation you might be able to use your app partly. Some tests may even succeed if the functions they test don't depend on lcms. -Hans

June 29, 2005

Re: wine/dlls/advapi32/tests security.c

by James Hawkins

On 6/28/05, Robert Shearman <rob(a)codeweavers.com> wrote: > > James, the SD in the tests seems to be filled with random data. Can you > have a go at fixing this? > Yea, I'll work on this till I get it fixed. -- James Hawkins

June 29, 2005

shell32/tests: ILFree is not exported on all versions

by Saulius Krasuckas

Vitaliy, I have been messing around shell32/tests some day ago, and stuck upon a MSDN, which states that SHGetMalloc() is obsolete. It says we must should stick with CoTaskMemFree() and CoTaskMemAlloc() instead. Would you take a thought on this?

June 29, 2005

Re: dlls/ntdll/cdrom.c breakage

by Dmitry Timoshkov

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > The following change to dlls/ntdll/cdrom.c > > revision 1.57 > date: 2005/06/27 12:07:49; author: julliard; state: Exp; lines: +13 -19 > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Add a check for sg_io_hdr_t and (not tested) check for scsireq_t > presence. > > breaks on FreeBSD > > cdrom.c: In function `CDROM_ScsiPassThroughDirect': > cdrom.c:1419: error: invalid application of `sizeof' to an incomplete type > cdrom.c:1411: warning: unused variable `io' > cdrom.c: In function `CDROM_ScsiPassThrough': > cdrom.c:1534: error: invalid application of `sizeof' to an incomplete type > cdrom.c:1526: warning: unused variable `io' > > which does not have struct request_sense, but does have struct > scsi_request_sense in /usr/include/cam/scsi/scsi_all.h. > > I would have tried to cobble up a patch guard these by #ifdef linux, > but I'm not sure whether the patch to cdrom.c really was correct as > it currently looks: defining struct linux_cdrom_generic_command in > cdrom.c seems like quite bad a hack, doesn't it? Attached patch is a workaround for the problem. A correct approach is to add a test for presence of the 'struct request_sense' to configure and add appropriate #ifdef's in the code. Changelog: Dmitry Timoshkov <dmitry(a)codeweavers.com> A workaround for missing struct request_sense on FreeBSD. -- Dmitry.

June 29, 2005

Re: lostwages: fix link to ICM documentation

by Tom Wickline

On 6/28/05, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > * On Tue, 28 Jun 2005, Hans Leidekker wrote: > > * On Tuesday 28 June 2005 20:23, Jeremy Newman wrote: > > > > > I'll hold off on this patch until the best link is disclosed to me. ;-) > > > > OK, I'll be the judge on this, since I wrote MSCMS for Wine. > > Good, soon I will post some question regarding Wine MSCMS implementation. > > > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/ > > > icm/icm_20kz.asp > > > > Saulius was right, this is the best one. It provides an > > overview of color management and the API reference can > > be reached from this page. > > Ok, I think it was Tom. :-) > We could link to both ICM and CMMs ???? I'm just glad that someone is *finally* interested in this ..Yipee -Tom

June 29, 2005

Re: wine/dlls/advapi32/tests security.c

by Robert Shearman

Alexandre Julliard wrote: >ChangeSet ID: 18501 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/06/28 08:52:01 > >Modified files: > dlls/advapi32/tests: security.c > >Log message: > Mark as todo a couple of tests that currently fail. > >Patch: http://cvs.winehq.org/patch.py?id=18501 > >Old revision New revision Changes Path > 1.20 1.21 +3 -3 wine/dlls/advapi32/tests/security.c > > This patch is wrong. The failures are caused by the following patch: >ChangeSet ID: 18498 >CVSROOT: /opt/cvs-commit >Module name: wine >Changes by: julliard(a)wine.codeweavers.com 2005/06/28 05:54:29 > >Modified files: > dlls/ntdll : sec.c > >Log message: > James Hawkins <truiken(a)gmail.com> > Forward RtlAddAccess* to add_access_ace. > >Patch: http://cvs.winehq.org/patch.py?id=18498 > >Old revision New revision Changes Path > 1.62 1.63 +6 -58 wine/dlls/ntdll/sec.c > > James, the SD in the tests seems to be filled with random data. Can you have a go at fixing this? -- Rob Shearman

June 29, 2005

Re: MSHTML: THIS macros clean up

by Dimi Paun

----- Original Message ----- From: "Jacek Caban" <jack(a)itma.pwr.wroc.pl> > @@ -78,29 +77,35 @@ static HRESULT WINAPI PersistMoniker_IsD > static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL fFullyAvailable, > IMoniker *pimkName, LPBC pibc, DWORD grfMode) > { > - FIXME("(%p)->(%x %p %p %08lx)\n", iface, fFullyAvailable, pimkName, pibc, grfMode); > + PERSISTMON_THIS > + FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc, grfMode); > return S_OK; > } This code looks weird. It should still look like C code, even if we use a macro. I would suggest something like this: static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL fFullyAvailable, IMoniker *pimkName, LPBC pibc, DWORD grfMode) { HTMLDocument *This = PERSISTMON_THIS(iface); FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc, grfMode); return S_OK; } It's a bit more verbose, but a lot more readable. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

June 28, 2005

Re: Fix libGL.a check on configure

by Anderson Lizardo

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexandre Julliard wrote: > Anderson Lizardo <andersonlizardo(a)yahoo.com.br> writes: >>Fixed the libGL.a configure check for systems where >>/usr/X11R6/lib/libGL.so is a symbolic link. >> >> >>PS.: I've not used a simple "test -e" because >>http://www.winehq.org/hypermail/wine-patches/2002/01/0206.html says this >>does not work on Solaris. > > > My guess is that if test -e doesn't work, test -L won't work either... What about the attached patch? It uses "ls" instead of "test" to test for file presence (assuming ls returns non-zero code on a non-present file, which is true for a POSIX compliant system). Snippet: - - if test -f /usr/X11R6/lib/libGL.a -a ! -f /usr/X11R6/lib/libGL.so -a ! -f /usr/X11R6/lib/libGL.dylib + if ls /usr/X11R6/lib/libGL.a >/dev/null 2>&1 -a \ + ! ls /usr/X11R6/lib/libGL.so >/dev/null 2>&1 -a \ + ! ls /usr/X11R6/lib/libGL.dylib >/dev/null 2>&1 Best regards, - -- Anderson Lizardo -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFCwbGhtyCO/xz4QpMRAoVBAJ9Iqt0dhdAiTEofYLDc3IlbPpChwQCfWKMx eYoJmCPW8QIwyodJqGfP3fU= =YEd8 -----END PGP SIGNATURE-----

June 28, 2005

MSCMS: testing with no support for color management

by Saulius Krasuckas

MSCMS tests fails on my box: | [s2(a)katleriai wine]$ wine dlls/mscms/tests/mscms_test.exe.so 2>&1 | head -n 6 | This version of Wine was compiled without support for color management | functions. This means many color functions are empty stubs and you should | expect your application to fail. To enable Wine to use LittleCMS for color | management please install a liblcms development package version 1.13 or | higher and rebuild Wine. | http://www.littlecms.com I want to fix this by avoiding to upgrade my liblcms and install dev-pkg. Would it be OK to put some #ifdef-s in some unimplemented function, let say EnumColorProfilesA(), and to SetLastError(ERROR_CALL_NOT_IMPLEMENTED)? Then at the start of the test we could check this and return from the test when GetLastError() return ERROR_CALL_NOT_IMPLEMENTED. Is this way OK?

June 28, 2005

Re: lostwages: fix link to ICM documentation

by Saulius Krasuckas

* On Tue, 28 Jun 2005, Hans Leidekker wrote: > * On Tuesday 28 June 2005 20:23, Jeremy Newman wrote: > > > I'll hold off on this patch until the best link is disclosed to me. ;-) > > OK, I'll be the judge on this, since I wrote MSCMS for Wine. Good, soon I will post some question regarding Wine MSCMS implementation. > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/ > > icm/icm_20kz.asp > > Saulius was right, this is the best one. It provides an > overview of color management and the API reference can > be reached from this page. Ok, I think it was Tom. :-)

June 28, 2005